[jira] [Work logged] (AMQNET-619) Remote detach is not handled properly for sender link
[
https://issues.apache.org/jira/browse/AMQNET-619?focusedWorklogId=323888=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323888
]
ASF GitHub Bot logged work on AMQNET-619:
-
Author: ASF GitHub Bot
Created on: 05/Oct/19 08:23
Start Date: 05/Oct/19 08:23
Worklog Time Spent: 10m
Work Description: Havret commented on pull request #42: AMQNET-619:
Handle remote detach properly for sender link
URL: https://github.com/apache/activemq-nms-amqp/pull/42#discussion_r331738433
##
File path: src/NMS.AMQP/Provider/Amqp/AmqpProducer.cs
##
@@ -53,13 +53,13 @@ public Task Attach()
};
string linkName = info.Id + ":" + target.Address;
-var taskCompletionSource = new TaskCompletionSource();
-senderLink = new SenderLink(session.UnderlyingSession, linkName,
frame, (link, attach) => { taskCompletionSource.SetResult(true); });
+TaskCompletionSource tsc = new TaskCompletionSource();
Review comment:
Hope it's ok now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 323888)
Time Spent: 50m (was: 40m)
> Remote detach is not handled properly for sender link
> -
>
> Key: AMQNET-619
> URL: https://issues.apache.org/jira/browse/AMQNET-619
> Project: ActiveMQ .Net
> Issue Type: Bug
> Components: AMQP
>Reporter: Krzysztof Porebski
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Remote detach is not handled properly for sender link. MessageProducer is
> created even if no link terminus was created. It results in unexpected
> behavior if we try to use MessageProducer immediately after its creation
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (AMQNET-620) ConnectionFactory is not initialized properly with Uri overload
[ https://issues.apache.org/jira/browse/AMQNET-620?focusedWorklogId=323885=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323885 ] ASF GitHub Bot logged work on AMQNET-620: - Author: ASF GitHub Bot Created on: 05/Oct/19 06:56 Start Date: 05/Oct/19 06:56 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on pull request #44: AMQNET-620: Initialize ConnectionFactory properly with System.Uri overload URL: https://github.com/apache/activemq-nms-amqp/pull/44 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 323885) Time Spent: 40m (was: 0.5h) > ConnectionFactory is not initialized properly with Uri overload > --- > > Key: AMQNET-620 > URL: https://issues.apache.org/jira/browse/AMQNET-620 > Project: ActiveMQ .Net > Issue Type: Bug > Components: AMQP >Reporter: Krzysztof Porebski >Priority: Major > Fix For: 1.8.0 > > Time Spent: 40m > Remaining Estimate: 0h > > ConnectionFactory is not initialized properly with constructor that takes > System.Uri as a parameter. Additional properties that are specified in broker > uri (like username or password) are not applied on connection factory. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AMQNET-620) ConnectionFactory is not initialized properly with Uri overload
[ https://issues.apache.org/jira/browse/AMQNET-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944999#comment-16944999 ] ASF subversion and git services commented on AMQNET-620: Commit 6761c1f9df9e6f1c84150ecebcd805c0836dec96 in activemq-nms-amqp's branch refs/heads/master from Michael André Pearce [ https://gitbox.apache.org/repos/asf?p=activemq-nms-amqp.git;h=6761c1f ] Merge pull request #44 from HavretGC/connection_factory_uri_overload_fix AMQNET-620: Initialize ConnectionFactory properly with System.Uri overload > ConnectionFactory is not initialized properly with Uri overload > --- > > Key: AMQNET-620 > URL: https://issues.apache.org/jira/browse/AMQNET-620 > Project: ActiveMQ .Net > Issue Type: Bug > Components: AMQP >Reporter: Krzysztof Porebski >Priority: Major > Fix For: 1.8.0 > > Time Spent: 40m > Remaining Estimate: 0h > > ConnectionFactory is not initialized properly with constructor that takes > System.Uri as a parameter. Additional properties that are specified in broker > uri (like username or password) are not applied on connection factory. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AMQNET-620) ConnectionFactory is not initialized properly with Uri overload
[ https://issues.apache.org/jira/browse/AMQNET-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944998#comment-16944998 ] ASF subversion and git services commented on AMQNET-620: Commit 04c0b219faf22e11393e74f19a4d4122ed955257 in activemq-nms-amqp's branch refs/heads/master from Havret [ https://gitbox.apache.org/repos/asf?p=activemq-nms-amqp.git;h=04c0b21 ] AMQNET-620: Initialize ConnectionFactory properly with System.Uri overload ConnectionFactory was not initialized properly with constructor that takes System.Uri as a parameter. Additional properties that were specified in broker uri (like username or password) were not applied on connection factory. > ConnectionFactory is not initialized properly with Uri overload > --- > > Key: AMQNET-620 > URL: https://issues.apache.org/jira/browse/AMQNET-620 > Project: ActiveMQ .Net > Issue Type: Bug > Components: AMQP >Reporter: Krzysztof Porebski >Priority: Major > Fix For: 1.8.0 > > Time Spent: 40m > Remaining Estimate: 0h > > ConnectionFactory is not initialized properly with constructor that takes > System.Uri as a parameter. Additional properties that are specified in broker > uri (like username or password) are not applied on connection factory. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (AMQNET-619) Remote detach is not handled properly for sender link
[
https://issues.apache.org/jira/browse/AMQNET-619?focusedWorklogId=323884=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323884
]
ASF GitHub Bot logged work on AMQNET-619:
-
Author: ASF GitHub Bot
Created on: 05/Oct/19 06:55
Start Date: 05/Oct/19 06:55
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #42:
AMQNET-619: Handle remote detach properly for sender link
URL: https://github.com/apache/activemq-nms-amqp/pull/42#discussion_r331736022
##
File path: src/NMS.AMQP/Provider/Amqp/AmqpProducer.cs
##
@@ -53,13 +53,13 @@ public Task Attach()
};
string linkName = info.Id + ":" + target.Address;
-var taskCompletionSource = new TaskCompletionSource();
-senderLink = new SenderLink(session.UnderlyingSession, linkName,
frame, (link, attach) => { taskCompletionSource.SetResult(true); });
+TaskCompletionSource tsc = new TaskCompletionSource();
Review comment:
You made further changes...:s the name is still shortened i meant to put it
back to var taskCompletionService so there is no change in this line.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 323884)
Time Spent: 40m (was: 0.5h)
> Remote detach is not handled properly for sender link
> -
>
> Key: AMQNET-619
> URL: https://issues.apache.org/jira/browse/AMQNET-619
> Project: ActiveMQ .Net
> Issue Type: Bug
> Components: AMQP
>Reporter: Krzysztof Porebski
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Remote detach is not handled properly for sender link. MessageProducer is
> created even if no link terminus was created. It results in unexpected
> behavior if we try to use MessageProducer immediately after its creation
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AMQNET-619) Remote detach is not handled properly for sender link
[ https://issues.apache.org/jira/browse/AMQNET-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945031#comment-16945031 ] ASF subversion and git services commented on AMQNET-619: Commit 590fc549d06c347cbeb2fda685ff51113e8fe7a5 in activemq-nms-amqp's branch refs/heads/master from Havret [ https://gitbox.apache.org/repos/asf?p=activemq-nms-amqp.git;h=590fc54 ] AMQNET-619: Handle remote detach properly for sender link > Remote detach is not handled properly for sender link > - > > Key: AMQNET-619 > URL: https://issues.apache.org/jira/browse/AMQNET-619 > Project: ActiveMQ .Net > Issue Type: Bug > Components: AMQP >Reporter: Krzysztof Porebski >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Remote detach is not handled properly for sender link. MessageProducer is > created even if no link terminus was created. It results in unexpected > behavior if we try to use MessageProducer immediately after its creation -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (AMQNET-619) Remote detach is not handled properly for sender link
[ https://issues.apache.org/jira/browse/AMQNET-619?focusedWorklogId=323905=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323905 ] ASF GitHub Bot logged work on AMQNET-619: - Author: ASF GitHub Bot Created on: 05/Oct/19 11:02 Start Date: 05/Oct/19 11:02 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on pull request #42: AMQNET-619: Handle remote detach properly for sender link URL: https://github.com/apache/activemq-nms-amqp/pull/42 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 323905) Time Spent: 1h (was: 50m) > Remote detach is not handled properly for sender link > - > > Key: AMQNET-619 > URL: https://issues.apache.org/jira/browse/AMQNET-619 > Project: ActiveMQ .Net > Issue Type: Bug > Components: AMQP >Reporter: Krzysztof Porebski >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Remote detach is not handled properly for sender link. MessageProducer is > created even if no link terminus was created. It results in unexpected > behavior if we try to use MessageProducer immediately after its creation -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AMQNET-619) Remote detach is not handled properly for sender link
[ https://issues.apache.org/jira/browse/AMQNET-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945032#comment-16945032 ] ASF subversion and git services commented on AMQNET-619: Commit fe647a9e842ec4bcda2e08ddf6285467df879ed5 in activemq-nms-amqp's branch refs/heads/master from Michael André Pearce [ https://gitbox.apache.org/repos/asf?p=activemq-nms-amqp.git;h=fe647a9 ] Merge pull request #42 from Havret/handle_sender_link_remote_detach_properly AMQNET-619: Handle remote detach properly for sender link > Remote detach is not handled properly for sender link > - > > Key: AMQNET-619 > URL: https://issues.apache.org/jira/browse/AMQNET-619 > Project: ActiveMQ .Net > Issue Type: Bug > Components: AMQP >Reporter: Krzysztof Porebski >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Remote detach is not handled properly for sender link. MessageProducer is > created even if no link terminus was created. It results in unexpected > behavior if we try to use MessageProducer immediately after its creation -- This message was sent by Atlassian Jira (v8.3.4#803005)
