[jira] [Commented] (ARTEMIS-2673) PageStore should only be removed when Address is removed
[ https://issues.apache.org/jira/browse/ARTEMIS-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065201#comment-17065201 ] ASF subversion and git services commented on ARTEMIS-2673: -- Commit f874a02d17eb7787410c69024397353e53fc7689 in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=f874a02 ] ARTEMIS-2673 PageStore should only be removed when Address is removed & ARTEMIS-2674 AMQP should use a separate executor for IO > PageStore should only be removed when Address is removed > > > Key: ARTEMIS-2673 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2673 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.11.0 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.12.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-2674) AMQP should use a separate executor for IO
[ https://issues.apache.org/jira/browse/ARTEMIS-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065202#comment-17065202 ] ASF subversion and git services commented on ARTEMIS-2674: -- Commit f874a02d17eb7787410c69024397353e53fc7689 in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=f874a02 ] ARTEMIS-2673 PageStore should only be removed when Address is removed & ARTEMIS-2674 AMQP should use a separate executor for IO > AMQP should use a separate executor for IO > -- > > Key: ARTEMIS-2674 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2674 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Clebert Suconic >Priority: Major > > In cases where there's Paging involving, the netty thread may be locked > interrupting processing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ARTEMIS-2671) Hard-coded search in LegacyLDAPSecuritySettingPlugin listener
[ https://issues.apache.org/jira/browse/ARTEMIS-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram resolved ARTEMIS-2671. - Fix Version/s: 2.12.0 Resolution: Fixed > Hard-coded search in LegacyLDAPSecuritySettingPlugin listener > - > > Key: ARTEMIS-2671 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2671 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.12.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The {{javax.naming.event.ObjectChangeListener}} implementation for > {{org.apache.activemq.artemis.core.server.impl.LegacyLDAPSecuritySettingPlugin}} > has a hard-coded search for {{uid}}. This can cause a > {{NullPointerException}}, e.g.: > {noformat} > Exception in thread "Thread-12" java.lang.NullPointerException > at > java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936) > at > org.apache.activemq.artemis.core.settings.impl.HierarchicalObjectRepository.getMatch(HierarchicalObjectRepository.java:207) > at > org.apache.activemq.artemis.core.server.impl.LegacyLDAPSecuritySettingPlugin.objectRemoved(LegacyLDAPSecuritySettingPlugin.java:490) > at > org.apache.activemq.artemis.core.server.impl.LegacyLDAPSecuritySettingPlugin.objectChanged(LegacyLDAPSecuritySettingPlugin.java:543) > at > org.apache.activemq.artemis.core.server.impl.LegacyLDAPSecuritySettingPlugin$LDAPNamespaceChangeListener.objectChanged(LegacyLDAPSecuritySettingPlugin.java:581) > at javax.naming.event.NamingEvent.dispatch(NamingEvent.java:295) > at com.sun.jndi.ldap.EventQueue.run(EventQueue.java:147) > at java.lang.Thread.run(Thread.java:748) > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ARTEMIS-2667) NPE when clearing non-persistent duplicate ID cache
[ https://issues.apache.org/jira/browse/ARTEMIS-2667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram resolved ARTEMIS-2667. - Fix Version/s: 2.12.0 Resolution: Fixed > NPE when clearing non-persistent duplicate ID cache > --- > > Key: ARTEMIS-2667 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2667 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.12.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Adding a call to {{clear()}} at the end of > {{org.apache.activemq.artemis.tests.integration.persistence.DuplicateCacheTest#testDuplicateNonPersistent}} > triggers an NPE: > {noformat} > java.lang.NullPointerException > at > org.apache.activemq.artemis.core.postoffice.impl.DuplicateIDCacheImpl.clear(DuplicateIDCacheImpl.java:307) > at > org.apache.activemq.artemis.tests.integration.persistence.DuplicateCacheTest.testDuplicateNonPersistent(DuplicateCacheTest.java:122) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) > ... > at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58) > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=408317=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408317 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 23/Mar/20 21:05 Start Date: 23/Mar/20 21:05 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-602855737 Sure bud, there is no hurry and this change should be simpler enough to be rebased against your when you have done ;) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408317) Time Spent: 40m (was: 0.5h) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-2654) Improve Paging.Stop cleanup
[ https://issues.apache.org/jira/browse/ARTEMIS-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065094#comment-17065094 ] Clebert Suconic commented on ARTEMIS-2654: -- Instead I'm doing ARTEMIS-2673 > Improve Paging.Stop cleanup > --- > > Key: ARTEMIS-2654 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2654 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.11.0 >Reporter: Clebert Suconic >Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > > There's a Blocking operation on Page.stopPaging and cleanup should use its > own OperationContext. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (ARTEMIS-2654) Improve Paging.Stop cleanup
[ https://issues.apache.org/jira/browse/ARTEMIS-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic closed ARTEMIS-2654. Fix Version/s: (was: 2.12.0) Resolution: Won't Fix > Improve Paging.Stop cleanup > --- > > Key: ARTEMIS-2654 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2654 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.11.0 >Reporter: Clebert Suconic >Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > > There's a Blocking operation on Page.stopPaging and cleanup should use its > own OperationContext. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2654) Improve Paging.Stop cleanup
[ https://issues.apache.org/jira/browse/ARTEMIS-2654?focusedWorklogId=408314=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408314 ] ASF GitHub Bot logged work on ARTEMIS-2654: --- Author: ASF GitHub Bot Created on: 23/Mar/20 21:03 Start Date: 23/Mar/20 21:03 Worklog Time Spent: 10m Work Description: clebertsuconic commented on pull request #3015: ARTEMIS-2654 Improving Page cleanup and Operation Context URL: https://github.com/apache/activemq-artemis/pull/3015 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408314) Time Spent: 3h 40m (was: 3.5h) > Improve Paging.Stop cleanup > --- > > Key: ARTEMIS-2654 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2654 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.11.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.12.0 > > Time Spent: 3h 40m > Remaining Estimate: 0h > > There's a Blocking operation on Page.stopPaging and cleanup should use its > own OperationContext. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2671) Hard-coded search in LegacyLDAPSecuritySettingPlugin listener
[ https://issues.apache.org/jira/browse/ARTEMIS-2671?focusedWorklogId=408313=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408313 ] ASF GitHub Bot logged work on ARTEMIS-2671: --- Author: ASF GitHub Bot Created on: 23/Mar/20 21:02 Start Date: 23/Mar/20 21:02 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #3038: ARTEMIS-2671 NPE in LDAP security plugin listener URL: https://github.com/apache/activemq-artemis/pull/3038 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408313) Time Spent: 20m (was: 10m) > Hard-coded search in LegacyLDAPSecuritySettingPlugin listener > - > > Key: ARTEMIS-2671 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2671 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The {{javax.naming.event.ObjectChangeListener}} implementation for > {{org.apache.activemq.artemis.core.server.impl.LegacyLDAPSecuritySettingPlugin}} > has a hard-coded search for {{uid}}. This can cause a > {{NullPointerException}}, e.g.: > {noformat} > Exception in thread "Thread-12" java.lang.NullPointerException > at > java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936) > at > org.apache.activemq.artemis.core.settings.impl.HierarchicalObjectRepository.getMatch(HierarchicalObjectRepository.java:207) > at > org.apache.activemq.artemis.core.server.impl.LegacyLDAPSecuritySettingPlugin.objectRemoved(LegacyLDAPSecuritySettingPlugin.java:490) > at > org.apache.activemq.artemis.core.server.impl.LegacyLDAPSecuritySettingPlugin.objectChanged(LegacyLDAPSecuritySettingPlugin.java:543) > at > org.apache.activemq.artemis.core.server.impl.LegacyLDAPSecuritySettingPlugin$LDAPNamespaceChangeListener.objectChanged(LegacyLDAPSecuritySettingPlugin.java:581) > at javax.naming.event.NamingEvent.dispatch(NamingEvent.java:295) > at com.sun.jndi.ldap.EventQueue.run(EventQueue.java:147) > at java.lang.Thread.run(Thread.java:748) > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-2671) Hard-coded search in LegacyLDAPSecuritySettingPlugin listener
[ https://issues.apache.org/jira/browse/ARTEMIS-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065093#comment-17065093 ] ASF subversion and git services commented on ARTEMIS-2671: -- Commit 3107535a324448909149c245b26ca4085bb6e42b in activemq-artemis's branch refs/heads/master from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=3107535 ] ARTEMIS-2671 NPE in LDAP security plugin listener To get the name of the destination use the relative Rdn position rather than a strict match of "uid". Also, improve logging. > Hard-coded search in LegacyLDAPSecuritySettingPlugin listener > - > > Key: ARTEMIS-2671 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2671 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The {{javax.naming.event.ObjectChangeListener}} implementation for > {{org.apache.activemq.artemis.core.server.impl.LegacyLDAPSecuritySettingPlugin}} > has a hard-coded search for {{uid}}. This can cause a > {{NullPointerException}}, e.g.: > {noformat} > Exception in thread "Thread-12" java.lang.NullPointerException > at > java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936) > at > org.apache.activemq.artemis.core.settings.impl.HierarchicalObjectRepository.getMatch(HierarchicalObjectRepository.java:207) > at > org.apache.activemq.artemis.core.server.impl.LegacyLDAPSecuritySettingPlugin.objectRemoved(LegacyLDAPSecuritySettingPlugin.java:490) > at > org.apache.activemq.artemis.core.server.impl.LegacyLDAPSecuritySettingPlugin.objectChanged(LegacyLDAPSecuritySettingPlugin.java:543) > at > org.apache.activemq.artemis.core.server.impl.LegacyLDAPSecuritySettingPlugin$LDAPNamespaceChangeListener.objectChanged(LegacyLDAPSecuritySettingPlugin.java:581) > at javax.naming.event.NamingEvent.dispatch(NamingEvent.java:295) > at com.sun.jndi.ldap.EventQueue.run(EventQueue.java:147) > at java.lang.Thread.run(Thread.java:748) > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-975) Reading messages from page causes lost entries in db backend
[ https://issues.apache.org/jira/browse/ARTEMIS-975?focusedWorklogId=408301=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408301 ] ASF GitHub Bot logged work on ARTEMIS-975: -- Author: ASF GitHub Bot Created on: 23/Mar/20 20:55 Start Date: 23/Mar/20 20:55 Worklog Time Spent: 10m Work Description: clebertsuconic commented on pull request #3042: ARTEMIS-975: Add transactional records to deletedRecords to check for committed transactions that also hold references to URL: https://github.com/apache/activemq-artemis/pull/3042#discussion_r396750555 ## File path: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/JDBCJournalImpl.java ## @@ -232,6 +232,7 @@ public synchronized int sync() { holder = transactions.get(record.getTxId()); for (RecordInfo info : holder.recordsToDelete) { deletedRecords.add(record.getId()); + deletedRecords.add(info.id); Review comment: without a test I can't really say what is broken. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408301) Time Spent: 0.5h (was: 20m) > Reading messages from page causes lost entries in db backend > > > Key: ARTEMIS-975 > URL: https://issues.apache.org/jira/browse/ARTEMIS-975 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Benjamin Graf >Priority: Major > Attachments: screenshot-1.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > Consuming messages from pages with a db as persistence backend leaves commit > records in message_table which doesn't get cleaned up. Seems that depaging > does not add txids to internal map. > SQL script for cleanup (no known side effect): > {code} > DELETE > FROM MESSAGE_TABLE > WHERE txid IN > (SELECT txid > FROM >(SELECT count(*) AS cnt, >txid > FROM MESSAGE_TABLE > WHERE txid IN > (SELECT txid > FROM MESSAGE_TABLE > WHERE recordtype = 18) > GROUP BY txid)AS m > WHERE m.cnt=1) > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-2667) NPE when clearing non-persistent duplicate ID cache
[ https://issues.apache.org/jira/browse/ARTEMIS-2667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065085#comment-17065085 ] ASF subversion and git services commented on ARTEMIS-2667: -- Commit 402dda216187ec316b3bbe47f64509e270059a36 in activemq-artemis's branch refs/heads/master from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=402dda2 ] ARTEMIS-2667 NPE w/clearing non-durable dupl ID cache > NPE when clearing non-persistent duplicate ID cache > --- > > Key: ARTEMIS-2667 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2667 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Adding a call to {{clear()}} at the end of > {{org.apache.activemq.artemis.tests.integration.persistence.DuplicateCacheTest#testDuplicateNonPersistent}} > triggers an NPE: > {noformat} > java.lang.NullPointerException > at > org.apache.activemq.artemis.core.postoffice.impl.DuplicateIDCacheImpl.clear(DuplicateIDCacheImpl.java:307) > at > org.apache.activemq.artemis.tests.integration.persistence.DuplicateCacheTest.testDuplicateNonPersistent(DuplicateCacheTest.java:122) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) > ... > at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58) > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2667) NPE when clearing non-persistent duplicate ID cache
[ https://issues.apache.org/jira/browse/ARTEMIS-2667?focusedWorklogId=408302=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408302 ] ASF GitHub Bot logged work on ARTEMIS-2667: --- Author: ASF GitHub Bot Created on: 23/Mar/20 20:55 Start Date: 23/Mar/20 20:55 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #3034: ARTEMIS-2667 NPE w/clearing non-durable dupl ID cache URL: https://github.com/apache/activemq-artemis/pull/3034 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408302) Time Spent: 20m (was: 10m) > NPE when clearing non-persistent duplicate ID cache > --- > > Key: ARTEMIS-2667 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2667 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Adding a call to {{clear()}} at the end of > {{org.apache.activemq.artemis.tests.integration.persistence.DuplicateCacheTest#testDuplicateNonPersistent}} > triggers an NPE: > {noformat} > java.lang.NullPointerException > at > org.apache.activemq.artemis.core.postoffice.impl.DuplicateIDCacheImpl.clear(DuplicateIDCacheImpl.java:307) > at > org.apache.activemq.artemis.tests.integration.persistence.DuplicateCacheTest.testDuplicateNonPersistent(DuplicateCacheTest.java:122) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) > ... > at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58) > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=408299=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408299 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 23/Mar/20 20:54 Start Date: 23/Mar/20 20:54 Worklog Time Spent: 10m Work Description: clebertsuconic commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-602850622 If you could please wait my PR to be merged first? I'm changing around these methods also.. and I wanted to have a version closer to what we have now as I'm cherry-picking to a production branch based on a previous version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408299) Time Spent: 0.5h (was: 20m) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-975) Reading messages from page causes lost entries in db backend
[ https://issues.apache.org/jira/browse/ARTEMIS-975?focusedWorklogId=408247=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408247 ] ASF GitHub Bot logged work on ARTEMIS-975: -- Author: ASF GitHub Bot Created on: 23/Mar/20 20:19 Start Date: 23/Mar/20 20:19 Worklog Time Spent: 10m Work Description: jbertram commented on issue #3042: ARTEMIS-975: Add transactional records to deletedRecords to check for committed transactions that also hold references to URL: https://github.com/apache/activemq-artemis/pull/3042#issuecomment-602832587 This really needs a test in order to validate the fix and also to mitigate against regressions in the future. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408247) Time Spent: 20m (was: 10m) > Reading messages from page causes lost entries in db backend > > > Key: ARTEMIS-975 > URL: https://issues.apache.org/jira/browse/ARTEMIS-975 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Benjamin Graf >Priority: Major > Attachments: screenshot-1.png > > Time Spent: 20m > Remaining Estimate: 0h > > Consuming messages from pages with a db as persistence backend leaves commit > records in message_table which doesn't get cleaned up. Seems that depaging > does not add txids to internal map. > SQL script for cleanup (no known side effect): > {code} > DELETE > FROM MESSAGE_TABLE > WHERE txid IN > (SELECT txid > FROM >(SELECT count(*) AS cnt, >txid > FROM MESSAGE_TABLE > WHERE txid IN > (SELECT txid > FROM MESSAGE_TABLE > WHERE recordtype = 18) > GROUP BY txid)AS m > WHERE m.cnt=1) > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ARTEMIS-2668) Wrong formatting Strings in class LoggingResultSet
[ https://issues.apache.org/jira/browse/ARTEMIS-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram resolved ARTEMIS-2668. - Fix Version/s: 2.12.0 Resolution: Fixed > Wrong formatting Strings in class LoggingResultSet > -- > > Key: ARTEMIS-2668 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2668 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.11.0 >Reporter: Benjamin Graf >Priority: Minor > Fix For: 2.12.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Several methods of {{LoggingResultSet}} have wrong amount of parameters in > formatting {{String}} causing exception if TRACE logging. > e.g. > {noformat} > AMQ222010: Critical IO Error, shutting down the server. > file=org.apache.activemq.artemis.jdbc.store.file.JDBCSequentialFile@27cbabd3, > message=Error writing to JDBC file. > java.util.MissingFormatArgumentException: Format specifier '%s' > at java.util.Formatter.format(Formatter.java:2672) ~[?:?] > at java.util.Formatter.format(Formatter.java:2609) ~[?:?] > at java.lang.String.format(String.java:2897) ~[?:?] > at > org.ops4j.pax.logging.jbosslogging.JBossLoggingLogger.doLogf(JBossLoggingLogger.java:87) > ~[!/:?] > at org.jboss.logging.Logger.logf(Logger.java:2326) ~[!/:?] > at > org.apache.activemq.artemis.jdbc.store.logging.LoggingResultSet.updateBlob(LoggingResultSet.java:950) > ~[!/:?] > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2668) Wrong formatting Strings in class LoggingResultSet
[ https://issues.apache.org/jira/browse/ARTEMIS-2668?focusedWorklogId=408234=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408234 ] ASF GitHub Bot logged work on ARTEMIS-2668: --- Author: ASF GitHub Bot Created on: 23/Mar/20 20:05 Start Date: 23/Mar/20 20:05 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #3035: ARTEMIS-2668: Fix several format String definitions URL: https://github.com/apache/activemq-artemis/pull/3035 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408234) Time Spent: 20m (was: 10m) > Wrong formatting Strings in class LoggingResultSet > -- > > Key: ARTEMIS-2668 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2668 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.11.0 >Reporter: Benjamin Graf >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Several methods of {{LoggingResultSet}} have wrong amount of parameters in > formatting {{String}} causing exception if TRACE logging. > e.g. > {noformat} > AMQ222010: Critical IO Error, shutting down the server. > file=org.apache.activemq.artemis.jdbc.store.file.JDBCSequentialFile@27cbabd3, > message=Error writing to JDBC file. > java.util.MissingFormatArgumentException: Format specifier '%s' > at java.util.Formatter.format(Formatter.java:2672) ~[?:?] > at java.util.Formatter.format(Formatter.java:2609) ~[?:?] > at java.lang.String.format(String.java:2897) ~[?:?] > at > org.ops4j.pax.logging.jbosslogging.JBossLoggingLogger.doLogf(JBossLoggingLogger.java:87) > ~[!/:?] > at org.jboss.logging.Logger.logf(Logger.java:2326) ~[!/:?] > at > org.apache.activemq.artemis.jdbc.store.logging.LoggingResultSet.updateBlob(LoggingResultSet.java:950) > ~[!/:?] > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-2668) Wrong formatting Strings in class LoggingResultSet
[ https://issues.apache.org/jira/browse/ARTEMIS-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065057#comment-17065057 ] ASF subversion and git services commented on ARTEMIS-2668: -- Commit f0b6e519593cae6cd9d73cb275ff99199dce9ffa in activemq-artemis's branch refs/heads/master from Benjamin Graf [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=f0b6e51 ] ARTEMIS-2668: Fix several format String definitions > Wrong formatting Strings in class LoggingResultSet > -- > > Key: ARTEMIS-2668 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2668 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.11.0 >Reporter: Benjamin Graf >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Several methods of {{LoggingResultSet}} have wrong amount of parameters in > formatting {{String}} causing exception if TRACE logging. > e.g. > {noformat} > AMQ222010: Critical IO Error, shutting down the server. > file=org.apache.activemq.artemis.jdbc.store.file.JDBCSequentialFile@27cbabd3, > message=Error writing to JDBC file. > java.util.MissingFormatArgumentException: Format specifier '%s' > at java.util.Formatter.format(Formatter.java:2672) ~[?:?] > at java.util.Formatter.format(Formatter.java:2609) ~[?:?] > at java.lang.String.format(String.java:2897) ~[?:?] > at > org.ops4j.pax.logging.jbosslogging.JBossLoggingLogger.doLogf(JBossLoggingLogger.java:87) > ~[!/:?] > at org.jboss.logging.Logger.logf(Logger.java:2326) ~[!/:?] > at > org.apache.activemq.artemis.jdbc.store.logging.LoggingResultSet.updateBlob(LoggingResultSet.java:950) > ~[!/:?] > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2608) ClassCastException when consuming a message using OpenWire
[ https://issues.apache.org/jira/browse/ARTEMIS-2608?focusedWorklogId=408220=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408220 ] ASF GitHub Bot logged work on ARTEMIS-2608: --- Author: ASF GitHub Bot Created on: 23/Mar/20 19:55 Start Date: 23/Mar/20 19:55 Worklog Time Spent: 10m Work Description: clebertsuconic commented on issue #2954: ARTEMIS-2608 Fix ClassCastException on binary properties conversion URL: https://github.com/apache/activemq-artemis/pull/2954#issuecomment-602822329 @fvaleri the test does not fail without the fix.. I don't see how this test is validating anything. It would be nice to understand what is the issue so we can fix the converter. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408220) Time Spent: 4h 20m (was: 4h 10m) > ClassCastException when consuming a message using OpenWire > -- > > Key: ARTEMIS-2608 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2608 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP, OpenWire >Affects Versions: 2.11.0 >Reporter: Federico Valeri >Priority: Major > Attachments: cce-reproducer.zip > > Time Spent: 4h 20m > Remaining Estimate: 0h > > This issue seems to be related to the conversion of binary properties. > Quick workaround: clear message properties in the AMQP producer. > Reproducer (attached): > 1. Send a message to the broker using OpenWire client > 2. Consume that message using AMQP client > 3. Send that message back to the broker using AMQP client > Result: message could not be consumed by the OpenWire consumer. > {code:java} > 2020-01-23 12:52:44,095 WARN [org.apache.activemq.artemis.core.server] Error > during message dispatch: java.lang.ClassCastException: > org.apache.activemq.artemis.api.core.SimpleString cannot be cast to [B > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.toAMQMessage(OpenWireMessageConverter.java:629) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.createMessageDispatch(OpenWireMessageConverter.java:501) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQConsumer.handleDeliver(AMQConsumer.java:258) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQSession.sendMessage(AMQSession.java:312) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1161) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:504) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:3510) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2856) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.access$2300(QueueImpl.java:122) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:3848) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > [rt.jar:1.8.0_232] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > [rt.jar:1.8.0_232] > at > org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) >
[jira] [Work logged] (ARTEMIS-2608) ClassCastException when consuming a message using OpenWire
[ https://issues.apache.org/jira/browse/ARTEMIS-2608?focusedWorklogId=408131=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408131 ] ASF GitHub Bot logged work on ARTEMIS-2608: --- Author: ASF GitHub Bot Created on: 23/Mar/20 18:30 Start Date: 23/Mar/20 18:30 Worklog Time Spent: 10m Work Description: tabish121 commented on pull request #2954: ARTEMIS-2608 Fix ClassCastException on binary properties conversion URL: https://github.com/apache/activemq-artemis/pull/2954#discussion_r396669227 ## File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/AmqpCoreConverter.java ## @@ -477,7 +477,7 @@ private static void setProperty(javax.jms.Message msg, String key, Object value) } else if (value instanceof Decimal32) { msg.setFloatProperty(key, ((Decimal32) value).floatValue()); } else if (value instanceof Binary) { - msg.setStringProperty(key, value.toString()); + msg.setObjectProperty(key, ((Binary) value).getArray()); Review comment: This isn't a complete fix as the Binary value may contain a subsequence of some other array value possibly a slice from another buffer owned by someone else so you need to copy this if the Binary has an array offset or relative length value that doesn't match the underlying array otherwise you end up with a value on the other side that doesn't match the original scoped array contents. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408131) Time Spent: 4h 10m (was: 4h) > ClassCastException when consuming a message using OpenWire > -- > > Key: ARTEMIS-2608 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2608 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP, OpenWire >Affects Versions: 2.11.0 >Reporter: Federico Valeri >Priority: Major > Attachments: cce-reproducer.zip > > Time Spent: 4h 10m > Remaining Estimate: 0h > > This issue seems to be related to the conversion of binary properties. > Quick workaround: clear message properties in the AMQP producer. > Reproducer (attached): > 1. Send a message to the broker using OpenWire client > 2. Consume that message using AMQP client > 3. Send that message back to the broker using AMQP client > Result: message could not be consumed by the OpenWire consumer. > {code:java} > 2020-01-23 12:52:44,095 WARN [org.apache.activemq.artemis.core.server] Error > during message dispatch: java.lang.ClassCastException: > org.apache.activemq.artemis.api.core.SimpleString cannot be cast to [B > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.toAMQMessage(OpenWireMessageConverter.java:629) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.createMessageDispatch(OpenWireMessageConverter.java:501) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQConsumer.handleDeliver(AMQConsumer.java:258) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQSession.sendMessage(AMQSession.java:312) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1161) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:504) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:3510) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2856) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.access$2300(QueueImpl.java:122) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:3848) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at >
[jira] [Commented] (ARTEMIS-2675) No retry button in web console for messages in auto-created DLQs
[ https://issues.apache.org/jira/browse/ARTEMIS-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065009#comment-17065009 ] Justin Bertram commented on ARTEMIS-2675: - The {{retry(long)}} and {{retry()}} methods are available on *every* {{QueueControl}} whether or not it is being used for dead-letter or expiry purposes. The web console tries to be clever and only present the "Retry" button if it thinks the queue is a dead-letter queue, but I think this is the wrong approach. I think the "Retry" button should be available on every queue. > No retry button in web console for messages in auto-created DLQs > > > Key: ARTEMIS-2675 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2675 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.12.0 >Reporter: Piotr Klimczak >Priority: Major > > Retry button is not showing up as an option for messages in auto-created DLQs. > Instead "Resend" button is presented. > Quick code analysis is show that this in fact is caused by 2 reasons: > 1. There is no attribute on queue which would indicate easily if it is used > for DLQ purposes. > 2. Because of above, web console code has hardcoded value DLQ, unless > defined in console preferences. > See loadTable function in browse.js of artemis-plugin module. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2608) ClassCastException when consuming a message using OpenWire
[ https://issues.apache.org/jira/browse/ARTEMIS-2608?focusedWorklogId=408126=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408126 ] ASF GitHub Bot logged work on ARTEMIS-2608: --- Author: ASF GitHub Bot Created on: 23/Mar/20 18:24 Start Date: 23/Mar/20 18:24 Worklog Time Spent: 10m Work Description: brusdev commented on issue #2954: ARTEMIS-2608 Fix ClassCastException on binary properties conversion URL: https://github.com/apache/activemq-artemis/pull/2954#issuecomment-602775934 How does the test check the fix? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408126) Time Spent: 4h (was: 3h 50m) > ClassCastException when consuming a message using OpenWire > -- > > Key: ARTEMIS-2608 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2608 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP, OpenWire >Affects Versions: 2.11.0 >Reporter: Federico Valeri >Priority: Major > Attachments: cce-reproducer.zip > > Time Spent: 4h > Remaining Estimate: 0h > > This issue seems to be related to the conversion of binary properties. > Quick workaround: clear message properties in the AMQP producer. > Reproducer (attached): > 1. Send a message to the broker using OpenWire client > 2. Consume that message using AMQP client > 3. Send that message back to the broker using AMQP client > Result: message could not be consumed by the OpenWire consumer. > {code:java} > 2020-01-23 12:52:44,095 WARN [org.apache.activemq.artemis.core.server] Error > during message dispatch: java.lang.ClassCastException: > org.apache.activemq.artemis.api.core.SimpleString cannot be cast to [B > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.toAMQMessage(OpenWireMessageConverter.java:629) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.createMessageDispatch(OpenWireMessageConverter.java:501) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQConsumer.handleDeliver(AMQConsumer.java:258) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQSession.sendMessage(AMQSession.java:312) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1161) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:504) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:3510) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2856) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.access$2300(QueueImpl.java:122) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:3848) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > [rt.jar:1.8.0_232] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > [rt.jar:1.8.0_232] > at > org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > {code} > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-2678) Incomplete records for pages under high load
[ https://issues.apache.org/jira/browse/ARTEMIS-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064970#comment-17064970 ] Ansgar J. Sachs commented on ARTEMIS-2678: -- - I am using version 2.11.0 of Artemis with OpenWire as protocol. - We are using a shared-store after we had some troubles with Replication and XA-Transactions. - For our test setup we had two JVMs running on one node - so just separated by process > Incomplete records for pages under high load > > > Key: ARTEMIS-2678 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2678 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker > Environment: Linux >Reporter: Ansgar J. Sachs >Priority: Major > Attachments: Bildschirmfoto 2020-03-23 um 17.35.41.png > > > {quote}As developer, I expect paging to be resource saving and resilient to > high load{quote} > h3. Current Situation > During a performance test with a throughput of ~25.000 messages per second > that run mulitple hours, some consumers were too slow to consume and messages > piled up on the broker. For this reason, the broker started to page the > messages of growing queues. When we reduced the load from the broker, some > queues stopped consuming due to the following logs: > {code} > AMQ222033: Page file 7.page had incomplete records at position > 39,795,399 at record number 13,952 > target message no.16146 not found from start offset 46032883 and start > message number 16146: java.lang.RuntimeException: target message no.16146 not > found from start offset 46032883 and start message number 16146 > {code} > It wasnt possible to recover from this state but deleting the paging > directory. > h3. Expected Situation > I would expect that the paging mechanism is resilient to any errors. > h3. Scenario Setup > Master configuration: > {code:xml} > > > > true > > > > > > 256Mb > 64Mb > > 10 > PAGE > > {code} > An extract of the monitoring of the Performance Test is attached to this > issue. > h3. Workaround > Right now we disabled paging at all and only use our Heap. However, the heap > is exhausted at 5 million messages which is in our use case better than > loosing any of them. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (ARTEMIS-2678) Incomplete records for pages under high load
[ https://issues.apache.org/jira/browse/ARTEMIS-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064946#comment-17064946 ] Francesco Nigro edited comment on ARTEMIS-2678 at 3/23/20, 5:25 PM: * Which version of artemis? * I see you're using shared-store, are you sure is the right choice if high throughput is needed? * Are you using NFS or any similar solution? * Which protocol of messages is being used? Core, AMQP, etc etc was (Author: nigro@gmail.com): * Which version of artemis? * I see you're using shared-store, are you sure is the right choice if high throughput are needed? * Which protocol of messages is being used? Core, AMQP, etc etc > Incomplete records for pages under high load > > > Key: ARTEMIS-2678 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2678 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker > Environment: Linux >Reporter: Ansgar J. Sachs >Priority: Major > Attachments: Bildschirmfoto 2020-03-23 um 17.35.41.png > > > {quote}As developer, I expect paging to be resource saving and resilient to > high load{quote} > h3. Current Situation > During a performance test with a throughput of ~25.000 messages per second > that run mulitple hours, some consumers were too slow to consume and messages > piled up on the broker. For this reason, the broker started to page the > messages of growing queues. When we reduced the load from the broker, some > queues stopped consuming due to the following logs: > {code} > AMQ222033: Page file 7.page had incomplete records at position > 39,795,399 at record number 13,952 > target message no.16146 not found from start offset 46032883 and start > message number 16146: java.lang.RuntimeException: target message no.16146 not > found from start offset 46032883 and start message number 16146 > {code} > It wasnt possible to recover from this state but deleting the paging > directory. > h3. Expected Situation > I would expect that the paging mechanism is resilient to any errors. > h3. Scenario Setup > Master configuration: > {code:xml} > > > > true > > > > > > 256Mb > 64Mb > > 10 > PAGE > > {code} > An extract of the monitoring of the Performance Test is attached to this > issue. > h3. Workaround > Right now we disabled paging at all and only use our Heap. However, the heap > is exhausted at 5 million messages which is in our use case better than > loosing any of them. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=408064=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408064 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 23/Mar/20 17:07 Start Date: 23/Mar/20 17:07 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-602733268 I'm planning to add another commit to try save completely reading the `Page`, or I should just send another pr for this. @wy96f @clebertsuconic seems that I cannot assign reviewers, so I'm calling out directly ;) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408064) Time Spent: 20m (was: 10m) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=408063=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408063 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 23/Mar/20 17:06 Start Date: 23/Mar/20 17:06 Worklog Time Spent: 10m Work Description: franz1981 commented on pull request #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044 PageCurosrProviderImpl::cleanup is calling PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not present in the PageCache), just to trigger large messages delete. The decoding phase could be skipped and possibly the page read as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408063) Remaining Estimate: 0h Time Spent: 10m > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-2677) Artemis 2.11.0 RejectedExecutionException after successful failover
[ https://issues.apache.org/jira/browse/ARTEMIS-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064950#comment-17064950 ] Justin Bertram commented on ARTEMIS-2677: - Also, can you attach the {{broker.xml}} files from the two servers? > Artemis 2.11.0 RejectedExecutionException after successful failover > --- > > Key: ARTEMIS-2677 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2677 > Project: ActiveMQ Artemis > Issue Type: Bug > Environment: Environment: Artemis 2.11.0 (Master-Slave) > SharedStore, FilePing. AWS EFS/NFS. >Reporter: Jigar Shah >Priority: Major > > Observed an issue on master shutdown, the slave became active. Right after > slave being active it started printing "RejectedExecutionException". Also, > consumers from master to slave was not transferred. And client application > stopped processing messages. > Note RejectedExecutionException had [Terminated, pool size = 0, active > threads = 0, queued tasks = 0, completed tasks = 59059] > Following are the logs during failover from master to slave: > Master1: > {noformat} > 2020-03-18 12:34:39,911 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 26fb51af-690c-11ea-959a-12f8371a8293 > 2020-03-18 12:34:39,912 INFO [org.apache.activemq.artemis.core.server] > AMQ221029: stopped bridge > $.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9 > 2020-03-18 12:34:39,950 WARN [org.apache.activemq.artemis.core.server] > AMQ222061: Client connection failed, clearing up resources for session > 2655265e-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 2655265e-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222061: Client connection failed, clearing up resources for session > 2662e209-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 2662e209-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222061: Client connection failed, clearing up resources for session > 2669bfdd-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 2669bfdd-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,993 WARN [org.apache.activemq.artemis.core.server] > AMQ222061: Client connection failed, clearing up resources for session > 26615b64-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,994 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 26615b64-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,994 WARN [org.apache.activemq.artemis.core.client] > AMQ212037: Connection failure to artemis1.sl.idsk.com/10.110.0.17:61616 has > been detected: AMQ219015: The connection was disconnected because of server > shutdown [code=DISCONNECTED] > 2020-03-18 12:34:40,123 FINE [org.jgroups.protocols.FILE_PING] remove > persistence-fs > 2020-03-18 12:34:40,137 FINE [org.jgroups.protocols.FD_SOCK] > ip-10-110-0-17-18496: socket to ip-10-110-0-88-23224 was closed gracefully > 2020-03-18 12:34:40,138 FINE [org.jgroups.protocols.TCP] closing sockets and > stopping threads > 2020-03-18 12:34:40,169 WARN [org.apache.activemq.artemis.core.client] > AMQ212004: Failed to connect to server. > 2020-03-18 12:34:41,336 INFO [io.hawt.web.AuthenticationFilter] Destroying > hawtio authentication filter > 2020-03-18 12:34:41,341 INFO [io.hawt.HawtioContextListener] Destroying > hawtio services > 2020-03-18 12:34:41,464 INFO > [org.apache.activemq.hawtio.plugin.PluginContextListener] Destroyed > artemis-plugin plugin > 2020-03-18 12:34:41,472 INFO > [org.apache.activemq.hawtio.branding.PluginContextListener] Destroyed > activemq-branding plugin > 2020-03-18 12:34:41,509 INFO [org.apache.activemq.artemis.core.server] > AMQ221002: Apache ActiveMQ Artemis Message Broker version 2.11.0 > [19ade3bb-5f75-11ea-b327-1216d251b187] stopped, uptime 5 hours 2 minutes > {noformat} > Slave1: > {noformat} > 2020-03-18 12:35:01,613 INFO [org.apache.activemq.artemis.core.server] > AMQ221010: Backup Server is now live > 2020-03-18 12:35:01,626 INFO [org.apache.activemq.artemis.core.server] > AMQ221027: Bridge ClusterConnectionBridge@5ced3917 > [name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9, > queue=QueueImpl[name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9, > postOffice=PostOfficeImpl > [server=ActiveMQServerImpl::serverUUID=19ade3bb-5f75-11ea-b327-1216d251b187], > temp=false]@58d2a652
[jira] [Commented] (ARTEMIS-2677) Artemis 2.11.0 RejectedExecutionException after successful failover
[ https://issues.apache.org/jira/browse/ARTEMIS-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064949#comment-17064949 ] Justin Bertram commented on ARTEMIS-2677: - Can you replicate this outside of AWS? > Artemis 2.11.0 RejectedExecutionException after successful failover > --- > > Key: ARTEMIS-2677 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2677 > Project: ActiveMQ Artemis > Issue Type: Bug > Environment: Environment: Artemis 2.11.0 (Master-Slave) > SharedStore, FilePing. AWS EFS/NFS. >Reporter: Jigar Shah >Priority: Major > > Observed an issue on master shutdown, the slave became active. Right after > slave being active it started printing "RejectedExecutionException". Also, > consumers from master to slave was not transferred. And client application > stopped processing messages. > Note RejectedExecutionException had [Terminated, pool size = 0, active > threads = 0, queued tasks = 0, completed tasks = 59059] > Following are the logs during failover from master to slave: > Master1: > {noformat} > 2020-03-18 12:34:39,911 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 26fb51af-690c-11ea-959a-12f8371a8293 > 2020-03-18 12:34:39,912 INFO [org.apache.activemq.artemis.core.server] > AMQ221029: stopped bridge > $.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9 > 2020-03-18 12:34:39,950 WARN [org.apache.activemq.artemis.core.server] > AMQ222061: Client connection failed, clearing up resources for session > 2655265e-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 2655265e-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222061: Client connection failed, clearing up resources for session > 2662e209-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 2662e209-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222061: Client connection failed, clearing up resources for session > 2669bfdd-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 2669bfdd-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,993 WARN [org.apache.activemq.artemis.core.server] > AMQ222061: Client connection failed, clearing up resources for session > 26615b64-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,994 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 26615b64-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,994 WARN [org.apache.activemq.artemis.core.client] > AMQ212037: Connection failure to artemis1.sl.idsk.com/10.110.0.17:61616 has > been detected: AMQ219015: The connection was disconnected because of server > shutdown [code=DISCONNECTED] > 2020-03-18 12:34:40,123 FINE [org.jgroups.protocols.FILE_PING] remove > persistence-fs > 2020-03-18 12:34:40,137 FINE [org.jgroups.protocols.FD_SOCK] > ip-10-110-0-17-18496: socket to ip-10-110-0-88-23224 was closed gracefully > 2020-03-18 12:34:40,138 FINE [org.jgroups.protocols.TCP] closing sockets and > stopping threads > 2020-03-18 12:34:40,169 WARN [org.apache.activemq.artemis.core.client] > AMQ212004: Failed to connect to server. > 2020-03-18 12:34:41,336 INFO [io.hawt.web.AuthenticationFilter] Destroying > hawtio authentication filter > 2020-03-18 12:34:41,341 INFO [io.hawt.HawtioContextListener] Destroying > hawtio services > 2020-03-18 12:34:41,464 INFO > [org.apache.activemq.hawtio.plugin.PluginContextListener] Destroyed > artemis-plugin plugin > 2020-03-18 12:34:41,472 INFO > [org.apache.activemq.hawtio.branding.PluginContextListener] Destroyed > activemq-branding plugin > 2020-03-18 12:34:41,509 INFO [org.apache.activemq.artemis.core.server] > AMQ221002: Apache ActiveMQ Artemis Message Broker version 2.11.0 > [19ade3bb-5f75-11ea-b327-1216d251b187] stopped, uptime 5 hours 2 minutes > {noformat} > Slave1: > {noformat} > 2020-03-18 12:35:01,613 INFO [org.apache.activemq.artemis.core.server] > AMQ221010: Backup Server is now live > 2020-03-18 12:35:01,626 INFO [org.apache.activemq.artemis.core.server] > AMQ221027: Bridge ClusterConnectionBridge@5ced3917 > [name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9, > queue=QueueImpl[name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9, > postOffice=PostOfficeImpl > [server=ActiveMQServerImpl::serverUUID=19ade3bb-5f75-11ea-b327-1216d251b187], > temp=false]@58d2a652 targetConnector=ServerLocatorImpl >
[jira] [Updated] (ARTEMIS-2677) Artemis 2.11.0 RejectedExecutionException after successful failover
[ https://issues.apache.org/jira/browse/ARTEMIS-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-2677: Environment: Environment: Artemis 2.11.0 (Master-Slave) SharedStore, FilePing. AWS EFS/NFS. was: *Environment: Artemis 2.11.0 (Master-Slave)* *SharedStore, FilePing. AWS EFS/NFS.* > Artemis 2.11.0 RejectedExecutionException after successful failover > --- > > Key: ARTEMIS-2677 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2677 > Project: ActiveMQ Artemis > Issue Type: Bug > Environment: Environment: Artemis 2.11.0 (Master-Slave) > SharedStore, FilePing. AWS EFS/NFS. >Reporter: Jigar Shah >Priority: Major > > Observed an issue on master shutdown, the slave became active. Right after > slave being active it started printing "RejectedExecutionException". Also, > consumers from master to slave was not transferred. And client application > stopped processing messages. > Note RejectedExecutionException had [Terminated, pool size = 0, active > threads = 0, queued tasks = 0, completed tasks = 59059] > Following are the logs during failover from master to slave: > Master1: > {noformat} > 2020-03-18 12:34:39,911 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 26fb51af-690c-11ea-959a-12f8371a8293 > 2020-03-18 12:34:39,912 INFO [org.apache.activemq.artemis.core.server] > AMQ221029: stopped bridge > $.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9 > 2020-03-18 12:34:39,950 WARN [org.apache.activemq.artemis.core.server] > AMQ222061: Client connection failed, clearing up resources for session > 2655265e-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 2655265e-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222061: Client connection failed, clearing up resources for session > 2662e209-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 2662e209-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222061: Client connection failed, clearing up resources for session > 2669bfdd-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 2669bfdd-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,993 WARN [org.apache.activemq.artemis.core.server] > AMQ222061: Client connection failed, clearing up resources for session > 26615b64-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,994 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 26615b64-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,994 WARN [org.apache.activemq.artemis.core.client] > AMQ212037: Connection failure to artemis1.sl.idsk.com/10.110.0.17:61616 has > been detected: AMQ219015: The connection was disconnected because of server > shutdown [code=DISCONNECTED] > 2020-03-18 12:34:40,123 FINE [org.jgroups.protocols.FILE_PING] remove > persistence-fs > 2020-03-18 12:34:40,137 FINE [org.jgroups.protocols.FD_SOCK] > ip-10-110-0-17-18496: socket to ip-10-110-0-88-23224 was closed gracefully > 2020-03-18 12:34:40,138 FINE [org.jgroups.protocols.TCP] closing sockets and > stopping threads > 2020-03-18 12:34:40,169 WARN [org.apache.activemq.artemis.core.client] > AMQ212004: Failed to connect to server. > 2020-03-18 12:34:41,336 INFO [io.hawt.web.AuthenticationFilter] Destroying > hawtio authentication filter > 2020-03-18 12:34:41,341 INFO [io.hawt.HawtioContextListener] Destroying > hawtio services > 2020-03-18 12:34:41,464 INFO > [org.apache.activemq.hawtio.plugin.PluginContextListener] Destroyed > artemis-plugin plugin > 2020-03-18 12:34:41,472 INFO > [org.apache.activemq.hawtio.branding.PluginContextListener] Destroyed > activemq-branding plugin > 2020-03-18 12:34:41,509 INFO [org.apache.activemq.artemis.core.server] > AMQ221002: Apache ActiveMQ Artemis Message Broker version 2.11.0 > [19ade3bb-5f75-11ea-b327-1216d251b187] stopped, uptime 5 hours 2 minutes > {noformat} > Slave1: > {noformat} > 2020-03-18 12:35:01,613 INFO [org.apache.activemq.artemis.core.server] > AMQ221010: Backup Server is now live > 2020-03-18 12:35:01,626 INFO [org.apache.activemq.artemis.core.server] > AMQ221027: Bridge ClusterConnectionBridge@5ced3917 > [name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9, > queue=QueueImpl[name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9, > postOffice=PostOfficeImpl >
[jira] [Updated] (ARTEMIS-2677) Artemis 2.11.0 RejectedExecutionException after successful failover
[ https://issues.apache.org/jira/browse/ARTEMIS-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-2677: Description: Observed an issue on master shutdown, the slave became active. Right after slave being active it started printing "RejectedExecutionException". Also, consumers from master to slave was not transferred. And client application stopped processing messages. Note RejectedExecutionException had [Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 59059] Following are the logs during failover from master to slave: Master1: {noformat} 2020-03-18 12:34:39,911 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 26fb51af-690c-11ea-959a-12f8371a8293 2020-03-18 12:34:39,912 INFO [org.apache.activemq.artemis.core.server] AMQ221029: stopped bridge $.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9 2020-03-18 12:34:39,950 WARN [org.apache.activemq.artemis.core.server] AMQ222061: Client connection failed, clearing up resources for session 2655265e-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 2655265e-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222061: Client connection failed, clearing up resources for session 2662e209-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 2662e209-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222061: Client connection failed, clearing up resources for session 2669bfdd-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 2669bfdd-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,993 WARN [org.apache.activemq.artemis.core.server] AMQ222061: Client connection failed, clearing up resources for session 26615b64-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,994 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 26615b64-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,994 WARN [org.apache.activemq.artemis.core.client] AMQ212037: Connection failure to artemis1.sl.idsk.com/10.110.0.17:61616 has been detected: AMQ219015: The connection was disconnected because of server shutdown [code=DISCONNECTED] 2020-03-18 12:34:40,123 FINE [org.jgroups.protocols.FILE_PING] remove persistence-fs 2020-03-18 12:34:40,137 FINE [org.jgroups.protocols.FD_SOCK] ip-10-110-0-17-18496: socket to ip-10-110-0-88-23224 was closed gracefully 2020-03-18 12:34:40,138 FINE [org.jgroups.protocols.TCP] closing sockets and stopping threads 2020-03-18 12:34:40,169 WARN [org.apache.activemq.artemis.core.client] AMQ212004: Failed to connect to server. 2020-03-18 12:34:41,336 INFO [io.hawt.web.AuthenticationFilter] Destroying hawtio authentication filter 2020-03-18 12:34:41,341 INFO [io.hawt.HawtioContextListener] Destroying hawtio services 2020-03-18 12:34:41,464 INFO [org.apache.activemq.hawtio.plugin.PluginContextListener] Destroyed artemis-plugin plugin 2020-03-18 12:34:41,472 INFO [org.apache.activemq.hawtio.branding.PluginContextListener] Destroyed activemq-branding plugin 2020-03-18 12:34:41,509 INFO [org.apache.activemq.artemis.core.server] AMQ221002: Apache ActiveMQ Artemis Message Broker version 2.11.0 [19ade3bb-5f75-11ea-b327-1216d251b187] stopped, uptime 5 hours 2 minutes {noformat} Slave1: {noformat} 2020-03-18 12:35:01,613 INFO [org.apache.activemq.artemis.core.server] AMQ221010: Backup Server is now live 2020-03-18 12:35:01,626 INFO [org.apache.activemq.artemis.core.server] AMQ221027: Bridge ClusterConnectionBridge@5ced3917 [name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9, queue=QueueImpl[name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9, postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUUID=19ade3bb-5f75-11ea-b327-1216d251b187], temp=false]@58d2a652 targetConnector=ServerLocatorImpl (identity=(Cluster-connection-bridge::ClusterConnectionBridge@5ced3917 [name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9, queue=QueueImpl[name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9, postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUUID=19ade3bb-5f75-11ea-b327-1216d251b187], temp=false]@58d2a652 targetConnector=ServerLocatorImpl [initialConnectors=[TransportConfiguration(name=netty-connector, factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory) ?port=61616=artemis2-sl-idsk-com], discoveryGroupConfiguration=null]]::ClusterConnectionImpl@1788190971[nodeUUID=19ade3bb-5f75-11ea-b327-1216d251b187,
[jira] [Commented] (ARTEMIS-2678) Incomplete records for pages under high load
[ https://issues.apache.org/jira/browse/ARTEMIS-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064946#comment-17064946 ] Francesco Nigro commented on ARTEMIS-2678: -- * Which version of artemis? * I see you're using shared-store, are you sure is the right choice if high throughput are needed? * Which protocol of messages is being used? Core, AMQP, etc etc > Incomplete records for pages under high load > > > Key: ARTEMIS-2678 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2678 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker > Environment: Linux >Reporter: Ansgar J. Sachs >Priority: Major > Attachments: Bildschirmfoto 2020-03-23 um 17.35.41.png > > > {quote}As developer, I expect paging to be resource saving and resilient to > high load{quote} > h3. Current Situation > During a performance test with a throughput of ~25.000 messages per second > that run mulitple hours, some consumers were too slow to consume and messages > piled up on the broker. For this reason, the broker started to page the > messages of growing queues. When we reduced the load from the broker, some > queues stopped consuming due to the following logs: > {code} > AMQ222033: Page file 7.page had incomplete records at position > 39,795,399 at record number 13,952 > target message no.16146 not found from start offset 46032883 and start > message number 16146: java.lang.RuntimeException: target message no.16146 not > found from start offset 46032883 and start message number 16146 > {code} > It wasnt possible to recover from this state but deleting the paging > directory. > h3. Expected Situation > I would expect that the paging mechanism is resilient to any errors. > h3. Scenario Setup > Master configuration: > {code:xml} > > > > true > > > > > > 256Mb > 64Mb > > 10 > PAGE > > {code} > An extract of the monitoring of the Performance Test is attached to this > issue. > h3. Workaround > Right now we disabled paging at all and only use our Heap. However, the heap > is exhausted at 5 million messages which is in our use case better than > loosing any of them. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ARTEMIS-2677) Artemis 2.11.0 RejectedExecutionException after successful failover
[ https://issues.apache.org/jira/browse/ARTEMIS-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-2677: Description: Observed an issue on master shutdown, the slave became active. Right after slave being active it started printing "RejectedExecutionException". Also, consumers from master to slave was not transferred. And client application stopped processing messages. Note RejectedExecutionException had [Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 59059] Following are the logs during failover from master to slave: Master1: {noformat} 2020-03-18 12:34:39,911 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 26fb51af-690c-11ea-959a-12f8371a8293 2020-03-18 12:34:39,912 INFO [org.apache.activemq.artemis.core.server] AMQ221029: stopped bridge $.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9 2020-03-18 12:34:39,950 WARN [org.apache.activemq.artemis.core.server] AMQ222061: Client connection failed, clearing up resources for session 2655265e-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 2655265e-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222061: Client connection failed, clearing up resources for session 2662e209-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 2662e209-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222061: Client connection failed, clearing up resources for session 2669bfdd-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 2669bfdd-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,993 WARN [org.apache.activemq.artemis.core.server] AMQ222061: Client connection failed, clearing up resources for session 26615b64-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,994 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 26615b64-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,994 WARN [org.apache.activemq.artemis.core.client] AMQ212037: Connection failure to artemis1.sl.idsk.com/10.110.0.17:61616 has been detected: AMQ219015: The connection was disconnected because of server shutdown [code=DISCONNECTED] 2020-03-18 12:34:40,123 FINE [org.jgroups.protocols.FILE_PING] remove persistence-fs 2020-03-18 12:34:40,137 FINE [org.jgroups.protocols.FD_SOCK] ip-10-110-0-17-18496: socket to ip-10-110-0-88-23224 was closed gracefully 2020-03-18 12:34:40,138 FINE [org.jgroups.protocols.TCP] closing sockets and stopping threads 2020-03-18 12:34:40,169 WARN [org.apache.activemq.artemis.core.client] AMQ212004: Failed to connect to server. 2020-03-18 12:34:41,336 INFO [io.hawt.web.AuthenticationFilter] Destroying hawtio authentication filter 2020-03-18 12:34:41,341 INFO [io.hawt.HawtioContextListener] Destroying hawtio services 2020-03-18 12:34:41,464 INFO [org.apache.activemq.hawtio.plugin.PluginContextListener] Destroyed artemis-plugin plugin 2020-03-18 12:34:41,472 INFO [org.apache.activemq.hawtio.branding.PluginContextListener] Destroyed activemq-branding plugin 2020-03-18 12:34:41,509 INFO [org.apache.activemq.artemis.core.server] AMQ221002: Apache ActiveMQ Artemis Message Broker version 2.11.0 [19ade3bb-5f75-11ea-b327-1216d251b187] stopped, uptime 5 hours 2 minutes {noformat} Slave1: {noformat} 2020-03-18 12:35:01,613 INFO [org.apache.activemq.artemis.core.server] AMQ221010: Backup Server is now live 2020-03-18 12:35:01,626 INFO [org.apache.activemq.artemis.core.server] AMQ221027: Bridge ClusterConnectionBridge@5ced3917 [name=$.artemis.internal.sf.my-cluster.2c85cd 9e-5f75-11ea-9be1-0af9119190b9, queue=QueueImpl[name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9, postOffice=PostOfficeImpl [server=ActiveMQSe rverImpl::serverUUID=19ade3bb-5f75-11ea-b327-1216d251b187], temp=false]@58d2a652 targetConnector=ServerLocatorImpl (identity=(Cluster-connection-bridge::ClusterConnectionBridge@5ced3917 [name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9, queue=QueueImpl[name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9, postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUUID=19ade3bb-5f75-11ea-b327-1216d251b187], temp=false]@58d2a652 targetConnector=ServerLocatorImpl [initialConnectors=[TransportConfiguration(name=netty-connector, factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory) ?port=61616=artemis2-sl-idsk-com], discoveryGroupConfiguration=null]]::ClusterConnectionImpl@1788190971[nodeUUID=19ade3bb-5f75-11ea-b327-1216d251b187,
[jira] [Updated] (ARTEMIS-2677) Artemis 2.11.0 RejectedExecutionException after successful failover
[ https://issues.apache.org/jira/browse/ARTEMIS-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-2677: Description: Observed an issue on master shutdown, the slave became active. Right after slave being active it started printing "RejectedExecutionException". Also, consumers from master to slave was not transferred. And client application stopped processing messages. Note RejectedExecutionException had [Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 59059] Following are the logs during failover from master to slave: Master1: {noformat} 2020-03-18 12:34:39,911 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 26fb51af-690c-11ea-959a-12f8371a8293 2020-03-18 12:34:39,912 INFO [org.apache.activemq.artemis.core.server] AMQ221029: stopped bridge $.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9 2020-03-18 12:34:39,950 WARN [org.apache.activemq.artemis.core.server] AMQ222061: Client connection failed, clearing up resources for session 2655265e-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 2655265e-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222061: Client connection failed, clearing up resources for session 2662e209-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 2662e209-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222061: Client connection failed, clearing up resources for session 2669bfdd-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 2669bfdd-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,993 WARN [org.apache.activemq.artemis.core.server] AMQ222061: Client connection failed, clearing up resources for session 26615b64-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,994 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 26615b64-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,994 WARN [org.apache.activemq.artemis.core.client] AMQ212037: Connection failure to artemis1.sl.idsk.com/10.110.0.17:61616 has been detected: AMQ219015: The connection was disconnected because of server shutdown [code=DISCONNECTED] 2020-03-18 12:34:40,123 FINE [org.jgroups.protocols.FILE_PING] remove persistence-fs 2020-03-18 12:34:40,137 FINE [org.jgroups.protocols.FD_SOCK] ip-10-110-0-17-18496: socket to ip-10-110-0-88-23224 was closed gracefully 2020-03-18 12:34:40,138 FINE [org.jgroups.protocols.TCP] closing sockets and stopping threads 2020-03-18 12:34:40,169 WARN [org.apache.activemq.artemis.core.client] AMQ212004: Failed to connect to server. 2020-03-18 12:34:41,336 INFO [io.hawt.web.AuthenticationFilter] Destroying hawtio authentication filter 2020-03-18 12:34:41,341 INFO [io.hawt.HawtioContextListener] Destroying hawtio services 2020-03-18 12:34:41,464 INFO [org.apache.activemq.hawtio.plugin.PluginContextListener] Destroyed artemis-plugin plugin 2020-03-18 12:34:41,472 INFO [org.apache.activemq.hawtio.branding.PluginContextListener] Destroyed activemq-branding plugin 2020-03-18 12:34:41,509 INFO [org.apache.activemq.artemis.core.server] AMQ221002: Apache ActiveMQ Artemis Message Broker version 2.11.0 [19ade3bb-5f75-11ea-b327-1216d251b187] stopped, uptime 5 hours 2 minutes {noformat} Slave1: {noformat} 2020-03-18 12:35:01,613 INFO [org.apache.activemq.artemis.core.server] AMQ221010: Backup Server is now live 2020-03-18 12:35:01,626 INFO [org.apache.activemq.artemis.core.server] AMQ221027: Bridge ClusterConnectionBridge@5ced3917 [name=$.artemis.internal.sf.my-cluster.2c85cd 9e-5f75-11ea-9be1-0af9119190b9, queue=QueueImpl[name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9, postOffice=PostOfficeImpl [server=ActiveMQSe rverImpl::serverUUID=19ade3bb-5f75-11ea-b327-1216d251b187], temp=false]@58d2a652 targetConnector=ServerLocatorImpl (identity=(Cluster-connection-bridge::ClusterConnecti onBridge@5ced3917 [name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9, queue=QueueImpl[name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea- 9be1-0af9119190b9, postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUUID=19ade3bb-5f75-11ea-b327-1216d251b187], temp=false]@58d2a652 targetConnector=ServerLo catorImpl [initialConnectors=[TransportConfiguration(name=netty-connector, factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory) ?port=616 16=artemis2-sl-idsk-c om], discoveryGroupConfiguration=null]]::ClusterConnectionImpl@1788190971[nodeUUID=19ade3bb-5f75-11ea-b327-1216d251b187,
[jira] [Created] (ARTEMIS-2678) Incomplete records for pages under high load
Ansgar J. Sachs created ARTEMIS-2678: Summary: Incomplete records for pages under high load Key: ARTEMIS-2678 URL: https://issues.apache.org/jira/browse/ARTEMIS-2678 Project: ActiveMQ Artemis Issue Type: Bug Components: Broker Environment: Linux Reporter: Ansgar J. Sachs Attachments: Bildschirmfoto 2020-03-23 um 17.35.41.png {quote}As developer, I expect paging to be resource saving and resilient to high load{quote} h3. Current Situation During a performance test with a throughput of ~25.000 messages per second that run mulitple hours, some consumers were too slow to consume and messages piled up on the broker. For this reason, the broker started to page the messages of growing queues. When we reduced the load from the broker, some queues stopped consuming due to the following logs: {code} AMQ222033: Page file 7.page had incomplete records at position 39,795,399 at record number 13,952 target message no.16146 not found from start offset 46032883 and start message number 16146: java.lang.RuntimeException: target message no.16146 not found from start offset 46032883 and start message number 16146 {code} It wasnt possible to recover from this state but deleting the paging directory. h3. Expected Situation I would expect that the paging mechanism is resilient to any errors. h3. Scenario Setup Master configuration: {code:xml} true 256Mb 64Mb 10 PAGE {code} An extract of the monitoring of the Performance Test is attached to this issue. h3. Workaround Right now we disabled paging at all and only use our Heap. However, the heap is exhausted at 5 million messages which is in our use case better than loosing any of them. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-2649) Auto-create DLQ message loss when moving messages between destinations
[ https://issues.apache.org/jira/browse/ARTEMIS-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064907#comment-17064907 ] Justin Bertram commented on ARTEMIS-2649: - bq. Also happy to see that FQQN addresses are also covered which should exhaust all possibilities for this problem to happen. Can you clarify this? I don't recall doing anything specific with FQQN in the PR. > Auto-create DLQ message loss when moving messages between destinations > -- > > Key: ARTEMIS-2649 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2649 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.12.0 > Environment: Centos 7 container in OKD with Java 8. >Reporter: Piotr Klimczak >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > [~jbertram], first of all thanks a lot for ARTEMIS-2587 implementation. > This was a must for me to switch to Artemis. > In past I have even tried to implement it in Artermis, but having no > previous experience with it, only with your PR I understood how nicely and > easily it can be implemented and how much I have overcomplicated it. > So I am testing 2.12.0 snapshot as I am really interested in work done under > ARTEMIS-2587. > I am connecting using open wire protocol using camel-jms component, having > replaced old AMQ5 with Artermis. > On failed consumption, I can see queue being created under DLQ address with > multicast and filter _AMQ_ORIG_ADDRESS = 'some.queue'. > However it is empty and message is lost. > Reproduction scenario: > # Sending message to address A > # Moving message from A queue to B using web console move function > # Consuming from B and failing consumption > Observed state: > # Queue is being created > # Message is lost and logs are not indicating anything > As a result this message being moved from A to be B queue, the header > "_AMQ_ORIG_ADDRESS" has value "A" instead of "B" and therefore it does not > match the filter "B" and is getting lost. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ARTEMIS-2608) ClassCastException when consuming a message using OpenWire
[ https://issues.apache.org/jira/browse/ARTEMIS-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated ARTEMIS-2608: - Component/s: AMQP > ClassCastException when consuming a message using OpenWire > -- > > Key: ARTEMIS-2608 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2608 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP, OpenWire >Affects Versions: 2.11.0 >Reporter: Federico Valeri >Priority: Major > Attachments: cce-reproducer.zip > > Time Spent: 3h 50m > Remaining Estimate: 0h > > This issue seems to be related to the conversion of binary properties. > Quick workaround: clear message properties in the AMQP producer. > Reproducer (attached): > 1. Send a message to the broker using OpenWire client > 2. Consume that message using AMQP client > 3. Send that message back to the broker using AMQP client > Result: message could not be consumed by the OpenWire consumer. > {code:java} > 2020-01-23 12:52:44,095 WARN [org.apache.activemq.artemis.core.server] Error > during message dispatch: java.lang.ClassCastException: > org.apache.activemq.artemis.api.core.SimpleString cannot be cast to [B > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.toAMQMessage(OpenWireMessageConverter.java:629) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.createMessageDispatch(OpenWireMessageConverter.java:501) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQConsumer.handleDeliver(AMQConsumer.java:258) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQSession.sendMessage(AMQSession.java:312) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1161) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:504) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:3510) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2856) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.access$2300(QueueImpl.java:122) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:3848) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > [rt.jar:1.8.0_232] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > [rt.jar:1.8.0_232] > at > org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > {code} > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2649) Auto-create DLQ message loss when moving messages between destinations
[ https://issues.apache.org/jira/browse/ARTEMIS-2649?focusedWorklogId=408015=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408015 ] ASF GitHub Bot logged work on ARTEMIS-2649: --- Author: ASF GitHub Bot Created on: 23/Mar/20 16:10 Start Date: 23/Mar/20 16:10 Worklog Time Spent: 10m Work Description: jbertram commented on pull request #3017: ARTEMIS-2649 refactor ORIG message props URL: https://github.com/apache/activemq-artemis/pull/3017#discussion_r396570384 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java ## @@ -3418,7 +3419,12 @@ private boolean sendToDeadLetterAddress(final Transaction tx, ref.acknowledge(tx, AckReason.KILLED, null); } else { ActiveMQServerLogger.LOGGER.messageExceededMaxDeliverySendtoDLA(ref, deadLetterAddress, name); -move(tx, deadLetterAddress, null, ref, false, AckReason.KILLED, null); +RoutingStatus status = move(tx, deadLetterAddress, null, ref, false, AckReason.KILLED, null); + +// this shouldn't happen, but in case it does it's better to log a message than just drop the message silently +if (status.equals(RoutingStatus.NO_BINDINGS) && server.getAddressSettingsRepository().getMatch(getAddress().toString()).isAutoCreateDeadLetterResources()) { + ActiveMQServerLogger.LOGGER.noMatchingBindingsOnDLAWithAutoCreateDLAResources(deadLetterAddress, ref.toString()); Review comment: Rather than get into a protracted discussion about coding philosophy I'll refer to [my comment on the Jira](https://issues.apache.org/jira/browse/ARTEMIS-2649?focusedCommentId=17058399=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17058399). Simply put, adding complexity is likely to result in more bugs, not less. Logging a message is extremely simple and follows precedence from other parts of the code when we encounter things that "shouldn't happen." When you add complexity to deal with these types of situations then you inevitably open yourself up to more potential bugs which requires more testing and oftentimes more user-configurable options (because not everybody wants to handle everything the same way) which requires even more code, tests, and documentation. Furthermore, if the original defensive code is sufficiently complex then it will need its own defensive code and that code will need tests, etc. Adding complexity is an untenable solution. I think the best defense against bugs here is simply more testing (as noted on the Jira). You tested the implementation and found a bug. I added a test for your use-case and fixed the bug. Please continue testing to verify everything works for your expected use-cases. I have no plans to allow additional customization of the filters for auto-created dead-letter-queues. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408015) Time Spent: 2h (was: 1h 50m) > Auto-create DLQ message loss when moving messages between destinations > -- > > Key: ARTEMIS-2649 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2649 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.12.0 > Environment: Centos 7 container in OKD with Java 8. >Reporter: Piotr Klimczak >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > [~jbertram], first of all thanks a lot for ARTEMIS-2587 implementation. > This was a must for me to switch to Artemis. > In past I have even tried to implement it in Artermis, but having no > previous experience with it, only with your PR I understood how nicely and > easily it can be implemented and how much I have overcomplicated it. > So I am testing 2.12.0 snapshot as I am really interested in work done under > ARTEMIS-2587. > I am connecting using open wire protocol using camel-jms component, having > replaced old AMQ5 with Artermis. > On failed consumption, I can see queue being created under DLQ address with > multicast and filter _AMQ_ORIG_ADDRESS = 'some.queue'. > However it is empty and message is lost. > Reproduction scenario: > # Sending message to address A > # Moving message from A queue to B using web console move function > # Consuming from B and failing consumption > Observed state: > # Queue is being created > #
[jira] [Updated] (ARTEMIS-2677) Artemis 2.11.0 RejectedExecutionException after successful failover
[ https://issues.apache.org/jira/browse/ARTEMIS-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jigar Shah updated ARTEMIS-2677: Environment: *Environment: Artemis 2.11.0 (Master-Slave)* *SharedStore, FilePing. AWS EFS/NFS.* was: *Environment: 2.11.0* *SharedStore, FilePing. AWS EFS/NFS.* > Artemis 2.11.0 RejectedExecutionException after successful failover > --- > > Key: ARTEMIS-2677 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2677 > Project: ActiveMQ Artemis > Issue Type: Bug > Environment: *Environment: Artemis 2.11.0 (Master-Slave)* > *SharedStore, FilePing. AWS EFS/NFS.* >Reporter: Jigar Shah >Priority: Major > > Observed an issue on master shutdown, the slave became active. Right after > slave being active it started printing "RejectedExecutionException". Also, > consumers from master to slave was not transferred. And client application > stopped processing messages. > Note RejectedExecutionException had [Terminated, pool size = 0, active > threads = 0, queued tasks = 0, completed tasks = 59059] > Following are the logs during failover from master to slave: > Master1: > 2020-03-18 12:34:39,911 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 26fb51af-690c-11ea-959a-12f8371a8293 > 2020-03-18 12:34:39,912 INFO [org.apache.activemq.artemis.core.server] > AMQ221029: stopped bridge > $.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9 > 2020-03-18 12:34:39,950 WARN [org.apache.activemq.artemis.core.server] > AMQ222061: Client connection failed, clearing up resources for session > 2655265e-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 2655265e-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222061: Client connection failed, clearing up resources for session > 2662e209-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 2662e209-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222061: Client connection failed, clearing up resources for session > 2669bfdd-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 2669bfdd-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,993 WARN [org.apache.activemq.artemis.core.server] > AMQ222061: Client connection failed, clearing up resources for session > 26615b64-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,994 WARN [org.apache.activemq.artemis.core.server] > AMQ222107: Cleared up resources for session > 26615b64-690c-11ea-9d7c-12f7d16c4f81 > 2020-03-18 12:34:39,994 WARN [org.apache.activemq.artemis.core.client] > AMQ212037: Connection failure to artemis1.sl.idsk.com/10.110.0.17:61616 has > been detected: AMQ219015: The connection was disconnected because of server > shutdown [code=DISCONNECTED] > 2020-03-18 12:34:40,123 FINE [org.jgroups.protocols.FILE_PING] remove > persistence-fs > 2020-03-18 12:34:40,137 FINE [org.jgroups.protocols.FD_SOCK] > ip-10-110-0-17-18496: socket to ip-10-110-0-88-23224 was closed gracefully > 2020-03-18 12:34:40,138 FINE [org.jgroups.protocols.TCP] closing sockets and > stopping threads > 2020-03-18 12:34:40,169 WARN [org.apache.activemq.artemis.core.client] > AMQ212004: Failed to connect to server. > 2020-03-18 12:34:41,336 INFO [io.hawt.web.AuthenticationFilter] Destroying > hawtio authentication filter > 2020-03-18 12:34:41,341 INFO [io.hawt.HawtioContextListener] Destroying > hawtio services > 2020-03-18 12:34:41,464 INFO > [org.apache.activemq.hawtio.plugin.PluginContextListener] Destroyed > artemis-plugin plugin > 2020-03-18 12:34:41,472 INFO > [org.apache.activemq.hawtio.branding.PluginContextListener] Destroyed > activemq-branding plugin > 2020-03-18 12:34:41,509 INFO [org.apache.activemq.artemis.core.server] > AMQ221002: Apache ActiveMQ Artemis Message Broker version 2.11.0 > [19ade3bb-5f75-11ea-b327-1216d251b187] stopped, uptime 5 hours 2 minutes > Slave1: > 2020-03-18 12:35:01,613 INFO [org.apache.activemq.artemis.core.server] > AMQ221010: Backup Server is now live > 2020-03-18 12:35:01,626 INFO [org.apache.activemq.artemis.core.server] > AMQ221027: Bridge ClusterConnectionBridge@5ced3917 > [name=$.artemis.internal.sf.my-cluster.2c85cd > 9e-5f75-11ea-9be1-0af9119190b9, > queue=QueueImpl[name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9, > postOffice=PostOfficeImpl [server=ActiveMQSe > rverImpl::serverUUID=19ade3bb-5f75-11ea-b327-1216d251b187], >
[jira] [Work logged] (ARTEMIS-2608) ClassCastException when consuming a message using OpenWire
[ https://issues.apache.org/jira/browse/ARTEMIS-2608?focusedWorklogId=407941=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407941 ] ASF GitHub Bot logged work on ARTEMIS-2608: --- Author: ASF GitHub Bot Created on: 23/Mar/20 14:50 Start Date: 23/Mar/20 14:50 Worklog Time Spent: 10m Work Description: fvaleri commented on issue #2954: ARTEMIS-2608 Fix ClassCastException on binary properties retrieval URL: https://github.com/apache/activemq-artemis/pull/2954#issuecomment-602646764 Let me commit the one-line change to fix this. Then, I will create a distinct PR for proposed refactoring (same semantics). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 407941) Time Spent: 3h 50m (was: 3h 40m) > ClassCastException when consuming a message using OpenWire > -- > > Key: ARTEMIS-2608 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2608 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: OpenWire >Affects Versions: 2.11.0 >Reporter: Federico Valeri >Priority: Major > Attachments: cce-reproducer.zip > > Time Spent: 3h 50m > Remaining Estimate: 0h > > This issue seems to be related to the conversion of binary properties. > Quick workaround: clear message properties in the AMQP producer. > Reproducer (attached): > 1. Send a message to the broker using OpenWire client > 2. Consume that message using AMQP client > 3. Send that message back to the broker using AMQP client > Result: message could not be consumed by the OpenWire consumer. > {code:java} > 2020-01-23 12:52:44,095 WARN [org.apache.activemq.artemis.core.server] Error > during message dispatch: java.lang.ClassCastException: > org.apache.activemq.artemis.api.core.SimpleString cannot be cast to [B > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.toAMQMessage(OpenWireMessageConverter.java:629) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.createMessageDispatch(OpenWireMessageConverter.java:501) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQConsumer.handleDeliver(AMQConsumer.java:258) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQSession.sendMessage(AMQSession.java:312) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1161) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:504) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:3510) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2856) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.access$2300(QueueImpl.java:122) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:3848) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > [rt.jar:1.8.0_232] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > [rt.jar:1.8.0_232] > at > org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > {code} > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2608) ClassCastException when consuming a message using OpenWire
[ https://issues.apache.org/jira/browse/ARTEMIS-2608?focusedWorklogId=407919=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407919 ] ASF GitHub Bot logged work on ARTEMIS-2608: --- Author: ASF GitHub Bot Created on: 23/Mar/20 14:34 Start Date: 23/Mar/20 14:34 Worklog Time Spent: 10m Work Description: fvaleri commented on pull request #2954: ARTEMIS-2608 Fix ClassCastException on binary properties retrieval URL: https://github.com/apache/activemq-artemis/pull/2954#discussion_r396496357 ## File path: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenwireMessage.java ## @@ -30,8 +30,7 @@ import io.netty.buffer.ByteBuf; -// TODO: Implement this -public class OpenwireMessage implements Message { +public class OpenWireMessage implements Message { Review comment: ok This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 407919) Time Spent: 3h 40m (was: 3.5h) > ClassCastException when consuming a message using OpenWire > -- > > Key: ARTEMIS-2608 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2608 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: OpenWire >Affects Versions: 2.11.0 >Reporter: Federico Valeri >Priority: Major > Attachments: cce-reproducer.zip > > Time Spent: 3h 40m > Remaining Estimate: 0h > > This issue seems to be related to the conversion of binary properties. > Quick workaround: clear message properties in the AMQP producer. > Reproducer (attached): > 1. Send a message to the broker using OpenWire client > 2. Consume that message using AMQP client > 3. Send that message back to the broker using AMQP client > Result: message could not be consumed by the OpenWire consumer. > {code:java} > 2020-01-23 12:52:44,095 WARN [org.apache.activemq.artemis.core.server] Error > during message dispatch: java.lang.ClassCastException: > org.apache.activemq.artemis.api.core.SimpleString cannot be cast to [B > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.toAMQMessage(OpenWireMessageConverter.java:629) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.createMessageDispatch(OpenWireMessageConverter.java:501) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQConsumer.handleDeliver(AMQConsumer.java:258) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQSession.sendMessage(AMQSession.java:312) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1161) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:504) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:3510) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2856) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.access$2300(QueueImpl.java:122) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:3848) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > [rt.jar:1.8.0_232] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) >
[jira] [Work logged] (ARTEMIS-2608) ClassCastException when consuming a message using OpenWire
[ https://issues.apache.org/jira/browse/ARTEMIS-2608?focusedWorklogId=407918=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407918 ] ASF GitHub Bot logged work on ARTEMIS-2608: --- Author: ASF GitHub Bot Created on: 23/Mar/20 14:32 Start Date: 23/Mar/20 14:32 Worklog Time Spent: 10m Work Description: fvaleri commented on pull request #2954: ARTEMIS-2608 Fix ClassCastException on binary properties retrieval URL: https://github.com/apache/activemq-artemis/pull/2954#discussion_r396494949 ## File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/AmqpCoreConverter.java ## @@ -308,9 +308,7 @@ private static ServerJMSMessage processApplicationProperties(ServerJMSMessage jm private static ServerJMSMessage processExtraProperties(ServerJMSMessage jms, TypedProperties properties) { if (properties != null) { properties.forEach((k, v) -> { -if (!k.equals(AMQPMessage.ADDRESS_PROPERTY)) { Review comment: my fault, let me fix this This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 407918) Time Spent: 3.5h (was: 3h 20m) > ClassCastException when consuming a message using OpenWire > -- > > Key: ARTEMIS-2608 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2608 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: OpenWire >Affects Versions: 2.11.0 >Reporter: Federico Valeri >Priority: Major > Attachments: cce-reproducer.zip > > Time Spent: 3.5h > Remaining Estimate: 0h > > This issue seems to be related to the conversion of binary properties. > Quick workaround: clear message properties in the AMQP producer. > Reproducer (attached): > 1. Send a message to the broker using OpenWire client > 2. Consume that message using AMQP client > 3. Send that message back to the broker using AMQP client > Result: message could not be consumed by the OpenWire consumer. > {code:java} > 2020-01-23 12:52:44,095 WARN [org.apache.activemq.artemis.core.server] Error > during message dispatch: java.lang.ClassCastException: > org.apache.activemq.artemis.api.core.SimpleString cannot be cast to [B > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.toAMQMessage(OpenWireMessageConverter.java:629) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.createMessageDispatch(OpenWireMessageConverter.java:501) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQConsumer.handleDeliver(AMQConsumer.java:258) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQSession.sendMessage(AMQSession.java:312) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1161) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:504) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:3510) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2856) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.access$2300(QueueImpl.java:122) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:3848) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at >
[jira] [Work logged] (ARTEMIS-2608) ClassCastException when consuming a message using OpenWire
[ https://issues.apache.org/jira/browse/ARTEMIS-2608?focusedWorklogId=407917=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407917 ] ASF GitHub Bot logged work on ARTEMIS-2608: --- Author: ASF GitHub Bot Created on: 23/Mar/20 14:28 Start Date: 23/Mar/20 14:28 Worklog Time Spent: 10m Work Description: clebertsuconic commented on pull request #2954: ARTEMIS-2608 Fix ClassCastException on binary properties retrieval URL: https://github.com/apache/activemq-artemis/pull/2954#discussion_r396491982 ## File path: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenwireMessage.java ## @@ -30,8 +30,7 @@ import io.netty.buffer.ByteBuf; -// TODO: Implement this -public class OpenwireMessage implements Message { +public class OpenWireMessage implements Message { Review comment: you didn't need to change this.. I would keep your changes to a minimal.. only what you really need. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 407917) Time Spent: 3h 20m (was: 3h 10m) > ClassCastException when consuming a message using OpenWire > -- > > Key: ARTEMIS-2608 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2608 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: OpenWire >Affects Versions: 2.11.0 >Reporter: Federico Valeri >Priority: Major > Attachments: cce-reproducer.zip > > Time Spent: 3h 20m > Remaining Estimate: 0h > > This issue seems to be related to the conversion of binary properties. > Quick workaround: clear message properties in the AMQP producer. > Reproducer (attached): > 1. Send a message to the broker using OpenWire client > 2. Consume that message using AMQP client > 3. Send that message back to the broker using AMQP client > Result: message could not be consumed by the OpenWire consumer. > {code:java} > 2020-01-23 12:52:44,095 WARN [org.apache.activemq.artemis.core.server] Error > during message dispatch: java.lang.ClassCastException: > org.apache.activemq.artemis.api.core.SimpleString cannot be cast to [B > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.toAMQMessage(OpenWireMessageConverter.java:629) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.createMessageDispatch(OpenWireMessageConverter.java:501) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQConsumer.handleDeliver(AMQConsumer.java:258) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQSession.sendMessage(AMQSession.java:312) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1161) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:504) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:3510) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2856) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.access$2300(QueueImpl.java:122) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:3848) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) >
[jira] [Work logged] (ARTEMIS-2608) ClassCastException when consuming a message using OpenWire
[ https://issues.apache.org/jira/browse/ARTEMIS-2608?focusedWorklogId=407916=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407916 ] ASF GitHub Bot logged work on ARTEMIS-2608: --- Author: ASF GitHub Bot Created on: 23/Mar/20 14:28 Start Date: 23/Mar/20 14:28 Worklog Time Spent: 10m Work Description: clebertsuconic commented on pull request #2954: ARTEMIS-2608 Fix ClassCastException on binary properties retrieval URL: https://github.com/apache/activemq-artemis/pull/2954#discussion_r396491608 ## File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/AmqpCoreConverter.java ## @@ -308,9 +308,7 @@ private static ServerJMSMessage processApplicationProperties(ServerJMSMessage jm private static ServerJMSMessage processExtraProperties(ServerJMSMessage jms, TypedProperties properties) { if (properties != null) { properties.forEach((k, v) -> { -if (!k.equals(AMQPMessage.ADDRESS_PROPERTY)) { Review comment: why? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 407916) Time Spent: 3h 10m (was: 3h) > ClassCastException when consuming a message using OpenWire > -- > > Key: ARTEMIS-2608 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2608 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: OpenWire >Affects Versions: 2.11.0 >Reporter: Federico Valeri >Priority: Major > Attachments: cce-reproducer.zip > > Time Spent: 3h 10m > Remaining Estimate: 0h > > This issue seems to be related to the conversion of binary properties. > Quick workaround: clear message properties in the AMQP producer. > Reproducer (attached): > 1. Send a message to the broker using OpenWire client > 2. Consume that message using AMQP client > 3. Send that message back to the broker using AMQP client > Result: message could not be consumed by the OpenWire consumer. > {code:java} > 2020-01-23 12:52:44,095 WARN [org.apache.activemq.artemis.core.server] Error > during message dispatch: java.lang.ClassCastException: > org.apache.activemq.artemis.api.core.SimpleString cannot be cast to [B > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.toAMQMessage(OpenWireMessageConverter.java:629) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.createMessageDispatch(OpenWireMessageConverter.java:501) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQConsumer.handleDeliver(AMQConsumer.java:258) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQSession.sendMessage(AMQSession.java:312) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1161) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:504) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:3510) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2856) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.access$2300(QueueImpl.java:122) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:3848) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at >
[jira] [Work logged] (ARTEMIS-2608) ClassCastException when consuming a message using OpenWire
[ https://issues.apache.org/jira/browse/ARTEMIS-2608?focusedWorklogId=407914=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407914 ] ASF GitHub Bot logged work on ARTEMIS-2608: --- Author: ASF GitHub Bot Created on: 23/Mar/20 14:23 Start Date: 23/Mar/20 14:23 Worklog Time Spent: 10m Work Description: fvaleri commented on issue #2954: ARTEMIS-2608 Fix ClassCastException on binary properties retrieval URL: https://github.com/apache/activemq-artemis/pull/2954#issuecomment-602618829 @gemmellr is right. The problem is in the `AmqpCoreConverter.setProperty` method which convert proton-j's Binary to String instead of byte[]: ```java ... } else if (value instanceof Binary) { msg.setStringProperty(key, value.toString()); ``` Please review my last commit which fixes the issue, adds a converter test and a bit of refactoring to have separate classes for CoreOpenWireConverter and OpenWireCoreConverter (much like in the AMQP protocol module). Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 407914) Time Spent: 3h (was: 2h 50m) > ClassCastException when consuming a message using OpenWire > -- > > Key: ARTEMIS-2608 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2608 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: OpenWire >Affects Versions: 2.11.0 >Reporter: Federico Valeri >Priority: Major > Attachments: cce-reproducer.zip > > Time Spent: 3h > Remaining Estimate: 0h > > This issue seems to be related to the conversion of binary properties. > Quick workaround: clear message properties in the AMQP producer. > Reproducer (attached): > 1. Send a message to the broker using OpenWire client > 2. Consume that message using AMQP client > 3. Send that message back to the broker using AMQP client > Result: message could not be consumed by the OpenWire consumer. > {code:java} > 2020-01-23 12:52:44,095 WARN [org.apache.activemq.artemis.core.server] Error > during message dispatch: java.lang.ClassCastException: > org.apache.activemq.artemis.api.core.SimpleString cannot be cast to [B > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.toAMQMessage(OpenWireMessageConverter.java:629) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.createMessageDispatch(OpenWireMessageConverter.java:501) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQConsumer.handleDeliver(AMQConsumer.java:258) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQSession.sendMessage(AMQSession.java:312) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1161) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:504) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:3510) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2856) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.access$2300(QueueImpl.java:122) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:3848) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at >
[jira] [Updated] (ARTEMIS-2608) ClassCastException when consuming a message using OpenWire
[ https://issues.apache.org/jira/browse/ARTEMIS-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated ARTEMIS-2608: - Description: This issue seems to be related to the conversion of binary properties. Quick workaround: clear message properties in the AMQP producer. Reproducer (attached): 1. Send a message to the broker using OpenWire client 2. Consume that message using AMQP client 3. Send that message back to the broker using AMQP client Result: message could not be consumed by the OpenWire consumer. {code:java} 2020-01-23 12:52:44,095 WARN [org.apache.activemq.artemis.core.server] Error during message dispatch: java.lang.ClassCastException: org.apache.activemq.artemis.api.core.SimpleString cannot be cast to [B at org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.toAMQMessage(OpenWireMessageConverter.java:629) [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] at org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.createMessageDispatch(OpenWireMessageConverter.java:501) [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] at org.apache.activemq.artemis.core.protocol.openwire.amq.AMQConsumer.handleDeliver(AMQConsumer.java:258) [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] at org.apache.activemq.artemis.core.protocol.openwire.amq.AMQSession.sendMessage(AMQSession.java:312) [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] at org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1161) [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] at org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:504) [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] at org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:3510) [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] at org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2856) [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] at org.apache.activemq.artemis.core.server.impl.QueueImpl.access$2300(QueueImpl.java:122) [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] at org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:3848) [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] at org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] at org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] at org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [rt.jar:1.8.0_232] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [rt.jar:1.8.0_232] at org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] {code} was: This issue seems to be related to the conversion of the "HDR" binary properties. Quick workaround: clear message properties in the AMQP producer. Reproducer: 1. Send a message to the broker using OpenWire client 2. Consume that message using AMQP client 3. Send that message back to the broker using AMQP client Result: message could not be consumed by the OpenWire consumer. {code:java} 2020-01-23 12:52:44,095 WARN [org.apache.activemq.artemis.core.server] Error during message dispatch: java.lang.ClassCastException: org.apache.activemq.artemis.api.core.SimpleString cannot be cast to [B at org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.toAMQMessage(OpenWireMessageConverter.java:629) [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] at org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.createMessageDispatch(OpenWireMessageConverter.java:501) [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] at org.apache.activemq.artemis.core.protocol.openwire.amq.AMQConsumer.handleDeliver(AMQConsumer.java:258) [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] at org.apache.activemq.artemis.core.protocol.openwire.amq.AMQSession.sendMessage(AMQSession.java:312) [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] at org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1161) [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] at org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:504)
[jira] [Updated] (ARTEMIS-2608) ClassCastException when consuming a message using OpenWire
[ https://issues.apache.org/jira/browse/ARTEMIS-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated ARTEMIS-2608: - Attachment: cce-reproducer.zip > ClassCastException when consuming a message using OpenWire > -- > > Key: ARTEMIS-2608 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2608 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: OpenWire >Affects Versions: 2.11.0 >Reporter: Federico Valeri >Priority: Major > Attachments: cce-reproducer.zip > > Time Spent: 2h 50m > Remaining Estimate: 0h > > This issue seems to be related to the conversion of the "HDR" binary > properties. > Quick workaround: clear message properties in the AMQP producer. > Reproducer: > 1. Send a message to the broker using OpenWire client > 2. Consume that message using AMQP client > 3. Send that message back to the broker using AMQP client > Result: message could not be consumed by the OpenWire consumer. > {code:java} > 2020-01-23 12:52:44,095 WARN [org.apache.activemq.artemis.core.server] Error > during message dispatch: java.lang.ClassCastException: > org.apache.activemq.artemis.api.core.SimpleString cannot be cast to [B > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.toAMQMessage(OpenWireMessageConverter.java:629) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.createMessageDispatch(OpenWireMessageConverter.java:501) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQConsumer.handleDeliver(AMQConsumer.java:258) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQSession.sendMessage(AMQSession.java:312) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1161) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:504) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:3510) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2856) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.access$2300(QueueImpl.java:122) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:3848) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > [rt.jar:1.8.0_232] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > [rt.jar:1.8.0_232] > at > org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > {code} > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2636) Expose disk store used percentage metric
[ https://issues.apache.org/jira/browse/ARTEMIS-2636?focusedWorklogId=407906=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407906 ] ASF GitHub Bot logged work on ARTEMIS-2636: --- Author: ASF GitHub Bot Created on: 23/Mar/20 14:13 Start Date: 23/Mar/20 14:13 Worklog Time Spent: 10m Work Description: clebertsuconic commented on issue #3005: ARTEMIS-2636: Introduce Disk Usage Metrics URL: https://github.com/apache/activemq-artemis/pull/3005#issuecomment-602621213 How did you come up with these formulas? did they come from the JIRA? or you made up them? as an user I would prefer seeing how much space I have left.. and what's the percentage of the disk that it's used This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 407906) Time Spent: 6h 50m (was: 6h 40m) > Expose disk store used percentage metric > > > Key: ARTEMIS-2636 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2636 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Christoph Ewerlin >Priority: Major > Time Spent: 6h 50m > Remaining Estimate: 0h > > It would be very nice if the disk store used could be exposed via the metrics > registry (preferably) and/or JMX like address.memory.usage already already is. > In addition it would be nice to have percentage values for both > address_memory_usage and disk_store_usage which would make setting up alarms > much easier. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2608) ClassCastException when consuming a message using OpenWire
[ https://issues.apache.org/jira/browse/ARTEMIS-2608?focusedWorklogId=407905=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407905 ] ASF GitHub Bot logged work on ARTEMIS-2608: --- Author: ASF GitHub Bot Created on: 23/Mar/20 14:11 Start Date: 23/Mar/20 14:11 Worklog Time Spent: 10m Work Description: fvaleri commented on issue #2954: ARTEMIS-2608 Fix ClassCastException on binary properties retrieval URL: https://github.com/apache/activemq-artemis/pull/2954#issuecomment-602618829 @gemmellr is right. The problem is in the `AmqpCoreConverter.setProperty` method which convert proton-j's Binary to String instead of byte[]: ```java ... } else if (value instanceof Binary) { msg.setStringProperty(key, value.toString()); ``` Please review my last commit which fixes the issue, adds a converter test and bit of refactoring to have separate classes for CoreOpenWireConverter and OpenWireCoreConverter (much like in the AMQP protocol module). Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 407905) Time Spent: 2h 50m (was: 2h 40m) > ClassCastException when consuming a message using OpenWire > -- > > Key: ARTEMIS-2608 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2608 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: OpenWire >Affects Versions: 2.11.0 >Reporter: Federico Valeri >Priority: Major > Time Spent: 2h 50m > Remaining Estimate: 0h > > This issue seems to be related to the conversion of the "HDR" binary > properties. > Quick workaround: clear message properties in the AMQP producer. > Reproducer: > 1. Send a message to the broker using OpenWire client > 2. Consume that message using AMQP client > 3. Send that message back to the broker using AMQP client > Result: message could not be consumed by the OpenWire consumer. > {code:java} > 2020-01-23 12:52:44,095 WARN [org.apache.activemq.artemis.core.server] Error > during message dispatch: java.lang.ClassCastException: > org.apache.activemq.artemis.api.core.SimpleString cannot be cast to [B > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.toAMQMessage(OpenWireMessageConverter.java:629) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.createMessageDispatch(OpenWireMessageConverter.java:501) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQConsumer.handleDeliver(AMQConsumer.java:258) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.protocol.openwire.amq.AMQSession.sendMessage(AMQSession.java:312) > [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1161) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:504) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:3510) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2856) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.access$2300(QueueImpl.java:122) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:3848) > [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) > [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) >
[jira] [Assigned] (AMQ-7448) Remove deprecated dependency ant:ant:1.6.2
[ https://issues.apache.org/jira/browse/AMQ-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré reassigned AMQ-7448: - Assignee: Jean-Baptiste Onofré > Remove deprecated dependency ant:ant:1.6.2 > -- > > Key: AMQ-7448 > URL: https://issues.apache.org/jira/browse/AMQ-7448 > Project: ActiveMQ > Issue Type: Bug >Affects Versions: 5.15.12 >Reporter: Sourabh Sarvotham Parkala >Assignee: Jean-Baptiste Onofré >Priority: Minor > > Please find the link below > [https://github.com/apache/activemq/blob/master/activemq-openwire-generator/pom.xml] > > [#L49|https://github.com/apache/activemq/blob/05c43fe3473b4460c6d8d768ad3076a53be302d3/activemq-openwire-generator/pom.xml#L49] > > I am wondering if we need this dependency. As the parent pom already has been > updated to org.apache.ant:ant. I tested it out by removing the dependency. It > does not throw any compilation issues. > > Also, this ant:ant:1.6.2 dependency brings this vulnerability > [https://nvd.nist.gov/vuln/detail/CVE-2012-2098]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AMQ-7448) Remove deprecated dependency ant:ant:1.6.2
[ https://issues.apache.org/jira/browse/AMQ-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064796#comment-17064796 ] Jean-Baptiste Onofré commented on AMQ-7448: --- I have to check as the openwire-generator provides a task used in activemq-client (for the openwire-generate profile). > Remove deprecated dependency ant:ant:1.6.2 > -- > > Key: AMQ-7448 > URL: https://issues.apache.org/jira/browse/AMQ-7448 > Project: ActiveMQ > Issue Type: Bug >Affects Versions: 5.15.12 >Reporter: Sourabh Sarvotham Parkala >Assignee: Jean-Baptiste Onofré >Priority: Minor > > Please find the link below > [https://github.com/apache/activemq/blob/master/activemq-openwire-generator/pom.xml] > > [#L49|https://github.com/apache/activemq/blob/05c43fe3473b4460c6d8d768ad3076a53be302d3/activemq-openwire-generator/pom.xml#L49] > > I am wondering if we need this dependency. As the parent pom already has been > updated to org.apache.ant:ant. I tested it out by removing the dependency. It > does not throw any compilation issues. > > Also, this ant:ant:1.6.2 dependency brings this vulnerability > [https://nvd.nist.gov/vuln/detail/CVE-2012-2098]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARTEMIS-2677) Artemis 2.11.0 RejectedExecutionException after successful failover
Jigar Shah created ARTEMIS-2677: --- Summary: Artemis 2.11.0 RejectedExecutionException after successful failover Key: ARTEMIS-2677 URL: https://issues.apache.org/jira/browse/ARTEMIS-2677 Project: ActiveMQ Artemis Issue Type: Bug Environment: *Environment: 2.11.0* *SharedStore, FilePing. AWS EFS/NFS.* Reporter: Jigar Shah Observed an issue on master shutdown, the slave became active. Right after slave being active it started printing "RejectedExecutionException". Also, consumers from master to slave was not transferred. And client application stopped processing messages. Note RejectedExecutionException had [Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 59059] Following are the logs during failover from master to slave: Master1: 2020-03-18 12:34:39,911 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 26fb51af-690c-11ea-959a-12f8371a8293 2020-03-18 12:34:39,912 INFO [org.apache.activemq.artemis.core.server] AMQ221029: stopped bridge $.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9 2020-03-18 12:34:39,950 WARN [org.apache.activemq.artemis.core.server] AMQ222061: Client connection failed, clearing up resources for session 2655265e-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 2655265e-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222061: Client connection failed, clearing up resources for session 2662e209-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 2662e209-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222061: Client connection failed, clearing up resources for session 2669bfdd-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,951 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 2669bfdd-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,993 WARN [org.apache.activemq.artemis.core.server] AMQ222061: Client connection failed, clearing up resources for session 26615b64-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,994 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session 26615b64-690c-11ea-9d7c-12f7d16c4f81 2020-03-18 12:34:39,994 WARN [org.apache.activemq.artemis.core.client] AMQ212037: Connection failure to artemis1.sl.idsk.com/10.110.0.17:61616 has been detected: AMQ219015: The connection was disconnected because of server shutdown [code=DISCONNECTED] 2020-03-18 12:34:40,123 FINE [org.jgroups.protocols.FILE_PING] remove persistence-fs 2020-03-18 12:34:40,137 FINE [org.jgroups.protocols.FD_SOCK] ip-10-110-0-17-18496: socket to ip-10-110-0-88-23224 was closed gracefully 2020-03-18 12:34:40,138 FINE [org.jgroups.protocols.TCP] closing sockets and stopping threads 2020-03-18 12:34:40,169 WARN [org.apache.activemq.artemis.core.client] AMQ212004: Failed to connect to server. 2020-03-18 12:34:41,336 INFO [io.hawt.web.AuthenticationFilter] Destroying hawtio authentication filter 2020-03-18 12:34:41,341 INFO [io.hawt.HawtioContextListener] Destroying hawtio services 2020-03-18 12:34:41,464 INFO [org.apache.activemq.hawtio.plugin.PluginContextListener] Destroyed artemis-plugin plugin 2020-03-18 12:34:41,472 INFO [org.apache.activemq.hawtio.branding.PluginContextListener] Destroyed activemq-branding plugin 2020-03-18 12:34:41,509 INFO [org.apache.activemq.artemis.core.server] AMQ221002: Apache ActiveMQ Artemis Message Broker version 2.11.0 [19ade3bb-5f75-11ea-b327-1216d251b187] stopped, uptime 5 hours 2 minutes Slave1: 2020-03-18 12:35:01,613 INFO [org.apache.activemq.artemis.core.server] AMQ221010: Backup Server is now live 2020-03-18 12:35:01,626 INFO [org.apache.activemq.artemis.core.server] AMQ221027: Bridge ClusterConnectionBridge@5ced3917 [name=$.artemis.internal.sf.my-cluster.2c85cd 9e-5f75-11ea-9be1-0af9119190b9, queue=QueueImpl[name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9, postOffice=PostOfficeImpl [server=ActiveMQSe rverImpl::serverUUID=19ade3bb-5f75-11ea-b327-1216d251b187], temp=false]@58d2a652 targetConnector=ServerLocatorImpl (identity=(Cluster-connection-bridge::ClusterConnecti onBridge@5ced3917 [name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea-9be1-0af9119190b9, queue=QueueImpl[name=$.artemis.internal.sf.my-cluster.2c85cd9e-5f75-11ea- 9be1-0af9119190b9, postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUUID=19ade3bb-5f75-11ea-b327-1216d251b187], temp=false]@58d2a652 targetConnector=ServerLo catorImpl [initialConnectors=[TransportConfiguration(name=netty-connector,
[jira] [Commented] (ARTEMIS-975) Reading messages from page causes lost entries in db backend
[ https://issues.apache.org/jira/browse/ARTEMIS-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064759#comment-17064759 ] Benjamin Graf commented on ARTEMIS-975: --- Hi [~jbertram], I finally found the root cause and fixed it. Regards, Benjamin > Reading messages from page causes lost entries in db backend > > > Key: ARTEMIS-975 > URL: https://issues.apache.org/jira/browse/ARTEMIS-975 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Benjamin Graf >Priority: Major > Attachments: screenshot-1.png > > Time Spent: 10m > Remaining Estimate: 0h > > Consuming messages from pages with a db as persistence backend leaves commit > records in message_table which doesn't get cleaned up. Seems that depaging > does not add txids to internal map. > SQL script for cleanup (no known side effect): > {code} > DELETE > FROM MESSAGE_TABLE > WHERE txid IN > (SELECT txid > FROM >(SELECT count(*) AS cnt, >txid > FROM MESSAGE_TABLE > WHERE txid IN > (SELECT txid > FROM MESSAGE_TABLE > WHERE recordtype = 18) > GROUP BY txid)AS m > WHERE m.cnt=1) > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-975) Reading messages from page causes lost entries in db backend
[ https://issues.apache.org/jira/browse/ARTEMIS-975?focusedWorklogId=407871=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407871 ] ASF GitHub Bot logged work on ARTEMIS-975: -- Author: ASF GitHub Bot Created on: 23/Mar/20 12:12 Start Date: 23/Mar/20 12:12 Worklog Time Spent: 10m Work Description: graben commented on pull request #3042: ARTEMIS-975: Add transactional records to deletedRecords to check for committed transactions that also hold references to URL: https://github.com/apache/activemq-artemis/pull/3042 Especially needed for paging/depaging records that are hold in several transactions not getting cleaned up completely. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 407871) Remaining Estimate: 0h Time Spent: 10m > Reading messages from page causes lost entries in db backend > > > Key: ARTEMIS-975 > URL: https://issues.apache.org/jira/browse/ARTEMIS-975 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Benjamin Graf >Priority: Major > Attachments: screenshot-1.png > > Time Spent: 10m > Remaining Estimate: 0h > > Consuming messages from pages with a db as persistence backend leaves commit > records in message_table which doesn't get cleaned up. Seems that depaging > does not add txids to internal map. > SQL script for cleanup (no known side effect): > {code} > DELETE > FROM MESSAGE_TABLE > WHERE txid IN > (SELECT txid > FROM >(SELECT count(*) AS cnt, >txid > FROM MESSAGE_TABLE > WHERE txid IN > (SELECT txid > FROM MESSAGE_TABLE > WHERE recordtype = 18) > GROUP BY txid)AS m > WHERE m.cnt=1) > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Nigro updated ARTEMIS-2676: - Summary: PageCursorProviderImpl::cleanup can save decoding pages without large messages (was: PageCurosrProviderImpl::cleanup can save decoding pages without large messages) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (AMQ-7448) Remove deprecated dependency ant:ant:1.6.2
[ https://issues.apache.org/jira/browse/AMQ-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sourabh Sarvotham Parkala updated AMQ-7448: --- Description: Please find the link below [https://github.com/apache/activemq/blob/master/activemq-openwire-generator/pom.xml] [#L49|https://github.com/apache/activemq/blob/05c43fe3473b4460c6d8d768ad3076a53be302d3/activemq-openwire-generator/pom.xml#L49] I am wondering if we need this dependency. As the parent pom already has been updated to org.apache.ant:ant. I tested it out by removing the dependency. It does not throw any compilation issues. Also, this ant:ant:1.6.2 dependency brings about [https://nvd.nist.gov/vuln/detail/CVE-2012-2098]. was: Please find the link below [https://github.com/apache/activemq/blob/master/activemq-openwire-generator/pom.xml] [#L49|https://github.com/apache/activemq/blob/05c43fe3473b4460c6d8d768ad3076a53be302d3/activemq-openwire-generator/pom.xml#L49] I am wondering if we need this dependency. As the parent pom already has been updated to org.apache.ant:ant. I tested it out by removing the dependency. It does not throw any compilation issues. Also, this ant:ant:1.6.2 dependency brings about [CVE-2012-2098|[https://nvd.nist.gov/vuln/detail/CVE-2012-2098]|https://nvd.nist.gov/vuln/detail/CVE-2012-2098]. > Remove deprecated dependency ant:ant:1.6.2 > -- > > Key: AMQ-7448 > URL: https://issues.apache.org/jira/browse/AMQ-7448 > Project: ActiveMQ > Issue Type: Bug >Affects Versions: 5.15.12 >Reporter: Sourabh Sarvotham Parkala >Priority: Minor > > Please find the link below > [https://github.com/apache/activemq/blob/master/activemq-openwire-generator/pom.xml] > > [#L49|https://github.com/apache/activemq/blob/05c43fe3473b4460c6d8d768ad3076a53be302d3/activemq-openwire-generator/pom.xml#L49] > > I am wondering if we need this dependency. As the parent pom already has been > updated to org.apache.ant:ant. I tested it out by removing the dependency. It > does not throw any compilation issues. > > Also, this ant:ant:1.6.2 dependency brings about > [https://nvd.nist.gov/vuln/detail/CVE-2012-2098]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (AMQ-7448) Remove deprecated dependency ant:ant:1.6.2
[ https://issues.apache.org/jira/browse/AMQ-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sourabh Sarvotham Parkala updated AMQ-7448: --- Description: Please find the link below [https://github.com/apache/activemq/blob/master/activemq-openwire-generator/pom.xml] [#L49|https://github.com/apache/activemq/blob/05c43fe3473b4460c6d8d768ad3076a53be302d3/activemq-openwire-generator/pom.xml#L49] I am wondering if we need this dependency. As the parent pom already has been updated to org.apache.ant:ant. I tested it out by removing the dependency. It does not throw any compilation issues. Also, this ant:ant:1.6.2 dependency brings this vulnerability [https://nvd.nist.gov/vuln/detail/CVE-2012-2098]. was: Please find the link below [https://github.com/apache/activemq/blob/master/activemq-openwire-generator/pom.xml] [#L49|https://github.com/apache/activemq/blob/05c43fe3473b4460c6d8d768ad3076a53be302d3/activemq-openwire-generator/pom.xml#L49] I am wondering if we need this dependency. As the parent pom already has been updated to org.apache.ant:ant. I tested it out by removing the dependency. It does not throw any compilation issues. Also, this ant:ant:1.6.2 dependency brings about [https://nvd.nist.gov/vuln/detail/CVE-2012-2098]. > Remove deprecated dependency ant:ant:1.6.2 > -- > > Key: AMQ-7448 > URL: https://issues.apache.org/jira/browse/AMQ-7448 > Project: ActiveMQ > Issue Type: Bug >Affects Versions: 5.15.12 >Reporter: Sourabh Sarvotham Parkala >Priority: Minor > > Please find the link below > [https://github.com/apache/activemq/blob/master/activemq-openwire-generator/pom.xml] > > [#L49|https://github.com/apache/activemq/blob/05c43fe3473b4460c6d8d768ad3076a53be302d3/activemq-openwire-generator/pom.xml#L49] > > I am wondering if we need this dependency. As the parent pom already has been > updated to org.apache.ant:ant. I tested it out by removing the dependency. It > does not throw any compilation issues. > > Also, this ant:ant:1.6.2 dependency brings this vulnerability > [https://nvd.nist.gov/vuln/detail/CVE-2012-2098]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (AMQ-7448) Remove deprecated dependency ant:ant:1.6.2
[ https://issues.apache.org/jira/browse/AMQ-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sourabh Sarvotham Parkala updated AMQ-7448: --- Description: Please find the link below [https://github.com/apache/activemq/blob/master/activemq-openwire-generator/pom.xml] [#L49|https://github.com/apache/activemq/blob/05c43fe3473b4460c6d8d768ad3076a53be302d3/activemq-openwire-generator/pom.xml#L49] I am wondering if we need this dependency. As the parent pom already has been updated to org.apache.ant:ant. I tested it out by removing the dependency. It does not throw any compilation issues. Also, this ant:ant:1.6.2 dependency brings about [[CVE-2012-2098||https://nvd.nist.gov/vuln/detail/CVE-2012-2098] [https://nvd.nist.gov/vuln/detail/CVE-2012-2098]|https://nvd.nist.gov/vuln/detail/CVE-2012-2098]. was: Please find the link below [https://github.com/apache/activemq/blob/master/activemq-openwire-generator/pom.xml] [#L49|https://github.com/apache/activemq/blob/05c43fe3473b4460c6d8d768ad3076a53be302d3/activemq-openwire-generator/pom.xml#L49] I am wondering if we need this dependency. As the parent pom already has been updated to org.apache.ant:ant. I tested it out by removing the dependency. It does not throw any compilation issues. Also, this ant:ant:1.6.2 dependency brings about [CVE-2012-2098|https://saas.whitesourcesoftware.com/Wss/WSS.html#!securityVulnerability;id=CVE-2012-2098;orgToken=74cbbb27-f32c-474e-bb6b-d99fbffddee4]. > Remove deprecated dependency ant:ant:1.6.2 > -- > > Key: AMQ-7448 > URL: https://issues.apache.org/jira/browse/AMQ-7448 > Project: ActiveMQ > Issue Type: Bug >Affects Versions: 5.15.12 >Reporter: Sourabh Sarvotham Parkala >Priority: Minor > > Please find the link below > [https://github.com/apache/activemq/blob/master/activemq-openwire-generator/pom.xml] > > [#L49|https://github.com/apache/activemq/blob/05c43fe3473b4460c6d8d768ad3076a53be302d3/activemq-openwire-generator/pom.xml#L49] > > I am wondering if we need this dependency. As the parent pom already has been > updated to org.apache.ant:ant. I tested it out by removing the dependency. It > does not throw any compilation issues. > > Also, this ant:ant:1.6.2 dependency brings about > [[CVE-2012-2098||https://nvd.nist.gov/vuln/detail/CVE-2012-2098] > [https://nvd.nist.gov/vuln/detail/CVE-2012-2098]|https://nvd.nist.gov/vuln/detail/CVE-2012-2098]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (AMQ-7448) Remove deprecated dependency ant:ant:1.6.2
[ https://issues.apache.org/jira/browse/AMQ-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sourabh Sarvotham Parkala updated AMQ-7448: --- Description: Please find the link below [https://github.com/apache/activemq/blob/master/activemq-openwire-generator/pom.xml] [#L49|https://github.com/apache/activemq/blob/05c43fe3473b4460c6d8d768ad3076a53be302d3/activemq-openwire-generator/pom.xml#L49] I am wondering if we need this dependency. As the parent pom already has been updated to org.apache.ant:ant. I tested it out by removing the dependency. It does not throw any compilation issues. Also, this ant:ant:1.6.2 dependency brings about [CVE-2012-2098|[https://nvd.nist.gov/vuln/detail/CVE-2012-2098]|https://nvd.nist.gov/vuln/detail/CVE-2012-2098]. was: Please find the link below [https://github.com/apache/activemq/blob/master/activemq-openwire-generator/pom.xml] [#L49|https://github.com/apache/activemq/blob/05c43fe3473b4460c6d8d768ad3076a53be302d3/activemq-openwire-generator/pom.xml#L49] I am wondering if we need this dependency. As the parent pom already has been updated to org.apache.ant:ant. I tested it out by removing the dependency. It does not throw any compilation issues. Also, this ant:ant:1.6.2 dependency brings about [[CVE-2012-2098||https://nvd.nist.gov/vuln/detail/CVE-2012-2098] [https://nvd.nist.gov/vuln/detail/CVE-2012-2098]|https://nvd.nist.gov/vuln/detail/CVE-2012-2098]. > Remove deprecated dependency ant:ant:1.6.2 > -- > > Key: AMQ-7448 > URL: https://issues.apache.org/jira/browse/AMQ-7448 > Project: ActiveMQ > Issue Type: Bug >Affects Versions: 5.15.12 >Reporter: Sourabh Sarvotham Parkala >Priority: Minor > > Please find the link below > [https://github.com/apache/activemq/blob/master/activemq-openwire-generator/pom.xml] > > [#L49|https://github.com/apache/activemq/blob/05c43fe3473b4460c6d8d768ad3076a53be302d3/activemq-openwire-generator/pom.xml#L49] > > I am wondering if we need this dependency. As the parent pom already has been > updated to org.apache.ant:ant. I tested it out by removing the dependency. It > does not throw any compilation issues. > > Also, this ant:ant:1.6.2 dependency brings about > [CVE-2012-2098|[https://nvd.nist.gov/vuln/detail/CVE-2012-2098]|https://nvd.nist.gov/vuln/detail/CVE-2012-2098]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (AMQ-7448) Remove deprecated dependency ant:ant:1.6.2
Sourabh Sarvotham Parkala created AMQ-7448: -- Summary: Remove deprecated dependency ant:ant:1.6.2 Key: AMQ-7448 URL: https://issues.apache.org/jira/browse/AMQ-7448 Project: ActiveMQ Issue Type: Bug Affects Versions: 5.15.12 Reporter: Sourabh Sarvotham Parkala Please find the link below [https://github.com/apache/activemq/blob/master/activemq-openwire-generator/pom.xml] [#L49|https://github.com/apache/activemq/blob/05c43fe3473b4460c6d8d768ad3076a53be302d3/activemq-openwire-generator/pom.xml#L49] I am wondering if we need this dependency. As the parent pom already has been updated to org.apache.ant:ant. I tested it out by removing the dependency. It does not throw any compilation issues. Also, this ant:ant:1.6.2 dependency brings about [CVE-2012-2098|https://saas.whitesourcesoftware.com/Wss/WSS.html#!securityVulnerability;id=CVE-2012-2098;orgToken=74cbbb27-f32c-474e-bb6b-d99fbffddee4]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARTEMIS-2676) PageCurosrProviderImpl::cleanup can save decoding pages without large messages
Francesco Nigro created ARTEMIS-2676: Summary: PageCurosrProviderImpl::cleanup can save decoding pages without large messages Key: ARTEMIS-2676 URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 Project: ActiveMQ Artemis Issue Type: Improvement Components: Broker Affects Versions: 2.11.0 Reporter: Francesco Nigro PageCurosrProviderImpl::cleanup is calling PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not present in the PageCache), just to trigger large messages delete. The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)