[jira] [Work logged] (ARTEMIS-2453) DeadLock between server.destroyQueue and server.removeAddressInfo

2019-08-15 Thread ASF GitHub Bot (JIRA) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2453?focusedWorklogId=296075=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296075
 ]

ASF GitHub Bot logged work on ARTEMIS-2453:
---

Author: ASF GitHub Bot
Created on: 16/Aug/19 04:57
Start Date: 16/Aug/19 04:57
Worklog Time Spent: 10m 
  Work Description: michaelandrepearce commented on pull request #2799: 
ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo
URL: https://github.com/apache/activemq-artemis/pull/2799#discussion_r314583108
 
 

 ##
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
 ##
 @@ -484,7 +482,7 @@ public QueueBinding updateQueue(SimpleString name,
Long delayBeforeDispatch,
SimpleString user,
Boolean configurationManaged) throws 
Exception {
-  synchronized (addressLock) {
+  synchronized (this) {
 
 Review comment:
   Why not make synchronized method for these methods if the whole block is 
syncd? 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 296075)
Time Spent: 1h 10m  (was: 1h)

> DeadLock between server.destroyQueue and server.removeAddressInfo
> -
>
> Key: ARTEMIS-2453
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2453
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: clebert suconic
>Priority: Major
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> "Thread-0 
> (ActiveMQ-remoting-threads-ActiveMQServerImpl::serverUUID=349ac51e-bf5e-11e9-9661-ecf4bbced624-2058174333)":
>  at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.getAddressInfo(PostOfficeImpl.java:652)
>  - waiting to lock <0x0005be7a5488> (a java.lang.Object) at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.removeBinding(PostOfficeImpl.java:749)
>  - locked <0x0005bb0702c8> (a 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl) at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deleteQueue(QueueImpl.java:1962)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2142)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2090)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2081)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2061)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.run(ServerSessionImpl.java:986)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.connectionFailed(ServerSessionImpl.java:1001)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.connectionFailed(ServerSessionImpl.java:1006)
>  at 
> org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:77)
>  at 
> org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:220)
>  at 
> org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:220)
>  at 
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.issueFailure(RemotingServiceImpl.java:572)
>  at 
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.connectionDestroyed(RemotingServiceImpl.java:553)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.NettyAcceptor$Listener.connectionDestroyed(NettyAcceptor.java:897)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler.lambda$channelInactive$0(ActiveMQChannelHandler.java:83)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler$$Lambda$56/1250509089.run(Unknown
>  Source) at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
>  at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
>  at 
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66)
>  at 
>

[jira] [Work logged] (ARTEMIS-2453) DeadLock between server.destroyQueue and server.removeAddressInfo

2019-08-15 Thread ASF GitHub Bot (JIRA) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2453?focusedWorklogId=295633=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295633
 ]

ASF GitHub Bot logged work on ARTEMIS-2453:
---

Author: ASF GitHub Bot
Created on: 15/Aug/19 18:06
Start Date: 15/Aug/19 18:06
Worklog Time Spent: 10m 
  Work Description: asfgit commented on pull request #2799: ARTEMIS-2453 
Fixing deadLock between destroyQueue and removeAddressInfo
URL: https://github.com/apache/activemq-artemis/pull/2799
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 295633)
Time Spent: 1h  (was: 50m)

> DeadLock between server.destroyQueue and server.removeAddressInfo
> -
>
> Key: ARTEMIS-2453
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2453
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: clebert suconic
>Priority: Major
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> "Thread-0 
> (ActiveMQ-remoting-threads-ActiveMQServerImpl::serverUUID=349ac51e-bf5e-11e9-9661-ecf4bbced624-2058174333)":
>  at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.getAddressInfo(PostOfficeImpl.java:652)
>  - waiting to lock <0x0005be7a5488> (a java.lang.Object) at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.removeBinding(PostOfficeImpl.java:749)
>  - locked <0x0005bb0702c8> (a 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl) at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deleteQueue(QueueImpl.java:1962)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2142)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2090)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2081)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2061)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.run(ServerSessionImpl.java:986)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.connectionFailed(ServerSessionImpl.java:1001)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.connectionFailed(ServerSessionImpl.java:1006)
>  at 
> org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:77)
>  at 
> org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:220)
>  at 
> org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:220)
>  at 
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.issueFailure(RemotingServiceImpl.java:572)
>  at 
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.connectionDestroyed(RemotingServiceImpl.java:553)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.NettyAcceptor$Listener.connectionDestroyed(NettyAcceptor.java:897)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler.lambda$channelInactive$0(ActiveMQChannelHandler.java:83)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler$$Lambda$56/1250509089.run(Unknown
>  Source) at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
>  at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
>  at 
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66)
>  at 
> org.apache.activemq.artemis.utils.actors.ProcessorBase$$Lambda$2/323326911.run(Unknown
>  Source) at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  at 
> org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
>  "Thread-1 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$6@4a55a6e8)":
>  at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.removeBinding(PostOfficeImpl.java:724)
>  - waiting to lock <0x0005bb0702c8> (a 
>

[jira] [Work logged] (ARTEMIS-2453) DeadLock between server.destroyQueue and server.removeAddressInfo

2019-08-15 Thread ASF GitHub Bot (JIRA) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2453?focusedWorklogId=295505=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295505
 ]

ASF GitHub Bot logged work on ARTEMIS-2453:
---

Author: ASF GitHub Bot
Created on: 15/Aug/19 15:40
Start Date: 15/Aug/19 15:40
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on pull request #2799: 
ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo
URL: https://github.com/apache/activemq-artemis/pull/2799#discussion_r314370749
 
 

 ##
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
 ##
 @@ -649,9 +647,7 @@ public AddressInfo removeAddressInfo(SimpleString address, 
boolean force) throws
 
@Override
public AddressInfo getAddressInfo(SimpleString addressName) {
-  synchronized (addressLock) {
- return addressManager.getAddressInfo(addressName);
-  }
+  return addressManager.getAddressInfo(addressName);
 
 Review comment:
   @jbertram thanks.. that confirms what I thought.
   
   I'm running the whole testsuite to confirm it.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 295505)
Time Spent: 50m  (was: 40m)

> DeadLock between server.destroyQueue and server.removeAddressInfo
> -
>
> Key: ARTEMIS-2453
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2453
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: clebert suconic
>Priority: Major
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> "Thread-0 
> (ActiveMQ-remoting-threads-ActiveMQServerImpl::serverUUID=349ac51e-bf5e-11e9-9661-ecf4bbced624-2058174333)":
>  at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.getAddressInfo(PostOfficeImpl.java:652)
>  - waiting to lock <0x0005be7a5488> (a java.lang.Object) at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.removeBinding(PostOfficeImpl.java:749)
>  - locked <0x0005bb0702c8> (a 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl) at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deleteQueue(QueueImpl.java:1962)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2142)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2090)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2081)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2061)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.run(ServerSessionImpl.java:986)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.connectionFailed(ServerSessionImpl.java:1001)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.connectionFailed(ServerSessionImpl.java:1006)
>  at 
> org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:77)
>  at 
> org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:220)
>  at 
> org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:220)
>  at 
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.issueFailure(RemotingServiceImpl.java:572)
>  at 
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.connectionDestroyed(RemotingServiceImpl.java:553)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.NettyAcceptor$Listener.connectionDestroyed(NettyAcceptor.java:897)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler.lambda$channelInactive$0(ActiveMQChannelHandler.java:83)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler$$Lambda$56/1250509089.run(Unknown
>  Source) at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
>  at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
>  at 
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66)
>  at 
>

[jira] [Work logged] (ARTEMIS-2453) DeadLock between server.destroyQueue and server.removeAddressInfo

2019-08-15 Thread ASF GitHub Bot (JIRA) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2453?focusedWorklogId=295502=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295502
 ]

ASF GitHub Bot logged work on ARTEMIS-2453:
---

Author: ASF GitHub Bot
Created on: 15/Aug/19 15:33
Start Date: 15/Aug/19 15:33
Worklog Time Spent: 10m 
  Work Description: jbertram commented on pull request #2799: ARTEMIS-2453 
Fixing deadLock between destroyQueue and removeAddressInfo
URL: https://github.com/apache/activemq-artemis/pull/2799#discussion_r314367295
 
 

 ##
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
 ##
 @@ -649,9 +647,7 @@ public AddressInfo removeAddressInfo(SimpleString address, 
boolean force) throws
 
@Override
public AddressInfo getAddressInfo(SimpleString addressName) {
-  synchronized (addressLock) {
- return addressManager.getAddressInfo(addressName);
-  }
+  return addressManager.getAddressInfo(addressName);
 
 Review comment:
   I don't see a need for the `synchronized (addressLock)` given that the 
underlying data structure in the address manager is a `ConcurrentHashMap` and 
no other operations are being done (unlike in the other places which use 
`addressLock`). I think this fix looks good.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 295502)
Time Spent: 40m  (was: 0.5h)

> DeadLock between server.destroyQueue and server.removeAddressInfo
> -
>
> Key: ARTEMIS-2453
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2453
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: clebert suconic
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> "Thread-0 
> (ActiveMQ-remoting-threads-ActiveMQServerImpl::serverUUID=349ac51e-bf5e-11e9-9661-ecf4bbced624-2058174333)":
>  at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.getAddressInfo(PostOfficeImpl.java:652)
>  - waiting to lock <0x0005be7a5488> (a java.lang.Object) at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.removeBinding(PostOfficeImpl.java:749)
>  - locked <0x0005bb0702c8> (a 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl) at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deleteQueue(QueueImpl.java:1962)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2142)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2090)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2081)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2061)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.run(ServerSessionImpl.java:986)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.connectionFailed(ServerSessionImpl.java:1001)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.connectionFailed(ServerSessionImpl.java:1006)
>  at 
> org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:77)
>  at 
> org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:220)
>  at 
> org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:220)
>  at 
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.issueFailure(RemotingServiceImpl.java:572)
>  at 
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.connectionDestroyed(RemotingServiceImpl.java:553)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.NettyAcceptor$Listener.connectionDestroyed(NettyAcceptor.java:897)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler.lambda$channelInactive$0(ActiveMQChannelHandler.java:83)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler$$Lambda$56/1250509089.run(Unknown
>  Source) at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
>  at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
>  at 
>

[jira] [Work logged] (ARTEMIS-2453) DeadLock between server.destroyQueue and server.removeAddressInfo

2019-08-15 Thread ASF GitHub Bot (JIRA) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2453?focusedWorklogId=295490=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295490
 ]

ASF GitHub Bot logged work on ARTEMIS-2453:
---

Author: ASF GitHub Bot
Created on: 15/Aug/19 15:25
Start Date: 15/Aug/19 15:25
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on pull request #2799: 
ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo
URL: https://github.com/apache/activemq-artemis/pull/2799
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 295490)
Time Spent: 10m
Remaining Estimate: 0h

> DeadLock between server.destroyQueue and server.removeAddressInfo
> -
>
> Key: ARTEMIS-2453
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2453
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: clebert suconic
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> "Thread-0 
> (ActiveMQ-remoting-threads-ActiveMQServerImpl::serverUUID=349ac51e-bf5e-11e9-9661-ecf4bbced624-2058174333)":
>  at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.getAddressInfo(PostOfficeImpl.java:652)
>  - waiting to lock <0x0005be7a5488> (a java.lang.Object) at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.removeBinding(PostOfficeImpl.java:749)
>  - locked <0x0005bb0702c8> (a 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl) at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deleteQueue(QueueImpl.java:1962)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2142)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2090)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2081)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2061)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.run(ServerSessionImpl.java:986)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.connectionFailed(ServerSessionImpl.java:1001)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.connectionFailed(ServerSessionImpl.java:1006)
>  at 
> org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:77)
>  at 
> org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:220)
>  at 
> org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:220)
>  at 
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.issueFailure(RemotingServiceImpl.java:572)
>  at 
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.connectionDestroyed(RemotingServiceImpl.java:553)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.NettyAcceptor$Listener.connectionDestroyed(NettyAcceptor.java:897)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler.lambda$channelInactive$0(ActiveMQChannelHandler.java:83)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler$$Lambda$56/1250509089.run(Unknown
>  Source) at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
>  at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
>  at 
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66)
>  at 
> org.apache.activemq.artemis.utils.actors.ProcessorBase$$Lambda$2/323326911.run(Unknown
>  Source) at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  at 
> org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
>  "Thread-1 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$6@4a55a6e8)":
>  at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.removeBinding(PostOfficeImpl.java:724)
>  - waiting to lock <0x0005bb0702c8> (a 
>

[jira] [Work logged] (ARTEMIS-2453) DeadLock between server.destroyQueue and server.removeAddressInfo

2019-08-15 Thread ASF GitHub Bot (JIRA) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2453?focusedWorklogId=295491=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295491
 ]

ASF GitHub Bot logged work on ARTEMIS-2453:
---

Author: ASF GitHub Bot
Created on: 15/Aug/19 15:25
Start Date: 15/Aug/19 15:25
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on pull request #2799: 
ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo
URL: https://github.com/apache/activemq-artemis/pull/2799#discussion_r314363162
 
 

 ##
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
 ##
 @@ -649,9 +647,7 @@ public AddressInfo removeAddressInfo(SimpleString address, 
boolean force) throws
 
@Override
public AddressInfo getAddressInfo(SimpleString addressName) {
-  synchronized (addressLock) {
- return addressManager.getAddressInfo(addressName);
-  }
+  return addressManager.getAddressInfo(addressName);
 
 Review comment:
   There's no need to lock here?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 295491)
Time Spent: 20m  (was: 10m)

> DeadLock between server.destroyQueue and server.removeAddressInfo
> -
>
> Key: ARTEMIS-2453
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2453
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: clebert suconic
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> "Thread-0 
> (ActiveMQ-remoting-threads-ActiveMQServerImpl::serverUUID=349ac51e-bf5e-11e9-9661-ecf4bbced624-2058174333)":
>  at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.getAddressInfo(PostOfficeImpl.java:652)
>  - waiting to lock <0x0005be7a5488> (a java.lang.Object) at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.removeBinding(PostOfficeImpl.java:749)
>  - locked <0x0005bb0702c8> (a 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl) at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deleteQueue(QueueImpl.java:1962)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2142)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2090)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2081)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2061)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.run(ServerSessionImpl.java:986)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.connectionFailed(ServerSessionImpl.java:1001)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.connectionFailed(ServerSessionImpl.java:1006)
>  at 
> org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:77)
>  at 
> org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:220)
>  at 
> org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:220)
>  at 
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.issueFailure(RemotingServiceImpl.java:572)
>  at 
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.connectionDestroyed(RemotingServiceImpl.java:553)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.NettyAcceptor$Listener.connectionDestroyed(NettyAcceptor.java:897)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler.lambda$channelInactive$0(ActiveMQChannelHandler.java:83)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler$$Lambda$56/1250509089.run(Unknown
>  Source) at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
>  at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
>  at 
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66)
>  at 
> org.apache.activemq.artemis.utils.actors.ProcessorBase$$Lambda$2/323326911.run(Unknown
>  Source) at 
>

[jira] [Work logged] (ARTEMIS-2453) DeadLock between server.destroyQueue and server.removeAddressInfo

2019-08-15 Thread ASF GitHub Bot (JIRA) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2453?focusedWorklogId=295492=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295492
 ]

ASF GitHub Bot logged work on ARTEMIS-2453:
---

Author: ASF GitHub Bot
Created on: 15/Aug/19 15:25
Start Date: 15/Aug/19 15:25
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on pull request #2799: 
ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo
URL: https://github.com/apache/activemq-artemis/pull/2799#discussion_r314363282
 
 

 ##
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
 ##
 @@ -649,9 +647,7 @@ public AddressInfo removeAddressInfo(SimpleString address, 
boolean force) throws
 
@Override
public AddressInfo getAddressInfo(SimpleString addressName) {
-  synchronized (addressLock) {
- return addressManager.getAddressInfo(addressName);
-  }
+  return addressManager.getAddressInfo(addressName);
 
 Review comment:
   @jbertram What do you think about this?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 295492)
Time Spent: 0.5h  (was: 20m)

> DeadLock between server.destroyQueue and server.removeAddressInfo
> -
>
> Key: ARTEMIS-2453
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2453
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: clebert suconic
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> "Thread-0 
> (ActiveMQ-remoting-threads-ActiveMQServerImpl::serverUUID=349ac51e-bf5e-11e9-9661-ecf4bbced624-2058174333)":
>  at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.getAddressInfo(PostOfficeImpl.java:652)
>  - waiting to lock <0x0005be7a5488> (a java.lang.Object) at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.removeBinding(PostOfficeImpl.java:749)
>  - locked <0x0005bb0702c8> (a 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl) at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deleteQueue(QueueImpl.java:1962)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2142)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2090)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2081)
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2061)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.run(ServerSessionImpl.java:986)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.connectionFailed(ServerSessionImpl.java:1001)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.connectionFailed(ServerSessionImpl.java:1006)
>  at 
> org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:77)
>  at 
> org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:220)
>  at 
> org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:220)
>  at 
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.issueFailure(RemotingServiceImpl.java:572)
>  at 
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.connectionDestroyed(RemotingServiceImpl.java:553)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.NettyAcceptor$Listener.connectionDestroyed(NettyAcceptor.java:897)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler.lambda$channelInactive$0(ActiveMQChannelHandler.java:83)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler$$Lambda$56/1250509089.run(Unknown
>  Source) at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
>  at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
>  at 
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66)
>  at 
> org.apache.activemq.artemis.utils.actors.ProcessorBase$$Lambda$2/323326911.run(Unknown
>  Source) at 
>