[jira] [Commented] (ARTEMIS-358) Topic disappears when STOMP subscriber client disconnects without unsubscribe

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115326#comment-15115326
 ] 

ASF GitHub Bot commented on ARTEMIS-358:


Github user scop commented on the pull request:

https://github.com/apache/activemq-artemis/pull/341#issuecomment-174532025
  
You seem to be missing that it's the *topic* (not subscription) that kind 
of goes away; trying to send to the topic starts to produce error messages.


> Topic disappears when STOMP subscriber client disconnects without unsubscribe
> -
>
> Key: ARTEMIS-358
> URL: https://issues.apache.org/jira/browse/ARTEMIS-358
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Stomp
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Ville Skyttä
>
> When a STOMP client which has a subscription to a topic disconnects without 
> unsubscribing first, the topic seems to disappear.
> Reproducer:
> # configure a server with a topic (e.g. jms.topic.testtopic) and start it
> # STOMP: connect to the server
> # STOMP: subscribe to the topic
> # STOMP: disconnect from the server (without unsubscribing first)
> # STOMP: connect to the server again
> # STOMP: send a message to the topic
> At this point the server responds with "AMQ339001: Destination does not 
> exist: jms.topic.testtopic"
> At this point the topic is still visible in jconsole though so maybe it has 
> not disappeared entirely, but anyway, messages cannot be sent to it with 
> STOMP any more. Restarting the server makes it possible to send to it again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-358) Topic disappears when STOMP subscriber client disconnects without unsubscribe

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115328#comment-15115328
 ] 

ASF GitHub Bot commented on ARTEMIS-358:


Github user scop commented on the pull request:

https://github.com/apache/activemq-artemis/pull/341#issuecomment-174532317
  
(Well, the subscription goes away too, but that's expected.)


> Topic disappears when STOMP subscriber client disconnects without unsubscribe
> -
>
> Key: ARTEMIS-358
> URL: https://issues.apache.org/jira/browse/ARTEMIS-358
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Stomp
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Ville Skyttä
>
> When a STOMP client which has a subscription to a topic disconnects without 
> unsubscribing first, the topic seems to disappear.
> Reproducer:
> # configure a server with a topic (e.g. jms.topic.testtopic) and start it
> # STOMP: connect to the server
> # STOMP: subscribe to the topic
> # STOMP: disconnect from the server (without unsubscribing first)
> # STOMP: connect to the server again
> # STOMP: send a message to the topic
> At this point the server responds with "AMQ339001: Destination does not 
> exist: jms.topic.testtopic"
> At this point the topic is still visible in jconsole though so maybe it has 
> not disappeared entirely, but anyway, messages cannot be sent to it with 
> STOMP any more. Restarting the server makes it possible to send to it again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-358) Topic disappears when STOMP subscriber client disconnects without unsubscribe

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115473#comment-15115473
 ] 

ASF GitHub Bot commented on ARTEMIS-358:


Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/341


> Topic disappears when STOMP subscriber client disconnects without unsubscribe
> -
>
> Key: ARTEMIS-358
> URL: https://issues.apache.org/jira/browse/ARTEMIS-358
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Stomp
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Ville Skyttä
>
> When a STOMP client which has a subscription to a topic disconnects without 
> unsubscribing first, the topic seems to disappear.
> Reproducer:
> # configure a server with a topic (e.g. jms.topic.testtopic) and start it
> # STOMP: connect to the server
> # STOMP: subscribe to the topic
> # STOMP: disconnect from the server (without unsubscribing first)
> # STOMP: connect to the server again
> # STOMP: send a message to the topic
> At this point the server responds with "AMQ339001: Destination does not 
> exist: jms.topic.testtopic"
> At this point the topic is still visible in jconsole though so maybe it has 
> not disappeared entirely, but anyway, messages cannot be sent to it with 
> STOMP any more. Restarting the server makes it possible to send to it again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-358) Topic disappears when STOMP subscriber client disconnects without unsubscribe

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115472#comment-15115472
 ] 

ASF subversion and git services commented on ARTEMIS-358:
-

Commit 09a3f224cdcb7202fbf88bd114e16d5beb9c9c53 in activemq-artemis's branch 
refs/heads/master from [~scop]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=09a3f22 ]

ARTEMIS-358 test case for topic disappearing on disconnect without unsubscribe


> Topic disappears when STOMP subscriber client disconnects without unsubscribe
> -
>
> Key: ARTEMIS-358
> URL: https://issues.apache.org/jira/browse/ARTEMIS-358
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Stomp
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Ville Skyttä
>
> When a STOMP client which has a subscription to a topic disconnects without 
> unsubscribing first, the topic seems to disappear.
> Reproducer:
> # configure a server with a topic (e.g. jms.topic.testtopic) and start it
> # STOMP: connect to the server
> # STOMP: subscribe to the topic
> # STOMP: disconnect from the server (without unsubscribing first)
> # STOMP: connect to the server again
> # STOMP: send a message to the topic
> At this point the server responds with "AMQ339001: Destination does not 
> exist: jms.topic.testtopic"
> At this point the topic is still visible in jconsole though so maybe it has 
> not disappeared entirely, but anyway, messages cannot be sent to it with 
> STOMP any more. Restarting the server makes it possible to send to it again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-358) Topic disappears when STOMP subscriber client disconnects without unsubscribe

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115471#comment-15115471
 ] 

ASF GitHub Bot commented on ARTEMIS-358:


Github user clebertsuconic commented on the pull request:

https://github.com/apache/activemq-artemis/pull/341#issuecomment-174561872
  
I am merging the test


> Topic disappears when STOMP subscriber client disconnects without unsubscribe
> -
>
> Key: ARTEMIS-358
> URL: https://issues.apache.org/jira/browse/ARTEMIS-358
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Stomp
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Ville Skyttä
>
> When a STOMP client which has a subscription to a topic disconnects without 
> unsubscribing first, the topic seems to disappear.
> Reproducer:
> # configure a server with a topic (e.g. jms.topic.testtopic) and start it
> # STOMP: connect to the server
> # STOMP: subscribe to the topic
> # STOMP: disconnect from the server (without unsubscribing first)
> # STOMP: connect to the server again
> # STOMP: send a message to the topic
> At this point the server responds with "AMQ339001: Destination does not 
> exist: jms.topic.testtopic"
> At this point the topic is still visible in jconsole though so maybe it has 
> not disappeared entirely, but anyway, messages cannot be sent to it with 
> STOMP any more. Restarting the server makes it possible to send to it again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-358) Topic disappears when STOMP subscriber client disconnects without unsubscribe

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116218#comment-15116218
 ] 

ASF GitHub Bot commented on ARTEMIS-358:


Github user jbertram commented on the pull request:

https://github.com/apache/activemq-artemis/pull/346#issuecomment-174705757
  
I think @howardgao should take a look at this before it's merged.


> Topic disappears when STOMP subscriber client disconnects without unsubscribe
> -
>
> Key: ARTEMIS-358
> URL: https://issues.apache.org/jira/browse/ARTEMIS-358
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Stomp
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Ville Skyttä
>Assignee: Justin Bertram
>
> When a STOMP client which has a subscription to a topic disconnects without 
> unsubscribing first, the topic seems to disappear.
> Reproducer:
> # configure a server with a topic (e.g. jms.topic.testtopic) and start it
> # STOMP: connect to the server
> # STOMP: subscribe to the topic
> # STOMP: disconnect from the server (without unsubscribing first)
> # STOMP: connect to the server again
> # STOMP: send a message to the topic
> At this point the server responds with "AMQ339001: Destination does not 
> exist: jms.topic.testtopic"
> At this point the topic is still visible in jconsole though so maybe it has 
> not disappeared entirely, but anyway, messages cannot be sent to it with 
> STOMP any more. Restarting the server makes it possible to send to it again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-358) Topic disappears when STOMP subscriber client disconnects without unsubscribe

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116215#comment-15116215
 ] 

ASF GitHub Bot commented on ARTEMIS-358:


GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/346

ARTEMIS-358 topic mistakenly removed with sub

The problem here is that the management notification listener was mistakenly
removing the topic itself instead of just the non-durable subscription. In
general I can't see why StompProtocolManager even needs to keep track of the
destinations when the broker already does that. As far as I can tell it is
redundant and it's clearly error-prone. Therefore I'm removing the 
destination
tracking from StompProtocolManager altogether.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-358

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/346.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #346


commit 960e29afadcd3b5848a95406ad14d48099fb6c3c
Author: jbertram 
Date:   2016-01-25T22:36:02Z

ARTEMIS-358 topic mistakenly removed with sub

The problem here is that the management notification listener was mistakenly
removing the topic itself instead of just the non-durable subscription. In
general I can't see why StompProtocolManager even needs to keep track of the
destinations when the broker already does that. As far as I can tell it is
redundant and it's clearly error-prone. Therefore I'm removing the 
destination
tracking from StompProtocolManager altogether.




> Topic disappears when STOMP subscriber client disconnects without unsubscribe
> -
>
> Key: ARTEMIS-358
> URL: https://issues.apache.org/jira/browse/ARTEMIS-358
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Stomp
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Ville Skyttä
>Assignee: Justin Bertram
>
> When a STOMP client which has a subscription to a topic disconnects without 
> unsubscribing first, the topic seems to disappear.
> Reproducer:
> # configure a server with a topic (e.g. jms.topic.testtopic) and start it
> # STOMP: connect to the server
> # STOMP: subscribe to the topic
> # STOMP: disconnect from the server (without unsubscribing first)
> # STOMP: connect to the server again
> # STOMP: send a message to the topic
> At this point the server responds with "AMQ339001: Destination does not 
> exist: jms.topic.testtopic"
> At this point the topic is still visible in jconsole though so maybe it has 
> not disappeared entirely, but anyway, messages cannot be sent to it with 
> STOMP any more. Restarting the server makes it possible to send to it again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-358) Topic disappears when STOMP subscriber client disconnects without unsubscribe

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116310#comment-15116310
 ] 

ASF GitHub Bot commented on ARTEMIS-358:


Github user jbertram commented on the pull request:

https://github.com/apache/activemq-artemis/pull/346#issuecomment-174735323
  
Not sure why this was reported as failed.  Everything looks good to me: 
https://builds.apache.org/job/ActiveMQ-Artemis-PR-Build/962/console.


> Topic disappears when STOMP subscriber client disconnects without unsubscribe
> -
>
> Key: ARTEMIS-358
> URL: https://issues.apache.org/jira/browse/ARTEMIS-358
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Stomp
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Ville Skyttä
>Assignee: Justin Bertram
>
> When a STOMP client which has a subscription to a topic disconnects without 
> unsubscribing first, the topic seems to disappear.
> Reproducer:
> # configure a server with a topic (e.g. jms.topic.testtopic) and start it
> # STOMP: connect to the server
> # STOMP: subscribe to the topic
> # STOMP: disconnect from the server (without unsubscribing first)
> # STOMP: connect to the server again
> # STOMP: send a message to the topic
> At this point the server responds with "AMQ339001: Destination does not 
> exist: jms.topic.testtopic"
> At this point the topic is still visible in jconsole though so maybe it has 
> not disappeared entirely, but anyway, messages cannot be sent to it with 
> STOMP any more. Restarting the server makes it possible to send to it again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-358) Topic disappears when STOMP subscriber client disconnects without unsubscribe

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116504#comment-15116504
 ] 

ASF subversion and git services commented on ARTEMIS-358:
-

Commit ddc95a0f28e5a55bb8abd04661ec09b0ac5432fc in activemq-artemis's branch 
refs/heads/master from [~jbertram]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=ddc95a0 ]

ARTEMIS-358 topic mistakenly removed with sub

The problem here is that the management notification listener was mistakenly
removing the topic itself instead of just the non-durable subscription. In
general I can't see why StompProtocolManager even needs to keep track of the
destinations when the broker already does that. As far as I can tell it is
redundant and it's clearly error-prone. Therefore I'm removing the destination
tracking from StompProtocolManager altogether.


> Topic disappears when STOMP subscriber client disconnects without unsubscribe
> -
>
> Key: ARTEMIS-358
> URL: https://issues.apache.org/jira/browse/ARTEMIS-358
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Stomp
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Ville Skyttä
>Assignee: Justin Bertram
>
> When a STOMP client which has a subscription to a topic disconnects without 
> unsubscribing first, the topic seems to disappear.
> Reproducer:
> # configure a server with a topic (e.g. jms.topic.testtopic) and start it
> # STOMP: connect to the server
> # STOMP: subscribe to the topic
> # STOMP: disconnect from the server (without unsubscribing first)
> # STOMP: connect to the server again
> # STOMP: send a message to the topic
> At this point the server responds with "AMQ339001: Destination does not 
> exist: jms.topic.testtopic"
> At this point the topic is still visible in jconsole though so maybe it has 
> not disappeared entirely, but anyway, messages cannot be sent to it with 
> STOMP any more. Restarting the server makes it possible to send to it again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-358) Topic disappears when STOMP subscriber client disconnects without unsubscribe

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116505#comment-15116505
 ] 

ASF GitHub Bot commented on ARTEMIS-358:


Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/346


> Topic disappears when STOMP subscriber client disconnects without unsubscribe
> -
>
> Key: ARTEMIS-358
> URL: https://issues.apache.org/jira/browse/ARTEMIS-358
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Stomp
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Ville Skyttä
>Assignee: Justin Bertram
>
> When a STOMP client which has a subscription to a topic disconnects without 
> unsubscribing first, the topic seems to disappear.
> Reproducer:
> # configure a server with a topic (e.g. jms.topic.testtopic) and start it
> # STOMP: connect to the server
> # STOMP: subscribe to the topic
> # STOMP: disconnect from the server (without unsubscribing first)
> # STOMP: connect to the server again
> # STOMP: send a message to the topic
> At this point the server responds with "AMQ339001: Destination does not 
> exist: jms.topic.testtopic"
> At this point the topic is still visible in jconsole though so maybe it has 
> not disappeared entirely, but anyway, messages cannot be sent to it with 
> STOMP any more. Restarting the server makes it possible to send to it again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-358) Topic disappears when STOMP subscriber client disconnects without unsubscribe

[JIRA]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114314#comment-15114314
 ] 

Ville Skyttä commented on ARTEMIS-358:
--

PR containing a test (not a fix): 
https://github.com/apache/activemq-artemis/pull/341

> Topic disappears when STOMP subscriber client disconnects without unsubscribe
> -
>
> Key: ARTEMIS-358
> URL: https://issues.apache.org/jira/browse/ARTEMIS-358
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Stomp
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Ville Skyttä
>
> When a STOMP client which has a subscription to a topic disconnects without 
> unsubscribing first, the topic seems to disappear.
> Reproducer:
> # configure a server with a topic (e.g. jms.topic.testtopic) and start it
> # STOMP: connect to the server
> # STOMP: subscribe to the topic
> # STOMP: disconnect from the server (without unsubscribing first)
> # STOMP: connect to the server again
> # STOMP: send a message to the topic
> At this point the server responds with "AMQ339001: Destination does not 
> exist: jms.topic.testtopic"
> At this point the topic is still visible in jconsole though so maybe it has 
> not disappeared entirely, but anyway, messages cannot be sent to it with 
> STOMP any more. Restarting the server makes it possible to send to it again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-358) Topic disappears when STOMP subscriber client disconnects without unsubscribe

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114313#comment-15114313
 ] 

ASF GitHub Bot commented on ARTEMIS-358:


GitHub user scop opened a pull request:

https://github.com/apache/activemq-artemis/pull/341

ARTEMIS-358 test case for topic disappearing on disconnect without unsub

Test case (not a fix) demonstrating the issue.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scop/activemq-artemis topic-disappears

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/341.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #341


commit c84f9c644c15cafeb02526c9343c17d538cdade9
Author: Ville Skyttä 
Date:   2016-01-24T13:50:53Z

ARTEMIS-358 test case for topic disappearing on disconnect without 
unsubscribe




> Topic disappears when STOMP subscriber client disconnects without unsubscribe
> -
>
> Key: ARTEMIS-358
> URL: https://issues.apache.org/jira/browse/ARTEMIS-358
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Stomp
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Ville Skyttä
>
> When a STOMP client which has a subscription to a topic disconnects without 
> unsubscribing first, the topic seems to disappear.
> Reproducer:
> # configure a server with a topic (e.g. jms.topic.testtopic) and start it
> # STOMP: connect to the server
> # STOMP: subscribe to the topic
> # STOMP: disconnect from the server (without unsubscribing first)
> # STOMP: connect to the server again
> # STOMP: send a message to the topic
> At this point the server responds with "AMQ339001: Destination does not 
> exist: jms.topic.testtopic"
> At this point the topic is still visible in jconsole though so maybe it has 
> not disappeared entirely, but anyway, messages cannot be sent to it with 
> STOMP any more. Restarting the server makes it possible to send to it again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)