isururanawaka opened a new pull request #1: NIO based file transport
implementation
URL: https://github.com/apache/airavata-mft/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, plea
DImuthuUpe commented on a change in pull request #1: NIO based file transport
implementation
URL: https://github.com/apache/airavata-mft/pull/1#discussion_r314576250
##
File path:
core/src/main/java/org/apache/airavata/mft/core/bufferedImpl/AbstractConnector.java
##
@@ -0
DImuthuUpe commented on a change in pull request #1: NIO based file transport
implementation
URL: https://github.com/apache/airavata-mft/pull/1#discussion_r314575572
##
File path:
core/src/main/java/org/apache/airavata/mft/core/bufferedImpl/PassthroughMediator.java
##
@@
DImuthuUpe commented on a change in pull request #1: NIO based file transport
implementation
URL: https://github.com/apache/airavata-mft/pull/1#discussion_r314576315
##
File path:
core/src/main/java/org/apache/airavata/mft/core/api/SinkConnector.java
##
@@ -0,0 +1,43 @@
+
DImuthuUpe commented on a change in pull request #1: NIO based file transport
implementation
URL: https://github.com/apache/airavata-mft/pull/1#discussion_r314575401
##
File path:
core/src/main/java/org/apache/airavata/mft/core/bufferedImpl/ChannelUtils.java
##
@@ -0,0 +1
DImuthuUpe commented on a change in pull request #1: NIO based file transport
implementation
URL: https://github.com/apache/airavata-mft/pull/1#discussion_r314576866
##
File path:
transport/s3-transport/src/main/java/org/apache/airavata/mft/transport/s3/S3SinkConnector.java
##
DImuthuUpe commented on a change in pull request #1: NIO based file transport
implementation
URL: https://github.com/apache/airavata-mft/pull/1#discussion_r314576342
##
File path:
core/src/main/java/org/apache/airavata/mft/core/api/SourceConnector.java
##
@@ -0,0 +1,37 @@
DImuthuUpe commented on a change in pull request #1: NIO based file transport
implementation
URL: https://github.com/apache/airavata-mft/pull/1#discussion_r314576170
##
File path:
core/src/main/java/org/apache/airavata/mft/core/bufferedImpl/AbstractConnector.java
##
@@ -0
DImuthuUpe commented on a change in pull request #1: NIO based file transport
implementation
URL: https://github.com/apache/airavata-mft/pull/1#discussion_r314577501
##
File path:
transport/s3-transport/src/main/java/org/apache/airavata/mft/transport/s3/S3SourceConnector.java
DImuthuUpe commented on a change in pull request #1: NIO based file transport
implementation
URL: https://github.com/apache/airavata-mft/pull/1#discussion_r314573684
##
File path:
transport/s3-transport/src/main/java/org/apache/airavata/mft/transport/s3/S3Constants.java
##
isururanawaka commented on a change in pull request #1: NIO based file
transport implementation
URL: https://github.com/apache/airavata-mft/pull/1#discussion_r314700755
##
File path:
core/src/main/java/org/apache/airavata/mft/core/bufferedImpl/ChannelUtils.java
##
@@ -0,0
isururanawaka commented on a change in pull request #1: NIO based file
transport implementation
URL: https://github.com/apache/airavata-mft/pull/1#discussion_r314701473
##
File path:
core/src/main/java/org/apache/airavata/mft/core/bufferedImpl/PassthroughMediator.java
##
isururanawaka commented on a change in pull request #1: NIO based file
transport implementation
URL: https://github.com/apache/airavata-mft/pull/1#discussion_r314702301
##
File path:
transport/s3-transport/src/main/java/org/apache/airavata/mft/transport/s3/S3Constants.java
###
isururanawaka commented on a change in pull request #1: NIO based file
transport implementation
URL: https://github.com/apache/airavata-mft/pull/1#discussion_r314704807
##
File path:
transport/s3-transport/src/main/java/org/apache/airavata/mft/transport/s3/S3SinkConnector.java
###
isururanawaka commented on a change in pull request #1: NIO based file
transport implementation
URL: https://github.com/apache/airavata-mft/pull/1#discussion_r314704807
##
File path:
transport/s3-transport/src/main/java/org/apache/airavata/mft/transport/s3/S3SinkConnector.java
###
isururanawaka commented on a change in pull request #1: NIO based file
transport implementation
URL: https://github.com/apache/airavata-mft/pull/1#discussion_r314707209
##
File path:
transport/s3-transport/src/main/java/org/apache/airavata/mft/transport/s3/S3SourceConnector.java
#
DImuthuUpe commented on issue #1: NIO based file transport implementation
URL: https://github.com/apache/airavata-mft/pull/1#issuecomment-523983703
Looks good to me. I'm going to merge this. Thanks @isururanawaka
This is an a
DImuthuUpe merged pull request #1: NIO based file transport implementation
URL: https://github.com/apache/airavata-mft/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on
lzf971107 opened a new pull request #2: add Copyright
URL: https://github.com/apache/airavata-mft/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
DImuthuUpe merged pull request #2: add Copyright
URL: https://github.com/apache/airavata-mft/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
aarushiibisht opened a new pull request #3: First version of mft python client
URL: https://github.com/apache/airavata-mft/pull/3
This is an automated message from the Apache Git Service.
To respond to the message, please log
pokearu opened a new pull request #4: Artifactory dependency version change to
0.17
URL: https://github.com/apache/airavata-mft/pull/4
The version of the dependencies in the maven repository were 0.17, but the
files were looking for 0.19.
This threw the below error.
 Added APIs to get storage types, all storages and resources.
2) Refactored FileBasedResourceBackend to avoid code duplicity and added
methods to get all storag
aarushiibisht commented on issue #3:
URL: https://github.com/apache/airavata-mft/pull/3#issuecomment-617596110
This is an old PR. The code for MFT portal is now in a separate repo. Hence
closing it.
This is an automated mess
DImuthuUpe commented on a change in pull request #7:
URL: https://github.com/apache/airavata-mft/pull/7#discussion_r412733587
##
File path: services/resource-service/stub/src/main/proto/ResourceService.proto
##
@@ -80,6 +82,10 @@ message SCPResourceDeleteRequest {
string r
pokearu commented on a change in pull request #6:
URL: https://github.com/apache/airavata-mft/pull/6#discussion_r412747890
##
File path:
transport/gcp-transport/src/main/java/org/apache/airavata/mft/transport/gcp/GCSMetadataCollector.java
##
@@ -0,0 +1,102 @@
+package org.apac
pokearu commented on a change in pull request #6:
URL: https://github.com/apache/airavata-mft/pull/6#discussion_r412749232
##
File path:
services/secret-service/server/src/main/java/org/apache/airavata/mft/secret/server/backend/file/FileBasedSecretBackend.java
##
@@ -211,4 +21
pokearu commented on a change in pull request #6:
URL: https://github.com/apache/airavata-mft/pull/6#discussion_r412750663
##
File path:
transport/gcp-transport/src/main/java/org/apache/airavata/mft/transport/gcp/GCSSender.java
##
@@ -0,0 +1,86 @@
+package org.apache.airavata.
DImuthuUpe commented on a change in pull request #6:
URL: https://github.com/apache/airavata-mft/pull/6#discussion_r413110551
##
File path:
transport/gcp-transport/src/main/java/org/apache/airavata/mft/transport/gcp/GCSSender.java
##
@@ -0,0 +1,86 @@
+package org.apache.airava
DImuthuUpe commented on a change in pull request #6:
URL: https://github.com/apache/airavata-mft/pull/6#discussion_r413114202
##
File path: transport/gcp-transport/pom.xml
##
@@ -0,0 +1,39 @@
+http://maven.apache.org/POM/4.0.0";
Review comment:
Add apache header
##
pokearu commented on a change in pull request #6:
URL: https://github.com/apache/airavata-mft/pull/6#discussion_r413149321
##
File path:
services/secret-service/server/src/main/java/org/apache/airavata/mft/secret/server/backend/file/FileBasedSecretBackend.java
##
@@ -211,4 +21
pokearu commented on a change in pull request #6:
URL: https://github.com/apache/airavata-mft/pull/6#discussion_r413155433
##
File path:
transport/gcp-transport/src/main/java/org/apache/airavata/mft/transport/gcp/GCSSender.java
##
@@ -0,0 +1,86 @@
+package org.apache.airavata.
DImuthuUpe commented on a change in pull request #6:
URL: https://github.com/apache/airavata-mft/pull/6#discussion_r413183181
##
File path:
services/secret-service/server/src/main/java/org/apache/airavata/mft/secret/server/backend/file/FileBasedSecretBackend.java
##
@@ -211,4
pokearu commented on a change in pull request #6:
URL: https://github.com/apache/airavata-mft/pull/6#discussion_r413194484
##
File path:
services/secret-service/server/src/main/java/org/apache/airavata/mft/secret/server/backend/file/FileBasedSecretBackend.java
##
@@ -211,4 +21
pokearu commented on a change in pull request #6:
URL: https://github.com/apache/airavata-mft/pull/6#discussion_r413194484
##
File path:
services/secret-service/server/src/main/java/org/apache/airavata/mft/secret/server/backend/file/FileBasedSecretBackend.java
##
@@ -211,4 +21
aarushiibisht commented on a change in pull request #7:
URL: https://github.com/apache/airavata-mft/pull/7#discussion_r413227263
##
File path: services/resource-service/stub/src/main/proto/ResourceService.proto
##
@@ -80,6 +82,10 @@ message SCPResourceDeleteRequest {
strin
sharanya17410 commented on a change in pull request #6:
URL: https://github.com/apache/airavata-mft/pull/6#discussion_r413269205
##
File path:
transport/gcp-transport/src/main/java/org/apache/airavata/mft/transport/gcp/GCSSender.java
##
@@ -0,0 +1,86 @@
+package org.apache.air
pokearu commented on issue #6:
URL: https://github.com/apache/airavata-mft/pull/6#issuecomment-618029906
We have implemented the requested changes. Please do check and let us know.
👍
This is an automated message from the Ap
DImuthuUpe commented on a change in pull request #6:
URL: https://github.com/apache/airavata-mft/pull/6#discussion_r413436548
##
File path:
transport/gcp-transport/src/main/java/org/apache/airavata/mft/transport/gcp/GCSSender.java
##
@@ -0,0 +1,86 @@
+package org.apache.airava
DImuthuUpe commented on a change in pull request #6:
URL: https://github.com/apache/airavata-mft/pull/6#discussion_r413437205
##
File path:
services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/file/FileBasedResourceBackend.java
##
@@ -
aksrajvanshi commented on a change in pull request #6:
URL: https://github.com/apache/airavata-mft/pull/6#discussion_r413443451
##
File path:
services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/file/FileBasedResourceBackend.java
##
@@
pokearu commented on issue #6:
URL: https://github.com/apache/airavata-mft/pull/6#issuecomment-618125083
@DImuthuUpe Okay we will add the license headers 👍
Sorry, but i am a bit unclear on what are the minor suggestions you are
referring to? Is it about the indentation or the content
DImuthuUpe commented on a change in pull request #6:
URL: https://github.com/apache/airavata-mft/pull/6#discussion_r413447927
##
File path:
services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/file/FileBasedResourceBackend.java
##
@@ -
DImuthuUpe commented on issue #6:
URL: https://github.com/apache/airavata-mft/pull/6#issuecomment-618127772
> @DImuthuUpe Okay we will add the license headers 👍
>
> Sorry, but i am a bit unclear on what are the minor suggestions you are
referring to? Is it about the indentation or th
aksrajvanshi commented on issue #6:
URL: https://github.com/apache/airavata-mft/pull/6#issuecomment-618135870
We have changed the indentation issue and added the license headers. Can you
please look into the changes once again?
-
DImuthuUpe commented on issue #6:
URL: https://github.com/apache/airavata-mft/pull/6#issuecomment-618137839
All look good to me. Great work. I'm going to merge this
This is an automated message from the Apache Git Service.
To
gkiran292 opened a new pull request #8:
URL: https://github.com/apache/airavata-mft/pull/8
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
sharanya17410 opened a new pull request #9:
URL: https://github.com/apache/airavata-mft/pull/9
@DImuthuUpe @smarru
We have implemented the mft dropbox transport protocol. Could you please
take a look at our implementation ?
Looking forward to your feedback.
---
pokearu commented on pull request #9:
URL: https://github.com/apache/airavata-mft/pull/9#issuecomment-619161191
Thank you for the feedback 😁
This is an automated message from the Apache Git Service.
To respond to the message,
smarru commented on pull request #9:
URL: https://github.com/apache/airavata-mft/pull/9#issuecomment-619163958
+ 1 very neat PR
This is an automated message from the Apache Git Service.
To respond to the message, please log o
gkiran292 opened a new pull request #10:
URL: https://github.com/apache/airavata-mft/pull/10
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
gkiran292 commented on pull request #10:
URL: https://github.com/apache/airavata-mft/pull/10#issuecomment-620391566
There are lot of eclipse-related hence I am adding gitignore to remove those
files to make the FTP PR cleaner
---
nbafna04 opened a new pull request #11:
URL: https://github.com/apache/airavata-mft/pull/11
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
gkiran292 opened a new pull request #12:
URL: https://github.com/apache/airavata-mft/pull/12
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
gkiran292 commented on pull request #10:
URL: https://github.com/apache/airavata-mft/pull/10#issuecomment-620946848
Yes, we can specify the languages and platforms that need to be included. I
used VSCode plugin to generate the .ignore file
-
DImuthuUpe commented on a change in pull request #11:
URL: https://github.com/apache/airavata-mft/pull/11#discussion_r417023741
##
File path:
transport/gdrive-transport/src/main/java/org/apache/airavata/mft/transport/gdrive/GDriveMetadataCollector.java
##
@@ -0,0 +1,151 @@
+/*
aniruddhavpatil commented on a change in pull request #11:
URL: https://github.com/apache/airavata-mft/pull/11#discussion_r417054930
##
File path:
services/secret-service/server/src/main/java/org/apache/airavata/mft/secret/server/backend/file/FileBasedSecretBackend.java
##
@@
aniruddhavpatil commented on pull request #11:
URL: https://github.com/apache/airavata-mft/pull/11#issuecomment-620987364
We made the following changes as per your review:
1. Removed unnecessary logs.
2. Removed the need for providing a constant application name.
3. Added the null c
DImuthuUpe commented on pull request #11:
URL: https://github.com/apache/airavata-mft/pull/11#issuecomment-620994948
@aniruddhavpatil Still there are some unresolved reviews in
https://github.com/apache/airavata-mft/pull/11/files. Please address them
DImuthuUpe commented on a change in pull request #11:
URL: https://github.com/apache/airavata-mft/pull/11#discussion_r417366756
##
File path:
transport/gdrive-transport/src/main/java/org/apache/airavata/mft/transport/gdrive/GDriveReceiver.java
##
@@ -0,0 +1,143 @@
+/*
+ * Lice
nbafna04 commented on a change in pull request #11:
URL: https://github.com/apache/airavata-mft/pull/11#discussion_r417483154
##
File path: services/secret-service/server/src/main/resources/secrets.json
##
@@ -36,6 +36,6 @@
{
"type": "GDRIVE",
"secretId": "gdrive-c
nbafna04 commented on a change in pull request #11:
URL: https://github.com/apache/airavata-mft/pull/11#discussion_r417487101
##
File path:
transport/gdrive-transport/src/main/java/org/apache/airavata/mft/transport/gdrive/GDriveReceiver.java
##
@@ -0,0 +1,143 @@
+/*
+ * Licens
JShivali commented on a change in pull request #11:
URL: https://github.com/apache/airavata-mft/pull/11#discussion_r417489482
##
File path:
transport/gdrive-transport/src/main/java/org/apache/airavata/mft/transport/gdrive/GDriveReceiver.java
##
@@ -0,0 +1,143 @@
+/*
+ * Licens
nbafna04 commented on a change in pull request #11:
URL: https://github.com/apache/airavata-mft/pull/11#discussion_r417490367
##
File path:
transport/gdrive-transport/src/main/java/org/apache/airavata/mft/transport/gdrive/GDriveReceiver.java
##
@@ -0,0 +1,143 @@
+/*
+ * Licens
gkiran292 opened a new pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13
FTP transport changes.
@DImuthuUpe Please review this.
This is an automated message from the Apache Git Service.
To respond t
gkiran292 commented on pull request #12:
URL: https://github.com/apache/airavata-mft/pull/12#issuecomment-621494753
Since there are a lot of changes that I need to do creating a proper PR with
only FTP changes. I will create the next PR after that is merged. I mistakenly
did the formatting
sharanya17410 edited a comment on pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13#issuecomment-622163825
You have missed including the dependency for your FTP-transport under
mft-agent/pom.xml
This is a
sharanya17410 commented on pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13#issuecomment-622163825
You have missed including your FTP-transport under mft-agent/pom.xml
This is an automated message from th
gkiran292 opened a new pull request #14:
URL: https://github.com/apache/airavata-mft/pull/14
Updating the client code to break when the transfer is completed and adding
"start agent" part
This is an automated message from th
gkiran292 commented on pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13#issuecomment-622173427
> You have missed including the dependency for your FTP-transport under
mft-agent/pom.xml
I have added it!
---
gkiran292 opened a new pull request #15:
URL: https://github.com/apache/airavata-mft/pull/15
There were streams that were not closed and redundant use of
outputstream.flush()
outputstream.close() does flush internally!
Th
dinukadesilva commented on a change in pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13#discussion_r418398107
##
File path:
services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/sql/SQLResourceBackend.java
##
@@ -18
aarushiibisht commented on a change in pull request #15:
URL: https://github.com/apache/airavata-mft/pull/15#discussion_r418398914
##
File path:
services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/file/FileBasedResourceBackend.java
##
dinukadesilva commented on a change in pull request #11:
URL: https://github.com/apache/airavata-mft/pull/11#discussion_r418400874
##
File path: services/secret-service/server/pom.xml
##
@@ -47,7 +47,7 @@
org.apache.airavata
airavata-credenti
dinukadesilva commented on pull request #7:
URL: https://github.com/apache/airavata-mft/pull/7#issuecomment-622235410
Can't we make these generic endpoints rather having specific endpoints for
each type of resource? Is that what we are trying already?
-
nbafna04 commented on a change in pull request #11:
URL: https://github.com/apache/airavata-mft/pull/11#discussion_r418412893
##
File path:
transport/gdrive-transport/src/main/java/org/apache/airavata/mft/transport/gdrive/GDriveReceiver.java
##
@@ -0,0 +1,128 @@
+/*
+ * Licens
nbafna04 commented on a change in pull request #11:
URL: https://github.com/apache/airavata-mft/pull/11#discussion_r418413119
##
File path: services/secret-service/server/pom.xml
##
@@ -47,7 +47,7 @@
org.apache.airavata
airavata-credential-st
nbafna04 commented on a change in pull request #11:
URL: https://github.com/apache/airavata-mft/pull/11#discussion_r418413961
##
File path:
services/resource-service/server/src/main/resources/distribution/conf/resources.json
##
@@ -59,5 +59,10 @@
"type": "DROPBOX",
"
1 - 100 of 672 matches
Mail list logo
