[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-03-05 Thread Luke Cwik (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052431#comment-17052431 ] Luke Cwik commented on BEAM-9288: - Release vote thread for RC #3:  [https://lists.apache.o

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-03-04 Thread Luke Cwik (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051631#comment-17051631 ] Luke Cwik commented on BEAM-9288: - Yes to your steps: My understanding to the follow up o

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-03-04 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051619#comment-17051619 ] Rui Wang commented on BEAM-9288: A followup question is, is "still are adding the conscr

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-03-04 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051602#comment-17051602 ] Rui Wang commented on BEAM-9288: [~lcwik] My understanding to the follow up of this Jira

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-03-03 Thread Luke Cwik (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050643#comment-17050643 ] Luke Cwik commented on BEAM-9288: - It seems we still are adding the conscrypt native libra

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-03-03 Thread Luke Cwik (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050468#comment-17050468 ] Luke Cwik commented on BEAM-9288: - RC #1 vote thread: [https://lists.apache.org/thread.ht

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-03-03 Thread Jira
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050052#comment-17050052 ] Ismaël Mejía commented on BEAM-9288: As mentioned by [~lukec...@gmail.com] If we cherr

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-03-02 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049607#comment-17049607 ] Rui Wang commented on BEAM-9288: I will cherry-pick #10940 and make 2.20.0 released. After

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-03-02 Thread Luke Cwik (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049540#comment-17049540 ] Luke Cwik commented on BEAM-9288: - A release needs to happen and the version used in Apach

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-03-02 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049537#comment-17049537 ] Rui Wang commented on BEAM-9288: [~sunjincheng121] will this Jira be considered finished?

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-02-28 Thread Kenneth Knowles (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047818#comment-17047818 ] Kenneth Knowles commented on BEAM-9288: --- Oh, and yea Beam definitely needs this. Per

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-02-28 Thread Kenneth Knowles (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047817#comment-17047817 ] Kenneth Knowles commented on BEAM-9288: --- If it is not a regression then I would not

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-02-28 Thread Jira
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047343#comment-17047343 ] Ismaël Mejía commented on BEAM-9288: Oh I see that's clearly a mistake I will unlink t

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-02-27 Thread Kenneth Knowles (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047061#comment-17047061 ] Kenneth Knowles commented on BEAM-9288: --- But since you filed BEAM-9252 (resolved) bu

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-02-27 Thread Kenneth Knowles (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047060#comment-17047060 ] Kenneth Knowles commented on BEAM-9288: --- I think leaving it as a residual dependency

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-02-27 Thread Jira
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046992#comment-17046992 ] Ismaël Mejía commented on BEAM-9288: Is this a real issue or just a nice to have, beca

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-02-24 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17043967#comment-17043967 ] Rui Wang commented on BEAM-9288: I am going to cut 2.20.0 branch on 02/26/2020. Can this J

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-02-22 Thread sunjincheng (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042601#comment-17042601 ] sunjincheng commented on BEAM-9288: --- I agree that we should exclude it from the vendored

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-02-20 Thread Kenneth Knowles (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17041366#comment-17041366 ] Kenneth Knowles commented on BEAM-9288: --- In the near term, I think we can exclude it

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-02-10 Thread Esun Kim (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034131#comment-17034131 ] Esun Kim commented on BEAM-9288: Gcsio starts depending on gRPC along with conscrypt and w

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-02-10 Thread Luke Cwik (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034076#comment-17034076 ] Luke Cwik commented on BEAM-9288: - If gcs io is shading conscrypt, then it should fix it's

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-02-10 Thread Igor Dvorzhak (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034066#comment-17034066 ] Igor Dvorzhak commented on BEAM-9288: - Will it be better to exclude Concrypt from shad

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-02-10 Thread Luke Cwik (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034021#comment-17034021 ] Luke Cwik commented on BEAM-9288: - I filed [https://github.com/google/conscrypt/issues/811

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-02-10 Thread Luke Cwik (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034017#comment-17034017 ] Luke Cwik commented on BEAM-9288: - The idea would be to use a solution similar to tcnative

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-02-10 Thread Luke Cwik (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034010#comment-17034010 ] Luke Cwik commented on BEAM-9288: - cc: [~sunjincheng121]   Conscrypt can be shaded prope

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-02-10 Thread Chamikara Madhusanka Jayalath (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034008#comment-17034008 ] Chamikara Madhusanka Jayalath commented on BEAM-9288: - Is there a way

[jira] [Commented] (BEAM-9288) Conscrypt shaded dependency

2020-02-10 Thread Chamikara Madhusanka Jayalath (Jira)
[ https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034007#comment-17034007 ] Chamikara Madhusanka Jayalath commented on BEAM-9288: - cc: [~lcwik] [~