[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=386066=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386066 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 12/Feb/20 16:49 Start Date: 12/Feb/20 16:49 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #10779: [BEAM-3221, BEAM-4180] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386066) Time Spent: 5h 50m (was: 5h 40m) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 5h 50m > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=385393=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-385393 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 11/Feb/20 19:30 Start Date: 11/Feb/20 19:30 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10779: [BEAM-3221, BEAM-4180] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779#issuecomment-584810497 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 385393) Time Spent: 5h 40m (was: 5.5h) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 5h 40m > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=384890=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384890 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 11/Feb/20 01:00 Start Date: 11/Feb/20 01:00 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10779: [BEAM-3221, BEAM-4180] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779#issuecomment-584432912 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 384890) Time Spent: 5.5h (was: 5h 20m) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 5.5h > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=384849=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384849 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 10/Feb/20 23:45 Start Date: 10/Feb/20 23:45 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10779: [BEAM-3221, BEAM-4180] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779#issuecomment-584414243 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 384849) Time Spent: 5h 20m (was: 5h 10m) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 5h 20m > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=384836=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384836 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 10/Feb/20 23:32 Start Date: 10/Feb/20 23:32 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10779: [BEAM-3221, BEAM-4180] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779#issuecomment-584410627 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 384836) Time Spent: 5h 10m (was: 5h) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 5h 10m > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=384786=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384786 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 10/Feb/20 22:46 Start Date: 10/Feb/20 22:46 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10779: [BEAM-3221, BEAM-4180] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779#issuecomment-584395599 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 384786) Time Spent: 5h (was: 4h 50m) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 5h > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=384734=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384734 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 10/Feb/20 21:00 Start Date: 10/Feb/20 21:00 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10779: [BEAM-3221, BEAM-4180] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779#issuecomment-584351541 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 384734) Time Spent: 4h 50m (was: 4h 40m) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 4h 50m > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=384030=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384030 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 09/Feb/20 02:08 Start Date: 09/Feb/20 02:08 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10779: [BEAM-3221, BEAM-4180] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779#issuecomment-583796413 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 384030) Time Spent: 4h 40m (was: 4.5h) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 4h 40m > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=383918=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383918 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 08/Feb/20 02:30 Start Date: 08/Feb/20 02:30 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10779: [BEAM-3221, BEAM-4180] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779#issuecomment-583693456 Run Java_Examples_Dataflow_Java11 PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383918) Time Spent: 4.5h (was: 4h 20m) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 4.5h > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=383917=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383917 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 08/Feb/20 02:29 Start Date: 08/Feb/20 02:29 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10779: [BEAM-3221, BEAM-4180] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779#issuecomment-583693436 Run JavaPortabilityApiJava11 PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383917) Time Spent: 4h 20m (was: 4h 10m) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 4h 20m > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=383916=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383916 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 08/Feb/20 02:29 Start Date: 08/Feb/20 02:29 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10779: [BEAM-3221, BEAM-4180] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779#issuecomment-583693408 Run Java11 PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383916) Time Spent: 4h 10m (was: 4h) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 4h 10m > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=383839=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383839 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 07/Feb/20 21:21 Start Date: 07/Feb/20 21:21 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10779: [BEAM-3221, BEAM-4180] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779#issuecomment-583618370 Run Java_Examples_Dataflow_Java11 PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383839) Time Spent: 4h (was: 3h 50m) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 4h > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=383837=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383837 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 07/Feb/20 21:21 Start Date: 07/Feb/20 21:21 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10779: [BEAM-3221, BEAM-4180] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779#issuecomment-583618242 Run Java11 PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383837) Time Spent: 3h 40m (was: 3.5h) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 3h 40m > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=383838=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383838 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 07/Feb/20 21:21 Start Date: 07/Feb/20 21:21 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10779: [BEAM-3221, BEAM-4180] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779#issuecomment-583618291 Run JavaPortabilityApiJava11 PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383838) Time Spent: 3h 50m (was: 3h 40m) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 3h 50m > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=383779=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383779 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 07/Feb/20 18:41 Start Date: 07/Feb/20 18:41 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10779: [BEAM-3221, BEAM-4180] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779#issuecomment-583548103 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383779) Time Spent: 3h 20m (was: 3h 10m) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 3h 20m > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=383780=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383780 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 07/Feb/20 18:41 Start Date: 07/Feb/20 18:41 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10779: [BEAM-3221, BEAM-4180] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779#issuecomment-583548190 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383780) Time Spent: 3.5h (was: 3h 20m) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 3.5h > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=383639=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383639 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 07/Feb/20 14:57 Start Date: 07/Feb/20 14:57 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10779: [BEAM-3221, BEAM-4180] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779#issuecomment-583428154 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383639) Time Spent: 3h 10m (was: 3h) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 3h 10m > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=383622=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383622 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 07/Feb/20 14:49 Start Date: 07/Feb/20 14:49 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10779: [BEAM-3221, BEAM-4180] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779#issuecomment-583422629 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383622) Time Spent: 3h (was: 2h 50m) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 3h > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[
https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=383171=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383171
]
ASF GitHub Bot logged work on BEAM-3221:
Author: ASF GitHub Bot
Created on: 06/Feb/20 21:34
Start Date: 06/Feb/20 21:34
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10779: [BEAM-3221]
Clarify documentation for StandardTransforms.Primitives, Pipeline, and
PTransform.
URL: https://github.com/apache/beam/pull/10779#discussion_r376094481
##
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##
@@ -78,31 +78,45 @@ message Components {
// A Pipeline is a hierarchical graph of PTransforms, linked
// by PCollections.
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 383171)
Time Spent: 2h 50m (was: 2h 40m)
> Model pipeline representation improvements
> --
>
> Key: BEAM-3221
> URL: https://issues.apache.org/jira/browse/BEAM-3221
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
>Reporter: Henning Rohde
>Priority: Major
> Labels: portability
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Collections of various (breaking) tweaks to the Runner API, notably the
> pipeline representation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[
https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=383170=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383170
]
ASF GitHub Bot logged work on BEAM-3221:
Author: ASF GitHub Bot
Created on: 06/Feb/20 21:33
Start Date: 06/Feb/20 21:33
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10779: [BEAM-3221]
Clarify documentation for StandardTransforms.Primitives, Pipeline, and
PTransform.
URL: https://github.com/apache/beam/pull/10779#discussion_r376094205
##
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##
@@ -78,31 +78,45 @@ message Components {
// A Pipeline is a hierarchical graph of PTransforms, linked
// by PCollections.
//
-// This is represented by a number of by-reference maps to nodes,
-// PCollections, SDK environments, UDF, etc., for
-// supporting compact reuse and arbitrary graph structure.
+// Impulse -> PCollection -> ParDo -> PCollection -> GroupByKey -> ...
+// \> PCollection -> ParDo -> ...
//
-// All of the keys in the maps here are arbitrary strings that are only
-// required to be internally consistent within this proto message.
+// This is represented by a number of by-reference maps to transforms,
+// PCollections, SDK environments, coders, etc., for
+// supporting compact reuse and arbitrary graph structure.
message Pipeline {
// (Required) The coders, UDFs, graph nodes, etc, that make up
// this pipeline.
Components components = 1;
- // (Required) The ids of all PTransforms that are not contained within
another PTransform.
- // These must be in shallow topological order, so that traversing them
recursively
- // in this order yields a recursively topological traversal.
+ // (Required) The ids of all PTransforms that are not contained within
another
+ // PTransform. These must be in shallow topological order, so that traversing
+ // them recursively in this order yields a recursively topological traversal.
repeated string root_transform_ids = 2;
// (Optional) Static display data for the pipeline. If there is none,
// it may be omitted.
DisplayData display_data = 3;
}
-// An applied PTransform! This does not contain the graph data, but only the
-// fields specific to a graph node that is a Runner API transform
-// between PCollections.
+// Transforms are the operations in your pipeline, and provide a generic
+// processing framework. You provide processing logic in the form of a function
+// object (colloquially referred to as “user code”), and your user code is
+// applied to each element of an input PCollection (or more than one
+// PCollection). Depending on the pipeline runner and back-end that you choose,
+// many different workers across a cluster may execute instances of your user
+// code in parallel. The user code running on each worker generates the output
+// elements that are ultimately added to the final output PCollection that the
+// transform produces.
+//
+//The Beam SDKs contain a number of different transforms that you can apply to
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 383170)
Time Spent: 2h 40m (was: 2.5h)
> Model pipeline representation improvements
> --
>
> Key: BEAM-3221
> URL: https://issues.apache.org/jira/browse/BEAM-3221
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
>Reporter: Henning Rohde
>Priority: Major
> Labels: portability
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Collections of various (breaking) tweaks to the Runner API, notably the
> pipeline representation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[
https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=383169=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383169
]
ASF GitHub Bot logged work on BEAM-3221:
Author: ASF GitHub Bot
Created on: 06/Feb/20 21:33
Start Date: 06/Feb/20 21:33
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10779: [BEAM-3221]
Clarify documentation for StandardTransforms.Primitives, Pipeline, and
PTransform.
URL: https://github.com/apache/beam/pull/10779#discussion_r376094181
##
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##
@@ -123,16 +137,9 @@ message PTransform {
//
// For primitive transform in the Runner API, this is required, and the
// payloads are well-defined messages. When the URN indicates ParDo it
- // is a ParDoPayload, and so on.
- //
- // TODO: document the standardized URNs and payloads
- // TODO: separate standardized payloads into a separate proto file
Review comment:
Yeah, I closed the related BEAM-4180 since the effort isn't worth it and the
`Payload` term does provide meaning that its meant to be embedded.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 383169)
Time Spent: 2.5h (was: 2h 20m)
> Model pipeline representation improvements
> --
>
> Key: BEAM-3221
> URL: https://issues.apache.org/jira/browse/BEAM-3221
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
>Reporter: Henning Rohde
>Priority: Major
> Labels: portability
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Collections of various (breaking) tweaks to the Runner API, notably the
> pipeline representation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[
https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=383167=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383167
]
ASF GitHub Bot logged work on BEAM-3221:
Author: ASF GitHub Bot
Created on: 06/Feb/20 21:32
Start Date: 06/Feb/20 21:32
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10779: [BEAM-3221]
Clarify documentation for StandardTransforms.Primitives, Pipeline, and
PTransform.
URL: https://github.com/apache/beam/pull/10779#discussion_r376093545
##
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##
@@ -78,31 +78,45 @@ message Components {
// A Pipeline is a hierarchical graph of PTransforms, linked
// by PCollections.
//
-// This is represented by a number of by-reference maps to nodes,
-// PCollections, SDK environments, UDF, etc., for
-// supporting compact reuse and arbitrary graph structure.
+// Impulse -> PCollection -> ParDo -> PCollection -> GroupByKey -> ...
+// \> PCollection -> ParDo -> ...
Review comment:
Its a multi output one.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 383167)
Time Spent: 2h 20m (was: 2h 10m)
> Model pipeline representation improvements
> --
>
> Key: BEAM-3221
> URL: https://issues.apache.org/jira/browse/BEAM-3221
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
>Reporter: Henning Rohde
>Priority: Major
> Labels: portability
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Collections of various (breaking) tweaks to the Runner API, notably the
> pipeline representation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[
https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=383094=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383094
]
ASF GitHub Bot logged work on BEAM-3221:
Author: ASF GitHub Bot
Created on: 06/Feb/20 19:30
Start Date: 06/Feb/20 19:30
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #10779:
[BEAM-3221] Clarify documentation for StandardTransforms.Primitives, Pipeline,
and PTransform.
URL: https://github.com/apache/beam/pull/10779#discussion_r376034358
##
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##
@@ -78,31 +78,45 @@ message Components {
// A Pipeline is a hierarchical graph of PTransforms, linked
// by PCollections.
//
-// This is represented by a number of by-reference maps to nodes,
-// PCollections, SDK environments, UDF, etc., for
-// supporting compact reuse and arbitrary graph structure.
+// Impulse -> PCollection -> ParDo -> PCollection -> GroupByKey -> ...
+// \> PCollection -> ParDo -> ...
//
-// All of the keys in the maps here are arbitrary strings that are only
-// required to be internally consistent within this proto message.
+// This is represented by a number of by-reference maps to transforms,
+// PCollections, SDK environments, coders, etc., for
+// supporting compact reuse and arbitrary graph structure.
message Pipeline {
// (Required) The coders, UDFs, graph nodes, etc, that make up
// this pipeline.
Components components = 1;
- // (Required) The ids of all PTransforms that are not contained within
another PTransform.
- // These must be in shallow topological order, so that traversing them
recursively
- // in this order yields a recursively topological traversal.
+ // (Required) The ids of all PTransforms that are not contained within
another
+ // PTransform. These must be in shallow topological order, so that traversing
+ // them recursively in this order yields a recursively topological traversal.
repeated string root_transform_ids = 2;
// (Optional) Static display data for the pipeline. If there is none,
// it may be omitted.
DisplayData display_data = 3;
}
-// An applied PTransform! This does not contain the graph data, but only the
-// fields specific to a graph node that is a Runner API transform
-// between PCollections.
+// Transforms are the operations in your pipeline, and provide a generic
+// processing framework. You provide processing logic in the form of a function
+// object (colloquially referred to as “user code”), and your user code is
+// applied to each element of an input PCollection (or more than one
+// PCollection). Depending on the pipeline runner and back-end that you choose,
+// many different workers across a cluster may execute instances of your user
+// code in parallel. The user code running on each worker generates the output
+// elements that are ultimately added to the final output PCollection that the
+// transform produces.
+//
+//The Beam SDKs contain a number of different transforms that you can apply to
Review comment:
nit: add a space here
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 383094)
Time Spent: 2h 10m (was: 2h)
> Model pipeline representation improvements
> --
>
> Key: BEAM-3221
> URL: https://issues.apache.org/jira/browse/BEAM-3221
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
>Reporter: Henning Rohde
>Priority: Major
> Labels: portability
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Collections of various (breaking) tweaks to the Runner API, notably the
> pipeline representation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[
https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=383092=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383092
]
ASF GitHub Bot logged work on BEAM-3221:
Author: ASF GitHub Bot
Created on: 06/Feb/20 19:30
Start Date: 06/Feb/20 19:30
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #10779:
[BEAM-3221] Clarify documentation for StandardTransforms.Primitives, Pipeline,
and PTransform.
URL: https://github.com/apache/beam/pull/10779#discussion_r376036293
##
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##
@@ -123,16 +137,9 @@ message PTransform {
//
// For primitive transform in the Runner API, this is required, and the
// payloads are well-defined messages. When the URN indicates ParDo it
- // is a ParDoPayload, and so on.
- //
- // TODO: document the standardized URNs and payloads
- // TODO: separate standardized payloads into a separate proto file
Review comment:
we didn't actually do this second TODO, ParDoPayload et al are still here. I
guess we don't want to move them anymore?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 383092)
Time Spent: 2h (was: 1h 50m)
> Model pipeline representation improvements
> --
>
> Key: BEAM-3221
> URL: https://issues.apache.org/jira/browse/BEAM-3221
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
>Reporter: Henning Rohde
>Priority: Major
> Labels: portability
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Collections of various (breaking) tweaks to the Runner API, notably the
> pipeline representation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[
https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=383093=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383093
]
ASF GitHub Bot logged work on BEAM-3221:
Author: ASF GitHub Bot
Created on: 06/Feb/20 19:30
Start Date: 06/Feb/20 19:30
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #10779:
[BEAM-3221] Clarify documentation for StandardTransforms.Primitives, Pipeline,
and PTransform.
URL: https://github.com/apache/beam/pull/10779#discussion_r376033988
##
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##
@@ -78,31 +78,45 @@ message Components {
// A Pipeline is a hierarchical graph of PTransforms, linked
// by PCollections.
//
-// This is represented by a number of by-reference maps to nodes,
-// PCollections, SDK environments, UDF, etc., for
-// supporting compact reuse and arbitrary graph structure.
+// Impulse -> PCollection -> ParDo -> PCollection -> GroupByKey -> ...
+// \> PCollection -> ParDo -> ...
Review comment:
Is this correct? I thought it would look like:
```
Impulse -> PCollection -> ParDo -> PCollection -> GroupByKey -> ...
\> ParDo -> ...
```
Or maybe the ParDo you're documenting is a multi-output one?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 383093)
Time Spent: 2h (was: 1h 50m)
> Model pipeline representation improvements
> --
>
> Key: BEAM-3221
> URL: https://issues.apache.org/jira/browse/BEAM-3221
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
>Reporter: Henning Rohde
>Priority: Major
> Labels: portability
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Collections of various (breaking) tweaks to the Runner API, notably the
> pipeline representation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[
https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=383086=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383086
]
ASF GitHub Bot logged work on BEAM-3221:
Author: ASF GitHub Bot
Created on: 06/Feb/20 19:21
Start Date: 06/Feb/20 19:21
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #10779:
[BEAM-3221] Clarify documentation for StandardTransforms.Primitives, Pipeline,
and PTransform.
URL: https://github.com/apache/beam/pull/10779#discussion_r376032683
##
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##
@@ -78,31 +78,45 @@ message Components {
// A Pipeline is a hierarchical graph of PTransforms, linked
// by PCollections.
Review comment:
maybe add something like "a typical graph may look like:"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 383086)
Time Spent: 1h 50m (was: 1h 40m)
> Model pipeline representation improvements
> --
>
> Key: BEAM-3221
> URL: https://issues.apache.org/jira/browse/BEAM-3221
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
>Reporter: Henning Rohde
>Priority: Major
> Labels: portability
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Collections of various (breaking) tweaks to the Runner API, notably the
> pipeline representation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=382656=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382656 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 06/Feb/20 01:13 Start Date: 06/Feb/20 01:13 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10779: [BEAM-3221] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779#issuecomment-582689320 R: @TheNeuralBit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 382656) Time Spent: 1h 40m (was: 1.5h) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 1h 40m > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=382601=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382601 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 05/Feb/20 23:35 Start Date: 05/Feb/20 23:35 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #10779: [BEAM-3221] Clarify documentation for StandardTransforms.Primitives, Pipeline, and PTransform. URL: https://github.com/apache/beam/pull/10779 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[![Build
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=381871=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381871 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 04/Feb/20 21:15 Start Date: 04/Feb/20 21:15 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #10754: [BEAM-3221] Expand/clarify timestamp comments within beam_runner_api.proto URL: https://github.com/apache/beam/pull/10754 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 381871) Time Spent: 1h 20m (was: 1h 10m) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 1h 20m > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=381834=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381834 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 04/Feb/20 19:43 Start Date: 04/Feb/20 19:43 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10754: [BEAM-3221] Expand/clarify timestamp comments within beam_runner_api.proto URL: https://github.com/apache/beam/pull/10754#issuecomment-582081882 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 381834) Time Spent: 1h 10m (was: 1h) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 1h 10m > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=381754=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381754 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 04/Feb/20 17:48 Start Date: 04/Feb/20 17:48 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10754: [BEAM-3221] Expand/clarify timestamp comments within beam_runner_api.proto URL: https://github.com/apache/beam/pull/10754#issuecomment-582032360 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 381754) Time Spent: 1h (was: 50m) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 1h > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=381259=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381259 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 03/Feb/20 23:56 Start Date: 03/Feb/20 23:56 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10754: [BEAM-3221] Expand/clarify timestamp comments within beam_runner_api.proto URL: https://github.com/apache/beam/pull/10754#issuecomment-581676818 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 381259) Time Spent: 50m (was: 40m) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 50m > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[
https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=381162=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381162
]
ASF GitHub Bot logged work on BEAM-3221:
Author: ASF GitHub Bot
Created on: 03/Feb/20 19:34
Start Date: 03/Feb/20 19:34
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10754: [BEAM-3221]
Expand/clarify timestamp comments within beam_runner_api.proto
URL: https://github.com/apache/beam/pull/10754#discussion_r374297835
##
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##
@@ -37,15 +37,21 @@ import "google/protobuf/timestamp.proto";
message BeamConstants {
enum Constants {
// All timestamps in milliseconds since Jan 1, 1970.
+
+// All timestamps of elements or window boundaries must be within
+// the interval [MIN_TIMESTAMP_MILLIS, MAX_TIMESTAMP_MILLIS].
+// The smallest representable timestamp of an element or a window boundary.
MIN_TIMESTAMP_MILLIS = 0 [(beam_constant) = "-9223372036854775"];
+// The largest representable timestamp of an element or a window boundary.
MAX_TIMESTAMP_MILLIS = 1 [(beam_constant) = "9223372036854775"];
+
// The maximum timestamp for the global window.
-// Triggers use maxTimestamp to set timers' timestamp. Timers fires when
+// Triggers use max timestamp to set timers' timestamp. Timers fire when
// the watermark passes their timestamps. So, the timestamp needs to be
// smaller than the MAX_TIMESTAMP_MILLIS.
// One standard day is subtracted from MAX_TIMESTAMP_MILLIS to make sure
-// the maxTimestamp is smaller than MAX_TIMESTAMP_MILLIS even after
rounding up
-// to seconds or minutes. See also GlobalWindow in the Java SDK.
+// the max timestamp is smaller than MAX_TIMESTAMP_MILLIS even after
rounding up
+// to seconds or minutes.
GLOBAL_WINDOW_MAX_TIMESTAMP_MILLIS = 2 [(beam_constant) =
"9223371950454775"];
Review comment:
We would need to define an EnumValueOption for each type we would like to
support.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 381162)
Time Spent: 40m (was: 0.5h)
> Model pipeline representation improvements
> --
>
> Key: BEAM-3221
> URL: https://issues.apache.org/jira/browse/BEAM-3221
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
>Reporter: Henning Rohde
>Priority: Major
> Labels: portability
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Collections of various (breaking) tweaks to the Runner API, notably the
> pipeline representation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[
https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=381158=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381158
]
ASF GitHub Bot logged work on BEAM-3221:
Author: ASF GitHub Bot
Created on: 03/Feb/20 19:24
Start Date: 03/Feb/20 19:24
Worklog Time Spent: 10m
Work Description: Ardagan commented on pull request #10754: [BEAM-3221]
Expand/clarify timestamp comments within beam_runner_api.proto
URL: https://github.com/apache/beam/pull/10754#discussion_r374292918
##
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##
@@ -37,15 +37,21 @@ import "google/protobuf/timestamp.proto";
message BeamConstants {
enum Constants {
// All timestamps in milliseconds since Jan 1, 1970.
+
+// All timestamps of elements or window boundaries must be within
+// the interval [MIN_TIMESTAMP_MILLIS, MAX_TIMESTAMP_MILLIS].
+// The smallest representable timestamp of an element or a window boundary.
MIN_TIMESTAMP_MILLIS = 0 [(beam_constant) = "-9223372036854775"];
+// The largest representable timestamp of an element or a window boundary.
MAX_TIMESTAMP_MILLIS = 1 [(beam_constant) = "9223372036854775"];
+
// The maximum timestamp for the global window.
-// Triggers use maxTimestamp to set timers' timestamp. Timers fires when
+// Triggers use max timestamp to set timers' timestamp. Timers fire when
// the watermark passes their timestamps. So, the timestamp needs to be
// smaller than the MAX_TIMESTAMP_MILLIS.
// One standard day is subtracted from MAX_TIMESTAMP_MILLIS to make sure
-// the maxTimestamp is smaller than MAX_TIMESTAMP_MILLIS even after
rounding up
-// to seconds or minutes. See also GlobalWindow in the Java SDK.
+// the max timestamp is smaller than MAX_TIMESTAMP_MILLIS even after
rounding up
+// to seconds or minutes.
GLOBAL_WINDOW_MAX_TIMESTAMP_MILLIS = 2 [(beam_constant) =
"9223371950454775"];
Review comment:
I'm curious, what's the reason to define all constants as strings?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 381158)
Time Spent: 0.5h (was: 20m)
> Model pipeline representation improvements
> --
>
> Key: BEAM-3221
> URL: https://issues.apache.org/jira/browse/BEAM-3221
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
>Reporter: Henning Rohde
>Priority: Major
> Labels: portability
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Collections of various (breaking) tweaks to the Runner API, notably the
> pipeline representation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=381142=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381142 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 03/Feb/20 18:56 Start Date: 03/Feb/20 18:56 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10754: [BEAM-3221] Expand/clarify timestamp comments within beam_runner_api.proto URL: https://github.com/apache/beam/pull/10754#issuecomment-581562717 R: @Ardagan @pabloem This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 381142) Time Spent: 20m (was: 10m) > Model pipeline representation improvements > -- > > Key: BEAM-3221 > URL: https://issues.apache.org/jira/browse/BEAM-3221 > Project: Beam > Issue Type: Improvement > Components: beam-model >Reporter: Henning Rohde >Priority: Major > Labels: portability > Time Spent: 20m > Remaining Estimate: 0h > > Collections of various (breaking) tweaks to the Runner API, notably the > pipeline representation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3221) Model pipeline representation improvements
[ https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=381141=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381141 ] ASF GitHub Bot logged work on BEAM-3221: Author: ASF GitHub Bot Created on: 03/Feb/20 18:56 Start Date: 03/Feb/20 18:56 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #10754: [BEAM-3221] Expand/clarify timestamp comments within beam_runner_api.proto URL: https://github.com/apache/beam/pull/10754 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[