[jira] [Work logged] (BEAM-5980) Add load tests for Core Apache Beam opertaions
[ https://issues.apache.org/jira/browse/BEAM-5980?focusedWorklogId=295104=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295104 ] ASF GitHub Bot logged work on BEAM-5980: Author: ASF GitHub Bot Created on: 15/Aug/19 00:43 Start Date: 15/Aug/19 00:43 Worklog Time Spent: 10m Work Description: pabloem commented on issue #9286: [BEAM-5980] Remove redundant combine tests URL: https://github.com/apache/beam/pull/9286#issuecomment-521471230 LGTM. Feel free to self-merge if necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 295104) Time Spent: 1h 50m (was: 1h 40m) > Add load tests for Core Apache Beam opertaions > --- > > Key: BEAM-5980 > URL: https://issues.apache.org/jira/browse/BEAM-5980 > Project: Beam > Issue Type: New Feature > Components: testing >Reporter: Lukasz Gajowy >Assignee: Lukasz Gajowy >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > This involves adding a suite of load tests described in this proposal: > [https://s.apache.org/load-test-basic-operations] -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5980) Add load tests for Core Apache Beam opertaions
[ https://issues.apache.org/jira/browse/BEAM-5980?focusedWorklogId=291214=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-291214 ] ASF GitHub Bot logged work on BEAM-5980: Author: ASF GitHub Bot Created on: 08/Aug/19 12:08 Start Date: 08/Aug/19 12:08 Worklog Time Spent: 10m Work Description: lgajowy commented on issue #9286: [BEAM-5980] Remove redundant combine tests URL: https://github.com/apache/beam/pull/9286#issuecomment-519490976 Let's wait unitl monday with this PR. There's ongoing discussion in the proposal whether all of them should be deleted or not This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 291214) Time Spent: 1h 40m (was: 1.5h) > Add load tests for Core Apache Beam opertaions > --- > > Key: BEAM-5980 > URL: https://issues.apache.org/jira/browse/BEAM-5980 > Project: Beam > Issue Type: New Feature > Components: testing >Reporter: Lukasz Gajowy >Assignee: Lukasz Gajowy >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > This involves adding a suite of load tests described in this proposal: > [https://s.apache.org/load-test-basic-operations] -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5980) Add load tests for Core Apache Beam opertaions
[ https://issues.apache.org/jira/browse/BEAM-5980?focusedWorklogId=290482=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290482 ] ASF GitHub Bot logged work on BEAM-5980: Author: ASF GitHub Bot Created on: 07/Aug/19 14:02 Start Date: 07/Aug/19 14:02 Worklog Time Spent: 10m Work Description: lgajowy commented on issue #9286: [BEAM-5980] Remove redundant combine tests URL: https://github.com/apache/beam/pull/9286#issuecomment-519111574 Run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 290482) Time Spent: 1.5h (was: 1h 20m) > Add load tests for Core Apache Beam opertaions > --- > > Key: BEAM-5980 > URL: https://issues.apache.org/jira/browse/BEAM-5980 > Project: Beam > Issue Type: New Feature > Components: testing >Reporter: Lukasz Gajowy >Assignee: Lukasz Gajowy >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > This involves adding a suite of load tests described in this proposal: > [https://s.apache.org/load-test-basic-operations] -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5980) Add load tests for Core Apache Beam opertaions
[
https://issues.apache.org/jira/browse/BEAM-5980?focusedWorklogId=290475=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290475
]
ASF GitHub Bot logged work on BEAM-5980:
Author: ASF GitHub Bot
Created on: 07/Aug/19 13:54
Start Date: 07/Aug/19 13:54
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #9286: [BEAM-5980]
Remove redundant combine tests
URL: https://github.com/apache/beam/pull/9286#discussion_r311565958
##
File path: .test-infra/jenkins/job_LoadTests_Combine_Flink_Python.groovy
##
@@ -149,22 +83,15 @@ def batchLoadTestJob = { scope, triggeringContext ->
scope.description('Runs Python Combine load tests on Flink runner in batch
mode')
commonJobProperties.setTopLevelMainJobProperties(scope, 'master', 240)
-def numberOfWorkers = 16
-def scaledNumberOfWorkers = 5
def datasetName = loadTestsBuilder.getBigQueryDataset('load_test',
triggeringContext)
infra.prepareSDKHarness(scope, CommonTestProperties.SDK.PYTHON,
dockerRegistryRoot, dockerTag)
infra.prepareFlinkJobServer(scope, flinkVersion, dockerRegistryRoot,
dockerTag)
-infra.setupFlinkCluster(scope, jenkinsJobName, flinkDownloadUrl,
pythonHarnessImageTag, jobServerImageTag, numberOfWorkers)
-def testConfigs = loadTestConfigurationsSixteenWorkers(datasetName)
-for (config in testConfigs) {
-loadTestsBuilder.loadTest(scope, config.title, config.runner,
CommonTestProperties.SDK.PYTHON, config.jobProperties, config.itClass)
-}
-
-infra.scaleCluster(scope, jenkinsJobName, scaledNumberOfWorkers)
+def numberOfWorkers = 16
Review comment:
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 290475)
Time Spent: 1h 20m (was: 1h 10m)
> Add load tests for Core Apache Beam opertaions
> ---
>
> Key: BEAM-5980
> URL: https://issues.apache.org/jira/browse/BEAM-5980
> Project: Beam
> Issue Type: New Feature
> Components: testing
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> This involves adding a suite of load tests described in this proposal:
> [https://s.apache.org/load-test-basic-operations]
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (BEAM-5980) Add load tests for Core Apache Beam opertaions
[
https://issues.apache.org/jira/browse/BEAM-5980?focusedWorklogId=290460=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290460
]
ASF GitHub Bot logged work on BEAM-5980:
Author: ASF GitHub Bot
Created on: 07/Aug/19 13:24
Start Date: 07/Aug/19 13:24
Worklog Time Spent: 10m
Work Description: kkucharc commented on pull request #9286: [BEAM-5980]
Remove redundant combine tests
URL: https://github.com/apache/beam/pull/9286#discussion_r311549710
##
File path: .test-infra/jenkins/job_LoadTests_Combine_Flink_Python.groovy
##
@@ -149,22 +83,15 @@ def batchLoadTestJob = { scope, triggeringContext ->
scope.description('Runs Python Combine load tests on Flink runner in batch
mode')
commonJobProperties.setTopLevelMainJobProperties(scope, 'master', 240)
-def numberOfWorkers = 16
-def scaledNumberOfWorkers = 5
def datasetName = loadTestsBuilder.getBigQueryDataset('load_test',
triggeringContext)
infra.prepareSDKHarness(scope, CommonTestProperties.SDK.PYTHON,
dockerRegistryRoot, dockerTag)
infra.prepareFlinkJobServer(scope, flinkVersion, dockerRegistryRoot,
dockerTag)
-infra.setupFlinkCluster(scope, jenkinsJobName, flinkDownloadUrl,
pythonHarnessImageTag, jobServerImageTag, numberOfWorkers)
-def testConfigs = loadTestConfigurationsSixteenWorkers(datasetName)
-for (config in testConfigs) {
-loadTestsBuilder.loadTest(scope, config.title, config.runner,
CommonTestProperties.SDK.PYTHON, config.jobProperties, config.itClass)
-}
-
-infra.scaleCluster(scope, jenkinsJobName, scaledNumberOfWorkers)
+def numberOfWorkers = 16
Review comment:
What do you think about making it global again and put in parallelism param
in each test configuration?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 290460)
Time Spent: 1h 10m (was: 1h)
> Add load tests for Core Apache Beam opertaions
> ---
>
> Key: BEAM-5980
> URL: https://issues.apache.org/jira/browse/BEAM-5980
> Project: Beam
> Issue Type: New Feature
> Components: testing
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This involves adding a suite of load tests described in this proposal:
> [https://s.apache.org/load-test-basic-operations]
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (BEAM-5980) Add load tests for Core Apache Beam opertaions
[ https://issues.apache.org/jira/browse/BEAM-5980?focusedWorklogId=290442=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290442 ] ASF GitHub Bot logged work on BEAM-5980: Author: ASF GitHub Bot Created on: 07/Aug/19 12:47 Start Date: 07/Aug/19 12:47 Worklog Time Spent: 10m Work Description: lgajowy commented on issue #9286: [BEAM-5980] Remove redundant combine tests URL: https://github.com/apache/beam/pull/9286#issuecomment-519081033 It seems that I didn't mess up the jobs. Could you take a look again @kkucharc ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 290442) Time Spent: 1h (was: 50m) > Add load tests for Core Apache Beam opertaions > --- > > Key: BEAM-5980 > URL: https://issues.apache.org/jira/browse/BEAM-5980 > Project: Beam > Issue Type: New Feature > Components: testing >Reporter: Lukasz Gajowy >Assignee: Lukasz Gajowy >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > This involves adding a suite of load tests described in this proposal: > [https://s.apache.org/load-test-basic-operations] -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5980) Add load tests for Core Apache Beam opertaions
[ https://issues.apache.org/jira/browse/BEAM-5980?focusedWorklogId=290432=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290432 ] ASF GitHub Bot logged work on BEAM-5980: Author: ASF GitHub Bot Created on: 07/Aug/19 12:10 Start Date: 07/Aug/19 12:10 Worklog Time Spent: 10m Work Description: lgajowy commented on issue #9286: [BEAM-5980] Remove redundant combine tests URL: https://github.com/apache/beam/pull/9286#issuecomment-519068705 Run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 290432) Time Spent: 50m (was: 40m) > Add load tests for Core Apache Beam opertaions > --- > > Key: BEAM-5980 > URL: https://issues.apache.org/jira/browse/BEAM-5980 > Project: Beam > Issue Type: New Feature > Components: testing >Reporter: Lukasz Gajowy >Assignee: Lukasz Gajowy >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > This involves adding a suite of load tests described in this proposal: > [https://s.apache.org/load-test-basic-operations] -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5980) Add load tests for Core Apache Beam opertaions
[ https://issues.apache.org/jira/browse/BEAM-5980?focusedWorklogId=290429=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290429 ] ASF GitHub Bot logged work on BEAM-5980: Author: ASF GitHub Bot Created on: 07/Aug/19 12:04 Start Date: 07/Aug/19 12:04 Worklog Time Spent: 10m Work Description: lgajowy commented on issue #9286: [BEAM-5980] Remove redundant combine tests URL: https://github.com/apache/beam/pull/9286#issuecomment-519066797 You are right - I will remove there too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 290429) Time Spent: 40m (was: 0.5h) > Add load tests for Core Apache Beam opertaions > --- > > Key: BEAM-5980 > URL: https://issues.apache.org/jira/browse/BEAM-5980 > Project: Beam > Issue Type: New Feature > Components: testing >Reporter: Lukasz Gajowy >Assignee: Lukasz Gajowy >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > This involves adding a suite of load tests described in this proposal: > [https://s.apache.org/load-test-basic-operations] -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5980) Add load tests for Core Apache Beam opertaions
[ https://issues.apache.org/jira/browse/BEAM-5980?focusedWorklogId=290376=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290376 ] ASF GitHub Bot logged work on BEAM-5980: Author: ASF GitHub Bot Created on: 07/Aug/19 11:00 Start Date: 07/Aug/19 11:00 Worklog Time Spent: 10m Work Description: lgajowy commented on issue #9286: [BEAM-5980] Remove redundant combine tests URL: https://github.com/apache/beam/pull/9286#issuecomment-519048539 @pabloem @kkucharc could you take a look? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 290376) Time Spent: 0.5h (was: 20m) > Add load tests for Core Apache Beam opertaions > --- > > Key: BEAM-5980 > URL: https://issues.apache.org/jira/browse/BEAM-5980 > Project: Beam > Issue Type: New Feature > Components: testing >Reporter: Lukasz Gajowy >Assignee: Lukasz Gajowy >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > This involves adding a suite of load tests described in this proposal: > [https://s.apache.org/load-test-basic-operations] -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5980) Add load tests for Core Apache Beam opertaions
[ https://issues.apache.org/jira/browse/BEAM-5980?focusedWorklogId=290365=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290365 ] ASF GitHub Bot logged work on BEAM-5980: Author: ASF GitHub Bot Created on: 07/Aug/19 10:49 Start Date: 07/Aug/19 10:49 Worklog Time Spent: 10m Work Description: lgajowy commented on issue #9286: [BEAM-5980] Remove redundant combine tests URL: https://github.com/apache/beam/pull/9286#issuecomment-519045299 Run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 290365) Time Spent: 20m (was: 10m) > Add load tests for Core Apache Beam opertaions > --- > > Key: BEAM-5980 > URL: https://issues.apache.org/jira/browse/BEAM-5980 > Project: Beam > Issue Type: New Feature > Components: testing >Reporter: Lukasz Gajowy >Assignee: Lukasz Gajowy >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > This involves adding a suite of load tests described in this proposal: > [https://s.apache.org/load-test-basic-operations] -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-5980) Add load tests for Core Apache Beam opertaions
[ https://issues.apache.org/jira/browse/BEAM-5980?focusedWorklogId=290364=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290364 ] ASF GitHub Bot logged work on BEAM-5980: Author: ASF GitHub Bot Created on: 07/Aug/19 10:49 Start Date: 07/Aug/19 10:49 Worklog Time Spent: 10m Work Description: lgajowy commented on pull request #9286: [BEAM-5980] Remove redundant combine tests URL: https://github.com/apache/beam/pull/9286 Size of input records is irrelevant for the combine operation because the byte[] value gets mapped to a Long before the Combine actually happens. This makes the tests redundant as size is the only thing that changes in the synthetic source options given to the input. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)[