[jira] [Work logged] (BEAM-8006) add retracting to windowing strategy translation
[ https://issues.apache.org/jira/browse/BEAM-8006?focusedWorklogId=298269=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298269 ] ASF GitHub Bot logged work on BEAM-8006: Author: ASF GitHub Bot Created on: 20/Aug/19 22:29 Start Date: 20/Aug/19 22:29 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #9375: [BEAM-8006] Add retracting to windowing strategy translation. URL: https://github.com/apache/beam/pull/9375 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 298269) Time Spent: 1h 20m (was: 1h 10m) > add retracting to windowing strategy translation > > > Key: BEAM-8006 > URL: https://issues.apache.org/jira/browse/BEAM-8006 > Project: Beam > Issue Type: Sub-task > Components: runner-core >Reporter: Rui Wang >Assignee: Rui Wang >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8006) add retracting to windowing strategy translation
[
https://issues.apache.org/jira/browse/BEAM-8006?focusedWorklogId=298259=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298259
]
ASF GitHub Bot logged work on BEAM-8006:
Author: ASF GitHub Bot
Created on: 20/Aug/19 22:21
Start Date: 20/Aug/19 22:21
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #9375: [BEAM-8006]
Add retracting to windowing strategy translation.
URL: https://github.com/apache/beam/pull/9375#discussion_r315928660
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/values/WindowingStrategy.java
##
@@ -47,7 +47,8 @@
/** The accumulation modes that can be used with windowing. */
public enum AccumulationMode {
DISCARDING_FIRED_PANES,
-ACCUMULATING_FIRED_PANES
+ACCUMULATING_FIRED_PANES,
+RETRACTING_FIRED_PANES,
Review comment:
It's actually a really nice catch that reminds me all future user facing
change regarding to retractions should be marked as experimental plus necessary
javadoc/comment warning.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 298259)
Time Spent: 1h 10m (was: 1h)
> add retracting to windowing strategy translation
>
>
> Key: BEAM-8006
> URL: https://issues.apache.org/jira/browse/BEAM-8006
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core
>Reporter: Rui Wang
>Assignee: Rui Wang
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8006) add retracting to windowing strategy translation
[
https://issues.apache.org/jira/browse/BEAM-8006?focusedWorklogId=298134=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298134
]
ASF GitHub Bot logged work on BEAM-8006:
Author: ASF GitHub Bot
Created on: 20/Aug/19 20:05
Start Date: 20/Aug/19 20:05
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #9375: [BEAM-8006]
Add retracting to windowing strategy translation.
URL: https://github.com/apache/beam/pull/9375#discussion_r315878718
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/values/WindowingStrategy.java
##
@@ -47,7 +47,8 @@
/** The accumulation modes that can be used with windowing. */
public enum AccumulationMode {
DISCARDING_FIRED_PANES,
-ACCUMULATING_FIRED_PANES
+ACCUMULATING_FIRED_PANES,
+RETRACTING_FIRED_PANES,
Review comment:
Thanks @lukecwik. I am not sure if I followed the best practice, but I add
`@Experimental` annotation, add a comment and also add to javadoc about
experimental information.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 298134)
Time Spent: 1h (was: 50m)
> add retracting to windowing strategy translation
>
>
> Key: BEAM-8006
> URL: https://issues.apache.org/jira/browse/BEAM-8006
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core
>Reporter: Rui Wang
>Assignee: Rui Wang
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8006) add retracting to windowing strategy translation
[
https://issues.apache.org/jira/browse/BEAM-8006?focusedWorklogId=298108=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298108
]
ASF GitHub Bot logged work on BEAM-8006:
Author: ASF GitHub Bot
Created on: 20/Aug/19 18:51
Start Date: 20/Aug/19 18:51
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9375: [BEAM-8006]
Add retracting to windowing strategy translation.
URL: https://github.com/apache/beam/pull/9375#discussion_r315848932
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/values/WindowingStrategy.java
##
@@ -47,7 +47,8 @@
/** The accumulation modes that can be used with windowing. */
public enum AccumulationMode {
DISCARDING_FIRED_PANES,
-ACCUMULATING_FIRED_PANES
+ACCUMULATING_FIRED_PANES,
+RETRACTING_FIRED_PANES,
Review comment:
Since this is part of the public API surface, it would be best if we
explicitly said that this was experimental here as a comment and also within
the javadoc.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 298108)
Time Spent: 50m (was: 40m)
> add retracting to windowing strategy translation
>
>
> Key: BEAM-8006
> URL: https://issues.apache.org/jira/browse/BEAM-8006
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core
>Reporter: Rui Wang
>Assignee: Rui Wang
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8006) add retracting to windowing strategy translation
[
https://issues.apache.org/jira/browse/BEAM-8006?focusedWorklogId=298106=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298106
]
ASF GitHub Bot logged work on BEAM-8006:
Author: ASF GitHub Bot
Created on: 20/Aug/19 18:50
Start Date: 20/Aug/19 18:50
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9375: [BEAM-8006]
Add retracting to windowing strategy translation.
URL: https://github.com/apache/beam/pull/9375#discussion_r315848932
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/values/WindowingStrategy.java
##
@@ -47,7 +47,8 @@
/** The accumulation modes that can be used with windowing. */
public enum AccumulationMode {
DISCARDING_FIRED_PANES,
-ACCUMULATING_FIRED_PANES
+ACCUMULATING_FIRED_PANES,
+RETRACTING_FIRED_PANES,
Review comment:
Since this is part of the public API surface, it would be best if we
explicitly said that this was experimental.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 298106)
Time Spent: 40m (was: 0.5h)
> add retracting to windowing strategy translation
>
>
> Key: BEAM-8006
> URL: https://issues.apache.org/jira/browse/BEAM-8006
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core
>Reporter: Rui Wang
>Assignee: Rui Wang
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-8006) add retracting to windowing strategy translation
[ https://issues.apache.org/jira/browse/BEAM-8006?focusedWorklogId=297384=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297384 ] ASF GitHub Bot logged work on BEAM-8006: Author: ASF GitHub Bot Created on: 19/Aug/19 20:07 Start Date: 19/Aug/19 20:07 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9375: [BEAM-8006] Add retracting to windowing strategy translation. URL: https://github.com/apache/beam/pull/9375#issuecomment-522733538 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297384) Time Spent: 0.5h (was: 20m) > add retracting to windowing strategy translation > > > Key: BEAM-8006 > URL: https://issues.apache.org/jira/browse/BEAM-8006 > Project: Beam > Issue Type: Sub-task > Components: runner-core >Reporter: Rui Wang >Assignee: Rui Wang >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8006) add retracting to windowing strategy translation
[ https://issues.apache.org/jira/browse/BEAM-8006?focusedWorklogId=297364=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297364 ] ASF GitHub Bot logged work on BEAM-8006: Author: ASF GitHub Bot Created on: 19/Aug/19 19:15 Start Date: 19/Aug/19 19:15 Worklog Time Spent: 10m Work Description: amaliujia commented on pull request #9375: [BEAM-8006] Add retracting to windowing strategy translation. URL: https://github.com/apache/beam/pull/9375 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- |
