[GitHub] [bookkeeper] leizhiyuan commented on pull request #3212: Added flag to control whether to transition to read-only mode when any disks full

leizhiyuan commented on PR #3212: URL: https://github.com/apache/bookkeeper/pull/3212#issuecomment-1193042969 thanks for your work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] horizonzy commented on a diff in pull request #3359: Feature: auto recover support repaired not adhering placement ledger

horizonzy commented on code in PR #3359: URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r928059554 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragment.java: ## @@ -217,11 +218,27 @@ public List getEnsemble() { return

[GitHub] [bookkeeper] rdhabalia commented on a diff in pull request #3359: Feature: auto recover support repaired not adhering placement ledger

rdhabalia commented on code in PR #3359: URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r928059417 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragment.java: ## @@ -217,11 +218,27 @@ public List getEnsemble() { return

[GitHub] [bookkeeper] rdhabalia commented on a diff in pull request #3359: Feature: auto recover support repaired not adhering placement ledger

rdhabalia commented on code in PR #3359: URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r928057386 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragment.java: ## @@ -217,11 +218,27 @@ public List getEnsemble() { return

[GitHub] [bookkeeper] horizonzy commented on pull request #3325: Avoid init WriteSet when waitForWriteSetMs < 0.

horizonzy commented on PR #3325: URL: https://github.com/apache/bookkeeper/pull/3325#issuecomment-1193027003 > ping @horizonzy, would you please rebase the master? done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [bookkeeper] rdhabalia commented on a diff in pull request #3359: Feature: auto recover support repaired not adhering placement ledger

rdhabalia commented on code in PR #3359: URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r928058192 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java: ## @@ -1128,14 +1129,24 @@ private ArrayList replaceBookiesInEnsemble(

[GitHub] [bookkeeper] rdhabalia commented on pull request #3359: Feature: auto recover support repaired not adhering placement ledger

rdhabalia commented on PR #3359: URL: https://github.com/apache/bookkeeper/pull/3359#issuecomment-1193025957 it's also better if you can add in description, what modification we are making in the PR. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [bookkeeper] rdhabalia commented on pull request #3359: Feature: auto recover support repaired not adhering placement ledger

rdhabalia commented on PR #3359: URL: https://github.com/apache/bookkeeper/pull/3359#issuecomment-1193025519 also, can we cherry-pick this change to previous release 4.14? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [bookkeeper] rdhabalia commented on a diff in pull request #3359: Feature: auto recover support repaired not adhering placement ledger

rdhabalia commented on code in PR #3359: URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r928057386 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragment.java: ## @@ -217,11 +218,27 @@ public List getEnsemble() { return

[GitHub] [bookkeeper] lordcheng10 commented on pull request #2983: fix bug : update lastLogMark after journal file forceWrite

lordcheng10 commented on PR #2983: URL: https://github.com/apache/bookkeeper/pull/2983#issuecomment-1193020611 @dlg99 PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] lordcheng10 commented on pull request #2983: fix bug : update lastLogMark after journal file forceWrite

lordcheng10 commented on PR #2983: URL: https://github.com/apache/bookkeeper/pull/2983#issuecomment-1193020309 ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [bookkeeper] hangc0276 commented on pull request #3325: Avoid init WriteSet when waitForWriteSetMs < 0.

hangc0276 commented on PR #3325: URL: https://github.com/apache/bookkeeper/pull/3325#issuecomment-1193012087 ping @horizonzy, would you please rebase the master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [bookkeeper] hangc0276 merged pull request #3390: [Issue 3389] Prioritize compaction of entry logs with the lowest amount of remaining usable data

hangc0276 merged PR #3390: URL: https://github.com/apache/bookkeeper/pull/3390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] dlg99 commented on pull request #3390: [Issue 3389] Prioritize compaction of entry logs with the lowest amount of remaining usable data

dlg99 commented on PR #3390: URL: https://github.com/apache/bookkeeper/pull/3390#issuecomment-1192987591 @hangc0276 Michael is on vacation and AFAIK he is ok with the change, unless there are other concerns this PR is good to merge. -- This is an automated message from the Apache Git

[GitHub] [bookkeeper] merlimat commented on pull request #3383: Consolidate Netty channel flushes to mitigate syscall overhead

merlimat commented on PR #3383: URL: https://github.com/apache/bookkeeper/pull/3383#issuecomment-1192778255 @eolivelli @dlg99 PTAL again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] merlimat commented on pull request #3383: Consolidate Netty channel flushes to mitigate syscall overhead

merlimat commented on PR #3383: URL: https://github.com/apache/bookkeeper/pull/3383#issuecomment-1192777442 @eolivelli @dlg99 @StevenLuMT We have done a lot of perf tests with this flush-merger enabled in BK and Pulsar. 1. At low request rates (eg: when there is batching

[GitHub] [bookkeeper] merlimat merged pull request #3330: Tuing PendingReadOp.java seq

merlimat merged PR #3330: URL: https://github.com/apache/bookkeeper/pull/3330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] merlimat merged pull request #3212: Added flag to control whether to transition to read-only mode when any disks full

merlimat merged PR #3212: URL: https://github.com/apache/bookkeeper/pull/3212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] merlimat closed issue #3141: auto read only mode support multi disks

merlimat closed issue #3141: auto read only mode support multi disks URL: https://github.com/apache/bookkeeper/issues/3141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [bookkeeper] merlimat merged pull request #3384: Switch back ordered executor to LinkedBlockingQueue

merlimat merged PR #3384: URL: https://github.com/apache/bookkeeper/pull/3384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] wenbingshen commented on pull request #3417: Optimize concurrent collection's shrink logic

wenbingshen commented on PR #3417: URL: https://github.com/apache/bookkeeper/pull/3417#issuecomment-1192475908 ping @Shoothzj PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] wenbingshen commented on pull request #3417: Optimize concurrent collection's shrink logic

wenbingshen commented on PR #3417: URL: https://github.com/apache/bookkeeper/pull/3417#issuecomment-1192475716 ping @dlg99 PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] wenbingshen commented on pull request #3417: Optimize concurrent collection's shrink logic

wenbingshen commented on PR #3417: URL: https://github.com/apache/bookkeeper/pull/3417#issuecomment-1192475546 ping @eolivelli PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] ArvinDevel commented on a diff in pull request #3194: BP-50: Add reuse journal file feature to support Intel PMem disk

ArvinDevel commented on code in PR #3194: URL: https://github.com/apache/bookkeeper/pull/3194#discussion_r927472583 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java: ## @@ -177,7 +190,21 @@ private JournalChannel(File journalDirectory, long

[GitHub] [bookkeeper] wenbingshen commented on pull request #3285: validate diskUsageThreshold and diskUsageLwmThreshold

wenbingshen commented on PR #3285: URL: https://github.com/apache/bookkeeper/pull/3285#issuecomment-1192373957 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] StevenLuMT commented on pull request #3382: Include BK error code in default case for BKException#getMessage

StevenLuMT commented on PR #3382: URL: https://github.com/apache/bookkeeper/pull/3382#issuecomment-1192327776 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] wenbingshen commented on pull request #3285: validate diskUsageThreshold and diskUsageLwmThreshold

wenbingshen commented on PR #3285: URL: https://github.com/apache/bookkeeper/pull/3285#issuecomment-1192316572 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] StevenLuMT commented on pull request #3382: Include BK error code in default case for BKException#getMessage

StevenLuMT commented on PR #3382: URL: https://github.com/apache/bookkeeper/pull/3382#issuecomment-1192291736 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] wenbingshen commented on pull request #3417: Optimize concurrent collection's shrink logic

wenbingshen commented on PR #3417: URL: https://github.com/apache/bookkeeper/pull/3417#issuecomment-1192269812 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] wenbingshen commented on pull request #3285: validate diskUsageThreshold and diskUsageLwmThreshold

wenbingshen commented on PR #3285: URL: https://github.com/apache/bookkeeper/pull/3285#issuecomment-1192263025 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific