[GitHub] [bookkeeper] lordcheng10 commented on pull request #3072: reduce unnecessary expansions for ConcurrentLong map and set

lordcheng10 commented on pull request #3072: URL: https://github.com/apache/bookkeeper/pull/3072#issuecomment-1064743953 > Merged to master branch. Feel free to add the tests if you want as follow up work. Not strictly needed Done: https://github.com/apache/bookkeeper/pull/3092

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3072: reduce unnecessary expansions for ConcurrentLong map and set

lordcheng10 commented on pull request #3072: URL: https://github.com/apache/bookkeeper/pull/3072#issuecomment-1064718307 > Merged to master branch. Feel free to add the tests if you want as follow up work. Not strictly needed OK, I will add unit tests -- This is an automated

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3072: reduce unnecessary expansions for ConcurrentLong map and set

lordcheng10 commented on pull request #3072: URL: https://github.com/apache/bookkeeper/pull/3072#issuecomment-1053548491 > > > Do we have tests about DeletedValue and the raw contents of the structures? > > > Is it worth to add some little test? > > > We can use PowerMock/Whitebox or

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3072: reduce unnecessary expansions for ConcurrentLong map and set

lordcheng10 commented on pull request #3072: URL: https://github.com/apache/bookkeeper/pull/3072#issuecomment-1051833829 > Do we have tests about DeletedValue and the raw contents of the structures? Is it worth to add some little test? We can use PowerMock/Whitebox or pure java

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3072: reduce unnecessary expansions for ConcurrentLong map and set

lordcheng10 commented on pull request #3072: URL: https://github.com/apache/bookkeeper/pull/3072#issuecomment-1048090266 @eolivelli @merlimat PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3072: reduce unnecessary expansions for ConcurrentLong map and set

lordcheng10 commented on pull request #3072: URL: https://github.com/apache/bookkeeper/pull/3072#issuecomment-1047949861 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3072: reduce unnecessary expansions for ConcurrentLong map and set

lordcheng10 commented on pull request #3072: URL: https://github.com/apache/bookkeeper/pull/3072#issuecomment-1047760282 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3072: reduce unnecessary expansions for ConcurrentLong map and set

lordcheng10 commented on pull request #3072: URL: https://github.com/apache/bookkeeper/pull/3072#issuecomment-1047451487 @eolivelli @merlimat PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above