[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-24 Thread GitBox
sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146491818 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-24 Thread GitBox
sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146482385 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -136,6 +147,11 @@ message

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-24 Thread GitBox
sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146482199 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-20 Thread GitBox
sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146034535 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerType.java ## @@

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-19 Thread GitBox
sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145789040 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerType.java ## @@

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r14556 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java ## @@

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

2017-10-18 Thread GitBox
sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145531204 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -73,6 +74,14 @@ message