[GitHub] sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338789477 retest this please This is an automated

[GitHub] sijie opened a new issue #656: Enable tests running with advertised address "127.0.0.1"

sijie opened a new issue #656: Enable tests running with advertised address "127.0.0.1" URL: https://github.com/apache/bookkeeper/issues/656 **Why** tests can be slow when DNS resolution is slow. running bookies with advertised address "127.0.0.1" will make tests running faster and

[GitHub] asfgit commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

asfgit commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338802231 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: bookkeeper-master #1925

See -- [...truncated 40.81 KB...] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.167 sec - in org.apache.bookkeeper.client.TestDelayEnsembleChange Running

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146355670 ## File path:

[GitHub] sijie commented on issue #655: Use Lambda expression when possible

sijie commented on issue #655: Use Lambda expression when possible URL: https://github.com/apache/bookkeeper/issues/655#issuecomment-338758593 @merlimat +1 This is an automated message from the Apache Git Service. To respond

[GitHub] sijie closed pull request #647: Fix a typo in PCBC logging

sijie closed pull request #647: Fix a typo in PCBC logging URL: https://github.com/apache/bookkeeper/pull/647 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146349344 ## File path:

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146355111 ## File path:

[GitHub] jvrao commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

jvrao commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338758125 @sijie will review it today. This is an

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146359096 ## File path:

[GitHub] sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338747907 @ivankelly I used merge than rebase, because I had the impression that github will lose commit related

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146350639 ## File path:

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146350662 ## File path:

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146352189 ## File path:

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146360130 ## File path:

[GitHub] sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338760553 @jvrao thank you This is an automated

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146351206 ## File path:

[GitHub] merlimat commented on issue #655: Use Lambda expression when possible

merlimat commented on issue #655: Use Lambda expression when possible URL: https://github.com/apache/bookkeeper/issues/655#issuecomment-338751727 > bookkeeper uses a lot of callbacks. those callbacks can be written in lambda expressions. It would be good to clean them up. In

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146354598 ## File path:

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146357086 ## File path:

[GitHub] sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338761747 @ivankelly - I addressed your comments. please review it when you have time.

[GitHub] asfgit commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

asfgit commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338770970 Refer to this link for build results (access rights to CI server needed):

[GitHub] sijie closed pull request #216: Issue164: Move findbug settings files to distributedlog-build-tools

sijie closed pull request #216: Issue164: Move findbug settings files to distributedlog-build-tools URL: https://github.com/apache/distributedlog/pull/216 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

Build failed in Jenkins: distributedlog-nightly-build #461

See -- Started by user sijie [EnvInject] - Loading node environment variables. Building remotely on ubuntu-4 (ubuntu trusty) in workspace

[GitHub] zhaijack opened a new pull request #218: Issue 217: Enable apache-rat check to output result to console

zhaijack opened a new pull request #218: Issue 217: Enable apache-rat check to output result to console URL: https://github.com/apache/distributedlog/pull/218 Descriptions of the changes in this PR: - bump `apache-rat` to 0.12. since `outputConsole` is only supported since 0.12

[GitHub] zhaijack opened a new issue #219: Exclude files under target directory from apache-rat check

zhaijack opened a new issue #219: Exclude files under target directory from apache-rat check URL: https://github.com/apache/distributedlog/issues/219 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? run distributedlog nightly build

[GitHub] sijie closed issue #219: Exclude files under target directory from apache-rat check

sijie closed issue #219: Exclude files under target directory from apache-rat check URL: https://github.com/apache/distributedlog/issues/219 This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie opened a new issue #221: Update FAQ page

sijie opened a new issue #221: Update FAQ page URL: https://github.com/apache/distributedlog/issues/221 **FEATURE REQUEST** 1. Please describe the feature you are requesting. The FAQ page is still empty. We should either update the FAQ page or just delete it. Since

[GitHub] sijie opened a new issue #222: post-commit ci job is broken

sijie opened a new issue #222: post-commit ci job is broken URL: https://github.com/apache/distributedlog/issues/222 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? run post commit job on CI - What did you expect to see?

[GitHub] sijie opened a new pull request #223: Issue 222: post-commit ci job is broken

sijie opened a new pull request #223: Issue 222: post-commit ci job is broken URL: https://github.com/apache/distributedlog/pull/223 Descriptions of the changes in this PR: The reason that the post commit ci job is broken is because `git remote show apache` is used in

[GitHub] jiazhai closed issue #222: post-commit ci job is broken

jiazhai closed issue #222: post-commit ci job is broken URL: https://github.com/apache/distributedlog/issues/222 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] jiazhai closed pull request #223: Issue 222: post-commit ci job is broken

jiazhai closed pull request #223: Issue 222: post-commit ci job is broken URL: https://github.com/apache/distributedlog/pull/223 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] jiazhai commented on issue #210: Issue 209: Support rename log

jiazhai commented on issue #210: Issue 209: Support rename log URL: https://github.com/apache/distributedlog/pull/210#issuecomment-338596459 Thanks for adding the test case. LGTM. This is an automated message from the Apache

Build failed in Jenkins: distributedlog-release-nightly-snapshot #60

See Changes: [sijie] ISSUE164: Move findbug settings files to distributedlog-build-tools [sijie] ISSUE #217: Enable apache-rat check to output result to console

[GitHub] jiazhai closed pull request #210: Issue 209: Support rename log

jiazhai closed pull request #210: Issue 209: Support rename log URL: https://github.com/apache/distributedlog/pull/210 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] jiazhai closed issue #209: Support log rename

jiazhai closed issue #209: Support log rename URL: https://github.com/apache/distributedlog/issues/209 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] zhaijack opened a new issue #217: Output the names of files that have unapproved licenses to the console

zhaijack opened a new issue #217: Output the names of files that have unapproved licenses to the console URL: https://github.com/apache/distributedlog/issues/217 **FEATURE REQUEST** 1. Please describe the feature you are requesting. Enable `apache-rat` to output the names of

[GitHub] zhaijack commented on issue #218: Issue 217: Enable apache-rat check to output result to console

zhaijack commented on issue #218: Issue 217: Enable apache-rat check to output result to console URL: https://github.com/apache/distributedlog/pull/218#issuecomment-338574411 @eolivelli bk is already on `apache-rat` 0.12 and `consoleOutput` is enabled.

Build failed in Jenkins: distributedlog-nightly-build #463

See Changes: [sijie] ISSUE #219: Exclude files under target directory from apache-rat check -- [...truncated 6.80 KB...] [INFO] Exclude: **/*.iws [INFO]

[GitHub] sijie closed pull request #218: Issue 217: Enable apache-rat check to output result to console

sijie closed pull request #218: Issue 217: Enable apache-rat check to output result to console URL: https://github.com/apache/distributedlog/pull/218 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] zhaijack opened a new pull request #220: Issue 219: Exclude files under target directory from apache-rat check

zhaijack opened a new pull request #220: Issue 219: Exclude files under target directory from apache-rat check URL: https://github.com/apache/distributedlog/pull/220 Descriptions of the changes in this PR: The problem is distributedlog-client and distributedlog-service have been

[GitHub] sijie commented on issue #164: Move findbug settings files to distributedlog-build-tools

sijie commented on issue #164: Move findbug settings files to distributedlog-build-tools URL: https://github.com/apache/distributedlog/issues/164#issuecomment-338584251 This has been fixed at #216. Thanks @ArvinDevel for the contribution.