[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396449927 @sijie I think the fix of infodog/bookkeeper#1 may have problem. because `request.complete(rCtx.getBookieIndex(), bookie, buffer, entryId) `will be

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396449927 @sijie I think the fix of infodog/bookkeeper#1 may have problem. because `request.complete(rCtx.getBookieIndex(), bookie, buffer, entryId) `will be

[GitHub] sijie commented on issue #1509: solve #1476 issue.

sijie commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396441626 @infodog : your fix is correct. however, it can be simplified with changing using `submitCallback` to use `completeRequest`. this would guarantee a request

[GitHub] sijie commented on issue #1505: [table service] replaying TxnRequest is not implemented

sijie commented on issue #1505: [table service] replaying TxnRequest is not implemented URL: https://github.com/apache/bookkeeper/pull/1505#issuecomment-396442317 run integration tests This is an automated message from the

[GitHub] sijie commented on issue #1508: ISSUE-1490 BookieJournalForceTest is flaky

sijie commented on issue #1508: ISSUE-1490 BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1508#issuecomment-396442755 run bookkeeper-server bookie tests This is an automated message from the

[GitHub] sijie commented on issue #1504: Issue #1489: Better Prevent Read Outliers during short-term Bookie Slow-Down

sijie commented on issue #1504: Issue #1489: Better Prevent Read Outliers during short-term Bookie Slow-Down URL: https://github.com/apache/bookkeeper/pull/1504#issuecomment-396442473 run bookkeeper-server tls tests This is

[GitHub] sijie commented on issue #1504: Issue #1489: Better Prevent Read Outliers during short-term Bookie Slow-Down

sijie commented on issue #1504: Issue #1489: Better Prevent Read Outliers during short-term Bookie Slow-Down URL: https://github.com/apache/bookkeeper/pull/1504#issuecomment-396442554 run bookkeeper-server bookie tests // BookieJournalTest is flaky due to #1508

[GitHub] sijie commented on issue #1509: solve #1476 issue.

sijie commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396441626 @infodog : your fix is corrected. however, it can be simplified with changing using `submitCallback` to use `completeRequest`. this would guarantee a

[GitHub] sijie commented on issue #1509: solve #1476 issue.

sijie commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396442014 @eolivelli - changes in infodog/bookkeeper#1 include the unit test. @jiazhai @yzang please review this PR as well, since it is dlog related.

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396449927 @sijie I think the fix of infodog/bookkeeper#1 may have problem. because `request.complete(rCtx.getBookieIndex(), bookie, buffer, entryId) `will be

[GitHub] sijie commented on issue #1436: BP-14 force() API - client side implementation

sijie commented on issue #1436: BP-14 force() API - client side implementation URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-396465963 > I have found an edge case, but I don't know if it is worth handling it. I would suggest not to error out pending adds. a force

[GitHub] sijie commented on a change in pull request #1508: ISSUE-1490 BookieJournalForceTest is flaky

sijie commented on a change in pull request #1508: ISSUE-1490 BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1508#discussion_r194597969 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalForceTest.java

[GitHub] sijie closed pull request #1505: [table service] replaying TxnRequest is not implemented

sijie closed pull request #1505: [table service] replaying TxnRequest is not implemented URL: https://github.com/apache/bookkeeper/pull/1505 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] sijie commented on issue #1509: solve #1476 issue.

sijie commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396464451 @infodog - https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedAndEntryOp.java#L127 use

[GitHub] sijie commented on issue #1507: [table service] Fix StringUtf8Coder and add VarIntCoder

sijie commented on issue #1507: [table service] Fix StringUtf8Coder and add VarIntCoder URL: https://github.com/apache/bookkeeper/pull/1507#issuecomment-396312289 run integration tests This is an automated message from the

[GitHub] sijie commented on issue #1505: [table service] replaying TxnRequest is not implemented

sijie commented on issue #1505: [table service] replaying TxnRequest is not implemented URL: https://github.com/apache/bookkeeper/pull/1505#issuecomment-396312532 run integration tests This is an automated message from the

[GitHub] sijie closed pull request #1507: [table service] Fix StringUtf8Coder and add VarIntCoder

sijie closed pull request #1507: [table service] Fix StringUtf8Coder and add VarIntCoder URL: https://github.com/apache/bookkeeper/pull/1507 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] sijie commented on issue #1501: Issue #1500: PendingReadOp.logErrorAndReattemptRead logs errors with debug level, some of them useful for troubleshooting at info/warn level

sijie commented on issue #1501: Issue #1500: PendingReadOp.logErrorAndReattemptRead logs errors with debug level, some of them useful for troubleshooting at info/warn level URL: https://github.com/apache/bookkeeper/pull/1501#issuecomment-396315086 the failure in "bookie tests" is related

[GitHub] sijie commented on issue #1509: solve #1476 issue.

sijie commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396317059 @eolivelli I think the problem only happened when speculations happen. also it is not just on long poll reads, I think it will impact normal reads. those tests

[GitHub] sijie closed pull request #1501: Issue #1500: PendingReadOp.logErrorAndReattemptRead logs errors with debug level, some of them useful for troubleshooting at info/warn level

sijie closed pull request #1501: Issue #1500: PendingReadOp.logErrorAndReattemptRead logs errors with debug level, some of them useful for troubleshooting at info/warn level URL: https://github.com/apache/bookkeeper/pull/1501 This is a PR merged from a forked repository. As GitHub hides

[GitHub] sijie commented on issue #1501: Issue #1500: PendingReadOp.logErrorAndReattemptRead logs errors with debug level, some of them useful for troubleshooting at info/warn level

sijie commented on issue #1501: Issue #1500: PendingReadOp.logErrorAndReattemptRead logs errors with debug level, some of them useful for troubleshooting at info/warn level URL: https://github.com/apache/bookkeeper/pull/1501#issuecomment-396315293 IGNORE CI

[GitHub] sijie closed issue #1500: PendingReadOp.logErrorAndReattemptRead logs errors with debug level, some of them useful for troubleshooting at info/warn level

sijie closed issue #1500: PendingReadOp.logErrorAndReattemptRead logs errors with debug level, some of them useful for troubleshooting at info/warn level URL: https://github.com/apache/bookkeeper/issues/1500 This is an

[GitHub] sijie commented on issue #1344: Allow to configure read-only mode in ZooKeeperClient

sijie commented on issue #1344: Allow to configure read-only mode in ZooKeeperClient URL: https://github.com/apache/bookkeeper/pull/1344#issuecomment-396315700 run integration tests This is an automated message from the

[GitHub] sijie closed issue #1487: [DbLedgerStorage] IllegalReferenceCount on filling readahead cache

sijie closed issue #1487: [DbLedgerStorage] IllegalReferenceCount on filling readahead cache URL: https://github.com/apache/bookkeeper/issues/1487 This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie commented on issue #1487: [DbLedgerStorage] IllegalReferenceCount on filling readahead cache

sijie commented on issue #1487: [DbLedgerStorage] IllegalReferenceCount on filling readahead cache URL: https://github.com/apache/bookkeeper/issues/1487#issuecomment-396325267 This is fixed at #1488 This is an automated

[GitHub] eolivelli commented on issue #1509: solve #1476 issue.

eolivelli commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396344562 @sijie sure, go ahead. This is an automated message from the Apache Git Service. To

[GitHub] philipsu522 commented on issue #1504: Issue #1489: Better Prevent Read Outliers during short-term Bookie Slow-Down

philipsu522 commented on issue #1504: Issue #1489: Better Prevent Read Outliers during short-term Bookie Slow-Down URL: https://github.com/apache/bookkeeper/pull/1504#issuecomment-396352783 awesome - LGTM! This is an

[GitHub] sijie commented on issue #1509: solve #1476 issue.

sijie commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396344039 @eolivelli - sure, we need to add test cases for this. however I don't think the fix address the root cause. still looking ...

[GitHub] philipsu522 commented on issue #1489: Better Prevent Read Outliers during short-term Bookie Slow-Down

philipsu522 commented on issue #1489: Better Prevent Read Outliers during short-term Bookie Slow-Down URL: https://github.com/apache/bookkeeper/issues/1489#issuecomment-396352860 Results look good! This is an automated

[GitHub] eolivelli commented on issue #1509: solve #1476 issue.

eolivelli commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396343230 So @sijie you are saying that we have some code path not covered by test cases. It would be good to have minimal coverage of this change, just by using

[GitHub] sijie opened a new issue #1510: bookkeeper client doesn't have any mechanism to cancel speculative requests

sijie opened a new issue #1510: bookkeeper client doesn't have any mechanism to cancel speculative requests URL: https://github.com/apache/bookkeeper/issues/1510 *Problem* #209 introduced the speculative policy interfaces. However the interfaces don't problem any mechanism to

[GitHub] eolivelli commented on a change in pull request #1508: ISSUE-1490 BookieJournalForceTest is flaky

eolivelli commented on a change in pull request #1508: ISSUE-1490 BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1508#discussion_r194321752 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalForceTest.java

[GitHub] eolivelli commented on issue #1436: BP-14 force() API - client side implementation

eolivelli commented on issue #1436: BP-14 force() API - client side implementation URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-396160571 @sijie @jvrao waiting for your comments and hopefully approval. I have found an edge case, but I don't know if it is

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396167544 I setup a bookkeeper cluster with 3 bookie server, and then setup a client read the logs , the client code is as following: ``` void downloadLog() throws

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396167544 @eolivelli I setup a bookkeeper cluster with 3 bookie server, and then setup a client read the logs , the client code is as following: ``` void

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396167544 I setup a bookkeeper cluster with 3 bookie server, and then setup a client read the logs , the client code is as following: ``` void downloadLog() throws

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396167544 @eolivelli I setup a bookkeeper cluster with 3 bookie server, and then setup two clients read the logs , the client code is as following: ``` void

[GitHub] eolivelli commented on issue #1509: solve #1476 issue.

eolivelli commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396171716 @infodog I see your description. It is better to fix the first known issue with your current work, then you will create a follow up issue if this is no

Jenkins build is back to stable : bookkeeper_postcommit_master_java8 #165

See

Jenkins build is back to stable : bookkeeper_postcommit_master_java9 #166

See