[GitHub] jvrao commented on a change in pull request #1532: ISSUE #1527: Make ExplicitLAC persistent

2018-07-11 Thread GitBox
jvrao commented on a change in pull request #1532: ISSUE #1527: Make ExplicitLAC persistent URL: https://github.com/apache/bookkeeper/pull/1532#discussion_r201730658 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ## @@ -784,6

[GitHub] jvrao commented on a change in pull request #1532: ISSUE #1527: Make ExplicitLAC persistent

2018-07-11 Thread GitBox
jvrao commented on a change in pull request #1532: ISSUE #1527: Make ExplicitLAC persistent URL: https://github.com/apache/bookkeeper/pull/1532#discussion_r201735151 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ## @@ -784,6

[GitHub] jvrao commented on a change in pull request #1532: ISSUE #1527: Make ExplicitLAC persistent

2018-07-11 Thread GitBox
jvrao commented on a change in pull request #1532: ISSUE #1527: Make ExplicitLAC persistent URL: https://github.com/apache/bookkeeper/pull/1532#discussion_r201737053 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java ## @@ -206,9

[GitHub] jvrao commented on a change in pull request #1532: ISSUE #1527: Make ExplicitLAC persistent

2018-07-11 Thread GitBox
jvrao commented on a change in pull request #1532: ISSUE #1527: Make ExplicitLAC persistent URL: https://github.com/apache/bookkeeper/pull/1532#discussion_r201730658 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ## @@ -784,6

[GitHub] reddycharan commented on issue #1532: ISSUE #1527: Make ExplicitLAC persistent

2018-07-11 Thread GitBox
reddycharan commented on issue #1532: ISSUE #1527: Make ExplicitLAC persistent URL: https://github.com/apache/bookkeeper/pull/1532#issuecomment-404359079 @jvrao @sijie actually i missed considering Journal version bump for this change. It seems for other special entries in journal,

[GitHub] reddycharan commented on a change in pull request #1532: ISSUE #1527: Make ExplicitLAC persistent

2018-07-11 Thread GitBox
reddycharan commented on a change in pull request #1532: ISSUE #1527: Make ExplicitLAC persistent URL: https://github.com/apache/bookkeeper/pull/1532#discussion_r201843516 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ## @@ -784,6