[GitHub] asfgit commented on issue #266: Issue 265: Add persistable bookie status

asfgit commented on issue #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#issuecomment-338863928 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/bookkeeper-precommit-pullrequest-

[GitHub] asfgit commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

asfgit commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338802231 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/

[GitHub] sijie opened a new issue #656: Enable tests running with advertised address "127.0.0.1"

sijie opened a new issue #656: Enable tests running with advertised address "127.0.0.1" URL: https://github.com/apache/bookkeeper/issues/656 **Why** tests can be slow when DNS resolution is slow. running bookies with advertised address "127.0.0.1" will make tests running faster and

[GitHub] sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338789477 retest this please This is an automated mes

[GitHub] sijie closed pull request #648: Pool the V2 keys

sijie closed pull request #648: Pool the V2 keys URL: https://github.com/apache/bookkeeper/pull/648 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork),

[GitHub] asfgit commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

asfgit commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338770970 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/

[GitHub] sijie closed pull request #647: Fix a typo in PCBC logging

sijie closed pull request #647: Fix a typo in PCBC logging URL: https://github.com/apache/bookkeeper/pull/647 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from

[GitHub] sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338761747 @ivankelly - I addressed your comments. please review it when you have time. ---

[GitHub] sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338760553 @jvrao thank you This is an automated messa

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146360130 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146359096 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] sijie commented on issue #655: Use Lambda expression when possible

sijie commented on issue #655: Use Lambda expression when possible URL: https://github.com/apache/bookkeeper/issues/655#issuecomment-338758593 @merlimat +1 This is an automated message from the Apache Git Service. To respond t

[GitHub] jvrao commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

jvrao commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338758125 @sijie will review it today. This is an au

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146357086 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146355670 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146355111 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146354598 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146352189 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] merlimat commented on issue #655: Use Lambda expression when possible

merlimat commented on issue #655: Use Lambda expression when possible URL: https://github.com/apache/bookkeeper/issues/655#issuecomment-338751727 > bookkeeper uses a lot of callbacks. those callbacks can be written in lambda expressions. It would be good to clean them up. In additio

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146351206 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146350705 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146350662 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146350639 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] sijie opened a new issue #655: Use Lambda expression when possible

sijie opened a new issue #655: Use Lambda expression when possible URL: https://github.com/apache/bookkeeper/issues/655 **FEATURE REQUEST** 1. Please describe the feature you are requesting. bookkeeper uses a lot of callbacks. those callbacks can be written in lambda e

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146349755 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146349344 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on issue #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#issuecomment-338747907 @ivankelly I used merge than rebase, because I had the impression that github will lose commit related comme

Build failed in Jenkins: bookkeeper-master #1925

See -- [...truncated 40.81 KB...] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.167 sec - in org.apache.bookkeeper.client.TestDelayEnsembleChange Running org.apache.

Jenkins build is still unstable: bookkeeper-release-nightly-snapshot #82

See