[GitHub] reddycharan commented on issue #1094: BP-27 (part 1): New BookKeeper CLI Skeleton

2018-02-15 Thread GitBox
reddycharan commented on issue #1094: BP-27 (part 1): New BookKeeper CLI Skeleton URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-366124429 it is matter of convenience and less error-prone to not have '-' in script filename/command name. When we spell it, people might

[GitHub] reddycharan commented on issue #1094: BP-27 (part 1): New BookKeeper CLI Skeleton

2018-02-15 Thread GitBox
reddycharan commented on issue #1094: BP-27 (part 1): New BookKeeper CLI Skeleton URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-366037024 overall LGTM. Other than the need of reflection and naming script/command with '-'. Regarding help usage message, it can be

[GitHub] reddycharan commented on issue #1094: BP-27 (part 1): New BookKeeper CLI Skeleton

2018-02-15 Thread GitBox
reddycharan commented on issue #1094: BP-27 (part 1): New BookKeeper CLI Skeleton URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-366035855 "@reddycharan updated this PR to use "bookkeeper-cli" instead of "bookie-shell" in the command output, to avoid confusion."