[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r154391492 ## File path: site/docs/latest/api/ledger-api.md ## @@ -471,3 +471,304 @@ mvn exec:java

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153603117 ## File path: site/docs/latest/api/ledger-api.md ## @@ -471,3 +471,304 @@ mvn exec:java

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153604520 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/api/WriteFlagTest.java ## @@ -0,0

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153601282 ## File path: site/docs/latest/api/ledger-api.md ## @@ -471,3 +471,304 @@ mvn exec:java

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153600707 ## File path: site/docs/latest/api/ledger-api.md ## @@ -36,12 +36,12 @@ If you're using

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153600627 ## File path: site/.ruby-version ## @@ -0,0 +1 @@ +2.4.1 Review comment: I don't think we need this.

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153600416 ## File path: site/docs/latest/api/ledger-api.md ## @@ -20,7 +20,7 @@ If you're using

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153600223 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/CreateBuilder.java ## @@ -91,6

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r152366130 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java ## @@ -0,0 +1,72

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r151910336 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java ## @@ -20,14

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r151910213 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/CreateBuilder.java ## @@ -100,6

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r151910458 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/api/WriteFlagTest.java ## @@ -20,34

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r151910635 ## File path: bookkeeper-proto/src/main/proto/BookkeeperProtocol.proto ## @@ -112,6 +112,7 @@ message