[jira] [Comment Edited] (CALCITE-2717) Cached traits in RelTraitDef's canonicalMap can't be garbage-collected

2018-11-29 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704311#comment-16704311 ] Haisheng Yuan edited comment on CALCITE-2717 at 11/30/18 6:19 AM: -- We

[jira] [Commented] (CALCITE-2717) Cached traits in RelTraitDef's canonicalMap can't be garbage-collected

2018-11-29 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704311#comment-16704311 ] Haisheng Yuan commented on CALCITE-2717: We have seen the OOM issue accidentally in our system

[jira] [Commented] (CALCITE-2709) GeodeFilter Support for temporal types and searches (DATE, TIME, TIMESTAMP etc.)

2018-11-29 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704285#comment-16704285 ] Julian Hyde commented on CALCITE-2709: -- I saw your PR. Can you change the commit message to

[jira] [Commented] (CALCITE-2705) Duplicated selectivity in metadata list

2018-11-29 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704232#comment-16704232 ] Julian Hyde commented on CALCITE-2705: -- Thanks; will commit shortly. > Duplicated selectivity in

[jira] [Resolved] (CALCITE-2718) field names are unexpected after ProjectRemoveRule applied

2018-11-29 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-2718. -- Resolution: Not A Problem Fix Version/s: (was: 1.18.0) We don't guarantee to

[jira] [Commented] (CALCITE-2632) Add hashCode and equals implementations to RexNode

2018-11-29 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704020#comment-16704020 ] Julian Hyde commented on CALCITE-2632: -- I'm reviewing and testing this, and reworking a little: * 

[jira] [Updated] (CALCITE-2632) Add hashCode and equals implementations to RexNode

2018-11-29 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-2632: - Fix Version/s: 1.18.0 > Add hashCode and equals implementations to RexNode >

[jira] [Updated] (CALCITE-2713) JDBC adapter may generate casts on PostgreSQL for VARCHAR type exceeding max length

2018-11-29 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-2713: - Fix Version/s: 1.18.0 > JDBC adapter may generate casts on PostgreSQL for VARCHAR type

[jira] [Commented] (CALCITE-2715) MS SQL Server does not support character set as part of data type

2018-11-29 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703826#comment-16703826 ] Julian Hyde commented on CALCITE-2715: -- Reviewing and testing now. Confirmed that the test case

[jira] [Updated] (CALCITE-2714) Make BasicSqlType immutable, and now createWithNullability re-uses existing type if possible

2018-11-29 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-2714: - Summary: Make BasicSqlType immutable, and now createWithNullability re-uses existing type if

[jira] [Updated] (CALCITE-2714) Slight optimization in SqlTypeFactoryImpl#createTypeWithNullability

2018-11-29 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-2714: - Fix Version/s: 1.18.0 > Slight optimization in SqlTypeFactoryImpl#createTypeWithNullability >

[jira] [Commented] (CALCITE-2689) ES Adapter. Grouping on date / number fields fails

2018-11-29 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703776#comment-16703776 ] Julian Hyde commented on CALCITE-2689: -- Reviewing and testing now. > ES Adapter. Grouping on date

[jira] [Commented] (CALCITE-2714) Slight optimization in SqlTypeFactoryImpl#createTypeWithNullability

2018-11-29 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703766#comment-16703766 ] Julian Hyde commented on CALCITE-2714: -- Reviewing and testing now. > Slight optimization in

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-11-29 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703710#comment-16703710 ] Enrico Olivelli commented on CALCITE-2662: -- Just because I did not see any test case about the

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-11-29 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703687#comment-16703687 ] Julian Hyde commented on CALCITE-2662: -- Why do you think it is not useful for the user to see the

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-11-29 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703682#comment-16703682 ] Enrico Olivelli commented on CALCITE-2662: -- I will add tests. As 'originalinput' query seems

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-11-29 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703592#comment-16703592 ] Julian Hyde commented on CALCITE-2662: -- The fact that you are able to use a StringReader is a good

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-11-29 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703362#comment-16703362 ] Enrico Olivelli commented on CALCITE-2662: -- [~julianhyde] I have added a Proof-of-concept

[jira] [Updated] (CALCITE-2719) MySQL does not support cast to bigint type

2018-11-29 Thread Piotr Bojko (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Bojko updated CALCITE-2719: - Description: Cast to BIGING is not supported in MySQL. The trick is to use CAST to UNSIGNED

[jira] [Commented] (CALCITE-2715) MS SQL Server does not support character set as part of data type

2018-11-29 Thread Piotr Bojko (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703195#comment-16703195 ] Piotr Bojko commented on CALCITE-2715: -- I have added a test case. I haven't really checked

[jira] [Created] (CALCITE-2719) MySQL does not support cast to bigint type

2018-11-29 Thread Piotr Bojko (JIRA)
Piotr Bojko created CALCITE-2719: Summary: MySQL does not support cast to bigint type Key: CALCITE-2719 URL: https://issues.apache.org/jira/browse/CALCITE-2719 Project: Calcite Issue Type:

[jira] [Updated] (CALCITE-2689) ES Adapter. Grouping on date / number fields fails

2018-11-29 Thread Andrei Sereda (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Sereda updated CALCITE-2689: --- Description: For [Terms 

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2018-11-29 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703125#comment-16703125 ] zhen wang commented on CALCITE-1935: okay, I will put it here first, adding it gradually:

[jira] [Updated] (CALCITE-2718) field names are unexpected after ProjectRemoveRule applied

2018-11-29 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated CALCITE-2718: Description: {code:java} @Test public void testProjectRemove() { final String sql = "select

[jira] [Created] (CALCITE-2718) field names are unexpected after ProjectRemoveRule applied

2018-11-29 Thread godfrey he (JIRA)
godfrey he created CALCITE-2718: --- Summary: field names are unexpected after ProjectRemoveRule applied Key: CALCITE-2718 URL: https://issues.apache.org/jira/browse/CALCITE-2718 Project: Calcite

[jira] [Commented] (CALCITE-2714) Slight optimization in SqlTypeFactoryImpl#createTypeWithNullability

2018-11-29 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702995#comment-16702995 ] Ruben Quesada Lopez commented on CALCITE-2714: -- Thanks for your feedback, [~julianhyde].