[jira] [Commented] (CALCITE-3830) The ‘approximate’ field should be considered when computing the digest of AggregateCall

2020-02-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046272#comment-17046272 ] Julian Hyde commented on CALCITE-3830: -- Let’s emit the keyword APPROXIMATE if the flag is set.

[jira] [Commented] (CALCITE-3825) Split AbstractMaterializedViewRule into multiple classes

2020-02-26 Thread Jesus Camacho Rodriguez (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046205#comment-17046205 ] Jesus Camacho Rodriguez commented on CALCITE-3825: -- Pushed addendum in

[jira] [Commented] (CALCITE-3825) Split AbstractMaterializedViewRule into multiple classes

2020-02-26 Thread Jesus Camacho Rodriguez (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046196#comment-17046196 ] Jesus Camacho Rodriguez commented on CALCITE-3825: -- This change causes a diff in

[jira] [Updated] (CALCITE-3832) NPE when decimal cast double

2020-02-26 Thread Zhixiong Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhixiong Chen updated CALCITE-3832: --- Summary: NPE when decimal cast double (was: Decimal cast double throws npe) > NPE when

[jira] [Updated] (CALCITE-3832) Decimal cast double throws npe

2020-02-26 Thread Zhixiong Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhixiong Chen updated CALCITE-3832: --- Summary: Decimal cast double throws npe (was: decimal cast double throws npe) > Decimal

[jira] [Commented] (CALCITE-3832) decimal cast double throws npe

2020-02-26 Thread Zhixiong Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046190#comment-17046190 ] Zhixiong Chen commented on CALCITE-3832: I found in RexToLixTranslator  when decimal cast to

[jira] [Updated] (CALCITE-3832) decimal cast double throws npe

2020-02-26 Thread Zhixiong Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhixiong Chen updated CALCITE-3832: --- Affects Version/s: 1.16.0 > decimal cast double throws npe >

[jira] [Created] (CALCITE-3832) decimal cast double throws npe

2020-02-26 Thread Zhixiong Chen (Jira)
Zhixiong Chen created CALCITE-3832: -- Summary: decimal cast double throws npe Key: CALCITE-3832 URL: https://issues.apache.org/jira/browse/CALCITE-3832 Project: Calcite Issue Type: Bug

[jira] [Updated] (CALCITE-3830) The ‘approximate’ field should be considered when computing the digest of AggregateCall

2020-02-26 Thread Shuo Cheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Cheng updated CALCITE-3830: Description: In planner optimization, the digest  of Aggregate node contains digest of its

[jira] [Commented] (CALCITE-3830) The ‘approximate’ field should be considered when computing the digest of AggregateCall

2020-02-26 Thread Shuo Cheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046184#comment-17046184 ] Shuo Cheng commented on CALCITE-3830: - [~danny0405], I've created a pr, please have a look. > The

[jira] [Updated] (CALCITE-3830) The ‘approximate’ field should be considered when computing the digest of AggregateCall

2020-02-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-3830: Labels: pull-request-available (was: ) > The ‘approximate’ field should be considered

[jira] [Assigned] (CALCITE-3830) The ‘approximate’ field should be considered when computing the digest of AggregateCall

2020-02-26 Thread Shuo Cheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Cheng reassigned CALCITE-3830: --- Assignee: Shuo Cheng > The ‘approximate’ field should be considered when computing the

[jira] [Updated] (CALCITE-3830) The ‘approximate’ field should be considered when computing the digest of AggregateCall

2020-02-26 Thread Shuo Cheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Cheng updated CALCITE-3830: Summary: The ‘approximate’ field should be considered when computing the digest of AggregateCall

[jira] [Resolved] (CALCITE-3824) JoinProjectTransposeRule should skip Projects containing windowing expression

2020-02-26 Thread Jesus Camacho Rodriguez (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesus Camacho Rodriguez resolved CALCITE-3824. -- Fix Version/s: 1.23.0 Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-3825) Split AbstractMaterializedViewRule into multiple classes

2020-02-26 Thread Jesus Camacho Rodriguez (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesus Camacho Rodriguez resolved CALCITE-3825. -- Fix Version/s: 1.23.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-3824) JoinProjectTransposeRule should skip Projects containing windowing expression

2020-02-26 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046110#comment-17046110 ] Danny Chen commented on CALCITE-3824: - Thanks for the fixing, [~vgarg] ! >

[jira] [Commented] (CALCITE-3412) FLOOR(timestamp TO WEEK) gives wrong result

2020-02-26 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046101#comment-17046101 ] Danny Chen commented on CALCITE-3412: - I have already upgrade Avatica version to 1.16.0 for Calcite

[jira] [Updated] (CALCITE-3831) AbstractMaterializedViewRule throws exception with an Aggregate on a Project projecting duplicate RexNodes

2020-02-26 Thread Steven Talbot (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Talbot updated CALCITE-3831: --- Description: Note that this only happens when a rollup is required ("forceRollup" in the

[jira] [Updated] (CALCITE-3831) AbstractMaterializedViewRule throws exception with an Aggregate on a Project projecting duplicate RexNodes

2020-02-26 Thread Steven Talbot (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Talbot updated CALCITE-3831: --- Description: Note that this only happens when a rollup is required ("forceRollup" in the

[jira] [Created] (CALCITE-3831) AbstractMaterializedViewRule throws exception with an Aggregate on a Project projecting duplicate RexNodes

2020-02-26 Thread Steven Talbot (Jira)
Steven Talbot created CALCITE-3831: -- Summary: AbstractMaterializedViewRule throws exception with an Aggregate on a Project projecting duplicate RexNodes Key: CALCITE-3831 URL:

[jira] [Commented] (CALCITE-3826) UPDATE assigns wrong type to bind variables

2020-02-26 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046094#comment-17046094 ] Danny Chen commented on CALCITE-3826: - Does the scan changes from: {code:java} EnumerableTableScan

[jira] [Commented] (CALCITE-3830) Digest of AggregateCall do not consider the ‘approximate’ attribute

2020-02-26 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046082#comment-17046082 ] Danny Chen commented on CALCITE-3830: - Reasonable, can you fire a fix soon, let's make this into

[jira] [Resolved] (CALCITE-3822) Source distribution must not contain fonts under SIL OFL 1.1 license (category B)

2020-02-26 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chen resolved CALCITE-3822. - Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-3818) Upgrade Avatica version to 1.16.0

2020-02-26 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chen resolved CALCITE-3818. - Resolution: Fixed Fixed in

[jira] [Updated] (CALCITE-3830) Digest of AggregateCall do not consider the ‘approximate’ attribute

2020-02-26 Thread Shuo Cheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Cheng updated CALCITE-3830: Summary: Digest of AggregateCall do not consider the ‘approximate’ attribute (was: The

[jira] [Updated] (CALCITE-3830) Digest of AggregateCall do not consider the ‘approximate’ attribute

2020-02-26 Thread Shuo Cheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Cheng updated CALCITE-3830: Description: In planner optimization, the digest  of Aggregate node contains digest of its

[jira] [Updated] (CALCITE-3830) The 'approximate' field should be considered in AggregateCall.toString() which is used as the digest

2020-02-26 Thread Shuo Cheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Cheng updated CALCITE-3830: Component/s: core Fix Version/s: 1.22.0 Affects Version/s: 1.21.0

[jira] [Created] (CALCITE-3830) Digest of AggregateCall do not consider the ''

2020-02-26 Thread Shuo Cheng (Jira)
Shuo Cheng created CALCITE-3830: --- Summary: Digest of AggregateCall do not consider the '' Key: CALCITE-3830 URL: https://issues.apache.org/jira/browse/CALCITE-3830 Project: Calcite Issue Type:

[jira] [Updated] (CALCITE-3823) Do not use String.replaceAll

2020-02-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-3823: - Fix Version/s: 1.23.0 > Do not use String.replaceAll > > >

[jira] [Updated] (CALCITE-3823) Do not use String.replaceAll

2020-02-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-3823: Labels: pull-request-available (was: ) > Do not use String.replaceAll >

[jira] [Created] (CALCITE-3829) MergeJoinEnumerator should not use inputs enumerators until it is really required

2020-02-26 Thread Ruben Q L (Jira)
Ruben Q L created CALCITE-3829: -- Summary: MergeJoinEnumerator should not use inputs enumerators until it is really required Key: CALCITE-3829 URL: https://issues.apache.org/jira/browse/CALCITE-3829

[jira] [Commented] (CALCITE-3826) UPDATE assigns wrong type to bind variables

2020-02-26 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045466#comment-17045466 ] Danny Chen commented on CALCITE-3826: - Checked this SQL: {code:java} @Test public void

[jira] [Commented] (CALCITE-3826) UPDATE assigns wrong type to bind variables

2020-02-26 Thread Enrico Olivelli (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045396#comment-17045396 ] Enrico Olivelli commented on CALCITE-3826: -- [~danny0405] Thanks for checking is your test

[jira] [Commented] (CALCITE-3826) UPDATE assigns wrong type to bind variables

2020-02-26 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045390#comment-17045390 ] Danny Chen commented on CALCITE-3826: - Not sure if this is a bug, i tried these tests in

[jira] [Updated] (CALCITE-3826) UPDATE assigns wrong type to bind variables

2020-02-26 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chen updated CALCITE-3826: Fix Version/s: (was: 1.22.0) > UPDATE assigns wrong type to bind variables >

[jira] [Issue Comment Deleted] (CALCITE-3826) UPDATE assigns wrong type to bind variables

2020-02-26 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chen updated CALCITE-3826: Comment: was deleted (was: Thanks for reporting this [~eolivelli], it is indeed a bug, fixing

[jira] [Updated] (CALCITE-3826) UPDATE assigns wrong type to bind variables

2020-02-26 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chen updated CALCITE-3826: Fix Version/s: 1.22.0 > UPDATE assigns wrong type to bind variables >

[jira] [Commented] (CALCITE-3826) UPDATE assigns wrong type to bind variables

2020-02-26 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045356#comment-17045356 ] Danny Chen commented on CALCITE-3826: - Thanks for reporting this [~eolivelli], it is indeed a bug,

[jira] [Comment Edited] (CALCITE-3828) MergeJoin throws NPE in case of null keys

2020-02-26 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045283#comment-17045283 ] Ruben Q L edited comment on CALCITE-3828 at 2/26/20 9:42 AM: - MergeJoin

[jira] [Updated] (CALCITE-3828) MergeJoin throws NPE in case of null keys

2020-02-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-3828: Labels: pull-request-available (was: ) > MergeJoin throws NPE in case of null keys >

[jira] [Commented] (CALCITE-3412) FLOOR(timestamp TO WEEK) gives wrong result

2020-02-26 Thread Andrew Tsvelodub (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045301#comment-17045301 ] Andrew Tsvelodub commented on CALCITE-3412: --- [~danny0405][~julianhyde] I see this bug is

[jira] [Commented] (CALCITE-3769) Deprecate TableScanRule

2020-02-26 Thread Enrico Olivelli (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045294#comment-17045294 ] Enrico Olivelli commented on CALCITE-3769: -- In my case the fix was easy, just to return "null"

[jira] [Commented] (CALCITE-3828) MergeJoin throws NPE in case of null keys

2020-02-26 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045283#comment-17045283 ] Ruben Q L commented on CALCITE-3828: MergeJoin algorithm assumes that inputs sorted in ascending

[jira] [Updated] (CALCITE-3828) MergeJoin throws NPE in case of null keys

2020-02-26 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Q L updated CALCITE-3828: --- Description: Problem can be reproduced with the following test (to be added to

[jira] [Created] (CALCITE-3828) MergeJoin throws NPE in case of null keys

2020-02-26 Thread Ruben Q L (Jira)
Ruben Q L created CALCITE-3828: -- Summary: MergeJoin throws NPE in case of null keys Key: CALCITE-3828 URL: https://issues.apache.org/jira/browse/CALCITE-3828 Project: Calcite Issue Type: Bug

[jira] [Updated] (CALCITE-3820) EnumerableDefaults#orderBy should be lazily computed + support enumerator re-initialization

2020-02-26 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Q L updated CALCITE-3820: --- Description: Currently, {{EnumerableDefaults#orderBy}} (which is the actual implementation behind

[jira] [Updated] (CALCITE-3820) EnumerableDefaults#orderBy should be lazily computed + support enumerator re-initialization

2020-02-26 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Q L updated CALCITE-3820: --- Fix Version/s: 1.23.0 > EnumerableDefaults#orderBy should be lazily computed + support enumerator

[jira] [Commented] (CALCITE-3824) JoinProjectTransposeRule should skip Projects containing windowing expression

2020-02-26 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045236#comment-17045236 ] Chunwei Lei commented on CALCITE-3824: -- Good catch~ > JoinProjectTransposeRule should skip

[jira] [Commented] (CALCITE-3820) EnumerableDefaults#orderBy should be lazily computed + support enumerator re-initialization

2020-02-26 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045233#comment-17045233 ] Ruben Q L commented on CALCITE-3820: Thanks for your feedback, [~julianhyde]. >

[jira] [Commented] (CALCITE-3827) Reduce the time complexity of finding in-edges of a vertex in the graph

2020-02-26 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045232#comment-17045232 ] Chunwei Lei commented on CALCITE-3827: -- Interesting! I would like to review it. > Reduce the time

[jira] [Updated] (CALCITE-3827) Reduce the time complexity of finding in-edges of a vertex in the graph

2020-02-26 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-3827: -- Description: In the current graph implementation, it takes O(1) time to find the out-edges of a

[jira] [Updated] (CALCITE-3827) Reduce the time complexity of finding in-edges of a vertex in the graph

2020-02-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-3827: Labels: pull-request-available (was: ) > Reduce the time complexity of finding in-edges

[jira] [Created] (CALCITE-3827) Reduce the time complexity of finding in-edges of a vertex in the graph

2020-02-26 Thread Liya Fan (Jira)
Liya Fan created CALCITE-3827: - Summary: Reduce the time complexity of finding in-edges of a vertex in the graph Key: CALCITE-3827 URL: https://issues.apache.org/jira/browse/CALCITE-3827 Project: Calcite