[
https://issues.apache.org/jira/browse/CALCITE-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1710#comment-1710
]
Haisheng Yuan commented on CALCITE-4003:
View matching is a computing intensive task, should
[
https://issues.apache.org/jira/browse/CALCITE-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haisheng Yuan updated CALCITE-4004:
---
Description: Override Object.toString() in RelOptRuleOperand to facilitate
debugging,
[
https://issues.apache.org/jira/browse/CALCITE-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haisheng Yuan updated CALCITE-4004:
---
Summary: Override Object.toString() in RelOptRuleOperand (was: Override
[
https://issues.apache.org/jira/browse/CALCITE-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107737#comment-17107737
]
Haisheng Yuan commented on CALCITE-4004:
Yes, you get my meaning. :) Overiding
[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Wang updated CALCITE-4000:
--
Description:
TUMBLE/HOP have an optional "OFFSET" parameter to indicate how many time off
from 0
[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107732#comment-17107732
]
Rui Wang commented on CALCITE-4000:
---
Thanks Viliam! Those are great points.
> 1. The parameter
[
https://issues.apache.org/jira/browse/CALCITE-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107731#comment-17107731
]
Haisheng Yuan commented on CALCITE-4002:
I understand that some rule needs to match physical
[
https://issues.apache.org/jira/browse/CALCITE-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107728#comment-17107728
]
Haisheng Yuan commented on CALCITE-4002:
:) Sorry for not being clear, my word is misleading.
[
https://issues.apache.org/jira/browse/CALCITE-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107710#comment-17107710
]
Julian Hyde commented on CALCITE-4002:
--
Might be controversial. You seem to have purist philosophy
[
https://issues.apache.org/jira/browse/CALCITE-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107709#comment-17107709
]
Julian Hyde commented on CALCITE-4004:
--
Technically you're overriding Object.toString() in
[
https://issues.apache.org/jira/browse/CALCITE-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107704#comment-17107704
]
Stamatis Zampetakis commented on CALCITE-4003:
--
I agree that we should solve these kind of
[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107665#comment-17107665
]
Viliam Durina edited comment on CALCITE-4000 at 5/14/20, 8:50 PM:
--
Few
[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107665#comment-17107665
]
Viliam Durina commented on CALCITE-4000:
Few more notes:
1. The parameter names, unlike Java,
Haisheng Yuan created CALCITE-4004:
--
Summary: Override RelOptRuleOperand.toString()
Key: CALCITE-4004
URL: https://issues.apache.org/jira/browse/CALCITE-4004
Project: Calcite
Issue Type:
[
https://issues.apache.org/jira/browse/CALCITE-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107655#comment-17107655
]
Haisheng Yuan commented on CALCITE-4003:
[~jinxing6...@126.com] You may find this interesting.
Haisheng Yuan created CALCITE-4003:
--
Summary: In MaterializationTest, FilterProjectTransposeRule
matches with logical and physical convention
Key: CALCITE-4003
URL:
Haisheng Yuan created CALCITE-4002:
--
Summary: Add security check to make sure TransformationRule
doesn't generate PhysicalNode
Key: CALCITE-4002
URL: https://issues.apache.org/jira/browse/CALCITE-4002
[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Wang updated CALCITE-4000:
--
Description:
TUMBLE/HOP have an optional "OFFSET" parameter to indicate how many time off
from 0
[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107638#comment-17107638
]
Rui Wang edited comment on CALCITE-4000 at 5/14/20, 8:24 PM:
-
Yes you are
[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Wang updated CALCITE-4000:
--
Description:
TUMBLE/HOP have an optional "OFFSET" parameter to indicate how many time off
from 0
[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107638#comment-17107638
]
Rui Wang commented on CALCITE-4000:
---
Yes you are right. SESSION does not have the offset parameter
[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Wang updated CALCITE-4000:
--
Description:
TUMBLE/HOP have an optional "OFFSET" parameter to indicate how many time off
from 0
[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Wang updated CALCITE-4000:
--
Description:
TUMBLE/HOP have an optional "OFFSET" parameter to indicate how many time off
from 0
[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Wang updated CALCITE-4000:
--
Summary: Support OFFSET parameter in TUMBLE/HOP table functions (was:
Support OFFSET parameter in
[
https://issues.apache.org/jira/browse/CALCITE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107612#comment-17107612
]
Julian Hyde commented on CALCITE-3977:
--
[~zabetak] is right. Flattening is one option. Flattening
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107610#comment-17107610
]
Enrico Olivelli commented on CALCITE-3997:
--
Thank you.
I will check tomorrow if this patch
[
https://issues.apache.org/jira/browse/CALCITE-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haisheng Yuan resolved CALCITE-3968.
Fix Version/s: 1.23.0
Resolution: Fixed
Fixed in
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haisheng Yuan resolved CALCITE-3997.
Fix Version/s: 1.23.0
Resolution: Fixed
Fixed in
[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107575#comment-17107575
]
Julian Hyde commented on CALCITE-4000:
--
Please give examples. This case will be the de facto
[
https://issues.apache.org/jira/browse/CALCITE-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107571#comment-17107571
]
Julian Hyde commented on CALCITE-4001:
--
Are you aware of the work done in CALCITE-3534, adding
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107421#comment-17107421
]
Haisheng Yuan commented on CALCITE-3997:
PR: https://github.com/apache/calcite/pull/1976
Test
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107352#comment-17107352
]
Haisheng Yuan commented on CALCITE-3997:
I am able to reproduce the issue now.
> Problem with
[
https://issues.apache.org/jira/browse/CALCITE-3996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107280#comment-17107280
]
Danny Chen commented on CALCITE-3996:
-
Thanks for reporting this [~levv], can you give a test case
[
https://issues.apache.org/jira/browse/CALCITE-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107279#comment-17107279
]
Danny Chen commented on CALCITE-4001:
-
I'm curious how you get the SqlNode for expression "cast(id
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107260#comment-17107260
]
Enrico Olivelli commented on CALCITE-3997:
--
[~hyuan]
I have removed that rules
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107260#comment-17107260
]
Enrico Olivelli edited comment on CALCITE-3997 at 5/14/20, 12:34 PM:
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Enrico Olivelli resolved CALCITE-3998.
--
Resolution: Not A Problem
> Bad datatype for sum(n), it should be BIGINT but it is
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107254#comment-17107254
]
Enrico Olivelli commented on CALCITE-3998:
--
In this case Calcite looks very smart !
As K1 is
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107188#comment-17107188
]
TANG Wen-hui edited comment on CALCITE-3998 at 5/14/20, 10:43 AM:
--
See
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107188#comment-17107188
]
TANG Wen-hui commented on CALCITE-3998:
---
See
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107187#comment-17107187
]
TANG Wen-hui commented on CALCITE-3998:
---
[~eolivelli] I guess that it is releated with
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107167#comment-17107167
]
Enrico Olivelli commented on CALCITE-3998:
--
[~winipanda]
I have run the tests adding
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107159#comment-17107159
]
Enrico Olivelli commented on CALCITE-3998:
--
[~winipanda]
the only difference between master
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107150#comment-17107150
]
TANG Wen-hui commented on CALCITE-3998:
---
I found that the result of Sum(n1) returns Long type
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107141#comment-17107141
]
Enrico Olivelli edited comment on CALCITE-3998 at 5/14/20, 9:37 AM:
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107141#comment-17107141
]
Enrico Olivelli commented on CALCITE-3998:
--
[~winipanda] thank you for debugging.
Do you see
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107134#comment-17107134
]
TANG Wen-hui commented on CALCITE-3998:
---
I debugged on the master branch which use calcite-1.22.
[
https://issues.apache.org/jira/browse/CALCITE-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107108#comment-17107108
]
Wang Yanlin commented on CALCITE-4001:
--
May be add
{noformat}
public void unparseType(SqlWriter
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TANG Wen-hui updated CALCITE-3998:
--
Attachment: image-2020-05-14-17-12-11-277.png
> Bad datatype for sum(n), it should be BIGINT
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TANG Wen-hui updated CALCITE-3998:
--
Attachment: image-2020-05-14-17-07-49-157.png
> Bad datatype for sum(n), it should be BIGINT
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107062#comment-17107062
]
Enrico Olivelli commented on CALCITE-3998:
--
{quote}
I'm curious. why the return type of
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TANG Wen-hui updated CALCITE-3998:
--
Attachment: image-2020-05-14-16-15-59-907.png
> Bad datatype for sum(n), it should be BIGINT
[
https://issues.apache.org/jira/browse/CALCITE-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zoltan Haindrich resolved CALCITE-3979.
---
Resolution: Fixed
Thank you all!
fixed in
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107020#comment-17107020
]
TANG Wen-hui edited comment on CALCITE-3998 at 5/14/20, 7:51 AM:
-
I'm
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107032#comment-17107032
]
Enrico Olivelli commented on CALCITE-3998:
--
The test is failing here
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107029#comment-17107029
]
Enrico Olivelli commented on CALCITE-3998:
--
[~winipanda] thank you so much
In the pom.xml we
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107020#comment-17107020
]
TANG Wen-hui commented on CALCITE-3998:
---
I'm not sure if I'm wrong, but I debug the test on
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TANG Wen-hui updated CALCITE-3998:
--
Attachment: image-2020-05-14-15-39-28-279.png
> Bad datatype for sum(n), it should be BIGINT
[
https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TANG Wen-hui updated CALCITE-3998:
--
Attachment: image-2020-05-14-15-37-14-571.png
> Bad datatype for sum(n), it should be BIGINT
[
https://issues.apache.org/jira/browse/CALCITE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107003#comment-17107003
]
Ruben Q L commented on CALCITE-3977:
Thanks [~zabetak], what you say makes sense. I will give the
[
https://issues.apache.org/jira/browse/CALCITE-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106971#comment-17106971
]
Viliam Durina commented on CALCITE-3970:
I didn't plan to do a PR.
> Table-valued function
[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106960#comment-17106960
]
Viliam Durina commented on CALCITE-4000:
There's no offset for SESSION.
> Support OFFSET
[
https://issues.apache.org/jira/browse/CALCITE-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xurenhe updated CALCITE-4001:
-
Description:
SqlBasicTypeNameSpec cannot cover all data types of other sql's engine, when
doing
Xurenhe created CALCITE-4001:
Summary: Should support dialect when unparsing SqlDataTypeSpec
Key: CALCITE-4001
URL: https://issues.apache.org/jira/browse/CALCITE-4001
Project: Calcite
Issue
[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Wang updated CALCITE-4000:
--
Description:
TUMBLE/HOP/SESSION have an optional "OFFSET" parameter to indicate how many
time off
[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Wang updated CALCITE-4000:
--
Summary: Support OFFSET parameter in TUMBLE/HOP/SESSION table functions
(was: Support the offset
Rui Wang created CALCITE-4000:
-
Summary: Support the offset parameters for TUMBLE/HOP/SESSION
table functions
Key: CALCITE-4000
URL: https://issues.apache.org/jira/browse/CALCITE-4000
Project: Calcite
67 matches
Mail list logo