[jira] [Updated] (CALCITE-4070) Add benchmark test for new Digest interface

2020-07-08 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4070: - Fix Version/s: (was: 1.24.0) > Add benchmark test for new Digest interface >

[jira] [Commented] (CALCITE-4112) Better judgment "config.forceDecorrelate" in DecorrelateProgram

2020-07-08 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154157#comment-17154157 ] Jiatao Tao commented on CALCITE-4112: - Hi [~julianhyde] I see an example like you said,

[jira] [Commented] (CALCITE-4108) ClassCastException: java.lang.Float cannot be cast to java.lang.Double

2020-07-08 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154150#comment-17154150 ] Feng Zhu commented on CALCITE-4108: --- How about *tp.o*'s type? I failed to reproduce it in my local

[jira] [Assigned] (CALCITE-4108) ClassCastException: java.lang.Float cannot be cast to java.lang.Double

2020-07-08 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu reassigned CALCITE-4108: - Assignee: Feng Zhu > ClassCastException: java.lang.Float cannot be cast to java.lang.Double >

[jira] [Commented] (CALCITE-4112) Better judgment "config.forceDecorrelate" in DecorrelateProgram

2020-07-08 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154147#comment-17154147 ] Jiatao Tao commented on CALCITE-4112: - CalciteConnectionConfig is an interface, should I new a 

[jira] [Resolved] (CALCITE-4107) Flink need result of method `allowsFraming` in `org.apache.calcite.sql.SqlRankFunction` to be true

2020-07-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-4107. -- Resolution: Not A Problem Yes, also the SQL standard: {{6.10 Rule 6a RANK & DENSE_RANK do

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-07-08 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154135#comment-17154135 ] Danny Chen commented on CALCITE-3786: - I'm afraid this is a mistake, i meant to change them all to

[jira] [Commented] (CALCITE-3840) Re-aliasing of VALUES that has column aliases produces wrong SQL in the JDBC adapter

2020-07-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154133#comment-17154133 ] Julian Hyde commented on CALCITE-3840: -- Yes please. That's what we do. It makes it easier for

[jira] [Commented] (CALCITE-4112) Better judgment "config.forceDecorrelate" in DecorrelateProgram

2020-07-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154118#comment-17154118 ] Julian Hyde commented on CALCITE-4112: -- Simplest thing would be to use a default config if the

[jira] [Updated] (CALCITE-3923) Refactor how planner rules are parameterized

2020-07-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-3923: Labels: pull-request-available (was: ) > Refactor how planner rules are parameterized >

[jira] [Updated] (CALCITE-4105) Replace Pair with Flat2List in RelDigestWriter to improve hash code distribution

2020-07-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-4105: Labels: pull-request-available (was: ) > Replace Pair with Flat2List in RelDigestWriter

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-07-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154096#comment-17154096 ] Julian Hyde commented on CALCITE-3786: -- [~danny0405], In this change, you marked

[jira] [Commented] (CALCITE-4079) Dialect constants in SqlDialect can cause class initialization deadlock

2020-07-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154070#comment-17154070 ] Julian Hyde commented on CALCITE-4079: -- I've assigned this case to myself. I'm going to fix it

[jira] [Updated] (CALCITE-3923) Refactor how planner rules are parameterized

2020-07-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-3923: - Fix Version/s: 1.25.0 > Refactor how planner rules are parameterized >

[jira] [Updated] (CALCITE-3923) Refactor how planner rules are parameterized

2020-07-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-3923: - Fix Version/s: (was: 1.24.0) > Refactor how planner rules are parameterized >

[jira] [Updated] (CALCITE-4079) Dialect constants in SqlDialect can cause class initialization deadlock

2020-07-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-4079: - Fix Version/s: 1.25.0 > Dialect constants in SqlDialect can cause class initialization

[jira] [Assigned] (CALCITE-4079) Dialect constants in SqlDialect can cause class initialization deadlock

2020-07-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde reassigned CALCITE-4079: Assignee: Julian Hyde > Dialect constants in SqlDialect can cause class initialization

[jira] [Commented] (CALCITE-4027) Add -Doverwrite option to SqlToRelTestBase

2020-07-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153860#comment-17153860 ] Julian Hyde commented on CALCITE-4027: -- Reviewing the PR again: * Don't swallow the IOException.

[jira] [Comment Edited] (CALCITE-4094) Allow SqlOperator of SqlKind#OTHER_FUNCTION to define a Strong.Policy

2020-07-08 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153656#comment-17153656 ] Ruben Q L edited comment on CALCITE-4094 at 7/8/20, 3:40 PM: - [~danny0405],

[jira] [Created] (CALCITE-4113) Support LEFT join in EnumerableMergeJoin

2020-07-08 Thread Ruben Q L (Jira)
Ruben Q L created CALCITE-4113: -- Summary: Support LEFT join in EnumerableMergeJoin Key: CALCITE-4113 URL: https://issues.apache.org/jira/browse/CALCITE-4113 Project: Calcite Issue Type: New

[jira] [Resolved] (CALCITE-3834) Support AntiJoin in EnumerableMergeJoin

2020-07-08 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Q L resolved CALCITE-3834. Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-4094) Allow SqlOperator of SqlKind#OTHER_FUNCTION to define a Strong.Policy

2020-07-08 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153656#comment-17153656 ] Ruben Q L commented on CALCITE-4094: [~danny0405], I have update the PR with your suggestions,

[jira] [Comment Edited] (CALCITE-4112) Better judgment "config.forceDecorrelate" in DecorrelateProgram

2020-07-08 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153547#comment-17153547 ] Jiatao Tao edited comment on CALCITE-4112 at 7/8/20, 12:27 PM: --- Hi

[jira] [Comment Edited] (CALCITE-4112) Better judgment "config.forceDecorrelate" in DecorrelateProgram

2020-07-08 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153547#comment-17153547 ] Jiatao Tao edited comment on CALCITE-4112 at 7/8/20, 12:20 PM: --- Hi

[jira] [Comment Edited] (CALCITE-4112) Better judgment "config.forceDecorrelate" in DecorrelateProgram

2020-07-08 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153547#comment-17153547 ] Jiatao Tao edited comment on CALCITE-4112 at 7/8/20, 12:20 PM: --- Hi

[jira] [Comment Edited] (CALCITE-4112) Better judgment "config.forceDecorrelate" in DecorrelateProgram

2020-07-08 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153547#comment-17153547 ] Jiatao Tao edited comment on CALCITE-4112 at 7/8/20, 12:18 PM: --- Hi

[jira] [Commented] (CALCITE-4112) Better judgment "config.forceDecorrelate" in DecorrelateProgram

2020-07-08 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153547#comment-17153547 ] Jiatao Tao commented on CALCITE-4112: - Hi [~julianhyde] Here's the background, we new

[jira] [Comment Edited] (CALCITE-4094) Allow SqlOperator of SqlKind#OTHER_FUNCTION to define a Strong.Policy

2020-07-08 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153541#comment-17153541 ] Ruben Q L edited comment on CALCITE-4094 at 7/8/20, 12:09 PM: --

[jira] [Commented] (CALCITE-4094) Allow SqlOperator of SqlKind#OTHER_FUNCTION to define a Strong.Policy

2020-07-08 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153541#comment-17153541 ] Ruben Q L commented on CALCITE-4094: Unfortunately, it is not that simple, since

[jira] [Created] (CALCITE-4112) Better judgment "config.forceDecorrelate" in DecorrelateProgram

2020-07-08 Thread Jiatao Tao (Jira)
Jiatao Tao created CALCITE-4112: --- Summary: Better judgment "config.forceDecorrelate" in DecorrelateProgram Key: CALCITE-4112 URL: https://issues.apache.org/jira/browse/CALCITE-4112 Project: Calcite

[jira] [Commented] (CALCITE-4094) Allow SqlOperator of SqlKind#OTHER_FUNCTION to define a Strong.Policy

2020-07-08 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153511#comment-17153511 ] Danny Chen commented on CALCITE-4094: - How about make a RexCall in the test, usually we do not add

[jira] [Commented] (CALCITE-4094) Allow SqlOperator of SqlKind#OTHER_FUNCTION to define a Strong.Policy

2020-07-08 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153474#comment-17153474 ] Ruben Q L commented on CALCITE-4094: Thanks for the feedback [~danny0405]. I agree about renaming

[jira] [Comment Edited] (CALCITE-4108) ClassCastException: java.lang.Float cannot be cast to java.lang.Double

2020-07-08 Thread Roman Churganov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153360#comment-17153360 ] Roman Churganov edited comment on CALCITE-4108 at 7/8/20, 8:47 AM: ---

[jira] [Comment Edited] (CALCITE-4108) ClassCastException: java.lang.Float cannot be cast to java.lang.Double

2020-07-08 Thread Roman Churganov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153360#comment-17153360 ] Roman Churganov edited comment on CALCITE-4108 at 7/8/20, 8:46 AM: ---

[jira] [Commented] (CALCITE-4108) ClassCastException: java.lang.Float cannot be cast to java.lang.Double

2020-07-08 Thread Roman Churganov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153360#comment-17153360 ] Roman Churganov commented on CALCITE-4108: -- tp.n in Schema is FLOAT, the value returned from

[jira] [Commented] (CALCITE-4094) Allow SqlOperator of SqlKind#OTHER_FUNCTION to define a Strong.Policy

2020-07-08 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153317#comment-17153317 ] Danny Chen commented on CALCITE-4094: - Based on current code, adding one interface {{Policy