[jira] [Commented] (CALCITE-4568) Tempura: extending Calcite into an incremental query optimizer

2022-07-15 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567115#comment-17567115 ] Botong Huang commented on CALCITE-4568: --- Hi [~julianhyde], a gentle reminder for this thread.

[jira] [Comment Edited] (CALCITE-4568) Tempura: extending Calcite into an incremental query optimizer

2022-01-19 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478613#comment-17478613 ] Botong Huang edited comment on CALCITE-4568 at 1/19/22, 11:53 AM: --

[jira] [Commented] (CALCITE-4568) Tempura: extending Calcite into an incremental query optimizer

2022-01-19 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478613#comment-17478613 ] Botong Huang commented on CALCITE-4568: --- [~Leo Zhou] yes, it will probably take some time to

[jira] [Commented] (CALCITE-4737) Add Volcano visualizer for debugging

2021-09-17 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17417002#comment-17417002 ] Botong Huang commented on CALCITE-4737: --- [~zuozhiw] and [~thomas.rebele], any updates? Please let

[jira] [Commented] (CALCITE-4737) Add Volcano visualizer for debugging

2021-08-14 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17399232#comment-17399232 ] Botong Huang commented on CALCITE-4737: --- Sounds good. We will work with [~thomas.rebele] to come

[jira] [Comment Edited] (CALCITE-4737) Add Volcano visualizer for debugging

2021-08-13 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17398858#comment-17398858 ] Botong Huang edited comment on CALCITE-4737 at 8/13/21, 6:43 PM: - Yes,

[jira] [Commented] (CALCITE-4737) Add Volcano visualizer for debugging

2021-08-13 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17398858#comment-17398858 ] Botong Huang commented on CALCITE-4737: --- [link title|http://example.com]Yes, the current

[jira] [Commented] (CALCITE-4568) Tempura: extending Calcite into an incremental query optimizer

2021-08-11 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397799#comment-17397799 ] Botong Huang commented on CALCITE-4568: --- Sounds good and please take your time. Our team will be

[jira] [Commented] (CALCITE-4568) Tempura: extending Calcite into an incremental query optimizer

2021-08-07 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395112#comment-17395112 ] Botong Huang commented on CALCITE-4568: --- (copied from dev email) Hi all, Please find our

[jira] [Commented] (CALCITE-4568) Tempura: extending Calcite into an incremental query optimizer

2021-05-17 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346265#comment-17346265 ] Botong Huang commented on CALCITE-4568: --- Hi Rui, the current version is runnable but we did not

[jira] [Comment Edited] (CALCITE-4568) Tempura: extending Calcite into an incremental query optimizer

2021-05-14 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344955#comment-17344955 ] Botong Huang edited comment on CALCITE-4568 at 5/15/21, 3:11 AM: -

[jira] [Commented] (CALCITE-4568) Tempura: extending Calcite into an incremental query optimizer

2021-05-14 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344955#comment-17344955 ] Botong Huang commented on CALCITE-4568: --- Please find the slides introducing Tempura here:

[jira] [Updated] (CALCITE-4568) Tempura: extending Calcite into an incremental query optimizer

2021-04-07 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Botong Huang updated CALCITE-4568: -- Summary: Tempura: extending Calcite into an incremental query optimizer (was: Tempura:

[jira] [Created] (CALCITE-4568) Tempura: extending Calcite into a incremental query optimizer

2021-04-07 Thread Botong Huang (Jira)
Botong Huang created CALCITE-4568: - Summary: Tempura: extending Calcite into a incremental query optimizer Key: CALCITE-4568 URL: https://issues.apache.org/jira/browse/CALCITE-4568 Project: Calcite

[jira] [Commented] (CALCITE-4514) [CALCITE-4514] Fine tune the merge order of two RelSets

2021-03-01 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293313#comment-17293313 ] Botong Huang commented on CALCITE-4514: --- Hi [~danny0405], openning a new Jira for it might be an

[jira] [Comment Edited] (CALCITE-4514) [CALCITE-4514] Fine tune the merge order of two RelSets

2021-03-01 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293313#comment-17293313 ] Botong Huang edited comment on CALCITE-4514 at 3/2/21, 3:12 AM: Hi

[jira] [Commented] (CALCITE-4514) [CALCITE-4514] Fine tune the merge order of two RelSets

2021-02-28 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292624#comment-17292624 ] Botong Huang commented on CALCITE-4514: --- Looks good to me, thanks! > [CALCITE-4514] Fine tune

[jira] [Commented] (CALCITE-4514) [CALCITE-4514] Fine tune the merge order of two RelSets

2021-02-28 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292537#comment-17292537 ] Botong Huang commented on CALCITE-4514: --- Hi [~julianhyde], I just noticed some minor issues. For

[jira] [Commented] (CALCITE-4514) [CALCITE-4514] Fine tune the merge order of two RelSets

2021-02-28 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292465#comment-17292465 ] Botong Huang commented on CALCITE-4514: --- Sounds good to me, thx! > [CALCITE-4514] Fine tune the

[jira] [Commented] (CALCITE-4514) [CALCITE-4514] Fine tune the merge order of two RelSets

2021-02-27 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292302#comment-17292302 ] Botong Huang commented on CALCITE-4514: --- Hi [~julianhyde], thanks! Your patch is almost the same

[jira] [Commented] (CALCITE-4514) [CALCITE-4514] Fine tune the merge order of two RelSets

2021-02-27 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292270#comment-17292270 ] Botong Huang commented on CALCITE-4514: --- Oh I see, updated patch back to the compute from

[jira] [Updated] (CALCITE-4514) [CALCITE-4514] Fine tune the merge order of two RelSets

2021-02-27 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Botong Huang updated CALCITE-4514: -- Summary: [CALCITE-4514] Fine tune the merge order of two RelSets (was: Fine tune the merge

[jira] [Commented] (CALCITE-4514) Fine tune the merge order of two RelSets, cache RelSet's childSet computation

2021-02-27 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292265#comment-17292265 ] Botong Huang commented on CALCITE-4514: --- Hi [~vladimirsitnikov] {quote}Is it really needed to

[jira] [Commented] (CALCITE-4514) Fine tune the merge order of two RelSets, cache RelSet's childSet computation

2021-02-27 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292245#comment-17292245 ] Botong Huang commented on CALCITE-4514: --- getChildSets is now changed to compute and maintain on

[jira] [Commented] (CALCITE-4514) Prefer merge new relset into old relset when they are parent set of each other

2021-02-26 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292007#comment-17292007 ] Botong Huang commented on CALCITE-4514: --- Hi Julian, thanks for the comments. I believe I've

[jira] [Updated] (CALCITE-4514) Fine tune the merge order of two RelSets, cache RelSet's childSet computation

2021-02-26 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Botong Huang updated CALCITE-4514: -- Summary: Fine tune the merge order of two RelSets, cache RelSet's childSet computation

[jira] [Commented] (CALCITE-4514) Prefer merge new relset into old relset when they are parent set of each other

2021-02-26 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291869#comment-17291869 ] Botong Huang commented on CALCITE-4514: --- Hi Vladimir, yes, you are right. Both preferences are

[jira] [Created] (CALCITE-4514) Prefer merge new relset into old relset when they are parent set of each other

2021-02-25 Thread Botong Huang (Jira)
Botong Huang created CALCITE-4514: - Summary: Prefer merge new relset into old relset when they are parent set of each other Key: CALCITE-4514 URL: https://issues.apache.org/jira/browse/CALCITE-4514

[jira] [Commented] (CALCITE-4302) Improve cost propagation in volcano to avoid re-propagation

2020-11-02 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225047#comment-17225047 ] Botong Huang commented on CALCITE-4302: --- Yes I agree. We can handle null in Volcano if needed by

[jira] [Commented] (CALCITE-4302) Improve cost propagation in volcano to avoid re-propagation

2020-11-02 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224996#comment-17224996 ] Botong Huang commented on CALCITE-4302: --- Hi [~vladimirsitnikov], thanks for letting us know, this

[jira] [Created] (CALCITE-4302) Improve cost propagation in volcano to avoid re-propagation

2020-10-02 Thread Botong Huang (Jira)
Botong Huang created CALCITE-4302: - Summary: Improve cost propagation in volcano to avoid re-propagation Key: CALCITE-4302 URL: https://issues.apache.org/jira/browse/CALCITE-4302 Project: Calcite

[jira] [Updated] (CALCITE-3991) The required boolean should always be provided in RelSet.getOrCreateSubset()

2020-06-03 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Botong Huang updated CALCITE-3991: -- Summary: The required boolean should always be provided in RelSet.getOrCreateSubset() (was:

[jira] [Commented] (CALCITE-3981) Volcano.register should not return stale/merged subset

2020-06-03 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125322#comment-17125322 ] Botong Huang commented on CALCITE-3981: --- Thanks [~julianhyde] and [~hyuan] for the review! >

[jira] [Commented] (CALCITE-4029) ProjectRemoveRule auto pruning may prevent rules from running if mixed conventions are used in a logical plan

2020-06-02 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124143#comment-17124143 ] Botong Huang commented on CALCITE-4029: --- Exactly, closing this Jira. > ProjectRemoveRule auto

[jira] [Commented] (CALCITE-4029) ProjectRemoveRule auto pruning may prevent rules from running if mixed conventions are used in a logical plan

2020-06-01 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120768#comment-17120768 ] Botong Huang commented on CALCITE-4029: --- This hack I proposed indeed won't work. {quote} If you

[jira] [Commented] (CALCITE-3939) Change UnionEliminatorRule and ProjectRemoveRule to auto pruning SubstitutionRule

2020-05-29 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119765#comment-17119765 ] Botong Huang commented on CALCITE-3939: --- [~anha] Understood (we are on the same page for Step 2).

[jira] [Commented] (CALCITE-3939) Change UnionEliminatorRule and ProjectRemoveRule to auto pruning SubstitutionRule

2020-05-28 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118941#comment-17118941 ] Botong Huang commented on CALCITE-3939: --- Thanks [~anha] for reporting the issue. However, as

[jira] [Created] (CALCITE-3991) the required boolean should always be provided in RelSet.getOrCreateSubset()

2020-05-11 Thread Botong Huang (Jira)
Botong Huang created CALCITE-3991: - Summary: the required boolean should always be provided in RelSet.getOrCreateSubset() Key: CALCITE-3991 URL: https://issues.apache.org/jira/browse/CALCITE-3991

[jira] [Commented] (CALCITE-3961) VolcanoPlanner.prunedNodes information is lost when duplicate relNode is discarded

2020-05-09 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103628#comment-17103628 ] Botong Huang commented on CALCITE-3961: --- Thanks [~hyuan] for the review! >

[jira] [Updated] (CALCITE-3981) Volcano.register should not return stale/merged subset

2020-05-08 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Botong Huang updated CALCITE-3981: -- Description: When a subset is registered, registerImpl() and registerSubset() currently

[jira] [Updated] (CALCITE-3981) Volcano.register should not return stale/merged subset

2020-05-08 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Botong Huang updated CALCITE-3981: -- Description: When a subset is registered, registerImpl() and registerSubset() currently

[jira] [Updated] (CALCITE-3981) Volcano.register should not return stale/merged subset

2020-05-08 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Botong Huang updated CALCITE-3981: -- Description: When a subset is registered, registerImpl() and registerSubset() currently

[jira] [Updated] (CALCITE-3981) Volcano.register should not return stale/merged subset

2020-05-08 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Botong Huang updated CALCITE-3981: -- Description: When a subset is registered, registerImpl() and registerSubset() currently

[jira] [Updated] (CALCITE-3981) Volcano.register should not return stale/merged subset

2020-05-08 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Botong Huang updated CALCITE-3981: -- Description: When a subset is registered, registerImpl() and registerSubset() currently

[jira] [Created] (CALCITE-3981) Volcano.register should not return stale/merged subset

2020-05-08 Thread Botong Huang (Jira)
Botong Huang created CALCITE-3981: - Summary: Volcano.register should not return stale/merged subset Key: CALCITE-3981 URL: https://issues.apache.org/jira/browse/CALCITE-3981 Project: Calcite

[jira] [Commented] (CALCITE-3947) AbstractRelOptPlanner.classes should be LinkedHashSet so that rule match order is deterministic across runs

2020-04-27 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093848#comment-17093848 ] Botong Huang commented on CALCITE-3947: --- Thanks [~julianhyde] for the detailed comment! Let me

[jira] [Created] (CALCITE-3961) VolcanoPlanner.prunedNodes information is lost when duplicate relNode is discarded

2020-04-26 Thread Botong Huang (Jira)
Botong Huang created CALCITE-3961: - Summary: VolcanoPlanner.prunedNodes information is lost when duplicate relNode is discarded Key: CALCITE-3961 URL: https://issues.apache.org/jira/browse/CALCITE-3961

[jira] [Commented] (CALCITE-3948) Improve operand's RelSubset matching handling in VolcanoRuleCall

2020-04-22 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090103#comment-17090103 ] Botong Huang commented on CALCITE-3948: --- Thanks [~hyuan] for the review! > Improve operand's

[jira] [Commented] (CALCITE-3947) AbstractRelOptPlanner.classes should be LinkedHashSet so that rule match order is deterministic across runs

2020-04-21 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089093#comment-17089093 ] Botong Huang commented on CALCITE-3947: --- Thanks [~hyuan] and [~julianhyde] for the quick review!

[jira] [Commented] (CALCITE-3947) AbstractRelOptPlanner.classes should be LinkedHashSet so that rule match order is deterministic across runs

2020-04-21 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089083#comment-17089083 ] Botong Huang commented on CALCITE-3947: --- Yes it will. Since the iteration order changes across

[jira] [Created] (CALCITE-3948) Improve operand's RelSubset matching handling in VolcanoRuleCall

2020-04-21 Thread Botong Huang (Jira)
Botong Huang created CALCITE-3948: - Summary: Improve operand's RelSubset matching handling in VolcanoRuleCall Key: CALCITE-3948 URL: https://issues.apache.org/jira/browse/CALCITE-3948 Project:

[jira] [Created] (CALCITE-3947) AbstractRelOptPlanner.classes should be LinkedHashSet so that rule match order is deterministic across runs

2020-04-21 Thread Botong Huang (Jira)
Botong Huang created CALCITE-3947: - Summary: AbstractRelOptPlanner.classes should be LinkedHashSet so that rule match order is deterministic across runs Key: CALCITE-3947 URL:

[jira] [Commented] (CALCITE-3927) RelSubset is not fired for rule when set gets merged

2020-04-21 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088982#comment-17088982 ] Botong Huang commented on CALCITE-3927: --- Thanks [~hyuan] and everyone for the review and

[jira] [Comment Edited] (CALCITE-3927) RelSubset is not fired for rule when set gets merged

2020-04-21 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088895#comment-17088895 ] Botong Huang edited comment on CALCITE-3927 at 4/21/20, 5:35 PM: - The

[jira] [Commented] (CALCITE-3927) RelSubset is not fired for rule when set gets merged

2020-04-21 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088895#comment-17088895 ] Botong Huang commented on CALCITE-3927: --- The unit test gives an example of what can happen in

[jira] [Commented] (CALCITE-3939) Change UnionEliminatorRule and ProjectRemoveRule to auto pruning SubstitutionRule

2020-04-20 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087987#comment-17087987 ] Botong Huang commented on CALCITE-3939: --- Title changed, please let me know if it is clearer, thx!

[jira] [Updated] (CALCITE-3939) Change UnionEliminatorRule and ProjectRemoveRule to auto pruning SubstitutionRule

2020-04-20 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Botong Huang updated CALCITE-3939: -- Summary: Change UnionEliminatorRule and ProjectRemoveRule to auto pruning SubstitutionRule

[jira] [Created] (CALCITE-3939) more auto pruning rules after SubstitutionRule is introduced

2020-04-19 Thread Botong Huang (Jira)
Botong Huang created CALCITE-3939: - Summary: more auto pruning rules after SubstitutionRule is introduced Key: CALCITE-3939 URL: https://issues.apache.org/jira/browse/CALCITE-3939 Project: Calcite

[jira] [Created] (CALCITE-3227) IndexOutOfBound when checking candidate parent match's input ordinal in VolcanoRuleCall

2019-08-03 Thread Botong Huang (JIRA)
Botong Huang created CALCITE-3227: - Summary: IndexOutOfBound when checking candidate parent match's input ordinal in VolcanoRuleCall Key: CALCITE-3227 URL: https://issues.apache.org/jira/browse/CALCITE-3227

[jira] [Updated] (CALCITE-3118) VolcanoRuleCall should look at RelSubset rather than RelSet when checking child ordinal of a parent operand

2019-07-21 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Botong Huang updated CALCITE-3118: -- Summary: VolcanoRuleCall should look at RelSubset rather than RelSet when checking child

[jira] [Updated] (CALCITE-3118) Properly check child ordinal when matching parent operand in VolcanoRuleCall

2019-07-21 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Botong Huang updated CALCITE-3118: -- Summary: Properly check child ordinal when matching parent operand in VolcanoRuleCall (was:

[jira] [Updated] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-08 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Botong Huang updated CALCITE-3118: -- Description: In VolcanoRuleCall.matchRecurse(), when ascending (child operand is matched,

[jira] [Updated] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-08 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Botong Huang updated CALCITE-3118: -- Description: In VolcanoRuleCall.matchRecurse(), when ascending (child operand is matched,

[jira] [Comment Edited] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-08 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859312#comment-16859312 ] Botong Huang edited comment on CALCITE-3118 at 6/8/19 9:29 PM: --- {quote}

[jira] [Commented] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-08 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859312#comment-16859312 ] Botong Huang commented on CALCITE-3118: --- {quote} Firstly you construct a RelNode tree like what

[jira] [Comment Edited] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-07 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858693#comment-16858693 ] Botong Huang edited comment on CALCITE-3118 at 6/8/19 4:13 AM: --- {quote}It

[jira] [Updated] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-07 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Botong Huang updated CALCITE-3118: -- Description: In VolcanoRuleCall.matchRecurse(), when ascending (child operand is matched,

[jira] [Commented] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-07 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858699#comment-16858699 ] Botong Huang commented on CALCITE-3118: --- bq. Or it might happen you could rewrite the test-case

[jira] [Comment Edited] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-07 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858178#comment-16858178 ] Botong Huang edited comment on CALCITE-3118 at 6/7/19 2:24 PM: --- Agree in

[jira] [Comment Edited] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-07 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858693#comment-16858693 ] Botong Huang edited comment on CALCITE-3118 at 6/7/19 2:20 PM: --- {quote}It

[jira] [Comment Edited] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-07 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858693#comment-16858693 ] Botong Huang edited comment on CALCITE-3118 at 6/7/19 2:19 PM: --- {quote}It

[jira] [Commented] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-07 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858693#comment-16858693 ] Botong Huang commented on CALCITE-3118: ---  bq. It is not wrong provided the children are identical

[jira] [Comment Edited] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-07 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858653#comment-16858653 ] Botong Huang edited comment on CALCITE-3118 at 6/7/19 1:39 PM: --- Thanks

[jira] [Comment Edited] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-07 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858053#comment-16858053 ] Botong Huang edited comment on CALCITE-3118 at 6/7/19 1:38 PM: --- Sure,

[jira] [Comment Edited] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-07 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858053#comment-16858053 ] Botong Huang edited comment on CALCITE-3118 at 6/7/19 1:39 PM: --- Sure,

[jira] [Commented] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-07 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858653#comment-16858653 ] Botong Huang commented on CALCITE-3118: --- Thanks [~danny0405] for reviewing! Having two relNodes

[jira] [Comment Edited] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-07 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858178#comment-16858178 ] Botong Huang edited comment on CALCITE-3118 at 6/7/19 1:27 PM: --- Agree in

[jira] [Comment Edited] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-06 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858178#comment-16858178 ] Botong Huang edited comment on CALCITE-3118 at 6/6/19 11:29 PM: Agree

[jira] [Commented] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-06 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858178#comment-16858178 ] Botong Huang commented on CALCITE-3118: --- Agree in general. But in this test case, the rule

[jira] [Commented] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-06 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858053#comment-16858053 ] Botong Huang commented on CALCITE-3118: --- Sure, supposedly this rule should only match once, with

[jira] [Commented] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-06 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858038#comment-16858038 ] Botong Huang commented on CALCITE-3118: --- New version pushed, can you take another look and see if

[jira] [Commented] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-06 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858020#comment-16858020 ] Botong Huang commented on CALCITE-3118: --- Sure, let me try make the unit test more readable. On a

[jira] [Comment Edited] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-06 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857997#comment-16857997 ] Botong Huang edited comment on CALCITE-3118 at 6/6/19 7:08 PM: --- Thanks

[jira] [Commented] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-06 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857997#comment-16857997 ] Botong Huang commented on CALCITE-3118: --- Thanks [~vladimirsitnikov] for reviewing. The real check

[jira] [Created] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-06 Thread Botong Huang (JIRA)
Botong Huang created CALCITE-3118: - Summary: VolcanoRuleCall match parent child ordinal not properly checked Key: CALCITE-3118 URL: https://issues.apache.org/jira/browse/CALCITE-3118 Project: Calcite