[jira] [Commented] (CALCITE-4607) F481 support

2021-05-17 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346109#comment-17346109 ] Zhen Wang commented on CALCITE-4607: this syntax looks interesting, could you expand a little

[jira] [Commented] (CALCITE-4349) Support GROUP_CONCAT aggregate function for MySQL

2021-01-15 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265855#comment-17265855 ] Zhen Wang commented on CALCITE-4349: [~julianhyde] updated and addressed review comments > Support

[jira] [Commented] (CALCITE-4349) Support GROUP_CONCAT aggregate function for MySQL

2021-01-14 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264727#comment-17264727 ] Zhen Wang commented on CALCITE-4349: well, I did notice allowsSeparator is causing too much

[jira] [Commented] (CALCITE-4349) Support GROUP_CONCAT aggregate function for MySQL

2021-01-04 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258620#comment-17258620 ] Zhen Wang commented on CALCITE-4349: right, I think I've squashed the commit too early to leave

[jira] [Commented] (CALCITE-4434) Cannot implement 'CASE row WHEN row ...'

2021-01-04 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258619#comment-17258619 ] Zhen Wang commented on CALCITE-4434: [~amaliujia] this is the latest commit message "[CALCITE-4434]

[jira] [Comment Edited] (CALCITE-4349) Support GROUP_CONCAT aggregate function for MySQL

2021-01-03 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257665#comment-17257665 ] Zhen Wang edited comment on CALCITE-4349 at 1/3/21, 9:21 AM: - from my

[jira] [Commented] (CALCITE-4349) Support GROUP_CONCAT aggregate function for MySQL

2021-01-03 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257696#comment-17257696 ] Zhen Wang commented on CALCITE-4349: {code:sql} select listagg(deptno, ename, ";") within

[jira] [Comment Edited] (CALCITE-4349) Support GROUP_CONCAT aggregate function for MySQL

2021-01-02 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257665#comment-17257665 ] Zhen Wang edited comment on CALCITE-4349 at 1/3/21, 6:57 AM: - from my

[jira] [Commented] (CALCITE-4349) Support GROUP_CONCAT aggregate function for MySQL

2021-01-02 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257665#comment-17257665 ] Zhen Wang commented on CALCITE-4349: from my experiment, group_concat in mysql context does support

[jira] [Assigned] (CALCITE-4349) Support GROUP_CONCAT aggregate function for MySQL

2020-12-31 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhen Wang reassigned CALCITE-4349: -- Assignee: Zhen Wang > Support GROUP_CONCAT aggregate function for MySQL >

[jira] [Commented] (CALCITE-4349) Support GROUP_CONCAT aggregate function for MySQL

2020-12-31 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257132#comment-17257132 ] Zhen Wang commented on CALCITE-4349: need some comments on the PR, thanks > Support GROUP_CONCAT

[jira] [Commented] (CALCITE-4349) Support GROUP_CONCAT aggregate function for MySQL

2020-12-30 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256837#comment-17256837 ] Zhen Wang commented on CALCITE-4349: want some discussion here, the overall implementation would be

[jira] [Comment Edited] (CALCITE-4434) Cannot implement 'CASE row WHEN row ...'

2020-12-28 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255759#comment-17255759 ] Zhen Wang edited comment on CALCITE-4434 at 12/29/20, 1:08 AM: ---

[jira] [Commented] (CALCITE-4434) Cannot implement 'CASE row WHEN row ...'

2020-12-28 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255759#comment-17255759 ] Zhen Wang commented on CALCITE-4434: [~julianhyde] I closed the previous and opened another. and

[jira] [Commented] (CALCITE-4434) Cannot implement 'CASE row WHEN row ...'

2020-12-16 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250211#comment-17250211 ] Zhen Wang commented on CALCITE-4434: {code:java} ARRAY(PrecScale.NO_NO, false, Types.ARRAY,

[jira] [Commented] (CALCITE-4434) Cannot implement 'CASE row WHEN row ...'

2020-12-16 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250203#comment-17250203 ] Zhen Wang commented on CALCITE-4434: reworked a little bit as you suggest. > Cannot implement

[jira] [Commented] (CALCITE-520) Support cancel in remote JDBC driver

2020-12-14 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248855#comment-17248855 ] Zhen Wang commented on CALCITE-520: --- I thought there is already a CancelFlag when implementing the

[jira] [Commented] (CALCITE-4434) Cannot implement 'CASE row WHEN row ...'

2020-12-13 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248764#comment-17248764 ] Zhen Wang commented on CALCITE-4434: https://github.com/apache/calcite/pull/2298 Array Compare is

[jira] [Commented] (CALCITE-1382) ClassCastException in JDBC Adapter

2020-12-11 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247731#comment-17247731 ] Zhen Wang commented on CALCITE-1382: verified that this is no longer an issue with latest master.

[jira] [Comment Edited] (CALCITE-3752) PIVOT and UNPIVOT

2020-09-26 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202619#comment-17202619 ] Zhen Wang edited comment on CALCITE-3752 at 9/26/20, 1:49 PM: -- any

[jira] [Comment Edited] (CALCITE-3752) PIVOT and UNPIVOT

2020-09-26 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202619#comment-17202619 ] Zhen Wang edited comment on CALCITE-3752 at 9/26/20, 1:46 PM: -- any

[jira] [Commented] (CALCITE-3752) PIVOT and UNPIVOT

2020-09-26 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202619#comment-17202619 ] Zhen Wang commented on CALCITE-3752: any backgrounds of specifically this syntax? are there plans

[jira] [Commented] (CALCITE-4147) Rename "master" branch to "main"

2020-08-04 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170762#comment-17170762 ] Zhen Wang commented on CALCITE-4147: [~mmior] any background explaination on this change?

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-08-13 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906175#comment-16906175 ] zhen wang commented on CALCITE-1935: [~julianhyde] you still managed to squeeze it into 3 big

[jira] [Commented] (CALCITE-3176) File adapter for parsing JSON files

2019-07-09 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881123#comment-16881123 ] zhen wang commented on CALCITE-3176: I somehow feels this is already supported. > File adapter for

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-06-30 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875736#comment-16875736 ] zhen wang commented on CALCITE-1935: [~julian.feinauer] , I spent some time on rebasing your work

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2018-11-29 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703125#comment-16703125 ] zhen wang commented on CALCITE-1935: okay, I will put it here first, adding it gradually:

[jira] [Comment Edited] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2018-11-28 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702572#comment-16702572 ] zhen wang edited comment on CALCITE-1935 at 11/29/18 1:37 AM: -- yep, I will

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2018-11-28 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702572#comment-16702572 ] zhen wang commented on CALCITE-1935: yep, I will play with it and add queries to `match.iq`. let

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2018-11-27 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700454#comment-16700454 ] zhen wang commented on CALCITE-1935: some of the 'oracle queries' I am looking at

[jira] [Commented] (CALCITE-2589) VolcanoPlanner#fireRules and VolcanoRuleCall#matchRecurse should ignore known-to-be-unimportant relations

2018-11-05 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675091#comment-16675091 ] zhen wang commented on CALCITE-2589: [~julianhyde] I also mentioned set importance to zero before

[jira] [Commented] (CALCITE-2223) ProjectMergeRule is infinitely matched when is applied after ProjectReduceExpressionsRule

2018-11-05 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675080#comment-16675080 ] zhen wang commented on CALCITE-2223: glad to see this pushed forward. [~vladimirsitnikov] BTW,

[jira] [Commented] (CALCITE-2620) Simplify "coalesce(null,x)" to "x"

2018-10-14 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649717#comment-16649717 ] zhen wang commented on CALCITE-2620: [~pzw2018] while this optimization surely looks reasonable,

[jira] [Commented] (CALCITE-1894) CsvTest.testCsvStream failing often

2018-09-18 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618926#comment-16618926 ] zhen wang commented on CALCITE-1894: for the streaming example, it should not throw away the first

[jira] [Commented] (CALCITE-2458) Evaluate use of Kotlin for unit tests

2018-09-17 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617393#comment-16617393 ] zhen wang commented on CALCITE-2458: with this PR, I'd start to give Kotlin a serioous look. I

[jira] [Commented] (CALCITE-2287) StackOverflowError from FlatList equals()

2018-04-29 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457948#comment-16457948 ] zhen wang commented on CALCITE-2287: [~zhong.j.yu] with pleasure

[jira] [Commented] (CALCITE-2223) ProjectMergeRule is infinitely matched when is applied after ProjectReduceExpressionsRule

2018-03-29 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418648#comment-16418648 ] zhen wang commented on CALCITE-2223: it is indeed connected with 1862, but this one isn't that

[jira] [Commented] (CALCITE-1862) StackOverflowException in RelMdUtil.estimateFilteredRows

2018-03-29 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418608#comment-16418608 ] zhen wang commented on CALCITE-1862: https://github.com/apache/calcite/pull/654 [~julianhyde] let

[jira] [Commented] (CALCITE-2223) ProjectMergeRule is infinitely matched when is applied after ProjectReduceExpressionsRule

2018-03-27 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416553#comment-16416553 ] zhen wang commented on CALCITE-2223: I suspect this is connected to CALCITE-1862, taking a look. >

[jira] [Comment Edited] (CALCITE-1862) StackOverflowException in RelMdUtil.estimateFilteredRows

2018-03-13 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396947#comment-16396947 ] zhen wang edited comment on CALCITE-1862 at 3/13/18 1:42 PM: - removing

[jira] [Commented] (CALCITE-1862) StackOverflowException in RelMdUtil.estimateFilteredRows

2018-03-13 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396947#comment-16396947 ] zhen wang commented on CALCITE-1862: removing either one of the two rules:

[jira] [Commented] (CALCITE-1862) StackOverflowException in RelMdUtil.estimateFilteredRows

2018-03-13 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396908#comment-16396908 ] zhen wang commented on CALCITE-1862: {code} before transform: EnumerableFilter(condition=[IS

[jira] [Commented] (CALCITE-971) Add "NEXT n VALUES FOR sequence" expression

2018-03-10 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394119#comment-16394119 ] zhen wang commented on CALCITE-971: --- okay, some mis-understanding of the linked jira. different thing.

[jira] [Commented] (CALCITE-971) Add "NEXT n VALUES FOR sequence" expression

2018-03-08 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391059#comment-16391059 ] zhen wang commented on CALCITE-971: --- this one is done, and could be closed per PHOENIX-2383 > Add

[jira] [Commented] (CALCITE-1862) StackOverflowException in RelMdUtil.estimateFilteredRows

2018-03-08 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391001#comment-16391001 ] zhen wang commented on CALCITE-1862: some findings the estimate row count method it self is actually

[jira] [Commented] (CALCITE-1048) Make metadata more robust

2018-03-07 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389559#comment-16389559 ] zhen wang commented on CALCITE-1048: and probably relates to CALCITE-1862 as well. > Make metadata

[jira] [Issue Comment Deleted] (CALCITE-2106) Where IN clause performs in memory filtration with > 20 values

2018-03-06 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhen wang updated CALCITE-2106: --- Comment: was deleted (was: [~vladimir.dolzhenko] what's your expected behavior here? more

[jira] [Commented] (CALCITE-1894) CsvTest.testCsvStream failing often

2018-02-26 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376555#comment-16376555 ] zhen wang commented on CALCITE-1894: this might have to do with {code} /** * The default file

[jira] [Commented] (CALCITE-2010) Cannot plan query that is UNION ALL applied to VALUES

2018-02-24 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375626#comment-16375626 ] zhen wang commented on CALCITE-2010: some thoughts, and need your comments [~julianhyde] {code}

[jira] [Commented] (CALCITE-2081) NPE in join of 2 subqueries using window functions

2018-02-23 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374196#comment-16374196 ] zhen wang commented on CALCITE-2081: updated. > NPE in join of 2 subqueries using window functions

[jira] [Commented] (CALCITE-2011) ProjectSetOpTransposeRule gives StackOverflowError

2018-02-23 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374086#comment-16374086 ] zhen wang commented on CALCITE-2011: @Test public void testSelectUnion() { final String sql =

[jira] [Commented] (CALCITE-2015) Planner generates incompatible plan

2018-02-23 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374080#comment-16374080 ] zhen wang commented on CALCITE-2015: there are just too many rules involved in the process, like 400

[jira] [Commented] (CALCITE-2015) Planner generates incompatible plan

2018-02-22 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372857#comment-16372857 ] zhen wang commented on CALCITE-2015: interesting. with some "hint" planner knows not to strip the

[jira] [Commented] (CALCITE-2081) NPE in join of 2 subqueries using window functions

2018-02-22 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372781#comment-16372781 ] zhen wang commented on CALCITE-2081: https://github.com/apache/calcite/pull/634 just like Luis

[jira] [Commented] (CALCITE-2002) Distinct query against in-memory values is sometimes wrong

2018-02-21 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372380#comment-16372380 ] zhen wang commented on CALCITE-2002: updated. > Distinct query against in-memory values is

[jira] [Commented] (CALCITE-2068) throws NPE in RelMdPercentageOriginalRows when getPercentageOriginalRows returns null

2018-02-21 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371562#comment-16371562 ] zhen wang commented on CALCITE-2068: is this purely from code review perspective or there is a real

[jira] [Commented] (CALCITE-2106) Where IN clause performs in memory filtration with > 20 values

2018-02-21 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371559#comment-16371559 ] zhen wang commented on CALCITE-2106: [~vladimir.dolzhenko] what's your expected behavior here? more

[jira] [Commented] (CALCITE-2002) Distinct query against in-memory values is sometimes wrong

2018-02-21 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371526#comment-16371526 ] zhen wang commented on CALCITE-2002: https://github.com/apache/calcite/pull/633 PR created.

[jira] [Issue Comment Deleted] (CALCITE-2002) Distinct query against in-memory values is sometimes wrong

2018-02-13 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhen wang updated CALCITE-2002: --- Comment: was deleted (was: current conclusion is : the first query is screwed by the optimization

[jira] [Commented] (CALCITE-2002) Distinct query against in-memory values is sometimes wrong

2018-02-13 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361958#comment-16361958 ] zhen wang commented on CALCITE-2002: current conclusion is : the first query is screwed by the

[jira] [Commented] (CALCITE-1406) Enable OLAP extensions

2018-02-12 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361664#comment-16361664 ] zhen wang commented on CALCITE-1406: I am looking at JIRAs from time to time and sure to lend a hand

[jira] [Commented] (CALCITE-1406) Enable OLAP extensions

2018-02-12 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360600#comment-16360600 ] zhen wang commented on CALCITE-1406: MDX, finally MDX is coming to calcite > Enable OLAP extensions

[jira] [Commented] (CALCITE-2099) generated code compile error when sql has union and aggregation

2018-02-12 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360592#comment-16360592 ] zhen wang commented on CALCITE-2099: https://github.com/apache/calcite/pull/625 created.

[jira] [Commented] (CALCITE-1154) Wrong Plan/Result if wrapping a query with SELECT * FROM

2017-05-27 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027390#comment-16027390 ] zhen wang commented on CALCITE-1154: reproduce {code} @Test public void

[jira] [Commented] (CALCITE-1154) Wrong Plan/Result if wrapping a query with SELECT * FROM

2017-05-27 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027382#comment-16027382 ] zhen wang commented on CALCITE-1154: I also noted some interesting phenomena here, when validating

[jira] [Comment Edited] (CALCITE-1154) Wrong Plan/Result if wrapping a query with SELECT * FROM

2017-05-27 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027368#comment-16027368 ] zhen wang edited comment on CALCITE-1154 at 5/27/17 9:25 AM: - it does look

[jira] [Comment Edited] (CALCITE-1154) Wrong Plan/Result if wrapping a query with SELECT * FROM

2017-05-27 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027368#comment-16027368 ] zhen wang edited comment on CALCITE-1154 at 5/27/17 9:18 AM: - it does look

[jira] [Commented] (CALCITE-1154) Wrong Plan/Result if wrapping a query with SELECT * FROM

2017-05-27 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027368#comment-16027368 ] zhen wang commented on CALCITE-1154: it does look like `SELECT * is not validated and parsed

[jira] [Commented] (CALCITE-1629) EXTRACT function not working in CSVTest

2017-02-10 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862143#comment-15862143 ] zhen wang commented on CALCITE-1629: [~julianhyde] continuing my original question then, what if

[jira] [Commented] (CALCITE-1629) EXTRACT function not working in CSVTest

2017-02-09 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860834#comment-15860834 ] zhen wang commented on CALCITE-1629: [~julianhyde] I think I get you now. did you mean `make a input

[jira] [Commented] (CALCITE-1535) Give error if ORDER BY clause references ambiguous column name

2017-01-22 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833360#comment-15833360 ] zhen wang commented on CALCITE-1535: I'm good. not that familiar with sql spec. it's just when are

[jira] [Commented] (CALCITE-1535) Give error if ORDER BY clause references ambiguous column name

2017-01-21 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832941#comment-15832941 ] zhen wang commented on CALCITE-1535: https://github.com/apache/calcite/pull/359 [~julianhyde]

[jira] [Commented] (CALCITE-1569) Date condition can generates Integer == Integer, which is always false

2017-01-20 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831621#comment-15831621 ] zhen wang commented on CALCITE-1569: https://github.com/apache/calcite/pull/356 tests fixed with

[jira] [Commented] (CALCITE-1569) Date condition can generates Integer == Integer, which is always false

2017-01-17 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825683#comment-15825683 ] zhen wang commented on CALCITE-1569: wrote another fix:

[jira] [Commented] (CALCITE-1569) Date condition can generates Integer == Integer, which is always false

2017-01-14 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823028#comment-15823028 ] zhen wang commented on CALCITE-1569: hmm, what will this line look like in your mind `/* 115 */

[jira] [Commented] (CALCITE-1569) Date condition can generates Integer == Integer, which is always false

2017-01-14 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822847#comment-15822847 ] zhen wang commented on CALCITE-1569: thanks [~vladimirsitnikov] for the test case. it seems if the

[jira] [Commented] (CALCITE-1227) Add streaming CSV table

2016-06-27 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15350540#comment-15350540 ] zhen wang commented on CALCITE-1227: [~julianhyde] I took a careful look at your work. looks all

[jira] [Commented] (CALCITE-1227) Add streaming CSV table

2016-06-01 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309877#comment-15309877 ] zhen wang commented on CALCITE-1227: I updated PR with one possible solution. don't quite like it

[jira] [Commented] (CALCITE-1227) Add streaming CSV table

2016-05-30 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15306375#comment-15306375 ] zhen wang commented on CALCITE-1227: indeed I didn't quite get how DataContext could used to help.

[jira] [Issue Comment Deleted] (CALCITE-1227) Add streaming CSV table

2016-05-28 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhen wang updated CALCITE-1227: --- Comment: was deleted (was: thanks [~julianhyde], will clean up the PR once fished the remaining

[jira] [Commented] (CALCITE-1227) Add streaming CSV table

2016-05-28 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305448#comment-15305448 ] zhen wang commented on CALCITE-1227: thanks [~julianhyde], will clean up the PR once fished the

[jira] [Commented] (CALCITE-1227) Add streaming CSV table

2016-05-26 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303513#comment-15303513 ] zhen wang commented on CALCITE-1227: I am having some fun with this one here:

[jira] [Commented] (CALCITE-1031) In prepared statement, CsvScannableTable.scan is called twice

2016-02-14 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146843#comment-15146843 ] zhen wang commented on CALCITE-1031: thanks [~julianhyde] mine is too hacky to form a PR, I am good

[jira] [Commented] (CALCITE-1031) In prepared statement, CsvScannableTable.scan is called twice

2016-01-29 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124795#comment-15124795 ] zhen wang commented on CALCITE-1031: This is a hack which works ( all case pass )

[jira] [Commented] (CALCITE-1015) AssertionError: trivial sort out of cartesian join offset 0

2015-12-14 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15057179#comment-15057179 ] zhen wang commented on CALCITE-1015: https://github.com/apache/calcite/pull/181 still some questions

[jira] [Comment Edited] (CALCITE-709) Errors with LIMIT inside scalar sub-query

2015-12-12 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15054288#comment-15054288 ] zhen wang edited comment on CALCITE-709 at 12/12/15 2:03 PM: - Two

[jira] [Commented] (CALCITE-709) Errors with LIMIT inside scalar sub-query

2015-12-12 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15054288#comment-15054288 ] zhen wang commented on CALCITE-709: --- Two observations for this issue (

[jira] [Comment Edited] (CALCITE-709) Errors with LIMIT inside scalar sub-query

2015-12-12 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15054288#comment-15054288 ] zhen wang edited comment on CALCITE-709 at 12/12/15 1:19 PM: - Two

[jira] [Comment Edited] (CALCITE-709) Errors with LIMIT inside scalar sub-query

2015-12-12 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15054288#comment-15054288 ] zhen wang edited comment on CALCITE-709 at 12/12/15 2:11 PM: - Two