[jira] [Created] (CALCITE-6435) SqlToRel conversion of IN expressions may lead to incorrect simplifications

2024-06-13 Thread Zoltan Haindrich (Jira)
Zoltan Haindrich created CALCITE-6435: - Summary: SqlToRel conversion of IN expressions may lead to incorrect simplifications Key: CALCITE-6435 URL: https://issues.apache.org/jira/browse/CALCITE-6435

[jira] [Commented] (CALCITE-6435) SqlToRel conversion of IN expressions may lead to incorrect simplifications

2024-06-13 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854764#comment-17854764 ] Zoltan Haindrich commented on CALCITE-6435: --- notes relating to fixing this: *

[jira] [Updated] (CALCITE-6435) SqlToRel conversion of IN expressions may lead to incorrect simplifications

2024-06-13 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-6435: -- Description: the query must have the following features: * not all columns are

[jira] [Commented] (CALCITE-5907) Unexpected boolean expression simplification for And expression

2023-10-17 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776061#comment-17776061 ] Zoltan Haindrich commented on CALCITE-5907: --- I wonder how valid an `=` is if it has a

[jira] [Resolved] (CALCITE-4189) Simplify 'p OR (p IS NOT TRUE)' to 'TRUE'

2023-10-03 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-4189. --- Fix Version/s: 1.36.0 Assignee: hongyu guo Resolution: Fixed Fixed

[jira] [Commented] (CALCITE-6020) SqlToRelConverter should not replace windowed SUM with equivalent expression using SUM0

2023-09-21 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767578#comment-17767578 ] Zoltan Haindrich commented on CALCITE-6020: --- [~jhyde]: I've tried to look after the origins

[jira] [Created] (CALCITE-6020) SqlToRelConverter should not replace windowed SUM with equivalent expression using SUM0

2023-09-21 Thread Zoltan Haindrich (Jira)
Zoltan Haindrich created CALCITE-6020: - Summary: SqlToRelConverter should not replace windowed SUM with equivalent expression using SUM0 Key: CALCITE-6020 URL:

[jira] [Updated] (CALCITE-5953) AggregateCaseToFilterRule may make inaccurate SUM transformation

2023-09-08 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-5953: -- Description: consider: {{sum(case when x = 1 then 2 else 0 end) as b}} notice that

[jira] [Updated] (CALCITE-5953) AggregateCaseToFilterRule may make inaccurate SUM transformation

2023-09-08 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-5953: -- Description: consider: {{sum(case when x = 1 then 2 else 0 end) as b}} notice that

[jira] [Resolved] (CALCITE-5953) AggregateCaseToFilterRule may make inaccurate SUM transformation

2023-09-05 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-5953. --- Fix Version/s: 1.36.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-5963) Simplify 'x OR NOT(x)' to TRUE

2023-08-28 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759620#comment-17759620 ] Zoltan Haindrich commented on CALCITE-5963: --- I think instead of restricting this by

[jira] [Commented] (CALCITE-5953) AggregateCaseToFilterRule may make inaccurate SUM transformation

2023-08-24 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758383#comment-17758383 ] Zoltan Haindrich commented on CALCITE-5953: --- I would also find it more natural if SUM would

[jira] [Updated] (CALCITE-5953) AggregateCaseToFilterRule may make inaccurate SUM transformation

2023-08-23 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-5953: -- Description: consider: {{sum(case when x = 1 then 2 else 0 end) as b}} notice that

[jira] [Created] (CALCITE-5953) AggregateCaseToFilterRule may make inaccurate SUM transformation

2023-08-23 Thread Zoltan Haindrich (Jira)
Zoltan Haindrich created CALCITE-5953: - Summary: AggregateCaseToFilterRule may make inaccurate SUM transformation Key: CALCITE-5953 URL: https://issues.apache.org/jira/browse/CALCITE-5953

[jira] [Comment Edited] (CALCITE-5907) Unexpected boolean expression simplification for And expression

2023-08-08 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752094#comment-17752094 ] Zoltan Haindrich edited comment on CALCITE-5907 at 8/8/23 3:17 PM: --- I

[jira] [Commented] (CALCITE-5907) Unexpected boolean expression simplification for And expression

2023-08-08 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752094#comment-17752094 ] Zoltan Haindrich commented on CALCITE-5907: --- I believe both operands should be of the same

[jira] [Commented] (CALCITE-4910) Enhance simplify to reduce ((a or d) and (a or c) and a and b) to (a and b)

2021-11-30 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451070#comment-17451070 ] Zoltan Haindrich commented on CALCITE-4910: --- [~Ziwei Liu]: if you use simple equals

[jira] [Updated] (CALCITE-4910) Enhance simplify to reduce ((a or d) and (a or c) and a and b) to (a and b)

2021-11-30 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-4910: -- Description: Considering this condition, (a or d) and (a or c) and a and b. This

[jira] [Commented] (CALCITE-4398) RexSimplify introduces cast(nullable as nonnull)

2020-11-12 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230898#comment-17230898 ] Zoltan Haindrich commented on CALCITE-4398: --- ">=(?0.int1, 0)" can be null; but the whole

[jira] [Commented] (CALCITE-4398) RexSimplify introduces cast(nullable as nonnull)

2020-11-12 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230789#comment-17230789 ] Zoltan Haindrich commented on CALCITE-4398: --- this is incorrect; at most it could be: {code}

[jira] [Commented] (CALCITE-4388) RexNode#isAlwaysFalse and isAlwaysTrue should be aligned with RexSimplify#isSafeExpression

2020-11-09 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228430#comment-17228430 ] Zoltan Haindrich commented on CALCITE-4388: --- oh...but I don't think I should get into these

[jira] [Commented] (CALCITE-4388) RexNode#isAlwaysFalse and isAlwaysTrue should be aligned with RexSimplify#isSafeExpression

2020-11-09 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228429#comment-17228429 ] Zoltan Haindrich commented on CALCITE-4388: --- [~vladimirsitnikov] thank you for pinging me;

[jira] [Commented] (CALCITE-4118) RexSimplify might remove CAST from RexNode incorrectly

2020-07-13 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156744#comment-17156744 ] Zoltan Haindrich commented on CALCITE-4118: --- it turned out that in case the varchar's

[jira] [Comment Edited] (CALCITE-4118) RexSimplify might remove CAST from RexNode incorrectly

2020-07-11 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155950#comment-17155950 ] Zoltan Haindrich edited comment on CALCITE-4118 at 7/11/20, 11:13 AM:

[jira] [Commented] (CALCITE-4118) RexSimplify might remove CAST from RexNode incorrectly

2020-07-11 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155950#comment-17155950 ] Zoltan Haindrich commented on CALCITE-4118: --- I forgot to make a note here: yesterday I

[jira] [Created] (CALCITE-4006) Add ordered-set aggregate functions

2020-05-18 Thread Zoltan Haindrich (Jira)
Zoltan Haindrich created CALCITE-4006: - Summary: Add ordered-set aggregate functions Key: CALCITE-4006 URL: https://issues.apache.org/jira/browse/CALCITE-4006 Project: Calcite Issue

[jira] [Resolved] (CALCITE-3979) Simplification might have removed CAST expression(s) incorrectly

2020-05-14 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-3979. --- Resolution: Fixed Thank you all! fixed in

[jira] [Commented] (CALCITE-3979) Simplification might have removed CAST expression(s) incorrectly

2020-05-13 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106678#comment-17106678 ] Zoltan Haindrich commented on CALCITE-3979: --- [~hyuan] please consider this for 1.23.0 - it's

[jira] [Commented] (CALCITE-3979) Simplification might have removed CAST expression(s) incorrectly

2020-05-13 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106670#comment-17106670 ] Zoltan Haindrich commented on CALCITE-3979: --- I see - this logic is org.eigenbase old - so it

[jira] [Commented] (CALCITE-3979) Simplification might have removed CAST expression(s) incorrectly

2020-05-11 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104169#comment-17104169 ] Zoltan Haindrich commented on CALCITE-3979: --- [~julianhyde] yes it can be dangerousIn this

[jira] [Updated] (CALCITE-3979) Simplification might have removed CAST expression(s) incorrectly

2020-05-10 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-3979: -- Labels: pull-request-available (was: ) > Simplification might have removed CAST

[jira] [Updated] (CALCITE-3979) Simplification might have removed CAST expression(s) incorrectly

2020-05-10 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-3979: -- Summary: Simplification might have removed CAST expression(s) incorrectly (was:

[jira] [Assigned] (CALCITE-3979) ReduceExpressionsRule might have removed CAST expression(s) incorrectly

2020-05-10 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich reassigned CALCITE-3979: - Assignee: Zoltan Haindrich > ReduceExpressionsRule might have removed CAST

[jira] [Commented] (CALCITE-3979) ReduceExpressionsRule might have removed CAST expression(s) incorrectly

2020-05-10 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103703#comment-17103703 ] Zoltan Haindrich commented on CALCITE-3979: --- as a matter of fact, this second issue is the

[jira] [Updated] (CALCITE-3979) ReduceExpressionsRule might have removed CAST expression(s) incorrectly

2020-05-10 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-3979: -- Summary: ReduceExpressionsRule might have removed CAST expression(s) incorrectly

[jira] [Commented] (CALCITE-3979) Unexpected removing of CAST in ReduceExpressionsRule

2020-05-10 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103696#comment-17103696 ] Zoltan Haindrich commented on CALCITE-3979: --- I've fixed this; but I see another issue with

[jira] [Resolved] (CALCITE-3887) Filter and Join conditions may not need to retain nullability during simplifications

2020-05-06 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-3887. --- Fix Version/s: 1.23.0 Resolution: Fixed > Filter and Join conditions may

[jira] [Commented] (CALCITE-3887) Filter and Join conditions may not need to retain nullability during simplifications

2020-05-06 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101193#comment-17101193 ] Zoltan Haindrich commented on CALCITE-3887: --- Fixed in

[jira] [Commented] (CALCITE-3887) Filter and Join conditions may not need to retain nullability during simplifications

2020-05-06 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100799#comment-17100799 ] Zoltan Haindrich commented on CALCITE-3887: --- RelBuilder was already doing this by calling the

[jira] [Resolved] (CALCITE-3880) Add SortExchange support to RelFieldTrimmer

2020-04-02 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-3880. --- Fix Version/s: 1.23.0 Resolution: Fixed fixed in

[jira] [Commented] (CALCITE-3890) Infer IS NOT NULL predicate from join

2020-04-01 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17072624#comment-17072624 ] Zoltan Haindrich commented on CALCITE-3890: --- [~Chunwei Lei]: in Hive we have a rule which

[jira] [Created] (CALCITE-3887) Filter and Join conditions may not need to retain nullability during simplifications

2020-03-30 Thread Zoltan Haindrich (Jira)
Zoltan Haindrich created CALCITE-3887: - Summary: Filter and Join conditions may not need to retain nullability during simplifications Key: CALCITE-3887 URL: https://issues.apache.org/jira/browse/CALCITE-3887

[jira] [Commented] (CALCITE-3852) RexSimplify doesn't simplify NOT EQUAL predicates

2020-03-12 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057637#comment-17057637 ] Zoltan Haindrich commented on CALCITE-3852: --- it would be better to rewrite it to {{AND(null,x

[jira] [Commented] (CALCITE-3852) RexSimplify doesn't simplify NOT EQUAL predicates

2020-03-11 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056969#comment-17056969 ] Zoltan Haindrich commented on CALCITE-3852: --- I always wanted to address this; but forgot :)

[jira] [Commented] (CALCITE-3842) RexSimplify doesn't simplify range predicates, as it looks at the operands in a particular order.

2020-03-11 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056925#comment-17056925 ] Zoltan Haindrich commented on CALCITE-3842: --- As [~Chunwei Lei]  already explained the reason

[jira] [Commented] (CALCITE-3803) Enhance RexSimplify to simplify 'a>1 or (a<3 and b)' to 'a>1 or b' if column a is not nullable

2020-02-18 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039476#comment-17039476 ] Zoltan Haindrich commented on CALCITE-3803: --- Looks good thank you [~Chunwei Lei] for looking

[jira] [Commented] (CALCITE-3803) Enhance RexSimplify to simplify 'a>1 or (a<3 and b)' to 'a>1 or b' if column a is not nullable

2020-02-17 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038434#comment-17038434 ] Zoltan Haindrich commented on CALCITE-3803: --- oh...yes; you are right - we can do much better

[jira] [Commented] (CALCITE-3803) Enhance RexSimplify to simplify 'a>1 or (a<3 and b)' to 'a>1 or b' if column a is not nullable

2020-02-17 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038427#comment-17038427 ] Zoltan Haindrich commented on CALCITE-3803: --- I'll take a look at it again with a fresh

[jira] [Commented] (CALCITE-3803) Enhance RexSimplify to simplify 'a>1 or (a<3 and b)' to 'a>1 or b' if column a is not nullable

2020-02-17 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038216#comment-17038216 ] Zoltan Haindrich commented on CALCITE-3803: --- some notes: Right now we use predicates during

[jira] [Commented] (CALCITE-3192) Simplification may weaken OR conditions containing inequalities

2020-02-17 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038188#comment-17038188 ] Zoltan Haindrich commented on CALCITE-3192: --- that's a great idea! I was thinking that

[jira] [Commented] (CALCITE-3192) Simplification may weaken OR conditions containing inequalities

2020-02-06 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031543#comment-17031543 ] Zoltan Haindrich commented on CALCITE-3192: --- I see now; so you are after whether that issue

[jira] [Commented] (CALCITE-3192) Simplification may weaken OR conditions containing inequalities

2020-02-03 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028943#comment-17028943 ] Zoltan Haindrich commented on CALCITE-3192: --- I think I might be interpreting your example a

[jira] [Commented] (CALCITE-3464) RexSimplify simplifies plan having filter with NULL to empty values

2019-10-31 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963839#comment-16963839 ] Zoltan Haindrich commented on CALCITE-3464: --- [~zabetak] you are fast :D [~yanlin-Lynn] if you

[jira] [Commented] (CALCITE-3368) Some problems simplifying ‘expression IS NULL’

2019-10-11 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949266#comment-16949266 ] Zoltan Haindrich commented on CALCITE-3368: --- Could you please change the summary...I think we

[jira] [Commented] (CALCITE-3368) Some problems simplifying ‘expression IS NULL’

2019-10-11 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949259#comment-16949259 ] Zoltan Haindrich commented on CALCITE-3368: --- I also think that we should probably add some

[jira] [Commented] (CALCITE-3368) Some problems simplifying ‘expression IS NULL’

2019-10-08 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946753#comment-16946753 ] Zoltan Haindrich commented on CALCITE-3368: --- iiuc the issue here is that *(max+max) is null*

[jira] [Resolved] (CALCITE-3215) Simplification may have not fully simplified IS NOT NULL expressions

2019-08-02 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-3215. --- Resolution: Fixed Fix Version/s: 1.21.0 fixed in

[jira] [Resolved] (CALCITE-3192) Simplification may weaken OR conditions containing inequalities

2019-08-02 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-3192. --- Resolution: Fixed Assignee: Zoltan Haindrich fixed in

[jira] [Updated] (CALCITE-3192) Simplification may weaken OR conditions containing inequalities

2019-07-30 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-3192: -- Summary: Simplification may weaken OR conditions containing inequalities (was:

[jira] [Updated] (CALCITE-3192) Simplification of OR incorrectly weaks condition

2019-07-30 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-3192: -- Summary: Simplification of OR incorrectly weaks condition (was: Simplify OR

[jira] [Commented] (CALCITE-3215) Simplification may have not fully simplified IS NOT NULL expressions

2019-07-30 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895877#comment-16895877 ] Zoltan Haindrich commented on CALCITE-3215: --- unfortunately no: * division is not safe,

[jira] [Updated] (CALCITE-3215) Simplification may have not fully simplified IS NOT NULL expressions

2019-07-30 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-3215: -- Summary: Simplification may have not fully simplified IS NOT NULL expressions (was:

[jira] [Created] (CALCITE-3215) Simplification may not fully simplify IsNotNull expressions

2019-07-26 Thread Zoltan Haindrich (JIRA)
Zoltan Haindrich created CALCITE-3215: - Summary: Simplification may not fully simplify IsNotNull expressions Key: CALCITE-3215 URL: https://issues.apache.org/jira/browse/CALCITE-3215 Project:

[jira] [Comment Edited] (CALCITE-3192) Simplify OR incorrectly weaks condition

2019-07-25 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892865#comment-16892865 ] Zoltan Haindrich edited comment on CALCITE-3192 at 7/25/19 3:25 PM:

[jira] [Commented] (CALCITE-3192) Simplify OR incorrectly weaks condition

2019-07-25 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892865#comment-16892865 ] Zoltan Haindrich commented on CALCITE-3192: --- [~jbal...@gmail.com] throwing away the

[jira] [Comment Edited] (CALCITE-3192) Simplify OR incorrectly weaks condition

2019-07-12 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883900#comment-16883900 ] Zoltan Haindrich edited comment on CALCITE-3192 at 7/12/19 3:17 PM:

[jira] [Updated] (CALCITE-3192) Simplify OR incorrectly weaks condition

2019-07-12 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-3192: -- Fix Version/s: 1.21.0 > Simplify OR incorrectly weaks condition >

[jira] [Commented] (CALCITE-3192) Simplify OR incorrectly weaks condition

2019-07-12 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883900#comment-16883900 ] Zoltan Haindrich commented on CALCITE-3192: --- {code} z or ( x and y ) z or ( x and y and !z )

[jira] [Updated] (CALCITE-2955) SQL queries after first query in same statement have no results returned

2019-04-05 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-2955: -- Fix Version/s: (was: 1.19.0) > SQL queries after first query in same statement

[jira] [Commented] (CALCITE-2829) Fix RexSimplify#processRange cast issue

2019-03-26 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801822#comment-16801822 ] Zoltan Haindrich commented on CALCITE-2829: --- [~Juhwan] I understand that this issue surfaces

[jira] [Commented] (CALCITE-2929) Simplification of IS NULL checks are incorrectly assuming that CAST-s are possible

2019-03-19 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796088#comment-16796088 ] Zoltan Haindrich commented on CALCITE-2929: --- I think I now see your point: Strong is only

[jira] [Comment Edited] (CALCITE-2934) Simplification of a filter =($0, false) to NOT($0) ($0 is boolean)

2019-03-19 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795975#comment-16795975 ] Zoltan Haindrich edited comment on CALCITE-2934 at 3/19/19 11:09 AM:

[jira] [Commented] (CALCITE-2934) Simplification of a filter =($0, false) to NOT($0) ($0 is boolean)

2019-03-19 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795975#comment-16795975 ] Zoltan Haindrich commented on CALCITE-2934: --- I don't see any "error" in the description; can

[jira] [Commented] (CALCITE-2929) Simplification of IS NULL checks are incorrectly assuming that CAST-s are possible

2019-03-19 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795796#comment-16795796 ] Zoltan Haindrich commented on CALCITE-2929: --- [~danny0405]: for nullability yes; the

[jira] [Commented] (CALCITE-2929) Simplification of IS NULL checks are incorrectly assuming that CAST-s are possible

2019-03-18 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795204#comment-16795204 ] Zoltan Haindrich commented on CALCITE-2929: --- If I count it correctly there are 4 issues here:

[jira] [Commented] (CALCITE-2929) Simplification of IS NULL checks are incorrectly assuming that CAST-s are possible

2019-03-18 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795088#comment-16795088 ] Zoltan Haindrich commented on CALCITE-2929: --- there is a 3. occurance of this: CAST should not

[jira] [Commented] (CALCITE-2929) Simplification of IS NULL checks are incorrectly assuming that CAST-s are possible

2019-03-18 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794849#comment-16794849 ] Zoltan Haindrich commented on CALCITE-2929: --- This is starting to get more complicated than it

[jira] [Created] (CALCITE-2929) Simplification of IS NULL checks are incorrectly assuming that CAST-s are possible

2019-03-18 Thread Zoltan Haindrich (JIRA)
Zoltan Haindrich created CALCITE-2929: - Summary: Simplification of IS NULL checks are incorrectly assuming that CAST-s are possible Key: CALCITE-2929 URL: https://issues.apache.org/jira/browse/CALCITE-2929

[jira] [Resolved] (CALCITE-2886) Simplification of AND expressions should push negations earlier

2019-03-14 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-2886. --- Resolution: Fixed Fix Version/s: 1.19.0 merged into master as

[jira] [Commented] (CALCITE-2918) Integration tests against postgres are broken

2019-03-13 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791600#comment-16791600 ] Zoltan Haindrich commented on CALCITE-2918: --- This issue seems to be more general than

[jira] [Created] (CALCITE-2886) Simplification of AND expressions should push negations earlier

2019-03-01 Thread Zoltan Haindrich (JIRA)
Zoltan Haindrich created CALCITE-2886: - Summary: Simplification of AND expressions should push negations earlier Key: CALCITE-2886 URL: https://issues.apache.org/jira/browse/CALCITE-2886 Project:

[jira] [Commented] (CALCITE-2883) HepPlanner subprogram may loop till getting out of memory

2019-03-01 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781747#comment-16781747 ] Zoltan Haindrich commented on CALCITE-2883: --- I think it would probably make sense to add a

[jira] [Resolved] (CALCITE-2257) Combination of predicates can be proved to be always true

2019-03-01 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-2257. --- Resolution: Fixed I'm closing this because I think right now simplification is

[jira] [Resolved] (CALCITE-2338) Make Simplification API more conservative

2019-03-01 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-2338. --- Resolution: Fixed Fix Version/s: 1.19.0 fixed in

[jira] [Commented] (CALCITE-2421) RexSimplify#simplifyAnds foregoes some simplications if unknownAsFalse set to true

2019-02-28 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780700#comment-16780700 ] Zoltan Haindrich commented on CALCITE-2421: --- [~laurentgo] I hope you don't mind; but I've

[jira] [Comment Edited] (CALCITE-2421) RexSimplify#simplifyAnds foregoes some simplications if unknownAsFalse set to true

2019-02-28 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770930#comment-16770930 ] Zoltan Haindrich edited comment on CALCITE-2421 at 2/28/19 3:58 PM:

[jira] [Commented] (CALCITE-2338) Make Simplification API more conservative

2019-02-26 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778009#comment-16778009 ] Zoltan Haindrich commented on CALCITE-2338: --- I've bumped into this again - these extra entry

[jira] [Updated] (CALCITE-2338) Make Simplification API more conservative

2019-02-26 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-2338: -- Summary: Make Simplification API more conservative (was: Reduce the externally

[jira] [Resolved] (CALCITE-2722) SqlImplementor createLeftCall method throws StackOverflowError

2019-02-25 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-2722. --- Resolution: Fixed Fix Version/s: 1.19.0 fixed in

[jira] [Resolved] (CALCITE-2839) Simplify comparisons against boolean literals

2019-02-25 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-2839. --- Resolution: Fixed Fix Version/s: 1.19.0 the patch handles comparisions

[jira] [Resolved] (CALCITE-2841) Simplification: push negation into Case expression

2019-02-24 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-2841. --- Resolution: Fixed Fix Version/s: 1.19.0 fixed in

[jira] [Resolved] (CALCITE-2848) Simplifying a case statement's first branch should ignore its safety

2019-02-24 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-2848. --- Resolution: Fixed Fix Version/s: 1.19.0 fixed in

[jira] [Commented] (CALCITE-2862) Deprecated ExprSimplifier causes some operands not being simplified

2019-02-23 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775933#comment-16775933 ] Zoltan Haindrich commented on CALCITE-2862: --- ExprSimplifier was doing some questionable

[jira] [Resolved] (CALCITE-2838) Simplification: Remove redundant IS TRUE checks

2019-02-23 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-2838. --- Resolution: Fixed fixed in

[jira] [Resolved] (CALCITE-2850) Geode adapter: support boolean column as filter operand

2019-02-21 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-2850. --- Resolution: Fixed Fix Version/s: 1.19.0 merged into master

[jira] [Updated] (CALCITE-2850) Geode adapter: support boolean column as filter operand

2019-02-19 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-2850: -- Summary: Geode adapter: support boolean column as filter operand (was: Geode

[jira] [Commented] (CALCITE-2421) RexSimplify#simplifyAnds foregoes some simplications if unknownAsFalse set to true

2019-02-18 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770930#comment-16770930 ] Zoltan Haindrich commented on CALCITE-2421: --- this right now is only working for

[jira] [Commented] (CALCITE-2851) Simplification: track visited nodes in paranoid mode

2019-02-18 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770896#comment-16770896 ] Zoltan Haindrich commented on CALCITE-2851: --- Yes, I had in mind to throw an error - as

[jira] [Commented] (CALCITE-2852) Simplification: traverse calculations and unknown UDFs

2019-02-18 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770863#comment-16770863 ] Zoltan Haindrich commented on CALCITE-2852: --- [~julianhyde]: at first I was only after an UDF

[jira] [Updated] (CALCITE-2852) Simplification: traverse calculations and unknown UDFs

2019-02-18 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-2852: -- Summary: Simplification: traverse calculations and unknown UDFs (was:

  1   2   3   >