[
https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140589#comment-16140589
]
Julian Hyde commented on CALCITE-1911:
--
Fixed in
[
https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137885#comment-16137885
]
Julian Hyde commented on CALCITE-1911:
--
Reviewing/testing now.
> Support WITHIN clause in
[
https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137738#comment-16137738
]
Dian Fu commented on CALCITE-1911:
--
Hi [~julianhyde], I have addressed your comments in the latest PR
[
https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125149#comment-16125149
]
Dian Fu commented on CALCITE-1911:
--
Make sense. Have updated the tests for INTERVAL.
> Support WITHIN
[
https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123502#comment-16123502
]
Julian Hyde commented on CALCITE-1911:
--
You've addressed almost everything. I was pleased to see
[
https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123278#comment-16123278
]
Dian Fu commented on CALCITE-1911:
--
Have updated the PR according to review comments.
Have also added
[
https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119167#comment-16119167
]
Julian Hyde commented on CALCITE-1911:
--
I think it's just a matter of generating the interval
[
https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118240#comment-16118240
]
Dian Fu commented on CALCITE-1911:
--
[~julianhyde], [~ransom] Thanks a lot for your review.
{quote}
I am
[
https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118070#comment-16118070
]
Zhiqiang He commented on CALCITE-1911:
--
SqlValidatorImpl.java shoud add check orderBy clause when
[
https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117548#comment-16117548
]
Julian Hyde commented on CALCITE-1911:
--
A few review comments:
* Add comments in Match etc. that
[
https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116608#comment-16116608
]
Dian Fu commented on CALCITE-1911:
--
[~julianhyde] [~ransom], Have create a PR. Could you help to
[
https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108289#comment-16108289
]
Dian Fu commented on CALCITE-1911:
--
Right, I think the {{rowtime}} column can be seen as the timestamp
[
https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108279#comment-16108279
]
Julian Hyde commented on CALCITE-1911:
--
Here's a possible solution. If people want to use WITHIN,
[
https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108257#comment-16108257
]
Dian Fu commented on CALCITE-1911:
--
Yes, this is not in Oracle 12 and also not in the SQL standard, but
[
https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107993#comment-16107993
]
Julian Hyde commented on CALCITE-1911:
--
To be clear, this is not in Oracle 12, and it is not in the
15 matches
Mail list logo
