[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662845#comment-16662845
]
Vladimir Sitnikov commented on CALCITE-2404:
[~zabetak], thanks for implementing the
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662837#comment-16662837
]
Stamatis Zampetakis commented on CALCITE-2404:
--
Thanks a lot for the review and the merge
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627289#comment-16627289
]
Stamatis Zampetakis commented on CALCITE-2404:
--
The requested changes are all in so the PR
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619093#comment-16619093
]
Stamatis Zampetakis commented on CALCITE-2404:
--
Great! I will resolve the new conflicts
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618083#comment-16618083
]
Vladimir Sitnikov commented on CALCITE-2404:
That is the only concern
> Accessing
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618085#comment-16618085
]
Vladimir Sitnikov commented on CALCITE-2404:
@Experemental works for me
> Accessing
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618073#comment-16618073
]
Julian Hyde commented on CALCITE-2404:
--
If adding a public API is the only concern then we can
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618051#comment-16618051
]
Vladimir Sitnikov commented on CALCITE-2404:
What bothers me is this change introduces
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617997#comment-16617997
]
Julian Hyde commented on CALCITE-2404:
--
As far as I can tell, this PR is not perfect but it is
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617155#comment-16617155
]
Stamatis Zampetakis commented on CALCITE-2404:
--
Hi [~vladimirsitnikov],
Sorry for
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604219#comment-16604219
]
Stamatis Zampetakis commented on CALCITE-2404:
--
{quote}Suppose the function returns
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602995#comment-16602995
]
Vladimir Sitnikov commented on CALCITE-2404:
{quote} The return type of the function is a
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602876#comment-16602876
]
Stamatis Zampetakis commented on CALCITE-2404:
--
The return type of the function is a
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602841#comment-16602841
]
Vladimir Sitnikov commented on CALCITE-2404:
Consider an example:
{code:java}select
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602710#comment-16602710
]
Stamatis Zampetakis commented on CALCITE-2404:
--
Thanks for your comments
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602455#comment-16602455
]
Vladimir Sitnikov commented on CALCITE-2404:
1) Re "phystype for structs", it would indeed
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597455#comment-16597455
]
Stamatis Zampetakis commented on CALCITE-2404:
--
[~julianhyde], [~vladimirsitnikov] , can
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575927#comment-16575927
]
Stamatis Zampetakis commented on CALCITE-2404:
--
I updated the PR. Let me know if you have
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567853#comment-16567853
]
Stamatis Zampetakis commented on CALCITE-2404:
--
OK great!
I will try to fix the flattener
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566184#comment-16566184
]
Julian Hyde commented on CALCITE-2404:
--
I agree that DOT should not be used in RexNode land. The
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566007#comment-16566007
]
Stamatis Zampetakis commented on CALCITE-2404:
--
{quote}There are some operators that are
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565816#comment-16565816
]
Julian Hyde commented on CALCITE-2404:
--
bq. In my opinion, we shouldn't have two ways of
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565257#comment-16565257
]
Stamatis Zampetakis commented on CALCITE-2404:
--
[~vladimirsitnikov] good catch! Thanks!
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565158#comment-16565158
]
Vladimir Sitnikov commented on CALCITE-2404:
[~zabetak], {{getDeclaredFields}} does not
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565161#comment-16565161
]
Vladimir Sitnikov commented on CALCITE-2404:
Just a quote:
{quote} The elements in the
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565109#comment-16565109
]
Stamatis Zampetakis commented on CALCITE-2404:
--
I think it is relevant to discuss a bit
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564071#comment-16564071
]
Julian Hyde commented on CALCITE-2404:
--
Regarding {{SqlToRelConverterTest.testArrayOfRecord}}. I'm
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563683#comment-16563683
]
Stamatis Zampetakis commented on CALCITE-2404:
--
I updated the PR with the proposed changes
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563364#comment-16563364
]
Stamatis Zampetakis commented on CALCITE-2404:
--
Thanks a lot for the comments. A few
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563097#comment-16563097
]
Julian Hyde commented on CALCITE-2404:
--
I have reviewed e6ffd3ba6:
* I saw that you marked
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546948#comment-16546948
]
Stamatis Zampetakis commented on CALCITE-2404:
--
A first attempt at resolving this issue
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538633#comment-16538633
]
Stamatis Zampetakis commented on CALCITE-2404:
--
FYI, it is definitely a bug and I already
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535923#comment-16535923
]
Stamatis Zampetakis commented on CALCITE-2404:
--
The use-cases that I tested do not include
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535898#comment-16535898
]
Julian Hyde commented on CALCITE-2404:
--
I'm always surprised by every bug! But this one is kind of
[
https://issues.apache.org/jira/browse/CALCITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535752#comment-16535752
]
Stamatis Zampetakis commented on CALCITE-2404:
--
I am a bit surprised that I bumped into
35 matches
Mail list logo