[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-12-03 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708236#comment-16708236 ] Enrico Olivelli commented on CALCITE-2662: -- Thank you Julian and Vladmin for review   >

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-12-02 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706568#comment-16706568 ] Julian Hyde commented on CALCITE-2662: -- Reviewing and testing now. > Planner: allow parsing

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-12-01 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705766#comment-16705766 ] Enrico Olivelli commented on CALCITE-2662: -- [~julianhyde] patch is ready from my side. (sorry

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-11-30 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704932#comment-16704932 ] Julian Hyde commented on CALCITE-2662: -- It's OK if you provide "?" if someone asks for the

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-11-29 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703710#comment-16703710 ] Enrico Olivelli commented on CALCITE-2662: -- Just because I did not see any test case about the

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-11-29 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703687#comment-16703687 ] Julian Hyde commented on CALCITE-2662: -- Why do you think it is not useful for the user to see the

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-11-29 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703682#comment-16703682 ] Enrico Olivelli commented on CALCITE-2662: -- I will add tests. As 'originalinput' query seems

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-11-29 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703592#comment-16703592 ] Julian Hyde commented on CALCITE-2662: -- The fact that you are able to use a StringReader is a good

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-11-29 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703362#comment-16703362 ] Enrico Olivelli commented on CALCITE-2662: -- [~julianhyde] I have added a Proof-of-concept

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-11-26 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699484#comment-16699484 ] Enrico Olivelli commented on CALCITE-2662: -- Great. I will add the test soon     This is the

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-11-26 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699459#comment-16699459 ] Julian Hyde commented on CALCITE-2662: -- Can you attach a link to the PR? If the PR is

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-11-24 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697810#comment-16697810 ] Enrico Olivelli commented on CALCITE-2662: -- Sorry for late reply. I have updated the patch

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-11-08 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680695#comment-16680695 ] Julian Hyde commented on CALCITE-2662: -- I'm skeptical that this will give a significant

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-11-07 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679378#comment-16679378 ] Vladimir Sitnikov commented on CALCITE-2662: Would you probably add a test case to

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-11-07 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679377#comment-16679377 ] Vladimir Sitnikov commented on CALCITE-2662: [~eolivelli], have you seen