[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

2018-12-11 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716889#comment-16716889 ] Stamatis Zampetakis commented on CALCITE-2730: -- I pushed a new commit replacing based on

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

2018-12-10 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715326#comment-16715326 ] Julian Hyde commented on CALCITE-2730: -- I don't think we should use reference equality. I think we

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

2018-12-10 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715225#comment-16715225 ] Stamatis Zampetakis commented on CALCITE-2730: -- Even before the introduction of

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

2018-12-10 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715176#comment-16715176 ] Zoltan Haindrich commented on CALCITE-2730: --- without equals being fully operable: equals()

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

2018-12-10 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715130#comment-16715130 ] Stamatis Zampetakis commented on CALCITE-2730: -- Before the change of [~kgyrtkirk]

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

2018-12-10 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715080#comment-16715080 ] Zoltan Haindrich commented on CALCITE-2730: --- I wanted to suggest to prune duplicates prior to

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

2018-12-10 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715075#comment-16715075 ] Julian Hyde commented on CALCITE-2730: -- We’d lose a lot if we just remove duplicates. We should be

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

2018-12-10 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715036#comment-16715036 ] Zoltan Haindrich commented on CALCITE-2730: --- I think at that point replacing only the actual

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

2018-12-10 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715020#comment-16715020 ] Stamatis Zampetakis commented on CALCITE-2730: -- OK, now I see better. Probably it is the

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

2018-12-10 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714965#comment-16714965 ] Zoltan Haindrich commented on CALCITE-2730: --- It was working in 1.17 because "equals" was not

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

2018-12-10 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714949#comment-16714949 ] Stamatis Zampetakis commented on CALCITE-2730: -- Naive question, why it was working in

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

2018-12-10 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714874#comment-16714874 ] Zoltan Haindrich commented on CALCITE-2730: --- [~zabetak] the issue is with the fact that in

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

2018-12-07 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713355#comment-16713355 ] Stamatis Zampetakis commented on CALCITE-2730: -- I will try to have a look on Monday.

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

2018-12-07 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713095#comment-16713095 ] Zoltan Haindrich commented on CALCITE-2730: --- This seems to be caused by CALCITE-2632; if I

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

2018-12-07 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713048#comment-16713048 ] Stamatis Zampetakis commented on CALCITE-2730: -- I added a PR with a simple unit test. The