[
https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716889#comment-16716889
]
Stamatis Zampetakis commented on CALCITE-2730:
--
I pushed a new commit replacing based on
[
https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715326#comment-16715326
]
Julian Hyde commented on CALCITE-2730:
--
I don't think we should use reference equality. I think we
[
https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715225#comment-16715225
]
Stamatis Zampetakis commented on CALCITE-2730:
--
Even before the introduction of
[
https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715176#comment-16715176
]
Zoltan Haindrich commented on CALCITE-2730:
---
without equals being fully operable: equals()
[
https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715130#comment-16715130
]
Stamatis Zampetakis commented on CALCITE-2730:
--
Before the change of [~kgyrtkirk]
[
https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715080#comment-16715080
]
Zoltan Haindrich commented on CALCITE-2730:
---
I wanted to suggest to prune duplicates prior to
[
https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715075#comment-16715075
]
Julian Hyde commented on CALCITE-2730:
--
We’d lose a lot if we just remove duplicates. We should be
[
https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715036#comment-16715036
]
Zoltan Haindrich commented on CALCITE-2730:
---
I think at that point replacing only the actual
[
https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715020#comment-16715020
]
Stamatis Zampetakis commented on CALCITE-2730:
--
OK, now I see better. Probably it is the
[
https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714965#comment-16714965
]
Zoltan Haindrich commented on CALCITE-2730:
---
It was working in 1.17 because "equals" was not
[
https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714949#comment-16714949
]
Stamatis Zampetakis commented on CALCITE-2730:
--
Naive question, why it was working in
[
https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714874#comment-16714874
]
Zoltan Haindrich commented on CALCITE-2730:
---
[~zabetak] the issue is with the fact that in
[
https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713355#comment-16713355
]
Stamatis Zampetakis commented on CALCITE-2730:
--
I will try to have a look on Monday.
[
https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713095#comment-16713095
]
Zoltan Haindrich commented on CALCITE-2730:
---
This seems to be caused by CALCITE-2632; if I
[
https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713048#comment-16713048
]
Stamatis Zampetakis commented on CALCITE-2730:
--
I added a PR with a simple unit test. The
15 matches
Mail list logo