[jira] [Commented] (CALCITE-3029) Java-oriented field type is wrongly forced to be NOT NULL after being converted to SQL-oriented

2019-04-29 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829913#comment-16829913 ] Hongze Zhang commented on CALCITE-3029: --- I've updated the PR accordingly. > Java-oriented field

[jira] [Commented] (CALCITE-3029) Java-oriented field type is wrongly forced to be NOT NULL after being converted to SQL-oriented

2019-04-29 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829779#comment-16829779 ] Stamatis Zampetakis commented on CALCITE-3029: -- I agree with all of you; let's remove the

[jira] [Commented] (CALCITE-3029) Java-oriented field type is wrongly forced to be NOT NULL after being converted to SQL-oriented

2019-04-29 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829044#comment-16829044 ] Danny Chan commented on CALCITE-3029: - +1 to remove this flag, we should sync the nullability even

[jira] [Commented] (CALCITE-3029) Java-oriented field type is wrongly forced to be NOT NULL after being converted to SQL-oriented

2019-04-29 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829033#comment-16829033 ] Ruben Quesada Lopez commented on CALCITE-3029: -- {{mustSetNullability }} flag was

[jira] [Commented] (CALCITE-3029) Java-oriented field type is wrongly forced to be NOT NULL after being converted to SQL-oriented

2019-04-29 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829015#comment-16829015 ] Hongze Zhang commented on CALCITE-3029: --- Thanks [~rubenql] and [~zabetak]! And the PR is

[jira] [Commented] (CALCITE-3029) Java-oriented field type is wrongly forced to be NOT NULL after being converted to SQL-oriented

2019-04-29 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828991#comment-16828991 ] Ruben Quesada Lopez commented on CALCITE-3029: -- [~zhztheplayer], I'll take a look. >

[jira] [Commented] (CALCITE-3029) Java-oriented field type is wrongly forced to be NOT NULL after being converted to SQL-oriented

2019-04-28 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828034#comment-16828034 ] Stamatis Zampetakis commented on CALCITE-3029: -- OK sorry about that! Either me or

[jira] [Commented] (CALCITE-3029) Java-oriented field type is wrongly forced to be NOT NULL after being converted to SQL-oriented

2019-04-28 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828032#comment-16828032 ] Hongze Zhang commented on CALCITE-3029: --- Thanks [~zabetak]. Regarding the issue, I am more or

[jira] [Commented] (CALCITE-3029) Java-oriented field type is wrongly forced to be NOT NULL after being converted to SQL-oriented

2019-04-28 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828019#comment-16828019 ] Stamatis Zampetakis commented on CALCITE-3029: -- Thanks for bringing this up

[jira] [Commented] (CALCITE-3029) Java-oriented field type is wrongly forced to be NOT NULL after being converted to SQL-oriented

2019-04-28 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827905#comment-16827905 ] Hongze Zhang commented on CALCITE-3029: --- It seems that the issue is introduced by CALCITE-2464