[jira] [Commented] (CALCITE-3085) Unused stack field in RelShuttleImpl

2019-05-29 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851082#comment-16851082 ] Julian Hyde commented on CALCITE-3085: -- How about creating a class RelBasicShuttle implements

[jira] [Commented] (CALCITE-3085) Unused stack field in RelShuttleImpl

2019-05-28 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850155#comment-16850155 ] Laurent Goujon commented on CALCITE-3085: - It's so useful no subclasses uses it (unlike

[jira] [Commented] (CALCITE-3085) Unused stack field in RelShuttleImpl

2019-05-28 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850140#comment-16850140 ] Julian Hyde commented on CALCITE-3085: -- Has this issue shown up empirically? The stack is

[jira] [Commented] (CALCITE-3085) Unused stack field in RelShuttleImpl

2019-05-23 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847011#comment-16847011 ] Haisheng Yuan commented on CALCITE-3085: I can't find any usage of the stack either. So I agree

[jira] [Commented] (CALCITE-3085) Unused stack field in RelShuttleImpl

2019-05-22 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846395#comment-16846395 ] Laurent Goujon commented on CALCITE-3085: - This is why I did check on Github. [~danny0405] are

[jira] [Commented] (CALCITE-3085) Unused stack field in RelShuttleImpl

2019-05-22 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846349#comment-16846349 ] Danny Chan commented on CALCITE-3085: - I don't think it's a good idea to remove the stack, this

[jira] [Commented] (CALCITE-3085) Unused stack field in RelShuttleImpl

2019-05-22 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846271#comment-16846271 ] Laurent Goujon commented on CALCITE-3085: - Alternative would be to create a variant of the