[jira] [Commented] (CALCITE-5044) OrderBy constant executing RelToSql ambiguously

2022-03-23 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511503#comment-17511503 ] Julian Hyde commented on CALCITE-5044: -- Reviewing and testing now. There's significant

[jira] [Commented] (CALCITE-5044) OrderBy constant executing RelToSql ambiguously

2022-03-23 Thread Xurenhe (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511322#comment-17511322 ] Xurenhe commented on CALCITE-5044: -- Ok, Got it. It's really closely related to *isOrderByOrdinal()*

[jira] [Commented] (CALCITE-5044) OrderBy constant executing RelToSql ambiguously

2022-03-22 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510811#comment-17510811 ] Julian Hyde commented on CALCITE-5044: -- I don't think anyone would want one dialect to remove

[jira] [Commented] (CALCITE-5044) OrderBy constant executing RelToSql ambiguously

2022-03-22 Thread Xurenhe (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510502#comment-17510502 ] Xurenhe commented on CALCITE-5044: -- Yes, I agree with you. We could define a

[jira] [Commented] (CALCITE-5044) OrderBy constant executing RelToSql ambiguously

2022-03-17 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508327#comment-17508327 ] Julian Hyde commented on CALCITE-5044: -- {{Context.orderField}} gets called when they want to sort

[jira] [Commented] (CALCITE-5044) OrderBy constant executing RelToSql ambiguously

2022-03-17 Thread Xurenhe (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508201#comment-17508201 ] Xurenhe commented on CALCITE-5044: -- *Context#orderField* should return null if the current dialect

[jira] [Commented] (CALCITE-5044) OrderBy constant executing RelToSql ambiguously

2022-03-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507827#comment-17507827 ] Julian Hyde commented on CALCITE-5044: -- Yes, it would be better if {{RelToSqlConverter}} did this.

[jira] [Commented] (CALCITE-5044) OrderBy constant executing RelToSql ambiguously

2022-03-16 Thread Xurenhe (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17507678#comment-17507678 ] Xurenhe commented on CALCITE-5044: -- [~julianhyde]  I'm very glad to receive your reply. I choose first

[jira] [Commented] (CALCITE-5044) OrderBy constant executing RelToSql ambiguously

2022-03-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506970#comment-17506970 ] Julian Hyde commented on CALCITE-5044: -- One option is to remove the sort key. Unlike GROUP BY,