[jira] [Updated] (CALCITE-3201) SqlValidator throws exception for sql insert target table with virtual columns

2019-07-18 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3201: Summary: SqlValidator throws exception for sql insert target table with virtual columns (was:

[jira] [Updated] (CALCITE-3201) Skip validation for sql insert columns with column strategy that can not insert into

2019-07-18 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3201: Description: Now if we have a target table with schema: {code:sql} t1 : - a int not null - b

[jira] [Updated] (CALCITE-3201) Skip validation for sql insert columns with column strategy that can not insert into

2019-07-18 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3201: Description: Now if we have a target table with schema: {code:sql} t1 : - a int not null - b

[jira] [Created] (CALCITE-3201) Skip validation for sql insert columns with column strategy that can not insert into

2019-07-17 Thread Danny Chan (JIRA)
Danny Chan created CALCITE-3201: --- Summary: Skip validation for sql insert columns with column strategy that can not insert into Key: CALCITE-3201 URL: https://issues.apache.org/jira/browse/CALCITE-3201

[jira] [Commented] (CALCITE-3113) Equivalent MutableAggregates with different row types fail with AssertionError

2019-07-17 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886908#comment-16886908 ] Danny Chan commented on CALCITE-3113: - Fixed in

[jira] [Resolved] (CALCITE-3113) Equivalent MutableAggregates with different row types fail with AssertionError

2019-07-17 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3113. - Resolution: Fixed Assignee: Danny Chan Fix Version/s: 1.21.0 > Equivalent

[jira] [Updated] (CALCITE-3186) IN expressions in UPDATE statements throws Exceptions

2019-07-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3186: Summary: IN expressions in UPDATE statements throws Exceptions (was: IN expressions in UPDATE

[jira] [Assigned] (CALCITE-3196) In Frameworks, add BasePrepareAction (a functional interface) and deprecate PrepareAction

2019-07-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3196: --- Assignee: Danny Chan > In Frameworks, add BasePrepareAction (a functional interface) and

[jira] [Commented] (CALCITE-3155) AssertionError in RelToSqlConverter when visiting empty Values node

2019-07-11 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883461#comment-16883461 ] Danny Chan commented on CALCITE-3155: - [~julianhyde] If the whole `values` statement is special

[jira] [Resolved] (CALCITE-3188) IndexOutOfBoundsException in ProjectFilterTransposeRule when executing SELECT COUNT(*)

2019-07-11 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3188. - Resolution: Fixed Fixed in

[jira] [Issue Comment Deleted] (CALCITE-3188) IndexOutOfBoundsException in ProjectFilterTransposeRule when executing SELECT COUNT(*)

2019-07-10 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3188: Comment: was deleted (was: [~zabetak], thanks for reporting this, i tried but don't know how to

[jira] [Commented] (CALCITE-3188) IndexOutOfBoundsException in ProjectFilterTransposeRule when executing SELECT COUNT(*)

2019-07-10 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882638#comment-16882638 ] Danny Chan commented on CALCITE-3188: - [~zabetak], thanks for reporting this, i tried but don't

[jira] [Commented] (CALCITE-3188) IndexOutOfBoundsException in ProjectFilterTransposeRule when executing SELECT COUNT(*)

2019-07-10 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882042#comment-16882042 ] Danny Chan commented on CALCITE-3188: - [~zabetak] It seems that the row type is a struct type but

[jira] [Assigned] (CALCITE-3188) IndexOutOfBoundsException in ProjectFilterTransposeRule when executing SELECT COUNT(*)

2019-07-10 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3188: --- Assignee: Danny Chan > IndexOutOfBoundsException in ProjectFilterTransposeRule when

[jira] [Commented] (CALCITE-3188) IndexOutOfBoundsException in ProjectFilterTransposeRule when executing SELECT COUNT(*)

2019-07-10 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882015#comment-16882015 ] Danny Chan commented on CALCITE-3188: - Thanks [~zabetak], i will take a look ! >

[jira] [Commented] (CALCITE-3187) Derive all decimal return type through type factory

2019-07-10 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882006#comment-16882006 ] Danny Chan commented on CALCITE-3187: - You can use the operators table of your own(not the

[jira] [Commented] (CALCITE-3187) Derive all decimal return type through type factory

2019-07-10 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881752#comment-16881752 ] Danny Chan commented on CALCITE-3187: - The `SqlReturnTypeInference DECIMAL_SUM` itself is designed

[jira] [Assigned] (CALCITE-3083) Add demos(how to) doc for all supported DDLs and DMLs

2019-07-08 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3083: --- Assignee: (was: Danny Chan) > Add demos(how to) doc for all supported DDLs and DMLs >

[jira] [Commented] (CALCITE-3184) Add the new logo to the website

2019-07-08 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880845#comment-16880845 ] Danny Chan commented on CALCITE-3184: - In out mailing list, the font of the logo are color dark

[jira] [Resolved] (CALCITE-3170) ANTI join on conditions push down generates wrong plan

2019-07-08 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3170. - Resolution: Fixed Fix Version/s: 1.21.0 Fixed in

[jira] [Updated] (CALCITE-3169) RelDecorrelator should return for SEMI/ANTI join decorrelate

2019-07-08 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3169: Summary: RelDecorrelator should return for SEMI/ANTI join decorrelate (was: RelDecorrelator

[jira] [Updated] (CALCITE-3169) RelDecorrelator should return for SEMI/ANTI join decorrelation

2019-07-08 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3169: Summary: RelDecorrelator should return for SEMI/ANTI join decorrelation (was: decorrelateRel

[jira] [Resolved] (CALCITE-3169) decorrelateRel method should return when meeting SEMI/ANTI join in RelDecorrelator

2019-07-08 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3169. - Resolution: Fixed Fixed in 

[jira] [Assigned] (CALCITE-3169) decorrelateRel method should return when meeting SEMI/ANTI join in RelDecorrelator

2019-07-08 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3169: --- Assignee: Danny Chan > decorrelateRel method should return when meeting SEMI/ANTI join in

[jira] [Resolved] (CALCITE-3171) SemiJoin on conditions push down throws IndexOutOfBoundsException

2019-07-08 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3171. - Resolution: Fixed Fix Version/s: 1.21.0 Fixed in 

[jira] [Comment Edited] (CALCITE-2843) Babel parser should parse PostgreSQL-style '::' cast operator

2019-07-08 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880063#comment-16880063 ] Danny Chan edited comment on CALCITE-2843 at 7/8/19 6:50 AM: - Thanks,

[jira] [Commented] (CALCITE-2843) Babel parser should parse PostgreSQL-style '::' cast operator

2019-07-08 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880063#comment-16880063 ] Danny Chan commented on CALCITE-2843: - Thanks, [~mgelbana], lets try {{SqlStdOperatorTable.CAST}} 

[jira] [Updated] (CALCITE-3171) SemiJoin on conditions push down throws IndexOutOfBoundsException

2019-07-06 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3171: Summary: SemiJoin on conditions push down throws IndexOutOfBoundsException (was:

[jira] [Assigned] (CALCITE-3171) SemiJoin on conditions push down throws IndexOutOfBoundsException

2019-07-06 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3171: --- Assignee: Danny Chan > SemiJoin on conditions push down throws IndexOutOfBoundsException

[jira] [Updated] (CALCITE-3170) ANTI join on conditions push down generates wrong plan

2019-07-06 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3170: Summary: ANTI join on conditions push down generates wrong plan (was: join condition of ANTI

[jira] [Assigned] (CALCITE-3170) join condition of ANTI join can not be pushed down

2019-07-06 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3170: --- Assignee: Danny Chan > join condition of ANTI join can not be pushed down >

[jira] [Commented] (CALCITE-3100) cast(? as DATE) won't work with PreparedStatement

2019-07-06 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879659#comment-16879659 ] Danny Chan commented on CALCITE-3100: - Thanks for you contribution [~yuqi], reviewing now ~~ You

[jira] [Resolved] (CALCITE-3121) VolcanoPlanner hangs due to subquery with dynamic star

2019-07-03 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3121. - Resolution: Fixed Fixed in

[jira] [Updated] (CALCITE-3152) Unify throws in sql parser

2019-07-02 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3152: Issue Type: Improvement (was: Bug) > Unify throws in sql parser > -- >

[jira] [Resolved] (CALCITE-3168) Add test for invalid literal of sql parser

2019-07-02 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3168. - Resolution: Fixed Fix Version/s: 1.21.0 Fixed in

[jira] [Commented] (CALCITE-3152) Unify throws in sql parser

2019-07-02 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877435#comment-16877435 ] Danny Chan commented on CALCITE-3152: - Thanks, i have fired another issue CALCITE-3168, and will

[jira] [Created] (CALCITE-3168) Add test for invalid literal of sql parser

2019-07-02 Thread Danny Chan (JIRA)
Danny Chan created CALCITE-3168: --- Summary: Add test for invalid literal of sql parser Key: CALCITE-3168 URL: https://issues.apache.org/jira/browse/CALCITE-3168 Project: Calcite Issue Type:

[jira] [Resolved] (CALCITE-3152) Unify throws in sql parser

2019-07-02 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3152. - Resolution: Fixed Fixed in

[jira] [Comment Edited] (CALCITE-3121) VolcanoPlanner hangs due to subquery with dynamic star

2019-07-02 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876697#comment-16876697 ] Danny Chan edited comment on CALCITE-3121 at 7/2/19 8:32 AM: - Well, finally

[jira] [Commented] (CALCITE-3121) VolcanoPlanner hangs due to subquery with dynamic star

2019-07-02 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876697#comment-16876697 ] Danny Chan commented on CALCITE-3121: - Well, finally i got the reason, now the

[jira] [Updated] (CALCITE-3121) VolcanoPlanner hangs due to subquery with dynamic star

2019-07-02 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3121: Summary: VolcanoPlanner hangs due to subquery with dynamic star (was: VolcanoPlanner hangs due

[jira] [Commented] (CALCITE-3166) Make RelBuilder configurable

2019-07-01 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876677#comment-16876677 ] Danny Chan commented on CALCITE-3166: - Thanks [~julianhyde], i'm ok with this Context unwrap, cause

[jira] [Commented] (CALCITE-3152) Unify throws in sql parser

2019-07-01 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876604#comment-16876604 ] Danny Chan commented on CALCITE-3152: - I'm gonna merge this PR if there are no more comments in 24

[jira] [Commented] (CALCITE-3166) Make RelBuilder configurable

2019-07-01 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876603#comment-16876603 ] Danny Chan commented on CALCITE-3166: - Reviewed and left some comments. > Make RelBuilder

[jira] [Commented] (CALCITE-3161) Remove deprecated SemiJoinType usage completely

2019-07-01 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876064#comment-16876064 ] Danny Chan commented on CALCITE-3161: - [~rubenql] Oops, i'm so sorry that i missed your JIRA issue,

[jira] [Created] (CALCITE-3161) Remove deprecated SemiJoinType usage completely

2019-07-01 Thread Danny Chan (JIRA)
Danny Chan created CALCITE-3161: --- Summary: Remove deprecated SemiJoinType usage completely Key: CALCITE-3161 URL: https://issues.apache.org/jira/browse/CALCITE-3161 Project: Calcite Issue

[jira] [Resolved] (CALCITE-3126) Remove deprecated SemiJoin usage completely

2019-07-01 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3126. - Resolution: Fixed Fixed in 

[jira] [Resolved] (CALCITE-3155) AssertionError in RelToSqlConverter when visiting empty Values node

2019-06-30 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3155. - Resolution: Fixed Assignee: Danny Chan Fixed in 

[jira] [Updated] (CALCITE-3155) AssertionError in RelToSqlConverter when visiting empty Values node

2019-06-30 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3155: Fix Version/s: 1.21.0 > AssertionError in RelToSqlConverter when visiting empty Values node >

[jira] [Updated] (CALCITE-3152) Unify throws in sql parser

2019-06-27 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3152: Description: Copied from DEV mail, Now our parser has 3 kinds of throws behavior: [1] Use

[jira] [Created] (CALCITE-3152) Unify throws in sql parser

2019-06-27 Thread Danny Chan (JIRA)
Danny Chan created CALCITE-3152: --- Summary: Unify throws in sql parser Key: CALCITE-3152 URL: https://issues.apache.org/jira/browse/CALCITE-3152 Project: Calcite Issue Type: Bug

[jira] [Updated] (CALCITE-3152) Unify throws in sql parser

2019-06-27 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3152: Environment: (was: {color:#33}Copied from DEV mail,{color} {color:#33}Now our parser

[jira] [Commented] (CALCITE-3128) Joining two tables producing only NULLs will return 0 rows

2019-06-27 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874592#comment-16874592 ] Danny Chan commented on CALCITE-3128: - [~julianhyde] thanks, {quote}if the condition is '(t1.c is

[jira] [Resolved] (CALCITE-3148) Validator throws IndexOutOfBoundsException for SqlInsert when source and sink have non-equal fields number

2019-06-27 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3148. - Resolution: Fixed Fixed in 

[jira] [Created] (CALCITE-3148) Validator throws IndexOutOfBoundsException for SqlInsert when source and sink have non-equal fields number

2019-06-26 Thread Danny Chan (JIRA)
Danny Chan created CALCITE-3148: --- Summary: Validator throws IndexOutOfBoundsException for SqlInsert when source and sink have non-equal fields number Key: CALCITE-3148 URL:

[jira] [Updated] (CALCITE-3142) An NPE when rounding a nullable numeric

2019-06-26 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3142: Summary: An NPE when rounding a nullable numeric (was: A NPE when rounding a nullable numeric)

[jira] [Commented] (CALCITE-3128) Joining two tables producing only NULLs will return 0 rows

2019-06-26 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873015#comment-16873015 ] Danny Chan commented on CALCITE-3128: - [~mgelbana] Thanks for your test case, i have applied a PR 

[jira] [Assigned] (CALCITE-3128) Joining two tables producing only NULLs will return 0 rows

2019-06-25 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3128: --- Assignee: Danny Chan > Joining two tables producing only NULLs will return 0 rows >

[jira] [Commented] (CALCITE-3140) Multiple failures when executing slow tests

2019-06-24 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871920#comment-16871920 ] Danny Chan commented on CALCITE-3140: - For "separately" i mean to run them in the IDEA test suit,

[jira] [Commented] (CALCITE-3128) Joining two tables producing only NULLs will return 0 rows

2019-06-24 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871051#comment-16871051 ] Danny Chan commented on CALCITE-3128: - While i execute the query in MYSQL 5.6: {code:sql} SELECT

[jira] [Commented] (CALCITE-3140) Multiple failures when executing slow tests

2019-06-24 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871046#comment-16871046 ] Danny Chan commented on CALCITE-3140: - [~zabetak] I ran them separately, and there is no error for

[jira] [Commented] (CALCITE-771) Use materialization for scan-project-sort query

2019-06-24 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871020#comment-16871020 ] Danny Chan commented on CALCITE-771: Thanks, [~donnyzone], i have left some review comments. > Use

[jira] [Commented] (CALCITE-3140) Multiple failures when executing slow tests

2019-06-22 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870400#comment-16870400 ] Danny Chan commented on CALCITE-3140: - Thanks [~zabetak] for reporting this. > Multiple failures

[jira] [Commented] (CALCITE-3132) Simply expressions in LogicalFilter generated for subqueries with quantified predicate

2019-06-18 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866589#comment-16866589 ] Danny Chan commented on CALCITE-3132: - Thanks, [~vgarg], the later 2 AND predicates are indeed

[jira] [Created] (CALCITE-3126) Remove deprecated SemiJoin usage completely

2019-06-12 Thread Danny Chan (JIRA)
Danny Chan created CALCITE-3126: --- Summary: Remove deprecated SemiJoin usage completely Key: CALCITE-3126 URL: https://issues.apache.org/jira/browse/CALCITE-3126 Project: Calcite Issue Type:

[jira] [Comment Edited] (CALCITE-3121) VolcanoPlanner hangs due to removing ORDER BY from sub-query

2019-06-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862010#comment-16862010 ] Danny Chan edited comment on CALCITE-3121 at 6/12/19 11:20 AM: --- If we

[jira] [Commented] (CALCITE-3121) VolcanoPlanner hangs due to removing ORDER BY from sub-query

2019-06-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862010#comment-16862010 ] Danny Chan commented on CALCITE-3121: - If we change the sql to {code:java} String sql = "select

[jira] [Commented] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-11 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861715#comment-16861715 ] Danny Chan commented on CALCITE-3118: - Okey, finally i believe this is a bug For this case, it

[jira] [Commented] (CALCITE-2744) RelDecorrelator use wrong output map for LogicalAggregate decorrelate

2019-06-10 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859828#comment-16859828 ] Danny Chan commented on CALCITE-2744: - Thanks [~julianhyde], i still apply the fix because i think

[jira] [Commented] (CALCITE-2822) Allow multi-join rules to be used with any project/filter

2019-06-09 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859694#comment-16859694 ] Danny Chan commented on CALCITE-2822: - The master branch build fails from this 

[jira] [Commented] (CALCITE-2744) RelDecorrelator use wrong output map for LogicalAggregate decorrelate

2019-06-09 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859670#comment-16859670 ] Danny Chan commented on CALCITE-2744: - [~julianhyde] I fired  a fix in 

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-06-09 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859664#comment-16859664 ] Danny Chan commented on CALCITE-3005: - An compile warning of JavaCC throws: {code:java} Warning:

[jira] [Commented] (CALCITE-3121) VolcanoPlanner hangs due to removing ORDER BY from sub-query

2019-06-07 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859104#comment-16859104 ] Danny Chan commented on CALCITE-3121: - It seems that after some planning rules matched, In

[jira] [Assigned] (CALCITE-3121) VolcanoPlanner hangs due to removing ORDER BY from sub-query

2019-06-07 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3121: --- Assignee: Danny Chan > VolcanoPlanner hangs due to removing ORDER BY from sub-query >

[jira] [Comment Edited] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-07 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859078#comment-16859078 ] Danny Chan edited comment on CALCITE-3118 at 6/8/19 2:20 AM: - I'm -1 on

[jira] [Commented] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-07 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859078#comment-16859078 ] Danny Chan commented on CALCITE-3118: - I'm -1 on this fix. Just like you said, 

[jira] [Commented] (CALCITE-3118) VolcanoRuleCall match parent child ordinal not properly checked

2019-06-07 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858325#comment-16858325 ] Danny Chan commented on CALCITE-3118: - I don't know why you make {{leftPhy}} and {{rightPhy}} 

[jira] [Commented] (CALCITE-3117) Distinguish Calcite's public APIs

2019-06-06 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858282#comment-16858282 ] Danny Chan commented on CALCITE-3117: - The parser and sql node should be split out of the

[jira] [Comment Edited] (CALCITE-2829) Use consistent types when processing ranges

2019-06-06 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858261#comment-16858261 ] Danny Chan edited comment on CALCITE-2829 at 6/7/19 2:40 AM: - Sure, the

[jira] [Commented] (CALCITE-2829) Use consistent types when processing ranges

2019-06-06 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858261#comment-16858261 ] Danny Chan commented on CALCITE-2829: - Sure, the more test cases the better, i would link this

[jira] [Commented] (CALCITE-3114) Support websocket transport

2019-06-06 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857429#comment-16857429 ] Danny Chan commented on CALCITE-3114: - What do you mean by websocket transport ? > Support

[jira] [Commented] (CALCITE-2280) Liberal "babel" parser that accepts all SQL dialects

2019-06-06 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857366#comment-16857366 ] Danny Chan commented on CALCITE-2280: - This is actually what we have to do in Flink custom parser,

[jira] [Commented] (CALCITE-2744) RelDecorrelator use wrong output map for LogicalAggregate decorrelate

2019-06-05 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857220#comment-16857220 ] Danny Chan commented on CALCITE-2744: - Fixed in 

[jira] [Resolved] (CALCITE-2744) RelDecorrelator use wrong output map for LogicalAggregate decorrelate

2019-06-05 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-2744. - Resolution: Fixed Fix Version/s: 1.20.0 > RelDecorrelator use wrong output map for

[jira] [Commented] (CALCITE-2968) New AntiJoin relational expression

2019-06-05 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856680#comment-16856680 ] Danny Chan commented on CALCITE-2968: - [~rubenql] I have also reviewed this PR and +1 for merging

[jira] [Commented] (CALCITE-3111) Allow custom implementations of Correlate in RelDecorrelator

2019-06-05 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856621#comment-16856621 ] Danny Chan commented on CALCITE-3111: - Thanks [~zabetak], but what is the meaning to support nodes

[jira] [Commented] (CALCITE-2280) Liberal "babel" parser that accepts all SQL dialects

2019-06-05 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856620#comment-16856620 ] Danny Chan commented on CALCITE-2280: - [~julianhyde] The Babel parser can mix-in all kinds of sql

[jira] [Commented] (CALCITE-2744) RelDecorrelator use wrong output map for LogicalAggregate decorrelate

2019-06-04 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856331#comment-16856331 ] Danny Chan commented on CALCITE-2744: - [~julianhyde] I think there is some problem with the

[jira] [Commented] (CALCITE-3101) PushDownJoinConditions is not always a valid transformation

2019-06-04 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856291#comment-16856291 ] Danny Chan commented on CALCITE-3101: - +1, project a boolean used for filtering seems a pattern

[jira] [Comment Edited] (CALCITE-2744) RelDecorrelator use wrong output map for LogicalAggregate decorrelate

2019-06-04 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856237#comment-16856237 ] Danny Chan edited comment on CALCITE-2744 at 6/5/19 2:17 AM: - I digged into

[jira] [Commented] (CALCITE-2744) RelDecorrelator use wrong output map for LogicalAggregate decorrelate

2019-06-04 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856237#comment-16856237 ] Danny Chan commented on CALCITE-2744: - I digged into the code and found that it is not because the

[jira] [Updated] (CALCITE-2744) RelDecorrelator use wrong output map for aggregate decorrelate

2019-06-04 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-2744: Summary: RelDecorrelator use wrong output map for aggregate decorrelate (was: Throws

[jira] [Updated] (CALCITE-2744) RelDecorrelator use wrong output map for LogicalAggregate decorrelate

2019-06-04 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-2744: Summary: RelDecorrelator use wrong output map for LogicalAggregate decorrelate (was:

[jira] [Reopened] (CALCITE-2744) Throws RuntimeException in RelDecorrelator when optimizing a Semi-Join query with a multi-param aggregate function in subquery

2019-06-03 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reopened CALCITE-2744: - > Throws RuntimeException in RelDecorrelator when optimizing a Semi-Join query > with a

[jira] [Updated] (CALCITE-2744) Throws RuntimeException in RelDecorrelator when optimizing a Semi-Join query with a multi-param aggregate function in subquery

2019-06-03 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-2744: Affects Version/s: (was: 1.17.0) 1.20.0 > Throws RuntimeException in

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

2019-05-31 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853520#comment-16853520 ] Danny Chan commented on CALCITE-2969: - Thanks [~rubenql], i would recheck the doc to see if i

[jira] [Commented] (CALCITE-3102) Deprecation warnings following [CALCITE-2969]

2019-05-31 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853515#comment-16853515 ] Danny Chan commented on CALCITE-3102: - Sorry for that [~julianhyde], i should have waited for your

[jira] [Commented] (CALCITE-3100) cast(? as DATE) won't work with PreparedStatement

2019-05-31 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852857#comment-16852857 ] Danny Chan commented on CALCITE-3100: - This is generated code: {code:java} return new

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

2019-05-31 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852772#comment-16852772 ] Danny Chan commented on CALCITE-2973: - +1 to skip this patch for 1.20 version. > Allow theta joins

[jira] [Commented] (CALCITE-3100) cast(? as DATE) won't work with PreparedStatement

2019-05-31 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852760#comment-16852760 ] Danny Chan commented on CALCITE-3100: - I have tried all other data types, it seems that all of the

<    1   2   3   4   5   6   >