[jira] [Commented] (CALCITE-6259) The implementation of the Log library operator does not match the actual dialect behavior.

2024-02-19 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818583#comment-17818583 ] Julian Hyde commented on CALCITE-6259: -- Go with [~mbudiu]'s method (separate SQL functions). But

[jira] [Commented] (CALCITE-6120) Add MATCHES_FILTER function, to match on Looker-style filter expressions

2024-02-17 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818221#comment-17818221 ] Julian Hyde commented on CALCITE-6120: -- I've started work. Dev branch:

[jira] [Assigned] (CALCITE-6120) Add MATCHES_FILTER function, to match on Looker-style filter expressions

2024-02-17 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde reassigned CALCITE-6120: Assignee: Julian Hyde > Add MATCHES_FILTER function, to match on Looker-style filter

[jira] [Commented] (CALCITE-6219) Support SQL Validation for Tables with columns tagged as 'filter required'

2024-02-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818121#comment-17818121 ] Julian Hyde commented on CALCITE-6219: -- [~oliverlee], I have added a few more cleanup commits in

[jira] [Commented] (CALCITE-6268) Support implementing custom JdbcSchema

2024-02-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818011#comment-17818011 ] Julian Hyde commented on CALCITE-6268: -- Why should we allow this? What is the problem you’re

[jira] [Commented] (CALCITE-6266) SqlValidatorException with LATERAL TABLE and JOIN

2024-02-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817803#comment-17817803 ] Julian Hyde commented on CALCITE-6266: -- That makes sense. I had the same hypothesis. But if the

[jira] [Commented] (CALCITE-6266) SqlValidatorException with LATERAL TABLE and JOIN

2024-02-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817764#comment-17817764 ] Julian Hyde commented on CALCITE-6266: -- It's quite possible that the new behavior is correct, and

[jira] [Commented] (CALCITE-6259) The implementation of the Log library operator does not match the actual dialect behavior.

2024-02-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817763#comment-17817763 ] Julian Hyde commented on CALCITE-6259: -- As I said above, the behavior of LOGx functions should be

[jira] [Commented] (CALCITE-6263) Discuss the coupling of Calcite with JTS

2024-02-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817762#comment-17817762 ] Julian Hyde commented on CALCITE-6263: -- I used string (WKT) as a simple example; binary (WKB)

[jira] [Updated] (CALCITE-6239) Add a postgis dialect that supports ST functions

2024-02-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6239: - Component/s: spatial > Add a postgis dialect that supports ST functions >

[jira] [Updated] (CALCITE-6239) Add a PostGIS dialect that supports ST_ functions

2024-02-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6239: - Summary: Add a PostGIS dialect that supports ST_ functions (was: Add a postgis dialect that

[jira] [Commented] (CALCITE-6265) Cannot provide different numeric type as placeholder

2024-02-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817759#comment-17817759 ] Julian Hyde commented on CALCITE-6265: -- Sure, it shows up in Calcite, but it's due to Avatica not

[jira] [Commented] (CALCITE-6252) BigQuery FORMAT_DATE uses the wrong calendar for Julian dates

2024-02-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817721#comment-17817721 ] Julian Hyde commented on CALCITE-6252: -- It's OK to change the summary, but it might be OK to keep

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-02-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817552#comment-17817552 ] Julian Hyde commented on CALCITE-6248: -- I understand your chain of reasoning. But it is flawed,

[jira] [Commented] (CALCITE-6263) Discuss the coupling of Calcite with JTS

2024-02-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817551#comment-17817551 ] Julian Hyde commented on CALCITE-6263: -- I don't mind Calcite having *some* coupling to JTS, but

[jira] [Commented] (CALCITE-6265) Cannot provide different numeric type as placeholder

2024-02-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817548#comment-17817548 ] Julian Hyde commented on CALCITE-6265: -- I think the bug is in Avatica - or at any rate, Avatica is

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-02-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817544#comment-17817544 ] Julian Hyde commented on CALCITE-6248: -- I think we should remain reasonably liberal in the format

[jira] [Commented] (CALCITE-6261) RelBuilder.aggregate() field pruning does not use permuted field indices when used with force project and duplicate agg calls

2024-02-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817542#comment-17817542 ] Julian Hyde commented on CALCITE-6261: -- [~zrlpar], No hurry. I know how corporate lawyers can be.

[jira] [Commented] (CALCITE-6261) RelBuilder.aggregate() field pruning does not use permuted field indices when used with force project and duplicate agg calls

2024-02-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817432#comment-17817432 ] Julian Hyde commented on CALCITE-6261: -- [~zrlpar], Thanks for taking this on. I have set

[jira] [Updated] (CALCITE-6261) RelBuilder.aggregate() field pruning does not use permuted field indices when used with force project and duplicate agg calls

2024-02-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6261: - Fix Version/s: 1.37.0 > RelBuilder.aggregate() field pruning does not use permuted field

[jira] [Resolved] (CALCITE-5888) Assertion error in aggregate

2024-02-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-5888. -- Fix Version/s: 1.37.0 Resolution: Duplicate Marking resolved as a duplicate; all work

[jira] [Commented] (CALCITE-6239) Add a postgis dialect that supports ST functions

2024-02-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816823#comment-17816823 ] Julian Hyde commented on CALCITE-6239: -- I reviewed the PR, looks pretty good. However, the change

[jira] [Commented] (CALCITE-6259) Return the result with the log10 and log functions of argument 0

2024-02-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816776#comment-17816776 ] Julian Hyde commented on CALCITE-6259: -- 1. Whatever behavior we choose, let's make sure the

[jira] [Commented] (CALCITE-6261) RelBuilder.aggregate() field pruning does not use permuted field indices when used with force project and duplicate agg calls

2024-02-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816710#comment-17816710 ] Julian Hyde commented on CALCITE-6261: -- Thanks for logging this; and I agree that it looks like a

[jira] [Commented] (CALCITE-6219) Support SQL Validation for Tables with columns tagged as 'filter required'

2024-02-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816265#comment-17816265 ] Julian Hyde commented on CALCITE-6219: -- [~oliverlee], In my

[jira] [Commented] (CALCITE-6244) Improve `Expressions#constant` to allow passing models with non-public fields

2024-02-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816218#comment-17816218 ] Julian Hyde commented on CALCITE-6244: -- Can you link the PR? (If you use CALCITE-6244 in the

[jira] [Commented] (CALCITE-6252) BigQuery FORMAT_DATE uses the wrong calendar for Julian dates

2024-02-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816211#comment-17816211 ] Julian Hyde commented on CALCITE-6252: -- [~mbudiu], In your PR, you deal with "" (full weekday

[jira] [Resolved] (CALCITE-6256) Incorrect rendering of HTML on InnoDB adapter page

2024-02-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-6256. -- Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-6256) Incorrect rendering of HTML on InnoDB adapter page

2024-02-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815870#comment-17815870 ] Julian Hyde commented on CALCITE-6256: -- The problems seem to start much earlier in the document,

[jira] [Commented] (CALCITE-2980) Implement the FORMAT clause of the CAST operator

2024-02-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815855#comment-17815855 ] Julian Hyde commented on CALCITE-2980: -- No apology needed. It's just good to state your goals

[jira] [Commented] (CALCITE-2980) Implement the FORMAT clause of the CAST operator

2024-02-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815849#comment-17815849 ] Julian Hyde commented on CALCITE-2980: -- [~jerin_john], In this PR do you intend to support

[jira] [Commented] (CALCITE-6252) BigQuery FORMAT_DATE uses the wrong calendar for Julian dates

2024-02-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815818#comment-17815818 ] Julian Hyde commented on CALCITE-6252: -- Ah, thanks [~mbudiu], sounds like we're on the same page.

[jira] [Commented] (CALCITE-6252) BigQuery FORMAT_DATE uses the wrong calendar for Julian dates

2024-02-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815809#comment-17815809 ] Julian Hyde commented on CALCITE-6252: -- My understanding is that SQL date values (e.g. {{DATE

[jira] [Commented] (CALCITE-6252) BigQuery FORMAT_DATE uses the wrong calendar for Julian dates

2024-02-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815808#comment-17815808 ] Julian Hyde commented on CALCITE-6252: -- Is this related to (or caused by) CALCITE-1884 or

[jira] [Comment Edited] (CALCITE-6254) Enable calling table functions without requiring TABLE() wrapper

2024-02-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815804#comment-17815804 ] Julian Hyde edited comment on CALCITE-6254 at 2/8/24 7:08 PM: -- Also note

[jira] [Commented] (CALCITE-6254) Enable calling table functions without requiring TABLE() wrapper

2024-02-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815804#comment-17815804 ] Julian Hyde commented on CALCITE-6254: -- Also note that {{TABLE tableName}} is a separate syntax

[jira] [Resolved] (CALCITE-1490) Allow table functions without explicit TABLE

2024-02-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-1490. -- Fix Version/s: 1.37.0 Resolution: Duplicate > Allow table functions without explicit

[jira] [Commented] (CALCITE-6254) Enable calling table functions without requiring TABLE() wrapper

2024-02-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815801#comment-17815801 ] Julian Hyde commented on CALCITE-6254: -- Thanks for this. The subject arose when we implemented

[jira] [Comment Edited] (CALCITE-6252) BigQuery FORMAT_DATE seems to use the wrong calendar for Julian dates

2024-02-07 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815479#comment-17815479 ] Julian Hyde edited comment on CALCITE-6252 at 2/8/24 2:30 AM: -- Do you know

[jira] [Commented] (CALCITE-6252) BigQuery FORMAT_DATE seems to use the wrong calendar for Julian dates

2024-02-07 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815479#comment-17815479 ] Julian Hyde commented on CALCITE-6252: -- Do you know what date BigQuery diverges from Calcite? Is

[jira] [Commented] (CALCITE-6240) Remove ROW_NUMBER if OVER PARTITION BY unique key

2024-02-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814506#comment-17814506 ] Julian Hyde commented on CALCITE-6240: -- Also related to CALCITE-5406, because {code:java} SELECT

[jira] [Commented] (CALCITE-6237) Using fractions in LOG function does not return correct results

2024-02-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814503#comment-17814503 ] Julian Hyde commented on CALCITE-6237: -- +1 [~asolimando] [~caicancai], Often the hardest problem

[jira] [Comment Edited] (CALCITE-6240) Remove ROW_NUMBER if OVER PARTITION BY unique key

2024-02-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814498#comment-17814498 ] Julian Hyde edited comment on CALCITE-6240 at 2/5/24 8:02 PM: -- Regarding

[jira] [Commented] (CALCITE-6240) Remove ROW_NUMBER if OVER PARTITION BY unique key

2024-02-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814498#comment-17814498 ] Julian Hyde commented on CALCITE-6240: -- Can this behavior be described by an algebraic property?

[jira] [Commented] (CALCITE-6244) Improve `Expressions#constant` to allow passing models with non-public fields

2024-02-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814429#comment-17814429 ] Julian Hyde commented on CALCITE-6244: -- Do you propose to allow any class with public fields? I’d

[jira] [Updated] (CALCITE-6244) Improve `Expressions#constant` to allow passing models with non-public fields

2024-02-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6244: - Component/s: linq4j (was: avatica) > Improve `Expressions#constant` to

[jira] [Commented] (CALCITE-1317) Rewrite "MAX" as "ORDER BY ... LIMIT ..."

2024-02-03 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814003#comment-17814003 ] Julian Hyde commented on CALCITE-1317: -- [~jiajunbernoulli], I agree that those optimizations make

[jira] [Commented] (CALCITE-6238) Exception while evaluating ROUND function

2024-02-02 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813822#comment-17813822 ] Julian Hyde commented on CALCITE-6238: -- Our operator tests already spot that a function has

[jira] [Commented] (CALCITE-6238) Exception while evaluating ROUND function

2024-02-02 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813820#comment-17813820 ] Julian Hyde commented on CALCITE-6238: -- Ideal would be a variation of the second: check that the

[jira] [Commented] (CALCITE-6237) Using fractions in LOG function does not return correct results

2024-02-02 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813815#comment-17813815 ] Julian Hyde commented on CALCITE-6237: -- [~caicancai], Do you understand why I closed CALCITE-6232

[jira] [Comment Edited] (CALCITE-6214) Remove DISTINCT in aggregate function if field is unique

2024-02-02 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813752#comment-17813752 ] Julian Hyde edited comment on CALCITE-6214 at 2/2/24 4:29 PM: -- That’s not

[jira] [Commented] (CALCITE-6214) Remove DISTINCT in aggregate function if field is unique

2024-02-02 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813752#comment-17813752 ] Julian Hyde commented on CALCITE-6214: -- That’s not what I said. In my example the combined columns

[jira] [Commented] (CALCITE-6232) Using fractions and 0 in LOG function does not return correct results

2024-02-01 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813358#comment-17813358 ] Julian Hyde commented on CALCITE-6232: -- Please open a new case. This case is closed. > Using

[jira] [Commented] (CALCITE-6232) Using fractions and 0 in LOG function does not return correct results

2024-02-01 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813356#comment-17813356 ] Julian Hyde commented on CALCITE-6232: -- Please open a new case. This one is closed. > Using

[jira] [Comment Edited] (CALCITE-6232) Using fractions and 0 in LOG function does not return correct results

2024-02-01 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813352#comment-17813352 ] Julian Hyde edited comment on CALCITE-6232 at 2/1/24 5:40 PM: -- The summary

[jira] [Commented] (CALCITE-6232) Using fractions and 0 in LOG function does not return correct results

2024-02-01 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813352#comment-17813352 ] Julian Hyde commented on CALCITE-6232: -- The summary is extremely unhelpful. It might as well say

[jira] [Comment Edited] (CALCITE-6221) JDBC adapter generates invalid query when the same table is joined multiple times

2024-01-30 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812425#comment-17812425 ] Julian Hyde edited comment on CALCITE-6221 at 1/30/24 5:39 PM: --- Thank you

[jira] [Commented] (CALCITE-6221) JDBC adapter generates invalid query when the same table is joined multiple times

2024-01-30 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812425#comment-17812425 ] Julian Hyde commented on CALCITE-6221: -- I agree that the subselect is necessary for the outer join

[jira] [Commented] (CALCITE-6235) MAP_CONTAINS_KEY function results correspond to Spark results

2024-01-30 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812415#comment-17812415 ] Julian Hyde commented on CALCITE-6235: -- That expression doesn't have a valid type. You can't use a

[jira] [Commented] (CALCITE-6219) Support SQL Validation for Tables with columns tagged as 'filter required'

2024-01-29 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812082#comment-17812082 ] Julian Hyde commented on CALCITE-6219: -- If a 'filter required' column is not filtered but it is in

[jira] [Commented] (CALCITE-6231) JDBC adapter generates "UNNEST" when it should generate "UNNEST ... WITH ORDINALITY"

2024-01-29 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812039#comment-17812039 ] Julian Hyde commented on CALCITE-6231: -- My concern was that end-users have not heard about

[jira] [Updated] (CALCITE-6231) JDBC adapter generates "UNNEST" when it should generate "UNNEST ... WITH ORDINALITY"

2024-01-29 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6231: - Summary: JDBC adapter generates "UNNEST" when it should generate "UNNEST ... WITH ORDINALITY"

[jira] [Commented] (CALCITE-6214) Remove DISTINCT in aggregate function if field is unique

2024-01-29 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812038#comment-17812038 ] Julian Hyde commented on CALCITE-6214: -- Does this change take into account GROUP BY keys? For

[jira] [Commented] (CALCITE-6221) JDBC adapter generates invalid query when the same table is joined multiple times

2024-01-29 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812036#comment-17812036 ] Julian Hyde commented on CALCITE-6221: -- There are too many changes in RelToSqlConverterTest (too

[jira] [Closed] (CALCITE-2031) Implement more OpenGIS functions

2024-01-29 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde closed CALCITE-2031. > Implement more OpenGIS functions > > > Key:

[jira] [Resolved] (CALCITE-2031) Implement more OpenGIS functions

2024-01-29 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-2031. -- Fix Version/s: 1.35.0 Resolution: Fixed Agreed. All of the core ST_ functions are

[jira] [Commented] (CALCITE-6231) ORDINALITY is omitted during the RelToSql stage

2024-01-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811544#comment-17811544 ] Julian Hyde commented on CALCITE-6231: -- Can you improve the summary? Readers of the release notes

[jira] [Commented] (CALCITE-6232) Using fractions and 0 in LOG function does not return correct results

2024-01-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811543#comment-17811543 ] Julian Hyde commented on CALCITE-6232: -- Why would you expect fractions to have a special behavior

[jira] [Resolved] (CALCITE-6232) Using fractions and 0 in LOG function does not return correct results

2024-01-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-6232. -- Resolution: Invalid > Using fractions and 0 in LOG function does not return correct results

[jira] [Commented] (CALCITE-6063) If ARRAY subquery has ORDER BY (without LIMIT), rows are not sorted

2024-01-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811392#comment-17811392 ] Julian Hyde commented on CALCITE-6063: -- Looks good. I asked for validator test but I see you added

[jira] [Resolved] (CALCITE-6222) Mysql does not have to_char function

2024-01-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-6222. -- Resolution: Invalid > Mysql does not have to_char function >

[jira] [Reopened] (CALCITE-6222) Mysql does not have to_char function

2024-01-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde reopened CALCITE-6222: -- > Mysql does not have to_char function > > >

[jira] [Commented] (CALCITE-6222) Mysql does not have to_char function

2024-01-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811389#comment-17811389 ] Julian Hyde commented on CALCITE-6222: -- The first step in this case should have been to contact

[jira] [Comment Edited] (CALCITE-6230) Jira case collections

2024-01-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811387#comment-17811387 ] Julian Hyde edited comment on CALCITE-6230 at 1/26/24 8:12 PM: --- Maybe the

[jira] [Commented] (CALCITE-6230) Jira case collections

2024-01-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811387#comment-17811387 ] Julian Hyde commented on CALCITE-6230: -- Maybe the intention of this case is to group cases to make

[jira] [Commented] (CALCITE-6225) Unparse LOGICAL_AND/OR as MIN/MAX for Snowflake

2024-01-25 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811057#comment-17811057 ] Julian Hyde commented on CALCITE-6225: -- This case (and fix) is too BigQuery-centric. LOGICAL_AND

[jira] [Commented] (CALCITE-6224) Add LOG2 function on SqlStdOperatorTable

2024-01-25 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811050#comment-17811050 ] Julian Hyde commented on CALCITE-6224: -- Should be in SqlLibraryOperators, not SqlStdOperatorTable.

[jira] [Commented] (CALCITE-6221) JDBC adapter generates invalid query when the same table is joined multiple times

2024-01-24 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810582#comment-17810582 ] Julian Hyde commented on CALCITE-6221: -- Nice bug! Is it minimal? (E.g. does it reproduce with only

[jira] [Updated] (CALCITE-6221) JDBC adapter generates invalid query when the same table is joined multiple times

2024-01-24 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6221: - Summary: JDBC adapter generates invalid query when the same table is joined multiple times

[jira] [Updated] (CALCITE-6063) If ARRAY subquery has ORDER BY, rows are not sorted

2024-01-24 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6063: - Summary: If ARRAY subquery has ORDER BY, rows are not sorted (was: ARRAY subquery with

[jira] [Commented] (CALCITE-6063) ARRAY subquery with OrderBy loses Sort

2024-01-24 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810581#comment-17810581 ] Julian Hyde commented on CALCITE-6063: -- Thanks for the PR. I have reviewed the PR, requested minor

[jira] [Updated] (CALCITE-6063) ARRAY subquery with OrderBy loses Sort

2024-01-24 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6063: - Fix Version/s: 1.37.0 > ARRAY subquery with OrderBy loses Sort >

[jira] [Updated] (CALCITE-6222) Mysql does not have to_char function

2024-01-24 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6222: - Component/s: (was: site) > Mysql does not have to_char function >

[jira] [Commented] (CALCITE-6222) Mysql does not have to_char function

2024-01-24 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810571#comment-17810571 ] Julian Hyde commented on CALCITE-6222: -- This is not minor. This is a functionality change. I've

[jira] [Comment Edited] (CALCITE-6219) Support SQL Validation for Tables with columns tagged as 'filter required'

2024-01-23 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810180#comment-17810180 ] Julian Hyde edited comment on CALCITE-6219 at 1/24/24 3:04 AM: --- That

[jira] [Commented] (CALCITE-6219) Support SQL Validation for Tables with columns tagged as 'filter required'

2024-01-23 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810180#comment-17810180 ] Julian Hyde commented on CALCITE-6219: -- That sounds good. Views are also a consideration;

[jira] [Comment Edited] (CALCITE-6188) Multi-query optimization

2024-01-23 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810169#comment-17810169 ] Julian Hyde edited comment on CALCITE-6188 at 1/24/24 2:41 AM: --- Thank

[jira] [Commented] (CALCITE-6188) Multi-query optimization

2024-01-23 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810169#comment-17810169 ] Julian Hyde commented on CALCITE-6188: -- Thank you, [~zabetak]! I knew Hive had such a syntax, but

[jira] [Commented] (CALCITE-6216) The JDBC adapter is unable to push down queries when a query involves multiple data sources

2024-01-23 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810164#comment-17810164 ] Julian Hyde commented on CALCITE-6216: -- As you note, JDBC rules are unique in that they have

[jira] [Commented] (CALCITE-6214) Remove DISTINCT in aggregate function if field is unique

2024-01-22 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809646#comment-17809646 ] Julian Hyde commented on CALCITE-6214: -- I'm not sure what you mean by 'merge aggregates'. If you

[jira] [Commented] (CALCITE-6216) The JDBC adapter is unable to push down queries when there is a join involved in the query.

2024-01-22 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809638#comment-17809638 ] Julian Hyde commented on CALCITE-6216: -- If a join involves two tables in different databases, and

[jira] [Created] (CALCITE-6217) PER clause for aggregate functions

2024-01-22 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-6217: Summary: PER clause for aggregate functions Key: CALCITE-6217 URL: https://issues.apache.org/jira/browse/CALCITE-6217 Project: Calcite Issue Type:

[jira] [Commented] (CALCITE-6214) Remove `DISTINCT` in `COUNT` if field is unique

2024-01-21 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809165#comment-17809165 ] Julian Hyde commented on CALCITE-6214: -- Can you remove backticks from the jira subject? Backticks

[jira] [Commented] (CALCITE-6214) Remove `DISTINCT` in `COUNT` if field is unique

2024-01-21 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809164#comment-17809164 ] Julian Hyde commented on CALCITE-6214: -- I have no problem with doing this via a rule. But it could

[jira] [Commented] (CALCITE-6209) Long queries are failing with "java.net.SocketTimeoutException: Read timed out" after 3 minutes

2024-01-21 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809157#comment-17809157 ] Julian Hyde commented on CALCITE-6209: -- [~stoty], More parameters more things to screw up. So we

[jira] [Commented] (CALCITE-6214) Remove `DISTINCT` in `COUNT` if field is unique

2024-01-21 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809147#comment-17809147 ] Julian Hyde commented on CALCITE-6214: -- You should do other aggregate functions also - e.g. SUM

[jira] [Commented] (CALCITE-6209) All queries are failing with "java.net.SocketTimeoutException: Read timed out" after 3 minutes

2024-01-18 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808351#comment-17808351 ] Julian Hyde commented on CALCITE-6209: -- I would presume that the

[jira] [Commented] (CALCITE-6209) All queries are failing with "java.net.SocketTimeoutException: Read timed out" after 3 minutes

2024-01-17 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807800#comment-17807800 ] Julian Hyde commented on CALCITE-6209: -- It seems that the server has stopped responding, for some

[jira] [Commented] (CALCITE-6207) Improve connection resource in JDBCUtils

2024-01-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807479#comment-17807479 ] Julian Hyde commented on CALCITE-6207: -- Yes, I think that would be best in this case. I think this

[jira] [Commented] (CALCITE-6207) Improve connection resource in JDBCUtils

2024-01-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807475#comment-17807475 ] Julian Hyde commented on CALCITE-6207: -- [~mbudiu], Can you check the jira conversation before you

<    1   2   3   4   5   6   7   8   9   10   >