[jira] [Commented] (CALCITE-980) Not (C='a' or C='b') as well as Not (C='a' and C='b') causes NPE

[ https://issues.apache.org/jira/browse/CALCITE-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030132#comment-15030132 ] Vladimir Sitnikov commented on CALCITE-980: --- That makes sense. So "nullable" translation of

[jira] [Comment Edited] (CALCITE-999) clean up all module pom.xml

[ https://issues.apache.org/jira/browse/CALCITE-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15036354#comment-15036354 ] Vladimir Sitnikov edited comment on CALCITE-999 at 12/2/15 6:48 PM:

[jira] [Commented] (CALCITE-980) Not (C='a' or C='b') as well as Not (C='a' and C='b') causes NPE

[ https://issues.apache.org/jira/browse/CALCITE-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047515#comment-15047515 ] Vladimir Sitnikov commented on CALCITE-980: --- [~julianhyde], it is not yet ready I've reworked

[jira] [Commented] (CALCITE-1012) Benchmark SQL parser

[ https://issues.apache.org/jira/browse/CALCITE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049389#comment-15049389 ] Vladimir Sitnikov commented on CALCITE-1012: {noformat} Benchmark

[jira] [Commented] (CALCITE-1012) Benchmark SQL parser

[ https://issues.apache.org/jira/browse/CALCITE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049395#comment-15049395 ] Vladimir Sitnikov commented on CALCITE-1012: {code:java} public void ReInit(java.io.Reader

[jira] [Comment Edited] (CALCITE-1012) Benchmark SQL parser

[ https://issues.apache.org/jira/browse/CALCITE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049372#comment-15049372 ] Vladimir Sitnikov edited comment on CALCITE-1012 at 12/9/15 9:04 PM: -

[jira] [Updated] (CALCITE-1012) Benchmark SQL parser

[ https://issues.apache.org/jira/browse/CALCITE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov updated CALCITE-1012: --- Attachment: allocations1.png allocations2.png

[jira] [Created] (CALCITE-1015) AssertionError: trivial sort out of cartesian join offset 0

Vladimir Sitnikov created CALCITE-1015: -- Summary: AssertionError: trivial sort out of cartesian join offset 0 Key: CALCITE-1015 URL: https://issues.apache.org/jira/browse/CALCITE-1015 Project:

[jira] [Updated] (CALCITE-1015) AssertionError: trivial sort out of cartesian join offset 0

[ https://issues.apache.org/jira/browse/CALCITE-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov updated CALCITE-1015: --- Affects Version/s: 1.5.0 > AssertionError: trivial sort out of cartesian join

[jira] [Commented] (CALCITE-1016) What should "GROUP BY 1" return on an empty table?

[ https://issues.apache.org/jira/browse/CALCITE-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15051687#comment-15051687 ] Vladimir Sitnikov commented on CALCITE-1016: {quote}Per the standard, it should return 1

[jira] [Comment Edited] (CALCITE-1016) What should "GROUP BY 1" return on an empty table?

[ https://issues.apache.org/jira/browse/CALCITE-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15051694#comment-15051694 ] Vladimir Sitnikov edited comment on CALCITE-1016 at 12/10/15 9:37 PM:

[jira] [Commented] (CALCITE-459) TokenMgrError parsing error when the query terminates a single-line comment without newline

[ https://issues.apache.org/jira/browse/CALCITE-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049254#comment-15049254 ] Vladimir Sitnikov commented on CALCITE-459: --- [~julianhyde], what is the recommended way to

[jira] [Comment Edited] (CALCITE-980) Not (C='a' or C='b') causes NPE

[ https://issues.apache.org/jira/browse/CALCITE-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025458#comment-15025458 ] Vladimir Sitnikov edited comment on CALCITE-980 at 11/24/15 9:33 PM: -

[jira] [Commented] (CALCITE-980) Not (C='a' or C='b') causes NPE

[ https://issues.apache.org/jira/browse/CALCITE-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025458#comment-15025458 ] Vladimir Sitnikov commented on CALCITE-980: --- The problem is with OR implementor in nullsAs=TRUE

[jira] [Commented] (CALCITE-980) Not (C='a' or C='b') causes NPE

[ https://issues.apache.org/jira/browse/CALCITE-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025336#comment-15025336 ] Vladimir Sitnikov commented on CALCITE-980: --- {code:java} /** Tests CALCITE-980: Not (C='a' or

[jira] [Updated] (CALCITE-980) Not (C='a' or C='b') as well as Not (C='a' and C='b') causes NPE

[ https://issues.apache.org/jira/browse/CALCITE-980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov updated CALCITE-980: -- Summary: Not (C='a' or C='b') as well as Not (C='a' and C='b') causes NPE (was: Not

[jira] [Comment Edited] (CALCITE-980) Not (C='a' or C='b') as well as Not (C='a' and C='b') causes NPE

[ https://issues.apache.org/jira/browse/CALCITE-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026393#comment-15026393 ] Vladimir Sitnikov edited comment on CALCITE-980 at 11/25/15 8:19 AM: -

[jira] [Commented] (CALCITE-980) Not (C='a' or C='b') as well as Not (C='a' and C='b') causes NPE

[ https://issues.apache.org/jira/browse/CALCITE-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026393#comment-15026393 ] Vladimir Sitnikov commented on CALCITE-980: --- Here's more sophisticated patch:

[jira] [Comment Edited] (CALCITE-980) Not (C='a' or C='b') as well as Not (C='a' and C='b') causes NPE

[ https://issues.apache.org/jira/browse/CALCITE-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026414#comment-15026414 ] Vladimir Sitnikov edited comment on CALCITE-980 at 11/25/15 11:14 AM:

[jira] [Commented] (CALCITE-980) Not (C='a' or C='b') as well as Not (C='a' and C='b') causes NPE

[ https://issues.apache.org/jira/browse/CALCITE-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029672#comment-15029672 ] Vladimir Sitnikov commented on CALCITE-980: --- {quote}SqlOperatorBaseTest, which some nice

[jira] [Commented] (CALCITE-849) Streams/Slow iterators dont close on statement close

[ https://issues.apache.org/jira/browse/CALCITE-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015356#comment-15015356 ] Vladimir Sitnikov commented on CALCITE-849: --- I'm not up to speed with this issue, however it

[jira] [Comment Edited] (CALCITE-849) Streams/Slow iterators dont close on statement close

[ https://issues.apache.org/jira/browse/CALCITE-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15020851#comment-15020851 ] Vladimir Sitnikov edited comment on CALCITE-849 at 11/22/15 5:47 AM: -

[jira] [Commented] (CALCITE-849) Streams/Slow iterators dont close on statement close

[ https://issues.apache.org/jira/browse/CALCITE-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15020851#comment-15020851 ] Vladimir Sitnikov commented on CALCITE-849: --- {quote}Do you happen to know the authors of this

[jira] [Commented] (CALCITE-1258) JDK9 support

[ https://issues.apache.org/jira/browse/CALCITE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331310#comment-15331310 ] Vladimir Sitnikov commented on CALCITE-1258: [~julianhyde], I've succeeded with jdk9-ea at

[jira] [Commented] (CALCITE-1258) JDK9 support

[ https://issues.apache.org/jira/browse/CALCITE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336707#comment-15336707 ] Vladimir Sitnikov commented on CALCITE-1258: For jmh, just upgrade to new version was

[jira] [Commented] (CALCITE-1258) JDK9 support

[ https://issues.apache.org/jira/browse/CALCITE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335998#comment-15335998 ] Vladimir Sitnikov commented on CALCITE-1258: {noformat}Caused by:

[jira] [Created] (CALCITE-1060) Java level deadlock when initializing remote driver

Vladimir Sitnikov created CALCITE-1060: -- Summary: Java level deadlock when initializing remote driver Key: CALCITE-1060 URL: https://issues.apache.org/jira/browse/CALCITE-1060 Project: Calcite

[jira] [Commented] (CALCITE-604) Invoke metadata providers via a class generated at runtime, rather than reflection

[ https://issues.apache.org/jira/browse/CALCITE-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131300#comment-15131300 ] Vladimir Sitnikov commented on CALCITE-604: --- I'll pick it up this Sunday. > Invoke metadata

[jira] [Commented] (CALCITE-553) "mvn clean install" fails due to missing SqlParserImpl

[ https://issues.apache.org/jira/browse/CALCITE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151063#comment-15151063 ] Vladimir Sitnikov commented on CALCITE-553: --- [~julianhyde], I'm inclined to agree that forcing

[jira] [Comment Edited] (CALCITE-553) "mvn clean install" fails due to missing SqlParserImpl

[ https://issues.apache.org/jira/browse/CALCITE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151063#comment-15151063 ] Vladimir Sitnikov edited comment on CALCITE-553 at 2/17/16 7:59 PM:

[jira] [Updated] (CALCITE-1164) Use setObject(int, Object, int) when binding parameters

[ https://issues.apache.org/jira/browse/CALCITE-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov updated CALCITE-1164: --- Description: Trying to capture some discussion from a recent pull request:

[jira] [Updated] (CALCITE-1164) Use setObject(int, Object, int) when binding parameters

[ https://issues.apache.org/jira/browse/CALCITE-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov updated CALCITE-1164: --- Description: Trying to capture some discussion from a recent pull request:

[jira] [Comment Edited] (CALCITE-1164) Use setObject(int, Object, int) when binding parameters

[ https://issues.apache.org/jira/browse/CALCITE-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209510#comment-15209510 ] Vladimir Sitnikov edited comment on CALCITE-1164 at 3/24/16 3:11 AM: -

[jira] [Comment Edited] (CALCITE-1164) Use setObject(int, Object, int) when binding parameters

[ https://issues.apache.org/jira/browse/CALCITE-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209510#comment-15209510 ] Vladimir Sitnikov edited comment on CALCITE-1164 at 3/24/16 12:47 AM:

[jira] [Commented] (CALCITE-1164) Use setObject(int, Object, int) when binding parameters

[ https://issues.apache.org/jira/browse/CALCITE-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209510#comment-15209510 ] Vladimir Sitnikov commented on CALCITE-1164: {code:java} @Test public void

[jira] [Commented] (CALCITE-1164) Use setObject(int, Object, int) when binding parameters

[ https://issues.apache.org/jira/browse/CALCITE-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15213080#comment-15213080 ] Vladimir Sitnikov commented on CALCITE-1164: {quote} There is no reason why ' = ' should

[jira] [Comment Edited] (CALCITE-1164) Use setObject(int, Object, int) when binding parameters

[ https://issues.apache.org/jira/browse/CALCITE-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209510#comment-15209510 ] Vladimir Sitnikov edited comment on CALCITE-1164 at 3/24/16 7:12 AM: -

[jira] [Commented] (CALCITE-1164) Use setObject(int, Object, int) when binding parameters

[ https://issues.apache.org/jira/browse/CALCITE-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209914#comment-15209914 ] Vladimir Sitnikov commented on CALCITE-1164: PostgreSQL: {code:sql} select 'Y' where '01'=1;

[jira] [Comment Edited] (CALCITE-1164) Use setObject(int, Object, int) when binding parameters

[ https://issues.apache.org/jira/browse/CALCITE-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209914#comment-15209914 ] Vladimir Sitnikov edited comment on CALCITE-1164 at 3/24/16 7:45 AM: -

[jira] [Comment Edited] (CALCITE-1164) Use setObject(int, Object, int) when binding parameters

[ https://issues.apache.org/jira/browse/CALCITE-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15213080#comment-15213080 ] Vladimir Sitnikov edited comment on CALCITE-1164 at 3/26/16 3:52 PM: -

[jira] [Commented] (CALCITE-1054) NPE caused by wrong code generation for Timestamp fields

[ https://issues.apache.org/jira/browse/CALCITE-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179472#comment-15179472 ] Vladimir Sitnikov commented on CALCITE-1054: It looks like 1066-oracle branch is using

[jira] [Commented] (CALCITE-30) Implement Statement.cancel method

[ https://issues.apache.org/jira/browse/CALCITE-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497142#comment-15497142 ] Vladimir Sitnikov commented on CALCITE-30: -- While the change itself looks good, it looks like

[jira] [Commented] (CALCITE-1569) Date condition can generates Integer == Integer, which is always false

[ https://issues.apache.org/jira/browse/CALCITE-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813034#comment-15813034 ] Vladimir Sitnikov commented on CALCITE-1569: [~liyang.g...@gmail.com], can you please

[jira] [Commented] (CALCITE-500) Ensure EnumerableJoin hashes the smallest input

[ https://issues.apache.org/jira/browse/CALCITE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086239#comment-16086239 ] Vladimir Sitnikov commented on CALCITE-500: --- In the mean time, I've created CALCITE-1890 to

[jira] [Updated] (CALCITE-500) Ensure EnumerableJoin hashes the smallest input

[ https://issues.apache.org/jira/browse/CALCITE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov updated CALCITE-500: -- Attachment: lookup.png > Ensure EnumerableJoin hashes the smallest input >

[jira] [Created] (CALCITE-1890) Override toString() in enumerable generated code to simplify debugging

Vladimir Sitnikov created CALCITE-1890: -- Summary: Override toString() in enumerable generated code to simplify debugging Key: CALCITE-1890 URL: https://issues.apache.org/jira/browse/CALCITE-1890

[jira] [Updated] (CALCITE-1890) Override toString() in enumerable generated code to simplify debugging

[ https://issues.apache.org/jira/browse/CALCITE-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov updated CALCITE-1890: --- Attachment: lookup.png > Override toString() in enumerable generated code to

[jira] [Comment Edited] (CALCITE-500) Ensure EnumerableJoin hashes the smallest input

[ https://issues.apache.org/jira/browse/CALCITE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086209#comment-16086209 ] Vladimir Sitnikov edited comment on CALCITE-500 at 7/13/17 6:52 PM:

[jira] [Updated] (CALCITE-1890) Override toString() in enumerable generated code to simplify debugging

[ https://issues.apache.org/jira/browse/CALCITE-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov updated CALCITE-1890: --- Description: Currently Enumerable generates lots of {{new AbstractEnumerable}}, and

[jira] [Comment Edited] (CALCITE-500) Ensure EnumerableJoin hashes the smallest input

[ https://issues.apache.org/jira/browse/CALCITE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086209#comment-16086209 ] Vladimir Sitnikov edited comment on CALCITE-500 at 7/13/17 6:53 PM:

[jira] [Commented] (CALCITE-500) Ensure EnumerableJoin hashes the smallest input

[ https://issues.apache.org/jira/browse/CALCITE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086209#comment-16086209 ] Vladimir Sitnikov commented on CALCITE-500: --- The below test was performed at {noformat} commit

[jira] [Commented] (CALCITE-1927) Mapping for Types.BIT: boolean or BitSet?

[ https://issues.apache.org/jira/browse/CALCITE-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114766#comment-16114766 ] Vladimir Sitnikov commented on CALCITE-1927: {quote}If you mean setting the value of a

[jira] [Commented] (CALCITE-1927) Mapping for Types.BIT: boolean or BitSet?

[ https://issues.apache.org/jira/browse/CALCITE-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114687#comment-16114687 ] Vladimir Sitnikov commented on CALCITE-1927: {quote}getBoolean should give a value if m <=

[jira] [Updated] (CALCITE-1927) Mapping for Types.BIT: boolean or BitSet?

[ https://issues.apache.org/jira/browse/CALCITE-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov updated CALCITE-1927: --- Description: Currently Avatica implements `Types.BIT` as `Boolean` (see

[jira] [Created] (CALCITE-1927) Mapping for Types.BIT: boolean or BitSet?

Vladimir Sitnikov created CALCITE-1927: -- Summary: Mapping for Types.BIT: boolean or BitSet? Key: CALCITE-1927 URL: https://issues.apache.org/jira/browse/CALCITE-1927 Project: Calcite

[jira] [Created] (CALCITE-1976) makeLiteral(Arrays.asList(...), structType, allowCast=any) does not work for Enumerable

Vladimir Sitnikov created CALCITE-1976: -- Summary: makeLiteral(Arrays.asList(...), structType, allowCast=any) does not work for Enumerable Key: CALCITE-1976 URL:

[jira] [Commented] (CALCITE-1856) Add option StructKind.PEEK_FIELDS_NO_EXPAND, similar to PEEK_FIELDS but is not expanded in "SELECT *"

[ https://issues.apache.org/jira/browse/CALCITE-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158418#comment-16158418 ] Vladimir Sitnikov commented on CALCITE-1856: {{select *}} projects

[jira] [Commented] (CALCITE-1976) makeLiteral(Arrays.asList(...), structType, allowCast=any) does not work for Enumerable

[ https://issues.apache.org/jira/browse/CALCITE-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159000#comment-16159000 ] Vladimir Sitnikov commented on CALCITE-1976: Thanks for the review. >

[jira] [Commented] (CALCITE-2438) RexCall#isAlwaysTrue return incorrect result

[ https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567475#comment-16567475 ] Vladimir Sitnikov commented on CALCITE-2438: PS.  RexSimplify misses   "null is false" kind

[jira] [Commented] (CALCITE-2439) Smart complete for SqlAdvisor

[ https://issues.apache.org/jira/browse/CALCITE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567436#comment-16567436 ] Vladimir Sitnikov commented on CALCITE-2439: Well, one of the options is "one impl fits

[jira] [Commented] (CALCITE-2438) RexCall#isAlwaysTrue return incorrect result

[ https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567490#comment-16567490 ] Vladimir Sitnikov commented on CALCITE-2438: Here's a test case (to be placed in

[jira] [Comment Edited] (CALCITE-2439) Smart complete for SqlAdvisor

[ https://issues.apache.org/jira/browse/CALCITE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567432#comment-16567432 ] Vladimir Sitnikov edited comment on CALCITE-2439 at 8/2/18 8:11 PM:

[jira] [Commented] (CALCITE-2438) RexCall#isAlwaysTrue return incorrect result

[ https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567526#comment-16567526 ] Vladimir Sitnikov commented on CALCITE-2438: Note: I have added NOT to the equations above,

[jira] [Commented] (CALCITE-2439) Smart complete for SqlAdvisor

[ https://issues.apache.org/jira/browse/CALCITE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567417#comment-16567417 ] Vladimir Sitnikov commented on CALCITE-2439: {quote}It seems to me that we would need to

[jira] [Comment Edited] (CALCITE-2439) Smart complete for SqlAdvisor

[ https://issues.apache.org/jira/browse/CALCITE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567421#comment-16567421 ] Vladimir Sitnikov edited comment on CALCITE-2439 at 8/2/18 7:53 PM:

[jira] [Commented] (CALCITE-2439) Smart complete for SqlAdvisor

[ https://issues.apache.org/jira/browse/CALCITE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567421#comment-16567421 ] Vladimir Sitnikov commented on CALCITE-2439: {quote}they should specify the algorithm that

[jira] [Commented] (CALCITE-2439) Smart complete for SqlAdvisor

[ https://issues.apache.org/jira/browse/CALCITE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567432#comment-16567432 ] Vladimir Sitnikov commented on CALCITE-2439: {quote}I think it adds too much complexity if

[jira] [Comment Edited] (CALCITE-2439) Smart complete for SqlAdvisor

[ https://issues.apache.org/jira/browse/CALCITE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567432#comment-16567432 ] Vladimir Sitnikov edited comment on CALCITE-2439 at 8/2/18 8:10 PM:

[jira] [Commented] (CALCITE-2439) Smart complete for SqlAdvisor

[ https://issues.apache.org/jira/browse/CALCITE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567504#comment-16567504 ] Vladimir Sitnikov commented on CALCITE-2439: {quote}I assume that {{getHintsToFilter}} 

[jira] [Comment Edited] (CALCITE-2438) RexCall#isAlwaysTrue return incorrect result

[ https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567490#comment-16567490 ] Vladimir Sitnikov edited comment on CALCITE-2438 at 8/2/18 9:53 PM:

[jira] [Commented] (CALCITE-2438) RexCall#isAlwaysTrue return incorrect result

[ https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568449#comment-16568449 ] Vladimir Sitnikov commented on CALCITE-2438: {{COALESCE(OR(null, $0), NOT(false))}} was

[jira] [Commented] (CALCITE-2438) RexCall#isAlwaysTrue return incorrect result

[ https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568370#comment-16568370 ] Vladimir Sitnikov commented on CALCITE-2438: Well, there's progress with

[jira] [Commented] (CALCITE-2438) RexCall#isAlwaysTrue return incorrect result

[ https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568518#comment-16568518 ] Vladimir Sitnikov commented on CALCITE-2438: {quote}Those don't belong in isAlwaysTrue.

[jira] [Commented] (CALCITE-2438) RexCall#isAlwaysTrue return incorrect result

[ https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568530#comment-16568530 ] Vladimir Sitnikov commented on CALCITE-2438: {quote}Also, can you add tests that call 

[jira] [Comment Edited] (CALCITE-2431) AssertionError: SqlUtil.getAncestry when providing completion hints for sub-schema

[ https://issues.apache.org/jira/browse/CALCITE-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562522#comment-16562522 ] Vladimir Sitnikov edited comment on CALCITE-2431 at 7/30/18 9:19 PM:

[jira] [Commented] (CALCITE-2431) AssertionError: SqlUtil.getAncestry when providing completion hints for sub-schema

[ https://issues.apache.org/jira/browse/CALCITE-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562522#comment-16562522 ] Vladimir Sitnikov commented on CALCITE-2431: [~julianhyde], the match there is against

[jira] [Commented] (CALCITE-2430) AssertionError: RelDataTypeImpl.getFieldList when SQL Advisor inspects non-struct field

[ https://issues.apache.org/jira/browse/CALCITE-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562495#comment-16562495 ] Vladimir Sitnikov commented on CALCITE-2430: I think this is relevant:

[jira] [Created] (CALCITE-2429) NPE: SqlValidatorImpl.lookupFieldNamespace when SQL Advisor observes non-existing field

Vladimir Sitnikov created CALCITE-2429: -- Summary: NPE: SqlValidatorImpl.lookupFieldNamespace when SQL Advisor observes non-existing field Key: CALCITE-2429 URL:

[jira] [Resolved] (CALCITE-2431) AssertionError: SqlUtil.getAncestry when providing completion hints for sub-schema

[ https://issues.apache.org/jira/browse/CALCITE-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov resolved CALCITE-2431. Resolution: Fixed Fix Version/s: 1.18.0 > AssertionError:

[jira] [Resolved] (CALCITE-2430) AssertionError: RelDataTypeImpl.getFieldList when SQL Advisor inspects non-struct field

[ https://issues.apache.org/jira/browse/CALCITE-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov resolved CALCITE-2430. Resolution: Fixed > AssertionError: RelDataTypeImpl.getFieldList when SQL

[jira] [Updated] (CALCITE-2430) AssertionError: RelDataTypeImpl.getFieldList when SQL Advisor inspects non-struct field

[ https://issues.apache.org/jira/browse/CALCITE-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov updated CALCITE-2430: --- Fix Version/s: 1.18.0 > AssertionError: RelDataTypeImpl.getFieldList when SQL

[jira] [Created] (CALCITE-2430) AssertionError: RelDataTypeImpl.getFieldList when SQL Advisor inspects non-struct field

Vladimir Sitnikov created CALCITE-2430: -- Summary: AssertionError: RelDataTypeImpl.getFieldList when SQL Advisor inspects non-struct field Key: CALCITE-2430 URL:

[jira] [Comment Edited] (CALCITE-2430) AssertionError: RelDataTypeImpl.getFieldList when SQL Advisor inspects non-struct field

[ https://issues.apache.org/jira/browse/CALCITE-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562519#comment-16562519 ] Vladimir Sitnikov edited comment on CALCITE-2430 at 7/30/18 9:16 PM:

[jira] [Commented] (CALCITE-2430) AssertionError: RelDataTypeImpl.getFieldList when SQL Advisor inspects non-struct field

[ https://issues.apache.org/jira/browse/CALCITE-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562519#comment-16562519 ] Vladimir Sitnikov commented on CALCITE-2430: {quote}Yes, I know. But is there any point in

[jira] [Updated] (CALCITE-2430) AssertionError: RelDataTypeImpl.getFieldList when SQL Advisor inspects non-struct field

[ https://issues.apache.org/jira/browse/CALCITE-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov updated CALCITE-2430: --- Attachment: fieldnamespace.png > AssertionError: RelDataTypeImpl.getFieldList when

[jira] [Commented] (CALCITE-2430) AssertionError: RelDataTypeImpl.getFieldList when SQL Advisor inspects non-struct field

[ https://issues.apache.org/jira/browse/CALCITE-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562486#comment-16562486 ] Vladimir Sitnikov commented on CALCITE-2430: Changing SqlValidatorImpl as follows:

[jira] [Commented] (CALCITE-2431) AssertionError: SqlUtil.getAncestry when providing completion hints for sub-schema

[ https://issues.apache.org/jira/browse/CALCITE-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562531#comment-16562531 ] Vladimir Sitnikov commented on CALCITE-2431: PS. The purpose of the check is to remove *

[jira] [Created] (CALCITE-2433) SqlAdvisor.getCompletionHints is hard-coded for " quoting

Vladimir Sitnikov created CALCITE-2433: -- Summary: SqlAdvisor.getCompletionHints is hard-coded for " quoting Key: CALCITE-2433 URL: https://issues.apache.org/jira/browse/CALCITE-2433 Project:

[jira] [Created] (CALCITE-2434) SqlAdvisor.getCompletionHints does not work for nested identifiers sub-match

Vladimir Sitnikov created CALCITE-2434: -- Summary: SqlAdvisor.getCompletionHints does not work for nested identifiers sub-match Key: CALCITE-2434 URL: https://issues.apache.org/jira/browse/CALCITE-2434

[jira] [Updated] (CALCITE-2433) SqlAdvisor.getCompletionHints is hard-coded for " quoting

[ https://issues.apache.org/jira/browse/CALCITE-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov updated CALCITE-2433: --- Environment: (was: Relevant source: {code:java} boolean quoted = false;

[jira] [Updated] (CALCITE-2434) SqlAdvisor.getCompletionHints does not work for nested identifiers sub-match

[ https://issues.apache.org/jira/browse/CALCITE-2434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov updated CALCITE-2434: --- Environment: (was: Test (SqlAdvisorTest): {code:java} @Test public void

[jira] [Commented] (CALCITE-2433) SqlAdvisor.getCompletionHints is hard-coded for " quoting

[ https://issues.apache.org/jira/browse/CALCITE-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564156#comment-16564156 ] Vladimir Sitnikov commented on CALCITE-2433: The relevant question is identifier quoting.

[jira] [Commented] (CALCITE-2433) SqlAdvisor.getCompletionHints is hard-coded for " quoting

[ https://issues.apache.org/jira/browse/CALCITE-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564184#comment-16564184 ] Vladimir Sitnikov commented on CALCITE-2433: {quote} JDBC describes how identifiers are to

[jira] [Commented] (CALCITE-2433) SqlAdvisor.getCompletionHints is hard-coded for " quoting

[ https://issues.apache.org/jira/browse/CALCITE-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564225#comment-16564225 ] Vladimir Sitnikov commented on CALCITE-2433: org.apache.calcite.sql.parser.SqlParser.Config

[jira] [Commented] (CALCITE-2433) SqlAdvisor.getCompletionHints is hard-coded for " quoting

[ https://issues.apache.org/jira/browse/CALCITE-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564180#comment-16564180 ] Vladimir Sitnikov commented on CALCITE-2433: SqlDialect does not expose

[jira] [Assigned] (CALCITE-2434) SqlAdvisor.getCompletionHints does not work for nested identifiers sub-match

[ https://issues.apache.org/jira/browse/CALCITE-2434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Sitnikov reassigned CALCITE-2434: -- Assignee: Vladimir Sitnikov (was: Julian Hyde) >

[jira] [Commented] (CALCITE-2433) SqlAdvisor.getCompletionHints is hard-coded for " quoting

[ https://issues.apache.org/jira/browse/CALCITE-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564173#comment-16564173 ] Vladimir Sitnikov commented on CALCITE-2433: There's

[jira] [Commented] (CALCITE-2433) SqlAdvisor.getCompletionHints is hard-coded for " quoting

[ https://issues.apache.org/jira/browse/CALCITE-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564196#comment-16564196 ] Vladimir Sitnikov commented on CALCITE-2433: SqlDialect provides no way to "get quoting

[jira] [Commented] (CALCITE-2435) Refactor SqlTestFactory

[ https://issues.apache.org/jira/browse/CALCITE-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565117#comment-16565117 ] Vladimir Sitnikov commented on CALCITE-2435: PR https://github.com/apache/calcite/pull/771

[jira] [Created] (CALCITE-2435) Refactor SqlTestFactory

Vladimir Sitnikov created CALCITE-2435: -- Summary: Refactor SqlTestFactory Key: CALCITE-2435 URL: https://issues.apache.org/jira/browse/CALCITE-2435 Project: Calcite Issue Type: Bug

  1   2   3   4   5   6   7   8   9   10   >