[jira] [Commented] (CALCITE-669) Move from Commons Logging to SLF4J
[ https://issues.apache.org/jira/browse/CALCITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115642#comment-15115642 ] Josh Elser commented on CALCITE-669: [~julianhyde], am I good to merge this into master? Not sure if I missed an "all-clear" from you, but it looks like you've dotted the "i"s and crossed the "t"s. > Move from Commons Logging to SLF4J > -- > > Key: CALCITE-669 > URL: https://issues.apache.org/jira/browse/CALCITE-669 > Project: Calcite > Issue Type: Task > Components: avatica >Reporter: Nick Dimiduk >Assignee: Josh Elser >Priority: Minor > Fix For: 1.7.0 > > > As mentioned on CALCITE-641, it could be useful to adopt a logging > implementation that supports pluggable backends and has > [MDC|http://www.slf4j.org/manual.html#mdc] support. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-669) Move from Commons Logging to SLF4J
[ https://issues.apache.org/jira/browse/CALCITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115902#comment-15115902 ] Julian Hyde commented on CALCITE-669: - [~elserj], Yes, commits are open following the release, and you can use your discretion as a committer. You'll probably hit a conflict in pom.xml due to CALCITE-699 https://github.com/apache/calcite/commit/4d58768d35d5accbf7330d10b91f2541b6f1ab38. > Move from Commons Logging to SLF4J > -- > > Key: CALCITE-669 > URL: https://issues.apache.org/jira/browse/CALCITE-669 > Project: Calcite > Issue Type: Task > Components: avatica >Reporter: Nick Dimiduk >Assignee: Josh Elser >Priority: Minor > Fix For: 1.7.0 > > > As mentioned on CALCITE-641, it could be useful to adopt a logging > implementation that supports pluggable backends and has > [MDC|http://www.slf4j.org/manual.html#mdc] support. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-669) Move from Commons Logging to SLF4J
[ https://issues.apache.org/jira/browse/CALCITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115974#comment-15115974 ] Josh Elser commented on CALCITE-669: Ok, thanks, Julian. > Move from Commons Logging to SLF4J > -- > > Key: CALCITE-669 > URL: https://issues.apache.org/jira/browse/CALCITE-669 > Project: Calcite > Issue Type: Task > Components: avatica >Reporter: Nick Dimiduk >Assignee: Josh Elser >Priority: Minor > Fix For: 1.7.0 > > > As mentioned on CALCITE-641, it could be useful to adopt a logging > implementation that supports pluggable backends and has > [MDC|http://www.slf4j.org/manual.html#mdc] support. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-669) Move from Commons Logging to SLF4J
[
https://issues.apache.org/jira/browse/CALCITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15107670#comment-15107670
]
Josh Elser commented on CALCITE-669:
I have this mostly working, one thing I'm trying to track down are some
spurious warnings while running the tests:
{noformat}
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further
details.
{noformat}
My only guess at this point is that there is some issue with loading things
with the parallel test runner. Right after the above, we can see the logging is
set up and functional.
{noformat}
Running org.apache.calcite.avatica.jdbc.JdbcMetaTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec - in
org.apache.calcite.avatica.jdbc.JdbcMetaTest
2016-01-19 18:25:42,802 [pool-1-thread-3] INFO - jetty-9.2.7.v20150116
2016-01-19 18:25:42,803 [pool-1-thread-3] INFO - Started
ServerConnector@7639fabd{HTTP/1.1}{0.0.0.0:51067}
2016-01-19 18:25:42,803 [pool-1-thread-3] INFO - Started @771ms
2016-01-19 18:25:42,804 [pool-1-thread-3] INFO - Service listening on port
51067.
2016-01-19 18:25:42,804 [pool-1-thread-3] INFO - jetty-9.2.7.v20150116
2016-01-19 18:25:42,806 [pool-1-thread-3] INFO - Started
ServerConnector@7a8c4ce2{HTTP/1.1}{0.0.0.0:51068}
2016-01-19 18:25:42,806 [pool-1-thread-3] INFO - Started @774ms
2016-01-19 18:25:42,806 [pool-1-thread-3] INFO - Service listening on port
51068.
{noformat}
I can say it's functional because this is the format I specified in the
log4j.properties file. I need to see if there is some sort of work around to
this -- the parallel tests cause such trouble :\
> Move from Commons Logging to SLF4J
> --
>
> Key: CALCITE-669
> URL: https://issues.apache.org/jira/browse/CALCITE-669
> Project: Calcite
> Issue Type: Task
> Components: avatica
>Reporter: Nick Dimiduk
>Assignee: Josh Elser
>Priority: Minor
> Fix For: 1.7.0
>
>
> As mentioned on CALCITE-641, it could be useful to adopt a logging
> implementation that supports pluggable backends and has
> [MDC|http://www.slf4j.org/manual.html#mdc] support.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-669) Move from Commons Logging to SLF4J
[ https://issues.apache.org/jira/browse/CALCITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15107691#comment-15107691 ] Josh Elser commented on CALCITE-669: Argh: http://jira.qos.ch/browse/SLF4J-167 targeted to be fixed in 1.7.14. I'll have to see if there is a simple workaround -- it would be a pain to hit this when trying to debug a test. > Move from Commons Logging to SLF4J > -- > > Key: CALCITE-669 > URL: https://issues.apache.org/jira/browse/CALCITE-669 > Project: Calcite > Issue Type: Task > Components: avatica >Reporter: Nick Dimiduk >Assignee: Josh Elser >Priority: Minor > Fix For: 1.7.0 > > > As mentioned on CALCITE-641, it could be useful to adopt a logging > implementation that supports pluggable backends and has > [MDC|http://www.slf4j.org/manual.html#mdc] support. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-669) Move from Commons Logging to SLF4J
[ https://issues.apache.org/jira/browse/CALCITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105581#comment-15105581 ] Josh Elser commented on CALCITE-669: Anyone have opinions on how to map the 3 levels from java logging to the 2 which slf4j provide? Java Logging * FINE * FINER * FINEST Slf4j Levels * DEBUG * TRACE What kind of breakdown would we want here? DEBUG == (FINE and FINER), TRACE == FINEST? DEBUG == FINE, TRACE == (FINER and FINEST)? > Move from Commons Logging to SLF4J > -- > > Key: CALCITE-669 > URL: https://issues.apache.org/jira/browse/CALCITE-669 > Project: Calcite > Issue Type: Task > Components: avatica >Reporter: Nick Dimiduk >Assignee: Josh Elser >Priority: Minor > Fix For: 1.7.0 > > > As mentioned on CALCITE-641, it could be useful to adopt a logging > implementation that supports pluggable backends and has > [MDC|http://www.slf4j.org/manual.html#mdc] support. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-669) Move from Commons Logging to SLF4J
[ https://issues.apache.org/jira/browse/CALCITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105500#comment-15105500 ] Julian Hyde commented on CALCITE-669: - +1 As part of this task, be sure to update the existing doc, such as the HOWTO. > Move from Commons Logging to SLF4J > -- > > Key: CALCITE-669 > URL: https://issues.apache.org/jira/browse/CALCITE-669 > Project: Calcite > Issue Type: Task > Components: avatica >Reporter: Nick Dimiduk >Assignee: Josh Elser >Priority: Minor > Fix For: 1.7.0 > > > As mentioned on CALCITE-641, it could be useful to adopt a logging > implementation that supports pluggable backends and has > [MDC|http://www.slf4j.org/manual.html#mdc] support. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-669) Move from Commons Logging to SLF4J
[ https://issues.apache.org/jira/browse/CALCITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105501#comment-15105501 ] Josh Elser commented on CALCITE-669: Thanks for the reminder. Will look at the docs. > Move from Commons Logging to SLF4J > -- > > Key: CALCITE-669 > URL: https://issues.apache.org/jira/browse/CALCITE-669 > Project: Calcite > Issue Type: Task > Components: avatica >Reporter: Nick Dimiduk >Assignee: Josh Elser >Priority: Minor > Fix For: 1.7.0 > > > As mentioned on CALCITE-641, it could be useful to adopt a logging > implementation that supports pluggable backends and has > [MDC|http://www.slf4j.org/manual.html#mdc] support. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-669) Move from Commons Logging to SLF4J
[ https://issues.apache.org/jira/browse/CALCITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105490#comment-15105490 ] Josh Elser commented on CALCITE-669: Going to work on swapping this out. > Move from Commons Logging to SLF4J > -- > > Key: CALCITE-669 > URL: https://issues.apache.org/jira/browse/CALCITE-669 > Project: Calcite > Issue Type: Task > Components: avatica >Reporter: Nick Dimiduk >Assignee: Josh Elser >Priority: Minor > Fix For: 1.7.0 > > > As mentioned on CALCITE-641, it could be useful to adopt a logging > implementation that supports pluggable backends and has > [MDC|http://www.slf4j.org/manual.html#mdc] support. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-669) Move from Commons Logging to SLF4J
[ https://issues.apache.org/jira/browse/CALCITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105768#comment-15105768 ] Josh Elser commented on CALCITE-669: I suppose "FINE" could also be put at the INFO level :). It doesn't seem like we have much coming out at that level anyways. > Move from Commons Logging to SLF4J > -- > > Key: CALCITE-669 > URL: https://issues.apache.org/jira/browse/CALCITE-669 > Project: Calcite > Issue Type: Task > Components: avatica >Reporter: Nick Dimiduk >Assignee: Josh Elser >Priority: Minor > Fix For: 1.7.0 > > > As mentioned on CALCITE-641, it could be useful to adopt a logging > implementation that supports pluggable backends and has > [MDC|http://www.slf4j.org/manual.html#mdc] support. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
