[jira] [Commented] (CALCITE-1943) Add back NavigationExpander and NavigationReplacer in SqlValidatorImpl

2017-08-28 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144583#comment-16144583 ] Julian Hyde commented on CALCITE-1943: -- Looks good. I will commit when tests pass. I changed

[jira] [Commented] (CALCITE-1943) Add back NavigationExpander and NavigationReplacer in SqlValidatorImpl

2017-08-22 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137508#comment-16137508 ] Julian Hyde commented on CALCITE-1943: -- Makes sense. Please document that rationale in the code and

[jira] [Commented] (CALCITE-1943) Add back NavigationExpander and NavigationReplacer in SqlValidatorImpl

2017-08-15 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127038#comment-16127038 ] Dian Fu commented on CALCITE-1943: -- In one word, if we don't transform {{A.net_weight}} to

[jira] [Commented] (CALCITE-1943) Add back NavigationExpander and NavigationReplacer in SqlValidatorImpl

2017-08-15 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127023#comment-16127023 ] Dian Fu commented on CALCITE-1943: -- You're right. This is related to how to implement the above

[jira] [Commented] (CALCITE-1943) Add back NavigationExpander and NavigationReplacer in SqlValidatorImpl

2017-08-15 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127009#comment-16127009 ] Julian Hyde commented on CALCITE-1943: -- I get the sense that you have had design discussions in

[jira] [Commented] (CALCITE-1943) Add back NavigationExpander and NavigationReplacer in SqlValidatorImpl

2017-08-15 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127003#comment-16127003 ] Julian Hyde commented on CALCITE-1943: -- Why is {{PREV("A"."net_weight", 0)}} better than

[jira] [Commented] (CALCITE-1943) Add back NavigationExpander and NavigationReplacer in SqlValidatorImpl

2017-08-15 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126989#comment-16126989 ] Dian Fu commented on CALCITE-1943: -- I have created a PR: https://github.com/apache/calcite/pull/516

[jira] [Commented] (CALCITE-1943) Add back NavigationExpander and NavigationReplacer in SqlValidatorImpl

2017-08-15 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126885#comment-16126885 ] Dian Fu commented on CALCITE-1943: -- For {{NavigationExpander}}, currently I have not got a quite