[jira] [Commented] (CALCITE-3050) Integrate SqlDialect and SqlParser.Config

2019-05-23 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846516#comment-16846516 ] Ruben Quesada Lopez commented on CALCITE-3050: -- Thanks [~julianhyde] > In

[jira] [Commented] (CALCITE-3050) Integrate SqlDialect and SqlParser.Config

2019-05-22 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845969#comment-16845969 ] Julian Hyde commented on CALCITE-3050: -- Yes, sorry. I’ll fix shortly.  > Integrat

[jira] [Commented] (CALCITE-3050) Integrate SqlDialect and SqlParser.Config

2019-05-22 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845864#comment-16845864 ] Ruben Quesada Lopez commented on CALCITE-3050: -- [~julianhyde], could it be

[jira] [Commented] (CALCITE-3050) Integrate SqlDialect and SqlParser.Config

2019-05-15 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840276#comment-16840276 ] Chunwei Lei commented on CALCITE-3050: -- [~julianhyde], the PR looks good and I lef

[jira] [Commented] (CALCITE-3050) Integrate SqlDialect and SqlParser.Config

2019-05-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840147#comment-16840147 ] Danny Chan commented on CALCITE-3050: - Thx [~julianhyde] and  [~Chunwei Lei], this

[jira] [Commented] (CALCITE-3050) Integrate SqlDialect and SqlParser.Config

2019-05-14 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839920#comment-16839920 ] Chunwei Lei commented on CALCITE-3050: -- [~julianhyde], I would like to review it.

[jira] [Commented] (CALCITE-3050) Integrate SqlDialect and SqlParser.Config

2019-05-14 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839647#comment-16839647 ] Julian Hyde commented on CALCITE-3050: -- I have added the method {{SqlDialect.conf

[jira] [Commented] (CALCITE-3050) Integrate SqlDialect and SqlParser.Config

2019-05-13 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838970#comment-16838970 ] Julian Hyde commented on CALCITE-3050: -- >From the [email >thread|https://lists.ap

[jira] [Commented] (CALCITE-3050) Integrate SqlDialect and SqlParser.Config

2019-05-07 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835268#comment-16835268 ] Danny Chan commented on CALCITE-3050: - I'm thinking about if we can merge these "Sq

[jira] [Commented] (CALCITE-3050) Integrate SqlDialect and SqlParser.Config

2019-05-07 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834983#comment-16834983 ] Julian Hyde commented on CALCITE-3050: -- Well, I agree with you. They are the same

[jira] [Commented] (CALCITE-3050) Integrate SqlDialect and SqlParser.Config

2019-05-06 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834338#comment-16834338 ] Danny Chan commented on CALCITE-3050: - I'm a little confused about why we need to c