[jira] [Updated] (CAMEL-12234) Camel-AWS: Since we are using builders, we need to remove the AWS endpoint options on the components that are using them

[Andrea Cosentino (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-12234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino updated CAMEL-12234:
-
Summary: Camel-AWS: Since we are using builders, we need to remove the AWS 
endpoint options on the components that are using them  (was: Camel-AWS: Since 
we are using builders, we need to deprecate the AWS endpoint options on the 
component that are using them)

> Camel-AWS: Since we are using builders, we need to remove the AWS endpoint 
> options on the components that are using them
> 
>
> Key: CAMEL-12234
> URL: https://issues.apache.org/jira/browse/CAMEL-12234
> Project: Camel
>  Issue Type: Task
>  Components: camel-aws
>Reporter: Andrea Cosentino
>Assignee: Andrea Cosentino
>Priority: Major
> Fix For: 2.21.0
>
>
> In case someone wants to specify an endpoint, he will be always able to build 
> an AWS client and add it to Camel registry.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (CAMEL-12235) Add Timestamp to Message header from ConsumerRecord in the camel-kafka component

[Andrea Cosentino (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-12235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino resolved CAMEL-12235.
--
Resolution: Fixed

> Add Timestamp to Message header  from ConsumerRecord in the camel-kafka 
> component 
> --
>
> Key: CAMEL-12235
> URL: https://issues.apache.org/jira/browse/CAMEL-12235
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-kafka
>Affects Versions: 2.21.0
>Reporter: Anand Banik
>Assignee: Andrea Cosentino
>Priority: Minor
> Fix For: 2.21.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currently, the timestamp of the message produced by the publisher cannot be 
> accessed by the Message API in the custom processor where the message is 
> being consumed. This improvement adds the timestamp to the Message Header.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12235) Add Timestamp to Message header from ConsumerRecord in the camel-kafka component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355026#comment-16355026
 ] 

ASF GitHub Bot commented on CAMEL-12235:


oscerd commented on issue #2210: CAMEL-12235 - Added timestamp to message header
URL: https://github.com/apache/camel/pull/2210#issuecomment-363672037
 
 
   Merged. Thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add Timestamp to Message header  from ConsumerRecord in the camel-kafka 
> component 
> --
>
> Key: CAMEL-12235
> URL: https://issues.apache.org/jira/browse/CAMEL-12235
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-kafka
>Affects Versions: 2.21.0
>Reporter: Anand Banik
>Priority: Minor
> Fix For: 2.21.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currently, the timestamp of the message produced by the publisher cannot be 
> accessed by the Message API in the custom processor where the message is 
> being consumed. This improvement adds the timestamp to the Message Header.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12235) Add Timestamp to Message header from ConsumerRecord in the camel-kafka component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355028#comment-16355028
 ] 

ASF GitHub Bot commented on CAMEL-12235:


Github user oscerd closed the pull request at:

https://github.com/apache/camel/pull/2210


> Add Timestamp to Message header  from ConsumerRecord in the camel-kafka 
> component 
> --
>
> Key: CAMEL-12235
> URL: https://issues.apache.org/jira/browse/CAMEL-12235
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-kafka
>Affects Versions: 2.21.0
>Reporter: Anand Banik
>Priority: Minor
> Fix For: 2.21.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currently, the timestamp of the message produced by the publisher cannot be 
> accessed by the Message API in the custom processor where the message is 
> being consumed. This improvement adds the timestamp to the Message Header.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (CAMEL-12235) Add Timestamp to Message header from ConsumerRecord in the camel-kafka component

[Andrea Cosentino (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-12235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino reassigned CAMEL-12235:


Assignee: Andrea Cosentino

> Add Timestamp to Message header  from ConsumerRecord in the camel-kafka 
> component 
> --
>
> Key: CAMEL-12235
> URL: https://issues.apache.org/jira/browse/CAMEL-12235
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-kafka
>Affects Versions: 2.21.0
>Reporter: Anand Banik
>Assignee: Andrea Cosentino
>Priority: Minor
> Fix For: 2.21.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currently, the timestamp of the message produced by the publisher cannot be 
> accessed by the Message API in the custom processor where the message is 
> being consumed. This improvement adds the timestamp to the Message Header.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (CAMEL-12235) Add Timestamp to Message header from ConsumerRecord in the camel-kafka component

[Andrea Cosentino (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-12235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino updated CAMEL-12235:
-
Flags:   (was: Patch)

> Add Timestamp to Message header  from ConsumerRecord in the camel-kafka 
> component 
> --
>
> Key: CAMEL-12235
> URL: https://issues.apache.org/jira/browse/CAMEL-12235
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-kafka
>Affects Versions: 2.21.0
>Reporter: Anand Banik
>Assignee: Andrea Cosentino
>Priority: Minor
> Fix For: 2.21.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currently, the timestamp of the message produced by the publisher cannot be 
> accessed by the Message API in the custom processor where the message is 
> being consumed. This improvement adds the timestamp to the Message Header.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12235) Add Timestamp to Message header from ConsumerRecord in the camel-kafka component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355027#comment-16355027
 ] 

ASF GitHub Bot commented on CAMEL-12235:


oscerd closed pull request #2210: CAMEL-12235 - Added timestamp to message 
header
URL: https://github.com/apache/camel/pull/2210
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaConstants.java
 
b/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaConstants.java
index ee66c8350b1..545273d6536 100644
--- 
a/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaConstants.java
+++ 
b/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaConstants.java
@@ -25,6 +25,7 @@
 public static final String OFFSET = "kafka.OFFSET";
 public static final String HEADERS = "kafka.HEADERS";
 public static final String LAST_RECORD_BEFORE_COMMIT = 
"kafka.LAST_RECORD_BEFORE_COMMIT";
+public static final String TIMESTAMP = "kafka.TIMESTAMP";
 
 @Deprecated
 public static final String KAFKA_DEFAULT_ENCODER = 
"kafka.serializer.DefaultEncoder";
diff --git 
a/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaEndpoint.java
 
b/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaEndpoint.java
index da2dc97cbb1..52e4ed54f08 100644
--- 
a/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaEndpoint.java
+++ 
b/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaEndpoint.java
@@ -173,6 +173,7 @@ public Exchange createKafkaExchange(ConsumerRecord record) {
 message.setHeader(KafkaConstants.TOPIC, record.topic());
 message.setHeader(KafkaConstants.OFFSET, record.offset());
 message.setHeader(KafkaConstants.HEADERS, record.headers());
+message.setHeader(KafkaConstants.TIMESTAMP, record.timestamp());
 if (record.key() != null) {
 message.setHeader(KafkaConstants.KEY, record.key());
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add Timestamp to Message header  from ConsumerRecord in the camel-kafka 
> component 
> --
>
> Key: CAMEL-12235
> URL: https://issues.apache.org/jira/browse/CAMEL-12235
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-kafka
>Affects Versions: 2.21.0
>Reporter: Anand Banik
>Priority: Minor
> Fix For: 2.21.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currently, the timestamp of the message produced by the publisher cannot be 
> accessed by the Message API in the custom processor where the message is 
> being consumed. This improvement adds the timestamp to the Message Header.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12235) Add Timestamp to Message header from ConsumerRecord in the camel-kafka component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354975#comment-16354975
 ] 

ASF GitHub Bot commented on CAMEL-12235:


anandbanik commented on issue #2210: CAMEL-12235 - Added timestamp to message 
header
URL: https://github.com/apache/camel/pull/2210#issuecomment-363659326
 
 
   thanks, Andrea!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add Timestamp to Message header  from ConsumerRecord in the camel-kafka 
> component 
> --
>
> Key: CAMEL-12235
> URL: https://issues.apache.org/jira/browse/CAMEL-12235
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-kafka
>Affects Versions: 2.21.0
>Reporter: Anand Banik
>Priority: Minor
> Fix For: 2.21.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currently, the timestamp of the message produced by the publisher cannot be 
> accessed by the Message API in the custom processor where the message is 
> being consumed. This improvement adds the timestamp to the Message Header.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work started] (CAMEL-12170) [XChange] Add initial support for account management

[Thomas Diesler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on CAMEL-12170 started by Thomas Diesler.
--
> [XChange] Add initial support for account management
> 
>
> Key: CAMEL-12170
> URL: https://issues.apache.org/jira/browse/CAMEL-12170
> Project: Camel
>  Issue Type: New Feature
>Reporter: Thomas Diesler
>Assignee: Thomas Diesler
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12235) Add Timestamp to Message header from ConsumerRecord in the camel-kafka component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354461#comment-16354461
 ] 

ASF GitHub Bot commented on CAMEL-12235:


oscerd commented on issue #2210: CAMEL-12235 - Added timestamp to message header
URL: https://github.com/apache/camel/pull/2210#issuecomment-363543911
 
 
   I'll merge tomorrow. Thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add Timestamp to Message header  from ConsumerRecord in the camel-kafka 
> component 
> --
>
> Key: CAMEL-12235
> URL: https://issues.apache.org/jira/browse/CAMEL-12235
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-kafka
>Affects Versions: 2.21.0
>Reporter: Anand Banik
>Priority: Minor
> Fix For: 2.21.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currently, the timestamp of the message produced by the publisher cannot be 
> accessed by the Message API in the custom processor where the message is 
> being consumed. This improvement adds the timestamp to the Message Header.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12235) Add Timestamp to Message header from ConsumerRecord in the camel-kafka component

[Anand Banik (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354424#comment-16354424
 ] 

Anand Banik commented on CAMEL-12235:
-

Create a PR # 2210 for this issue. Please review and let me know.

 

> Add Timestamp to Message header  from ConsumerRecord in the camel-kafka 
> component 
> --
>
> Key: CAMEL-12235
> URL: https://issues.apache.org/jira/browse/CAMEL-12235
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-kafka
>Affects Versions: 2.21.0
>Reporter: Anand Banik
>Priority: Minor
> Fix For: 2.21.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currently, the timestamp of the message produced by the publisher cannot be 
> accessed by the Message API in the custom processor where the message is 
> being consumed. This improvement adds the timestamp to the Message Header.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12235) Add Timestamp to Message header from ConsumerRecord in the camel-kafka component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354417#comment-16354417
 ] 

ASF GitHub Bot commented on CAMEL-12235:


anandbanik opened a new pull request #2210: CAMEL-12235 - Added timestamp to 
message header
URL: https://github.com/apache/camel/pull/2210
 
 
   Currently, the timestamp of the message produced by the publisher cannot be 
accessed by the Message API in the custom processor where the message is being 
consumed. This improvement adds the timestamp to the Message Header.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add Timestamp to Message header  from ConsumerRecord in the camel-kafka 
> component 
> --
>
> Key: CAMEL-12235
> URL: https://issues.apache.org/jira/browse/CAMEL-12235
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-kafka
>Affects Versions: 2.21.0
>Reporter: Anand Banik
>Priority: Minor
> Fix For: 2.21.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currently, the timestamp of the message produced by the publisher cannot be 
> accessed by the Message API in the custom processor where the message is 
> being consumed. This improvement adds the timestamp to the Message Header.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12235) Add Timestamp to Message header from ConsumerRecord in the camel-kafka component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354418#comment-16354418
 ] 

ASF GitHub Bot commented on CAMEL-12235:


GitHub user anandbanik opened a pull request:

https://github.com/apache/camel/pull/2210

CAMEL-12235 - Added timestamp to message header

Currently, the timestamp of the message produced by the publisher cannot be 
accessed by the Message API in the custom processor where the message is being 
consumed. This improvement adds the timestamp to the Message Header.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anandbanik/camel CAMEL-12235

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/2210.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2210


commit 114f47f369957f2af97049b2c5b0c5116a1f6cde
Author: Anand Banik 
Date:   2018-02-06T19:16:21Z

CAMEL-12235 - Added timestamp to message header




> Add Timestamp to Message header  from ConsumerRecord in the camel-kafka 
> component 
> --
>
> Key: CAMEL-12235
> URL: https://issues.apache.org/jira/browse/CAMEL-12235
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-kafka
>Affects Versions: 2.21.0
>Reporter: Anand Banik
>Priority: Minor
> Fix For: 2.21.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currently, the timestamp of the message produced by the publisher cannot be 
> accessed by the Message API in the custom processor where the message is 
> being consumed. This improvement adds the timestamp to the Message Header.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (CAMEL-12235) Add Timestamp to Message header from ConsumerRecord in the camel-kafka component

[Anand Banik (JIRA)]

Anand Banik created CAMEL-12235:
---

 Summary: Add Timestamp to Message header  from ConsumerRecord in 
the camel-kafka component 
 Key: CAMEL-12235
 URL: https://issues.apache.org/jira/browse/CAMEL-12235
 Project: Camel
  Issue Type: Improvement
  Components: camel-kafka
Affects Versions: 2.21.0
Reporter: Anand Banik
 Fix For: 2.21.0


Currently, the timestamp of the message produced by the publisher cannot be 
accessed by the Message API in the custom processor where the message is being 
consumed. This improvement adds the timestamp to the Message Header.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (CAMEL-8958) Add push/pop to the DSL so people can easily preserve and get back a message as-is

[Claus Ibsen (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-8958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen resolved CAMEL-8958.

Resolution: Fixed

> Add push/pop to the DSL so people can easily preserve and get back a message 
> as-is
> --
>
> Key: CAMEL-8958
> URL: https://issues.apache.org/jira/browse/CAMEL-8958
> Project: Camel
>  Issue Type: New Feature
>  Components: camel-core, eip
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 2.21.0
>
>
> We may ponder about some good naming for an EIP that remembers an Exchange 
> and then allow to restore that Exchange at a later point.
> We could have push/pop as a stack fashion. Or use some kind of naming, 
> push(foo) and then pop(foo). Or some better naming.
> People today have stored the message body as an exchange body and then 
> restored that later. But this may be simpler.
> For pop we could allow an optional aggregation strategy so people can merge 
> the current exchange with the pop in any way they want.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12232) aws-s3: Client is immutable when created with the builder

[Andrea Cosentino (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354158#comment-16354158
 ] 

Andrea Cosentino commented on CAMEL-12232:
--

We'll improve the documentation and remove the endpoint options.

> aws-s3:  Client is immutable when created with the builder
> --
>
> Key: CAMEL-12232
> URL: https://issues.apache.org/jira/browse/CAMEL-12232
> Project: Camel
>  Issue Type: Bug
>  Components: camel-aws
>Affects Versions: 2.20.2
>Reporter: Michele Mancini
>Assignee: Andrea Cosentino
>Priority: Blocker
> Fix For: 2.20.3
>
>
> Hi, 
> I want to connect to Amazon S3 Bucket but I have the following issue:
> *Client is immutable when created with the builder.*
> *endpoint*: 
> aws-s3://test/private/system/brand/ETL/Feed?accessKey=RAW(XX)=eu-west-1=RAW()
> Do you know what the problem is? 
> In the past with the version 2.17.7 the issue was not present.
> Kendall 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12232) aws-s3: Client is immutable when created with the builder

[Michele Mancini (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354155#comment-16354155
 ] 

Michele Mancini commented on CAMEL-12232:
-

Thank you for your explanation and support. It has been very useful.

Michele

> aws-s3:  Client is immutable when created with the builder
> --
>
> Key: CAMEL-12232
> URL: https://issues.apache.org/jira/browse/CAMEL-12232
> Project: Camel
>  Issue Type: Bug
>  Components: camel-aws
>Affects Versions: 2.20.2
>Reporter: Michele Mancini
>Assignee: Andrea Cosentino
>Priority: Blocker
> Fix For: 2.20.3
>
>
> Hi, 
> I want to connect to Amazon S3 Bucket but I have the following issue:
> *Client is immutable when created with the builder.*
> *endpoint*: 
> aws-s3://test/private/system/brand/ETL/Feed?accessKey=RAW(XX)=eu-west-1=RAW()
> Do you know what the problem is? 
> In the past with the version 2.17.7 the issue was not present.
> Kendall 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (CAMEL-12232) aws-s3: Client is immutable when created with the builder

[Andrea Cosentino (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino resolved CAMEL-12232.
--
Resolution: Not A Problem

> aws-s3:  Client is immutable when created with the builder
> --
>
> Key: CAMEL-12232
> URL: https://issues.apache.org/jira/browse/CAMEL-12232
> Project: Camel
>  Issue Type: Bug
>  Components: camel-aws
>Affects Versions: 2.20.2
>Reporter: Michele Mancini
>Assignee: Andrea Cosentino
>Priority: Blocker
> Fix For: 2.20.3
>
>
> Hi, 
> I want to connect to Amazon S3 Bucket but I have the following issue:
> *Client is immutable when created with the builder.*
> *endpoint*: 
> aws-s3://test/private/system/brand/ETL/Feed?accessKey=RAW(XX)=eu-west-1=RAW()
> Do you know what the problem is? 
> In the past with the version 2.17.7 the issue was not present.
> Kendall 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12232) aws-s3: Client is immutable when created with the builder

[Andrea Cosentino (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354026#comment-16354026
 ] 

Andrea Cosentino commented on CAMEL-12232:
--

Maybe you need to avoid using eu-west-1, and use EU_WEST_1

> aws-s3:  Client is immutable when created with the builder
> --
>
> Key: CAMEL-12232
> URL: https://issues.apache.org/jira/browse/CAMEL-12232
> Project: Camel
>  Issue Type: Bug
>  Components: camel-aws
>Affects Versions: 2.20.2
>Reporter: Michele Mancini
>Assignee: Andrea Cosentino
>Priority: Blocker
> Fix For: 2.20.3
>
>
> Hi, 
> I want to connect to Amazon S3 Bucket but I have the following issue:
> *Client is immutable when created with the builder.*
> *endpoint*: 
> aws-s3://test/private/system/brand/ETL/Feed?accessKey=RAW(XX)=eu-west-1=RAW()
> Do you know what the problem is? 
> In the past with the version 2.17.7 the issue was not present.
> Kendall 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12232) aws-s3: Client is immutable when created with the builder

[Andrea Cosentino (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354023#comment-16354023
 ] 

Andrea Cosentino commented on CAMEL-12232:
--

For example a route like this one works fine with 2.20.3-SNAPSHOT and 2.20.2

 
{code:java}
from("aws-s3://bucket?accessKey=RAW(X)=RAW(X)=US_WEST_1=false=25=5000")
{code}

> aws-s3:  Client is immutable when created with the builder
> --
>
> Key: CAMEL-12232
> URL: https://issues.apache.org/jira/browse/CAMEL-12232
> Project: Camel
>  Issue Type: Bug
>  Components: camel-aws
>Affects Versions: 2.20.2
>Reporter: Michele Mancini
>Assignee: Andrea Cosentino
>Priority: Blocker
> Fix For: 2.20.3
>
>
> Hi, 
> I want to connect to Amazon S3 Bucket but I have the following issue:
> *Client is immutable when created with the builder.*
> *endpoint*: 
> aws-s3://test/private/system/brand/ETL/Feed?accessKey=RAW(XX)=eu-west-1=RAW()
> Do you know what the problem is? 
> In the past with the version 2.17.7 the issue was not present.
> Kendall 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (CAMEL-12232) aws-s3: Client is immutable when created with the builder

[Andrea Cosentino (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354023#comment-16354023
 ] 

Andrea Cosentino edited comment on CAMEL-12232 at 2/6/18 3:41 PM:
--

For example a route like this one works fine with 2.20.3-SNAPSHOT and 2.20.2
{code:java}
from("aws-s3://bucket?accessKey=RAW(X)=RAW(X)=US_WEST_1=false=25=5000")
{code}


was (Author: ancosen):
For example a route like this one works fine with 2.20.3-SNAPSHOT and 2.20.2

 
{code:java}
from("aws-s3://bucket?accessKey=RAW(X)=RAW(X)=US_WEST_1=false=25=5000")
{code}

> aws-s3:  Client is immutable when created with the builder
> --
>
> Key: CAMEL-12232
> URL: https://issues.apache.org/jira/browse/CAMEL-12232
> Project: Camel
>  Issue Type: Bug
>  Components: camel-aws
>Affects Versions: 2.20.2
>Reporter: Michele Mancini
>Assignee: Andrea Cosentino
>Priority: Blocker
> Fix For: 2.20.3
>
>
> Hi, 
> I want to connect to Amazon S3 Bucket but I have the following issue:
> *Client is immutable when created with the builder.*
> *endpoint*: 
> aws-s3://test/private/system/brand/ETL/Feed?accessKey=RAW(XX)=eu-west-1=RAW()
> Do you know what the problem is? 
> In the past with the version 2.17.7 the issue was not present.
> Kendall 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12232) aws-s3: Client is immutable when created with the builder

[Andrea Cosentino (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354013#comment-16354013
 ] 

Andrea Cosentino commented on CAMEL-12232:
--

and the fact that it was not present in 2.17.7 doesn't mean that the behavior 
cannot change on 2.20.x. We can have breaking change between minor version 
(following semantic versioning) in Apache Camel. At least this is how things 
work from a while.

> aws-s3:  Client is immutable when created with the builder
> --
>
> Key: CAMEL-12232
> URL: https://issues.apache.org/jira/browse/CAMEL-12232
> Project: Camel
>  Issue Type: Bug
>  Components: camel-aws
>Affects Versions: 2.20.2
>Reporter: Michele Mancini
>Assignee: Andrea Cosentino
>Priority: Blocker
> Fix For: 2.20.3
>
>
> Hi, 
> I want to connect to Amazon S3 Bucket but I have the following issue:
> *Client is immutable when created with the builder.*
> *endpoint*: 
> aws-s3://test/private/system/brand/ETL/Feed?accessKey=RAW(XX)=eu-west-1=RAW()
> Do you know what the problem is? 
> In the past with the version 2.17.7 the issue was not present.
> Kendall 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12232) aws-s3: Client is immutable when created with the builder

[Andrea Cosentino (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354012#comment-16354012
 ] 

Andrea Cosentino commented on CAMEL-12232:
--

I'm currently using 2.20.1 and 2.20.2 in other projects, with accessKey, 
secretKey and region set exactly as you are trying to do. The documentation 
you're looking at, is not the latest you can take a look at 
https://github.com/apache/camel/blob/camel-2.20.x/components/camel-aws/src/main/docs/aws-s3-component.adoc

> aws-s3:  Client is immutable when created with the builder
> --
>
> Key: CAMEL-12232
> URL: https://issues.apache.org/jira/browse/CAMEL-12232
> Project: Camel
>  Issue Type: Bug
>  Components: camel-aws
>Affects Versions: 2.20.2
>Reporter: Michele Mancini
>Assignee: Andrea Cosentino
>Priority: Blocker
> Fix For: 2.20.3
>
>
> Hi, 
> I want to connect to Amazon S3 Bucket but I have the following issue:
> *Client is immutable when created with the builder.*
> *endpoint*: 
> aws-s3://test/private/system/brand/ETL/Feed?accessKey=RAW(XX)=eu-west-1=RAW()
> Do you know what the problem is? 
> In the past with the version 2.17.7 the issue was not present.
> Kendall 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12232) aws-s3: Client is immutable when created with the builder

[Andrea Cosentino (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354005#comment-16354005
 ] 

Andrea Cosentino commented on CAMEL-12232:
--

I already done a test.

> aws-s3:  Client is immutable when created with the builder
> --
>
> Key: CAMEL-12232
> URL: https://issues.apache.org/jira/browse/CAMEL-12232
> Project: Camel
>  Issue Type: Bug
>  Components: camel-aws
>Affects Versions: 2.20.2
>Reporter: Michele Mancini
>Assignee: Andrea Cosentino
>Priority: Blocker
> Fix For: 2.20.3
>
>
> Hi, 
> I want to connect to Amazon S3 Bucket but I have the following issue:
> *Client is immutable when created with the builder.*
> *endpoint*: 
> aws-s3://test/private/system/brand/ETL/Feed?accessKey=RAW(XX)=eu-west-1=RAW()
> Do you know what the problem is? 
> In the past with the version 2.17.7 the issue was not present.
> Kendall 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12221) Let's create a camel-fhir component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354002#comment-16354002
 ] 

ASF GitHub Bot commented on CAMEL-12221:


johnpoth commented on issue #2206: [CAMEL-12221] Let's create a camel-fhir 
component
URL: https://github.com/apache/camel/pull/2206#issuecomment-363456862
 
 
   @davsclaus changes updated.
   
   - [x]   Renamed `fhir-json` -> `fhirJson` dito for `fhirXml`
   - [x]   Made Spring XML more friendly. Note that creating a `FhirContext` is 
expensive.
   - [x]   Removed `XmlTransient`
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Let's create a camel-fhir component
> ---
>
> Key: CAMEL-12221
> URL: https://issues.apache.org/jira/browse/CAMEL-12221
> Project: Camel
>  Issue Type: New Feature
>Reporter: John Poth
>Priority: Major
>
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Reopened] (CAMEL-12232) aws-s3: Client is immutable when created with the builder

[Michele Mancini (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michele Mancini reopened CAMEL-12232:
-

*I am sorry but this behaviour was not present in the version 2.17.7.*

Following the documentation the field region is used as:

"The region who the bucket is located. This option is used in the 
{{com.amazonaws.services.s3.model.CreateBucketRequest}}."

The correct field is amazonS3Endpoint.

[http://camel.apache.org/aws-s3.html]

 

By the way, I did a test and it does not work.

 

Could you please perform a test before close this ticket?

Thanks

Michele

> aws-s3:  Client is immutable when created with the builder
> --
>
> Key: CAMEL-12232
> URL: https://issues.apache.org/jira/browse/CAMEL-12232
> Project: Camel
>  Issue Type: Bug
>  Components: camel-aws
>Affects Versions: 2.20.2
>Reporter: Michele Mancini
>Assignee: Andrea Cosentino
>Priority: Blocker
> Fix For: 2.20.3
>
>
> Hi, 
> I want to connect to Amazon S3 Bucket but I have the following issue:
> *Client is immutable when created with the builder.*
> *endpoint*: 
> aws-s3://test/private/system/brand/ETL/Feed?accessKey=RAW(XX)=eu-west-1=RAW()
> Do you know what the problem is? 
> In the past with the version 2.17.7 the issue was not present.
> Kendall 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (CAMEL-12234) Camel-AWS: Since we are using builders, we need to deprecate the AWS endpoint options on the component that are using them

[Andrea Cosentino (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-12234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino updated CAMEL-12234:
-
Description: In case someone wants to specify an endpoint, he will be 
always able to build an AWS client and add it to Camel registry.  (was: In case 
someone want to specify an endpoint, he will be always able to build an AWS 
client and add it to Camel registry.)

> Camel-AWS: Since we are using builders, we need to deprecate the AWS endpoint 
> options on the component that are using them
> --
>
> Key: CAMEL-12234
> URL: https://issues.apache.org/jira/browse/CAMEL-12234
> Project: Camel
>  Issue Type: Task
>  Components: camel-aws
>Reporter: Andrea Cosentino
>Assignee: Andrea Cosentino
>Priority: Major
> Fix For: 2.21.0
>
>
> In case someone wants to specify an endpoint, he will be always able to build 
> an AWS client and add it to Camel registry.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (CAMEL-12234) Camel-AWS: Since we are using builders, we need to deprecate the AWS endpoint options on the component that are using them

[Andrea Cosentino (JIRA)]

Andrea Cosentino created CAMEL-12234:


 Summary: Camel-AWS: Since we are using builders, we need to 
deprecate the AWS endpoint options on the component that are using them
 Key: CAMEL-12234
 URL: https://issues.apache.org/jira/browse/CAMEL-12234
 Project: Camel
  Issue Type: Task
  Components: camel-aws
Reporter: Andrea Cosentino
Assignee: Andrea Cosentino
 Fix For: 2.21.0


In case someone want to specify an endpoint, he will be always able to build an 
AWS client and add it to Camel registry.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12221) Let's create a camel-fhir component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353971#comment-16353971
 ] 

ASF GitHub Bot commented on CAMEL-12221:


johnpoth commented on a change in pull request #2206: [CAMEL-12221] Let's 
create a camel-fhir component
URL: https://github.com/apache/camel/pull/2206#discussion_r166329492
 
 

 ##
 File path: 
components/camel-fhir/src/main/java/org/apache/camel/component/fhir/FhirJsonDataFormat.java
 ##
 @@ -0,0 +1,98 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.fhir;
+
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.io.OutputStream;
+import java.io.OutputStreamWriter;
+
+import ca.uhn.fhir.context.FhirContext;
+import org.apache.camel.Exchange;
+import org.apache.camel.spi.DataFormat;
+import org.apache.camel.spi.DataFormatName;
+import org.apache.camel.support.ServiceSupport;
+import org.hl7.fhir.instance.model.api.IBaseResource;
+
+public class FhirJsonDataFormat extends ServiceSupport implements DataFormat, 
DataFormatName {
+
+private FhirContext fhirContext;
+private boolean contentTypeHeader = true;
 
 Review comment:
   Isn't it defined by default through 
[inheritance](https://github.com/apache/camel/blob/a030a22314eacafe416af749eb17b6a1046c4236/camel-core/src/main/java/org/apache/camel/model/DataFormatDefinition.java#L52)
 ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Let's create a camel-fhir component
> ---
>
> Key: CAMEL-12221
> URL: https://issues.apache.org/jira/browse/CAMEL-12221
> Project: Camel
>  Issue Type: New Feature
>Reporter: John Poth
>Priority: Major
>
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12221) Let's create a camel-fhir component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353967#comment-16353967
 ] 

ASF GitHub Bot commented on CAMEL-12221:


johnpoth commented on issue #2206: [CAMEL-12221] Let's create a camel-fhir 
component
URL: https://github.com/apache/camel/pull/2206#issuecomment-363447840
 
 
   Thanks @davsclaus reviewing :+1: won't despair for sure I'll take a look


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Let's create a camel-fhir component
> ---
>
> Key: CAMEL-12221
> URL: https://issues.apache.org/jira/browse/CAMEL-12221
> Project: Camel
>  Issue Type: New Feature
>Reporter: John Poth
>Priority: Major
>
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (CAMEL-12233) spring-boot: add threadNamePattern property

[Pascal Schumacher (JIRA)]

Pascal Schumacher created CAMEL-12233:
-

 Summary: spring-boot: add threadNamePattern property
 Key: CAMEL-12233
 URL: https://issues.apache.org/jira/browse/CAMEL-12233
 Project: Camel
  Issue Type: Improvement
  Components: camel-spring-boot
Reporter: Pascal Schumacher


In spring xml is is possible to configure the _threadNamePattern_ as an 
attribute of the _camelContext_ element.

I could not find a way to configure with camel-spring-boot.

It would be nice if _threadNamePattern_ was added to 
_CamelConfigurationProperties_.

Thanks in advance!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (CAMEL-12232) aws-s3: Client is immutable when created with the builder

[Andrea Cosentino (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino resolved CAMEL-12232.
--
Resolution: Not A Problem

> aws-s3:  Client is immutable when created with the builder
> --
>
> Key: CAMEL-12232
> URL: https://issues.apache.org/jira/browse/CAMEL-12232
> Project: Camel
>  Issue Type: Bug
>  Components: camel-aws
>Affects Versions: 2.20.2
>Reporter: Michele Mancini
>Assignee: Andrea Cosentino
>Priority: Blocker
> Fix For: 2.20.3
>
>
> Hi, 
> I want to connect to Amazon S3 Bucket but I have the following issue:
> *Client is immutable when created with the builder.*
> *endpoint*: 
> aws-s3://test/private/system/brand/ETL/Feed?accessKey=RAW(XX)=eu-west-1=RAW()
> Do you know what the problem is? 
> In the past with the version 2.17.7 the issue was not present.
> Kendall 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12232) aws-s3: Client is immutable when created with the builder

[Andrea Cosentino (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353956#comment-16353956
 ] 

Andrea Cosentino commented on CAMEL-12232:
--

For this kind of problem use the users mailing list. by the way instead of 
using amazonS3Endpoint use the region parameter.

> aws-s3:  Client is immutable when created with the builder
> --
>
> Key: CAMEL-12232
> URL: https://issues.apache.org/jira/browse/CAMEL-12232
> Project: Camel
>  Issue Type: Bug
>  Components: camel-aws
>Affects Versions: 2.20.2
>Reporter: Michele Mancini
>Assignee: Andrea Cosentino
>Priority: Blocker
> Fix For: 2.20.3
>
>
> Hi, 
> I want to connect to Amazon S3 Bucket but I have the following issue:
> *Client is immutable when created with the builder.*
> *endpoint*: 
> aws-s3://test/private/system/brand/ETL/Feed?accessKey=RAW(XX)=eu-west-1=RAW()
> Do you know what the problem is? 
> In the past with the version 2.17.7 the issue was not present.
> Kendall 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (CAMEL-12232) aws-s3: Client is immutable when created with the builder

[Andrea Cosentino (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino reassigned CAMEL-12232:


Assignee: Andrea Cosentino

> aws-s3:  Client is immutable when created with the builder
> --
>
> Key: CAMEL-12232
> URL: https://issues.apache.org/jira/browse/CAMEL-12232
> Project: Camel
>  Issue Type: Bug
>  Components: camel-aws
>Affects Versions: 2.20.2
>Reporter: Michele Mancini
>Assignee: Andrea Cosentino
>Priority: Blocker
> Fix For: 2.20.3
>
>
> Hi, 
> I want to connect to Amazon S3 Bucket but I have the following issue:
> *Client is immutable when created with the builder.*
> *endpoint*: 
> aws-s3://test/private/system/brand/ETL/Feed?accessKey=RAW(XX)=eu-west-1=RAW()
> Do you know what the problem is? 
> In the past with the version 2.17.7 the issue was not present.
> Kendall 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (CAMEL-12232) aws-s3: Client is immutable when created with the builder

[Michele Mancini (JIRA)]

Michele Mancini created CAMEL-12232:
---

 Summary: aws-s3:  Client is immutable when created with the builder
 Key: CAMEL-12232
 URL: https://issues.apache.org/jira/browse/CAMEL-12232
 Project: Camel
  Issue Type: Bug
  Components: camel-aws
Affects Versions: 2.20.2
Reporter: Michele Mancini
 Fix For: 2.20.3


Hi, 

I want to connect to Amazon S3 Bucket but I have the following issue:

*Client is immutable when created with the builder.*

*endpoint*: 
aws-s3://test/private/system/brand/ETL/Feed?accessKey=RAW(XX)=eu-west-1=RAW()


Do you know what the problem is? 

In the past with the version 2.17.7 the issue was not present.

Kendall 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12167) [XChange] Get the list of supported currency pairs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353940#comment-16353940
 ] 

ASF GitHub Bot commented on CAMEL-12167:


GitHub user tdiesler opened a pull request:

https://github.com/apache/camel/pull/2209

[XChange] Get the list of supported currency pairs

Resolves CAMEL-12167

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tdiesler/camel CAMEL-12167

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/2209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2209


commit 39577e39fef63dd20ca56ad5fdec4739a0c4302f
Author: Thomas Diesler 
Date:   2018-02-06T14:32:54Z

[XChange] Get the list of supported currency pairs

Resolves CAMEL-12167




> [XChange] Get the list of supported currency pairs
> --
>
> Key: CAMEL-12167
> URL: https://issues.apache.org/jira/browse/CAMEL-12167
> Project: Camel
>  Issue Type: New Feature
>Reporter: Thomas Diesler
>Assignee: Thomas Diesler
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12221) Let's create a camel-fhir component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353837#comment-16353837
 ] 

ASF GitHub Bot commented on CAMEL-12221:


davsclaus commented on issue #2206: [CAMEL-12221] Let's create a camel-fhir 
component
URL: https://github.com/apache/camel/pull/2206#issuecomment-363413540
 
 
   btw dont dispair, creating a new data format is one of the hardest one to 
get right, as they are more special than anything in camel.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Let's create a camel-fhir component
> ---
>
> Key: CAMEL-12221
> URL: https://issues.apache.org/jira/browse/CAMEL-12221
> Project: Camel
>  Issue Type: New Feature
>Reporter: John Poth
>Priority: Major
>
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12221) Let's create a camel-fhir component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353824#comment-16353824
 ] 

ASF GitHub Bot commented on CAMEL-12221:


davsclaus commented on a change in pull request #2206: [CAMEL-12221] Let's 
create a camel-fhir component
URL: https://github.com/apache/camel/pull/2206#discussion_r166284484
 
 

 ##
 File path: 
camel-core/src/main/java/org/apache/camel/model/dataformat/FhirJsonDataFormat.java
 ##
 @@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.model.dataformat;
+
+import javax.xml.bind.annotation.XmlAccessType;
+import javax.xml.bind.annotation.XmlAccessorType;
+import javax.xml.bind.annotation.XmlRootElement;
+import javax.xml.bind.annotation.XmlTransient;
+import org.apache.camel.CamelContext;
+import org.apache.camel.model.DataFormatDefinition;
+import org.apache.camel.spi.DataFormat;
+import org.apache.camel.spi.Metadata;
+
+/**
+ * The FHIR JSON data format is used to marshall/unmarshall to/from FHIR 
objects to/from JSON.
+ */
+@Metadata(firstVersion = "2.21.0", label = "dataformat,transformation,json", 
title = "FHIR JSON")
+@XmlRootElement(name = "fhir-json")
+@XmlAccessorType(XmlAccessType.FIELD)
+public class FhirJsonDataFormat extends DataFormatDefinition {
+
+@XmlTransient
+private Object fhirContext;
 
 Review comment:
   Also this needs a way to configure this in XML by having an `@XmlAttribute` 
where you can specify the id of this fhir context to lookup in the registry, 
see some of the other data formats.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Let's create a camel-fhir component
> ---
>
> Key: CAMEL-12221
> URL: https://issues.apache.org/jira/browse/CAMEL-12221
> Project: Camel
>  Issue Type: New Feature
>Reporter: John Poth
>Priority: Major
>
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12221) Let's create a camel-fhir component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353826#comment-16353826
 ] 

ASF GitHub Bot commented on CAMEL-12221:


davsclaus commented on a change in pull request #2206: [CAMEL-12221] Let's 
create a camel-fhir component
URL: https://github.com/apache/camel/pull/2206#discussion_r166283634
 
 

 ##
 File path: 
camel-core/src/main/java/org/apache/camel/model/dataformat/FhirJsonDataFormat.java
 ##
 @@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.model.dataformat;
+
+import javax.xml.bind.annotation.XmlAccessType;
+import javax.xml.bind.annotation.XmlAccessorType;
+import javax.xml.bind.annotation.XmlRootElement;
+import javax.xml.bind.annotation.XmlTransient;
+import org.apache.camel.CamelContext;
+import org.apache.camel.model.DataFormatDefinition;
+import org.apache.camel.spi.DataFormat;
+import org.apache.camel.spi.Metadata;
+
+/**
+ * The FHIR JSON data format is used to marshall/unmarshall to/from FHIR 
objects to/from JSON.
+ */
+@Metadata(firstVersion = "2.21.0", label = "dataformat,transformation,json", 
title = "FHIR JSON")
+@XmlRootElement(name = "fhir-json")
 
 Review comment:
   We dont use dash in those xml names, and btw it should be the same as you 
define in DataFormatsDefinition, so it should be `fhirJson` etc and ditto for 
the XML guy


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Let's create a camel-fhir component
> ---
>
> Key: CAMEL-12221
> URL: https://issues.apache.org/jira/browse/CAMEL-12221
> Project: Camel
>  Issue Type: New Feature
>Reporter: John Poth
>Priority: Major
>
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12221) Let's create a camel-fhir component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353833#comment-16353833
 ] 

ASF GitHub Bot commented on CAMEL-12221:


davsclaus commented on a change in pull request #2206: [CAMEL-12221] Let's 
create a camel-fhir component
URL: https://github.com/apache/camel/pull/2206#discussion_r166285038
 
 

 ##
 File path: components/camel-fhir/src/test/resources/log4j2.properties
 ##
 @@ -0,0 +1,23 @@
+## ---
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements.  See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License.  You may obtain a copy of the License at
+##
+##  http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---
+
+appender.out.type = Console
+appender.out.name = out
+appender.out.layout.type = PatternLayout
+appender.out.layout.pattern = [%30.30t] %-30.30c{1} %-5p %m%n
+rootLogger.level = INFO
+rootLogger.appenderRef.out.ref = out
 
 Review comment:
   Add logging to file as well, see the other data formats


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Let's create a camel-fhir component
> ---
>
> Key: CAMEL-12221
> URL: https://issues.apache.org/jira/browse/CAMEL-12221
> Project: Camel
>  Issue Type: New Feature
>Reporter: John Poth
>Priority: Major
>
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12221) Let's create a camel-fhir component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353832#comment-16353832
 ] 

ASF GitHub Bot commented on CAMEL-12221:


davsclaus commented on a change in pull request #2206: [CAMEL-12221] Let's 
create a camel-fhir component
URL: https://github.com/apache/camel/pull/2206#discussion_r166284248
 
 

 ##
 File path: 
camel-core/src/main/java/org/apache/camel/model/dataformat/FhirJsonDataFormat.java
 ##
 @@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.model.dataformat;
+
+import javax.xml.bind.annotation.XmlAccessType;
+import javax.xml.bind.annotation.XmlAccessorType;
+import javax.xml.bind.annotation.XmlRootElement;
+import javax.xml.bind.annotation.XmlTransient;
+import org.apache.camel.CamelContext;
+import org.apache.camel.model.DataFormatDefinition;
+import org.apache.camel.spi.DataFormat;
+import org.apache.camel.spi.Metadata;
+
+/**
+ * The FHIR JSON data format is used to marshall/unmarshall to/from FHIR 
objects to/from JSON.
+ */
+@Metadata(firstVersion = "2.21.0", label = "dataformat,transformation,json", 
title = "FHIR JSON")
+@XmlRootElement(name = "fhir-json")
+@XmlAccessorType(XmlAccessType.FIELD)
+public class FhirJsonDataFormat extends DataFormatDefinition {
+
+@XmlTransient
+private Object fhirContext;
 
 Review comment:
   Is this not required, if so add `@Metadata(required = true)`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Let's create a camel-fhir component
> ---
>
> Key: CAMEL-12221
> URL: https://issues.apache.org/jira/browse/CAMEL-12221
> Project: Camel
>  Issue Type: New Feature
>Reporter: John Poth
>Priority: Major
>
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12221) Let's create a camel-fhir component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353834#comment-16353834
 ] 

ASF GitHub Bot commented on CAMEL-12221:


davsclaus commented on a change in pull request #2206: [CAMEL-12221] Let's 
create a camel-fhir component
URL: https://github.com/apache/camel/pull/2206#discussion_r166285288
 
 

 ##
 File path: 
components/camel-fhir/src/test/resources/org/apache/camel/dataformat/fhir/json/FhirJsonDataFormatSpringTest.xml
 ##
 @@ -0,0 +1,44 @@
+
+
+http://www.springframework.org/schema/beans;
+   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+   xsi:schemaLocation="
+   http://www.springframework.org/schema/beans 
http://www.springframework.org/schema/beans/spring-beans.xsd
+   http://camel.apache.org/schema/spring 
http://camel.apache.org/schema/spring/camel-spring.xsd
+">
+  
 
 Review comment:
   Find a way to make configuring this easier in XML - for example add some 
kind of way to just say "forDstu3" and Camel can do all this stuff for you. 
Only if you need to manually do something you can do all of this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Let's create a camel-fhir component
> ---
>
> Key: CAMEL-12221
> URL: https://issues.apache.org/jira/browse/CAMEL-12221
> Project: Camel
>  Issue Type: New Feature
>Reporter: John Poth
>Priority: Major
>
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12221) Let's create a camel-fhir component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353827#comment-16353827
 ] 

ASF GitHub Bot commented on CAMEL-12221:


davsclaus commented on a change in pull request #2206: [CAMEL-12221] Let's 
create a camel-fhir component
URL: https://github.com/apache/camel/pull/2206#discussion_r166284536
 
 

 ##
 File path: 
camel-core/src/main/java/org/apache/camel/model/dataformat/FhirJsonDataFormat.java
 ##
 @@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.model.dataformat;
+
+import javax.xml.bind.annotation.XmlAccessType;
+import javax.xml.bind.annotation.XmlAccessorType;
+import javax.xml.bind.annotation.XmlRootElement;
+import javax.xml.bind.annotation.XmlTransient;
+import org.apache.camel.CamelContext;
+import org.apache.camel.model.DataFormatDefinition;
+import org.apache.camel.spi.DataFormat;
+import org.apache.camel.spi.Metadata;
+
+/**
+ * The FHIR JSON data format is used to marshall/unmarshall to/from FHIR 
objects to/from JSON.
+ */
+@Metadata(firstVersion = "2.21.0", label = "dataformat,transformation,json", 
title = "FHIR JSON")
+@XmlRootElement(name = "fhir-json")
+@XmlAccessorType(XmlAccessType.FIELD)
+public class FhirJsonDataFormat extends DataFormatDefinition {
+
+@XmlTransient
+private Object fhirContext;
 
 Review comment:
   In other words it should not be transient


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Let's create a camel-fhir component
> ---
>
> Key: CAMEL-12221
> URL: https://issues.apache.org/jira/browse/CAMEL-12221
> Project: Camel
>  Issue Type: New Feature
>Reporter: John Poth
>Priority: Major
>
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12221) Let's create a camel-fhir component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353825#comment-16353825
 ] 

ASF GitHub Bot commented on CAMEL-12221:


davsclaus commented on a change in pull request #2206: [CAMEL-12221] Let's 
create a camel-fhir component
URL: https://github.com/apache/camel/pull/2206#discussion_r166283829
 
 

 ##
 File path: 
camel-core/src/main/java/org/apache/camel/model/dataformat/FhirJsonDataFormat.java
 ##
 @@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.model.dataformat;
+
+import javax.xml.bind.annotation.XmlAccessType;
+import javax.xml.bind.annotation.XmlAccessorType;
+import javax.xml.bind.annotation.XmlRootElement;
+import javax.xml.bind.annotation.XmlTransient;
+import org.apache.camel.CamelContext;
+import org.apache.camel.model.DataFormatDefinition;
+import org.apache.camel.spi.DataFormat;
+import org.apache.camel.spi.Metadata;
+
+/**
+ * The FHIR JSON data format is used to marshall/unmarshall to/from FHIR 
objects to/from JSON.
+ */
+@Metadata(firstVersion = "2.21.0", label = "dataformat,transformation,json", 
title = "FHIR JSON")
+@XmlRootElement(name = "fhir-json")
 
 Review comment:
   Is this not for HL7, if so add "hl7" to the label as well


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Let's create a camel-fhir component
> ---
>
> Key: CAMEL-12221
> URL: https://issues.apache.org/jira/browse/CAMEL-12221
> Project: Camel
>  Issue Type: New Feature
>Reporter: John Poth
>Priority: Major
>
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12221) Let's create a camel-fhir component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353829#comment-16353829
 ] 

ASF GitHub Bot commented on CAMEL-12221:


davsclaus commented on a change in pull request #2206: [CAMEL-12221] Let's 
create a camel-fhir component
URL: https://github.com/apache/camel/pull/2206#discussion_r166284001
 
 

 ##
 File path: components/camel-fhir/pom.xml
 ##
 @@ -0,0 +1,133 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+
+  4.0.0
+
+  
+org.apache.camel
+components
+2.21.0-SNAPSHOT
+  
+  
+  camel-fhir
+  jar
+
+  Camel :: Fhir
+  Camel Fhir Component
 
 Review comment:
   The description should say data format as its not a regular component


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Let's create a camel-fhir component
> ---
>
> Key: CAMEL-12221
> URL: https://issues.apache.org/jira/browse/CAMEL-12221
> Project: Camel
>  Issue Type: New Feature
>Reporter: John Poth
>Priority: Major
>
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12221) Let's create a camel-fhir component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353830#comment-16353830
 ] 

ASF GitHub Bot commented on CAMEL-12221:


davsclaus commented on a change in pull request #2206: [CAMEL-12221] Let's 
create a camel-fhir component
URL: https://github.com/apache/camel/pull/2206#discussion_r166284682
 
 

 ##
 File path: 
components/camel-fhir/src/main/java/org/apache/camel/component/fhir/FhirXmlDataFormat.java
 ##
 @@ -0,0 +1,98 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.fhir;
+
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.io.OutputStream;
+import java.io.OutputStreamWriter;
+
+import ca.uhn.fhir.context.FhirContext;
+import org.apache.camel.Exchange;
+import org.apache.camel.spi.DataFormat;
+import org.apache.camel.spi.DataFormatName;
+import org.apache.camel.support.ServiceSupport;
+import org.hl7.fhir.instance.model.api.IBaseResource;
+
+public class FhirXmlDataFormat extends ServiceSupport implements DataFormat, 
DataFormatName {
+
+private FhirContext fhirContext;
+private boolean contentTypeHeader = true;
 
 Review comment:
   Ditto


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Let's create a camel-fhir component
> ---
>
> Key: CAMEL-12221
> URL: https://issues.apache.org/jira/browse/CAMEL-12221
> Project: Camel
>  Issue Type: New Feature
>Reporter: John Poth
>Priority: Major
>
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12221) Let's create a camel-fhir component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353831#comment-16353831
 ] 

ASF GitHub Bot commented on CAMEL-12221:


davsclaus commented on a change in pull request #2206: [CAMEL-12221] Let's 
create a camel-fhir component
URL: https://github.com/apache/camel/pull/2206#discussion_r166284642
 
 

 ##
 File path: 
components/camel-fhir/src/main/java/org/apache/camel/component/fhir/FhirJsonDataFormat.java
 ##
 @@ -0,0 +1,98 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.fhir;
+
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.io.OutputStream;
+import java.io.OutputStreamWriter;
+
+import ca.uhn.fhir.context.FhirContext;
+import org.apache.camel.Exchange;
+import org.apache.camel.spi.DataFormat;
+import org.apache.camel.spi.DataFormatName;
+import org.apache.camel.support.ServiceSupport;
+import org.hl7.fhir.instance.model.api.IBaseResource;
+
+public class FhirJsonDataFormat extends ServiceSupport implements DataFormat, 
DataFormatName {
+
+private FhirContext fhirContext;
+private boolean contentTypeHeader = true;
 
 Review comment:
   This option should also be on the model so end users can configure it there 
too


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Let's create a camel-fhir component
> ---
>
> Key: CAMEL-12221
> URL: https://issues.apache.org/jira/browse/CAMEL-12221
> Project: Camel
>  Issue Type: New Feature
>Reporter: John Poth
>Priority: Major
>
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12221) Let's create a camel-fhir component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353828#comment-16353828
 ] 

ASF GitHub Bot commented on CAMEL-12221:


davsclaus commented on a change in pull request #2206: [CAMEL-12221] Let's 
create a camel-fhir component
URL: https://github.com/apache/camel/pull/2206#discussion_r166284045
 
 

 ##
 File path: components/camel-fhir/pom.xml
 ##
 @@ -0,0 +1,133 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+
+  4.0.0
+
+  
+org.apache.camel
+components
+2.21.0-SNAPSHOT
+  
+  
+  camel-fhir
+  jar
+
+  Camel :: Fhir
+  Camel Fhir Component
+
+  
+
+  org.apache.camel.spi.DataFormatResolver;dataformat=fhir-json,
+  org.apache.camel.spi.DataFormatResolver;dataformat=fhir-xml,
 
 Review comment:
   Remove trailing comma


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Let's create a camel-fhir component
> ---
>
> Key: CAMEL-12221
> URL: https://issues.apache.org/jira/browse/CAMEL-12221
> Project: Camel
>  Issue Type: New Feature
>Reporter: John Poth
>Priority: Major
>
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (CAMEL-12231) Camel-Amqp: Use Netty 4.1.x since Qpid-jms-client now use that version

[Andrea Cosentino (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-12231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino resolved CAMEL-12231.
--
Resolution: Fixed

> Camel-Amqp: Use Netty 4.1.x since Qpid-jms-client now use that version
> --
>
> Key: CAMEL-12231
> URL: https://issues.apache.org/jira/browse/CAMEL-12231
> Project: Camel
>  Issue Type: Task
>Reporter: Andrea Cosentino
>Assignee: Andrea Cosentino
>Priority: Major
> Fix For: 2.21.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (CAMEL-12231) Camel-Amqp: Use Netty 4.1.x since Qpid-jms-client now use that version

[Andrea Cosentino (JIRA)]

Andrea Cosentino created CAMEL-12231:


 Summary: Camel-Amqp: Use Netty 4.1.x since Qpid-jms-client now use 
that version
 Key: CAMEL-12231
 URL: https://issues.apache.org/jira/browse/CAMEL-12231
 Project: Camel
  Issue Type: Task
Reporter: Andrea Cosentino
Assignee: Andrea Cosentino
 Fix For: 2.21.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-8958) Add push/pop to the DSL so people can easily preserve and get back a message as-is

[Claus Ibsen (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-8958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353664#comment-16353664
 ] 

Claus Ibsen commented on CAMEL-8958:


Okay you can now filter using a include/exclude prefix with + and - sign. By 
default everything is included, but you can say "-body,-header:bar" to exclude 
these two etc.

> Add push/pop to the DSL so people can easily preserve and get back a message 
> as-is
> --
>
> Key: CAMEL-8958
> URL: https://issues.apache.org/jira/browse/CAMEL-8958
> Project: Camel
>  Issue Type: New Feature
>  Components: camel-core, eip
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 2.21.0
>
>
> We may ponder about some good naming for an EIP that remembers an Exchange 
> and then allow to restore that Exchange at a later point.
> We could have push/pop as a stack fashion. Or use some kind of naming, 
> push(foo) and then pop(foo). Or some better naming.
> People today have stored the message body as an exchange body and then 
> restored that later. But this may be simpler.
> For pop we could allow an optional aggregation strategy so people can merge 
> the current exchange with the pop in any way they want.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12221) Let's create a camel-fhir component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353659#comment-16353659
 ] 

ASF GitHub Bot commented on CAMEL-12221:


johnpoth commented on issue #2206: [CAMEL-12221] Let's create a camel-fhir 
component
URL: https://github.com/apache/camel/pull/2206#issuecomment-363369985
 
 
   @davsclaus thanks for reviewing, changes updated to add default constructor 
with default context.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Let's create a camel-fhir component
> ---
>
> Key: CAMEL-12221
> URL: https://issues.apache.org/jira/browse/CAMEL-12221
> Project: Camel
>  Issue Type: New Feature
>Reporter: John Poth
>Priority: Major
>
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12180) camel-braintree - Downgrade to version without org.json

[Andrea Cosentino (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353613#comment-16353613
 ] 

Andrea Cosentino commented on CAMEL-12180:
--

The braintree Karaf feature is aligned, we currently don't use the bundle from 
SMX, but we can switch soon.

> camel-braintree - Downgrade to version without org.json
> ---
>
> Key: CAMEL-12180
> URL: https://issues.apache.org/jira/browse/CAMEL-12180
> Project: Camel
>  Issue Type: Task
>  Components: camel-braintree
>Affects Versions: 2.21.0
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 2.21.0
>
>
> We cannot use newer version as it uses org.json JAR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work started] (CAMEL-12167) [XChange] Get the list of supported currency pairs

[Thomas Diesler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-12167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on CAMEL-12167 started by Thomas Diesler.
--
> [XChange] Get the list of supported currency pairs
> --
>
> Key: CAMEL-12167
> URL: https://issues.apache.org/jira/browse/CAMEL-12167
> Project: Camel
>  Issue Type: New Feature
>Reporter: Thomas Diesler
>Assignee: Thomas Diesler
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12221) Let's create a camel-fhir component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353622#comment-16353622
 ] 

ASF GitHub Bot commented on CAMEL-12221:


davsclaus commented on issue #2206: [CAMEL-12221] Let's create a camel-fhir 
component
URL: https://github.com/apache/camel/pull/2206#issuecomment-363361292
 
 
   The data format class implementation must have a default no-arg constructor, 
and then getter/setter for its options. 
   
   In the XML example then its a smell when you must use constructor 
configuration. Ideally it should be simpler than that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Let's create a camel-fhir component
> ---
>
> Key: CAMEL-12221
> URL: https://issues.apache.org/jira/browse/CAMEL-12221
> Project: Camel
>  Issue Type: New Feature
>Reporter: John Poth
>Priority: Major
>
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (CAMEL-12180) camel-braintree - Downgrade to version without org.json

[Andrea Cosentino (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-12180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino resolved CAMEL-12180.
--
Resolution: Fixed

> camel-braintree - Downgrade to version without org.json
> ---
>
> Key: CAMEL-12180
> URL: https://issues.apache.org/jira/browse/CAMEL-12180
> Project: Camel
>  Issue Type: Task
>  Components: camel-braintree
>Affects Versions: 2.21.0
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 2.21.0
>
>
> We cannot use newer version as it uses org.json JAR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12221) Let's create a camel-fhir component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353606#comment-16353606
 ] 

ASF GitHub Bot commented on CAMEL-12221:


johnpoth commented on issue #2206: [CAMEL-12221] Let's create a camel-fhir 
component
URL: https://github.com/apache/camel/pull/2206#issuecomment-363358635
 
 
   @davsclaus changes updated. I removed the FhirEndpoint which didn't have a 
UriPath. Users can use the sdk client in a processing step directly (as in 
`Hl7v2PatientToFhirPatientIT`) or use camel-http when accessing the FHIR REST 
server. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Let's create a camel-fhir component
> ---
>
> Key: CAMEL-12221
> URL: https://issues.apache.org/jira/browse/CAMEL-12221
> Project: Camel
>  Issue Type: New Feature
>Reporter: John Poth
>Priority: Major
>
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-8958) Add push/pop to the DSL so people can easily preserve and get back a message as-is

[Claus Ibsen (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-8958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353589#comment-16353589
 ] 

Claus Ibsen commented on CAMEL-8958:


The data is being renamed to include and then we add an exclude as well. 

> Add push/pop to the DSL so people can easily preserve and get back a message 
> as-is
> --
>
> Key: CAMEL-8958
> URL: https://issues.apache.org/jira/browse/CAMEL-8958
> Project: Camel
>  Issue Type: New Feature
>  Components: camel-core, eip
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 2.21.0
>
>
> We may ponder about some good naming for an EIP that remembers an Exchange 
> and then allow to restore that Exchange at a later point.
> We could have push/pop as a stack fashion. Or use some kind of naming, 
> push(foo) and then pop(foo). Or some better naming.
> People today have stored the message body as an exchange body and then 
> restored that later. But this may be simpler.
> For pop we could allow an optional aggregation strategy so people can merge 
> the current exchange with the pop in any way they want.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12230) Camel-Ribbon: add a Karaf feature

[Andrea Cosentino (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353543#comment-16353543
 ] 

Andrea Cosentino commented on CAMEL-12230:
--

Changed to task, we'll need to try to add a karaf feature for the component.

> Camel-Ribbon: add a Karaf feature
> -
>
> Key: CAMEL-12230
> URL: https://issues.apache.org/jira/browse/CAMEL-12230
> Project: Camel
>  Issue Type: Task
>  Components: camel-ribbon
>Affects Versions: 2.20.2
> Environment: Karaf 4.1.4
> Camel 2.20.2
> Win 10
> Oracle Java 1.8.0_161
>Reporter: Vadim R
>Priority: Minor
>
> I'm trying to use ribbon load balancer in *Karaf* like this:
> {code:java}
> from("timer:consumerTimer?fixedRate=true=0=1")
> .routeId("consumeService")
> .setBody(simple("Hello, Producer! This is message from 
> consumer on ${camelId}/${routeId}"))
> .serviceCall()
> .name("producer")
> .component("netty4:tcp")
> .ribbonLoadBalancer()
> .consulServiceDiscovery()
> .endParent()
> .convertBodyTo(String.class)
> .log("Producer response: ${body}");
> {code}
> But after start my bundle, following error appear in log (log:display):
> {code:java}
> 2018-02-06 10:53:24,289 | ERROR | nt Dispatcher: 1 | BlueprintCamelContext
> | 36 - org.apache.camel.camel-blueprint - 2.20.2 | Error occurred 
> during starting Camel Context  consumer-context
> org.apache.camel.FailedToCreateRouteException: Failed to create route 
> consumeService at: >>> ServiceCall[producer] <<< in route: 
> Route(consumeService)[[From[timer:consumerTimer?fixedRate=tr... because of 
> Could not find factory class for resource: 
> META-INF/services/org/apache/camel/cloud/ribbon-service-load-balancer
> at 
> org.apache.camel.model.RouteDefinition.addRoutes(RouteDefinition.java:1298) 
> [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.model.RouteDefinition.addRoutes(RouteDefinition.java:204) 
> [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.startRoute(DefaultCamelContext.java:1148)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.startRouteDefinitions(DefaultCamelContext.java:3727)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.doStartCamel(DefaultCamelContext.java:3441)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.access$000(DefaultCamelContext.java:208)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext$2.call(DefaultCamelContext.java:3249)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext$2.call(DefaultCamelContext.java:3245)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.doWithDefinedClassLoader(DefaultCamelContext.java:3268)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.doStart(DefaultCamelContext.java:3245)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.support.ServiceSupport.start(ServiceSupport.java:61) 
> [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.start(DefaultCamelContext.java:3168)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.blueprint.BlueprintCamelContext.start(BlueprintCamelContext.java:244)
>  [36:org.apache.camel.camel-blueprint:2.20.2]
> at 
> org.apache.camel.blueprint.BlueprintCamelContext.maybeStart(BlueprintCamelContext.java:284)
>  [36:org.apache.camel.camel-blueprint:2.20.2]
> at 
> org.apache.camel.blueprint.BlueprintCamelContext.blueprintEvent(BlueprintCamelContext.java:177)
>  [36:org.apache.camel.camel-blueprint:2.20.2]
> at 
> org.apache.aries.blueprint.container.BlueprintEventDispatcher$4.call(BlueprintEventDispatcher.java:201)
>  [28:org.apache.aries.blueprint.core:1.8.3]
> at 
> org.apache.aries.blueprint.container.BlueprintEventDispatcher$4.call(BlueprintEventDispatcher.java:199)
>  [28:org.apache.aries.blueprint.core:1.8.3]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:?]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:?]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
> at 
> 

[jira] [Updated] (CAMEL-12230) Karaf error while using ribbon load balancer

[Andrea Cosentino (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-12230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino updated CAMEL-12230:
-
Issue Type: Task  (was: Bug)

> Karaf error while using ribbon load balancer
> 
>
> Key: CAMEL-12230
> URL: https://issues.apache.org/jira/browse/CAMEL-12230
> Project: Camel
>  Issue Type: Task
>  Components: camel-ribbon
>Affects Versions: 2.20.2
> Environment: Karaf 4.1.4
> Camel 2.20.2
> Win 10
> Oracle Java 1.8.0_161
>Reporter: Vadim R
>Priority: Minor
>
> I'm trying to use ribbon load balancer in *Karaf* like this:
> {code:java}
> from("timer:consumerTimer?fixedRate=true=0=1")
> .routeId("consumeService")
> .setBody(simple("Hello, Producer! This is message from 
> consumer on ${camelId}/${routeId}"))
> .serviceCall()
> .name("producer")
> .component("netty4:tcp")
> .ribbonLoadBalancer()
> .consulServiceDiscovery()
> .endParent()
> .convertBodyTo(String.class)
> .log("Producer response: ${body}");
> {code}
> But after start my bundle, following error appear in log (log:display):
> {code:java}
> 2018-02-06 10:53:24,289 | ERROR | nt Dispatcher: 1 | BlueprintCamelContext
> | 36 - org.apache.camel.camel-blueprint - 2.20.2 | Error occurred 
> during starting Camel Context  consumer-context
> org.apache.camel.FailedToCreateRouteException: Failed to create route 
> consumeService at: >>> ServiceCall[producer] <<< in route: 
> Route(consumeService)[[From[timer:consumerTimer?fixedRate=tr... because of 
> Could not find factory class for resource: 
> META-INF/services/org/apache/camel/cloud/ribbon-service-load-balancer
> at 
> org.apache.camel.model.RouteDefinition.addRoutes(RouteDefinition.java:1298) 
> [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.model.RouteDefinition.addRoutes(RouteDefinition.java:204) 
> [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.startRoute(DefaultCamelContext.java:1148)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.startRouteDefinitions(DefaultCamelContext.java:3727)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.doStartCamel(DefaultCamelContext.java:3441)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.access$000(DefaultCamelContext.java:208)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext$2.call(DefaultCamelContext.java:3249)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext$2.call(DefaultCamelContext.java:3245)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.doWithDefinedClassLoader(DefaultCamelContext.java:3268)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.doStart(DefaultCamelContext.java:3245)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.support.ServiceSupport.start(ServiceSupport.java:61) 
> [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.start(DefaultCamelContext.java:3168)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.blueprint.BlueprintCamelContext.start(BlueprintCamelContext.java:244)
>  [36:org.apache.camel.camel-blueprint:2.20.2]
> at 
> org.apache.camel.blueprint.BlueprintCamelContext.maybeStart(BlueprintCamelContext.java:284)
>  [36:org.apache.camel.camel-blueprint:2.20.2]
> at 
> org.apache.camel.blueprint.BlueprintCamelContext.blueprintEvent(BlueprintCamelContext.java:177)
>  [36:org.apache.camel.camel-blueprint:2.20.2]
> at 
> org.apache.aries.blueprint.container.BlueprintEventDispatcher$4.call(BlueprintEventDispatcher.java:201)
>  [28:org.apache.aries.blueprint.core:1.8.3]
> at 
> org.apache.aries.blueprint.container.BlueprintEventDispatcher$4.call(BlueprintEventDispatcher.java:199)
>  [28:org.apache.aries.blueprint.core:1.8.3]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:?]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:?]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
> at 
> 

[jira] [Updated] (CAMEL-12230) Camel-Ribbon: add a Karaf feature

[Andrea Cosentino (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-12230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino updated CAMEL-12230:
-
Summary: Camel-Ribbon: add a Karaf feature  (was: Karaf error while using 
ribbon load balancer)

> Camel-Ribbon: add a Karaf feature
> -
>
> Key: CAMEL-12230
> URL: https://issues.apache.org/jira/browse/CAMEL-12230
> Project: Camel
>  Issue Type: Task
>  Components: camel-ribbon
>Affects Versions: 2.20.2
> Environment: Karaf 4.1.4
> Camel 2.20.2
> Win 10
> Oracle Java 1.8.0_161
>Reporter: Vadim R
>Priority: Minor
>
> I'm trying to use ribbon load balancer in *Karaf* like this:
> {code:java}
> from("timer:consumerTimer?fixedRate=true=0=1")
> .routeId("consumeService")
> .setBody(simple("Hello, Producer! This is message from 
> consumer on ${camelId}/${routeId}"))
> .serviceCall()
> .name("producer")
> .component("netty4:tcp")
> .ribbonLoadBalancer()
> .consulServiceDiscovery()
> .endParent()
> .convertBodyTo(String.class)
> .log("Producer response: ${body}");
> {code}
> But after start my bundle, following error appear in log (log:display):
> {code:java}
> 2018-02-06 10:53:24,289 | ERROR | nt Dispatcher: 1 | BlueprintCamelContext
> | 36 - org.apache.camel.camel-blueprint - 2.20.2 | Error occurred 
> during starting Camel Context  consumer-context
> org.apache.camel.FailedToCreateRouteException: Failed to create route 
> consumeService at: >>> ServiceCall[producer] <<< in route: 
> Route(consumeService)[[From[timer:consumerTimer?fixedRate=tr... because of 
> Could not find factory class for resource: 
> META-INF/services/org/apache/camel/cloud/ribbon-service-load-balancer
> at 
> org.apache.camel.model.RouteDefinition.addRoutes(RouteDefinition.java:1298) 
> [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.model.RouteDefinition.addRoutes(RouteDefinition.java:204) 
> [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.startRoute(DefaultCamelContext.java:1148)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.startRouteDefinitions(DefaultCamelContext.java:3727)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.doStartCamel(DefaultCamelContext.java:3441)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.access$000(DefaultCamelContext.java:208)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext$2.call(DefaultCamelContext.java:3249)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext$2.call(DefaultCamelContext.java:3245)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.doWithDefinedClassLoader(DefaultCamelContext.java:3268)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.doStart(DefaultCamelContext.java:3245)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.support.ServiceSupport.start(ServiceSupport.java:61) 
> [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.start(DefaultCamelContext.java:3168)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.blueprint.BlueprintCamelContext.start(BlueprintCamelContext.java:244)
>  [36:org.apache.camel.camel-blueprint:2.20.2]
> at 
> org.apache.camel.blueprint.BlueprintCamelContext.maybeStart(BlueprintCamelContext.java:284)
>  [36:org.apache.camel.camel-blueprint:2.20.2]
> at 
> org.apache.camel.blueprint.BlueprintCamelContext.blueprintEvent(BlueprintCamelContext.java:177)
>  [36:org.apache.camel.camel-blueprint:2.20.2]
> at 
> org.apache.aries.blueprint.container.BlueprintEventDispatcher$4.call(BlueprintEventDispatcher.java:201)
>  [28:org.apache.aries.blueprint.core:1.8.3]
> at 
> org.apache.aries.blueprint.container.BlueprintEventDispatcher$4.call(BlueprintEventDispatcher.java:199)
>  [28:org.apache.aries.blueprint.core:1.8.3]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:?]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:?]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
> at 
> 

[jira] [Commented] (CAMEL-12230) Karaf error while using ribbon load balancer

[Andrea Cosentino (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353536#comment-16353536
 ] 

Andrea Cosentino commented on CAMEL-12230:
--

It's never been supported in Karaf. 

> Karaf error while using ribbon load balancer
> 
>
> Key: CAMEL-12230
> URL: https://issues.apache.org/jira/browse/CAMEL-12230
> Project: Camel
>  Issue Type: Bug
>  Components: camel-ribbon
>Affects Versions: 2.20.2
> Environment: Karaf 4.1.4
> Camel 2.20.2
> Win 10
> Oracle Java 1.8.0_161
>Reporter: Vadim R
>Priority: Minor
>
> I'm trying to use ribbon load balancer in *Karaf* like this:
> {code:java}
> from("timer:consumerTimer?fixedRate=true=0=1")
> .routeId("consumeService")
> .setBody(simple("Hello, Producer! This is message from 
> consumer on ${camelId}/${routeId}"))
> .serviceCall()
> .name("producer")
> .component("netty4:tcp")
> .ribbonLoadBalancer()
> .consulServiceDiscovery()
> .endParent()
> .convertBodyTo(String.class)
> .log("Producer response: ${body}");
> {code}
> But after start my bundle, following error appear in log (log:display):
> {code:java}
> 2018-02-06 10:53:24,289 | ERROR | nt Dispatcher: 1 | BlueprintCamelContext
> | 36 - org.apache.camel.camel-blueprint - 2.20.2 | Error occurred 
> during starting Camel Context  consumer-context
> org.apache.camel.FailedToCreateRouteException: Failed to create route 
> consumeService at: >>> ServiceCall[producer] <<< in route: 
> Route(consumeService)[[From[timer:consumerTimer?fixedRate=tr... because of 
> Could not find factory class for resource: 
> META-INF/services/org/apache/camel/cloud/ribbon-service-load-balancer
> at 
> org.apache.camel.model.RouteDefinition.addRoutes(RouteDefinition.java:1298) 
> [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.model.RouteDefinition.addRoutes(RouteDefinition.java:204) 
> [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.startRoute(DefaultCamelContext.java:1148)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.startRouteDefinitions(DefaultCamelContext.java:3727)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.doStartCamel(DefaultCamelContext.java:3441)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.access$000(DefaultCamelContext.java:208)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext$2.call(DefaultCamelContext.java:3249)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext$2.call(DefaultCamelContext.java:3245)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.doWithDefinedClassLoader(DefaultCamelContext.java:3268)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.doStart(DefaultCamelContext.java:3245)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.support.ServiceSupport.start(ServiceSupport.java:61) 
> [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.impl.DefaultCamelContext.start(DefaultCamelContext.java:3168)
>  [39:org.apache.camel.camel-core:2.20.2]
> at 
> org.apache.camel.blueprint.BlueprintCamelContext.start(BlueprintCamelContext.java:244)
>  [36:org.apache.camel.camel-blueprint:2.20.2]
> at 
> org.apache.camel.blueprint.BlueprintCamelContext.maybeStart(BlueprintCamelContext.java:284)
>  [36:org.apache.camel.camel-blueprint:2.20.2]
> at 
> org.apache.camel.blueprint.BlueprintCamelContext.blueprintEvent(BlueprintCamelContext.java:177)
>  [36:org.apache.camel.camel-blueprint:2.20.2]
> at 
> org.apache.aries.blueprint.container.BlueprintEventDispatcher$4.call(BlueprintEventDispatcher.java:201)
>  [28:org.apache.aries.blueprint.core:1.8.3]
> at 
> org.apache.aries.blueprint.container.BlueprintEventDispatcher$4.call(BlueprintEventDispatcher.java:199)
>  [28:org.apache.aries.blueprint.core:1.8.3]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:?]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:?]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
> at 
> 

[jira] [Created] (CAMEL-12230) Karaf error while using ribbon load balancer

[Vadim Ryzhov (JIRA)]

Vadim Ryzhov created CAMEL-12230:


 Summary: Karaf error while using ribbon load balancer
 Key: CAMEL-12230
 URL: https://issues.apache.org/jira/browse/CAMEL-12230
 Project: Camel
  Issue Type: Bug
  Components: camel-ribbon
Affects Versions: 2.20.2
 Environment: Karaf 4.1.4
Camel 2.20.2
Win 10
Oracle Java 1.8.0_161
Reporter: Vadim Ryzhov


I'm trying to use ribbon load balancer in *Karaf* like this:

{code:java}
from("timer:consumerTimer?fixedRate=true=0=1")
.routeId("consumeService")
.setBody(simple("Hello, Producer! This is message from consumer 
on ${camelId}/${routeId}"))
.serviceCall()
.name("producer")
.component("netty4:tcp")
.ribbonLoadBalancer()
.consulServiceDiscovery()
.endParent()
.convertBodyTo(String.class)
.log("Producer response: ${body}");
{code}

But after start my bundle, following error appear in log (log:display):
{code:java}
2018-02-06 10:53:24,289 | ERROR | nt Dispatcher: 1 | BlueprintCamelContext  
  | 36 - org.apache.camel.camel-blueprint - 2.20.2 | Error occurred during 
starting Camel Context  consumer-context
org.apache.camel.FailedToCreateRouteException: Failed to create route 
consumeService at: >>> ServiceCall[producer] <<< in route: 
Route(consumeService)[[From[timer:consumerTimer?fixedRate=tr... because of 
Could not find factory class for resource: 
META-INF/services/org/apache/camel/cloud/ribbon-service-load-balancer
at 
org.apache.camel.model.RouteDefinition.addRoutes(RouteDefinition.java:1298) 
[39:org.apache.camel.camel-core:2.20.2]
at 
org.apache.camel.model.RouteDefinition.addRoutes(RouteDefinition.java:204) 
[39:org.apache.camel.camel-core:2.20.2]
at 
org.apache.camel.impl.DefaultCamelContext.startRoute(DefaultCamelContext.java:1148)
 [39:org.apache.camel.camel-core:2.20.2]
at 
org.apache.camel.impl.DefaultCamelContext.startRouteDefinitions(DefaultCamelContext.java:3727)
 [39:org.apache.camel.camel-core:2.20.2]
at 
org.apache.camel.impl.DefaultCamelContext.doStartCamel(DefaultCamelContext.java:3441)
 [39:org.apache.camel.camel-core:2.20.2]
at 
org.apache.camel.impl.DefaultCamelContext.access$000(DefaultCamelContext.java:208)
 [39:org.apache.camel.camel-core:2.20.2]
at 
org.apache.camel.impl.DefaultCamelContext$2.call(DefaultCamelContext.java:3249) 
[39:org.apache.camel.camel-core:2.20.2]
at 
org.apache.camel.impl.DefaultCamelContext$2.call(DefaultCamelContext.java:3245) 
[39:org.apache.camel.camel-core:2.20.2]
at 
org.apache.camel.impl.DefaultCamelContext.doWithDefinedClassLoader(DefaultCamelContext.java:3268)
 [39:org.apache.camel.camel-core:2.20.2]
at 
org.apache.camel.impl.DefaultCamelContext.doStart(DefaultCamelContext.java:3245)
 [39:org.apache.camel.camel-core:2.20.2]
at 
org.apache.camel.support.ServiceSupport.start(ServiceSupport.java:61) 
[39:org.apache.camel.camel-core:2.20.2]
at 
org.apache.camel.impl.DefaultCamelContext.start(DefaultCamelContext.java:3168) 
[39:org.apache.camel.camel-core:2.20.2]
at 
org.apache.camel.blueprint.BlueprintCamelContext.start(BlueprintCamelContext.java:244)
 [36:org.apache.camel.camel-blueprint:2.20.2]
at 
org.apache.camel.blueprint.BlueprintCamelContext.maybeStart(BlueprintCamelContext.java:284)
 [36:org.apache.camel.camel-blueprint:2.20.2]
at 
org.apache.camel.blueprint.BlueprintCamelContext.blueprintEvent(BlueprintCamelContext.java:177)
 [36:org.apache.camel.camel-blueprint:2.20.2]
at 
org.apache.aries.blueprint.container.BlueprintEventDispatcher$4.call(BlueprintEventDispatcher.java:201)
 [28:org.apache.aries.blueprint.core:1.8.3]
at 
org.apache.aries.blueprint.container.BlueprintEventDispatcher$4.call(BlueprintEventDispatcher.java:199)
 [28:org.apache.aries.blueprint.core:1.8.3]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:?]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:?]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
 [?:?]
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
 [?:?]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
[?:?]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
[?:?]
at