ajantha-bhat commented on a change in pull request #3778:
URL: https://github.com/apache/carbondata/pull/3778#discussion_r458547213
##
File path:
index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/TestSIWithComplexArrayType.scala
##
@@
ajantha-bhat edited a comment on pull request #3778:
URL: https://github.com/apache/carbondata/pull/3778#issuecomment-662251770
a) I feel we should handle the SI support for all array of primitive not
just string.
b) Better to discuss the row level SI solution in community once ?
ajantha-bhat commented on pull request #3778:
URL: https://github.com/apache/carbondata/pull/3778#issuecomment-662251770
a) I feel we should handle the SI support for all array not just
string.
b) Better to discuss the row level SI solution in community once ?
@QiangCai ,
vikramahuja1001 commented on pull request #3855:
URL: https://github.com/apache/carbondata/pull/3855#issuecomment-662251240
@MarvinLitt , please add proper description as to why this PR is needed and
what changes are proposed
brijoobopanna commented on pull request #3774:
URL: https://github.com/apache/carbondata/pull/3774#issuecomment-662238464
retest this please
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/CARBONDATA-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash R Nilugal resolved CARBONDATA-3902.
-
Fix Version/s: 2.1.0
Resolution: Fixed
> Query on partition table
asfgit closed pull request #3846:
URL: https://github.com/apache/carbondata/pull/3846
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
akashrn5 commented on pull request #3846:
URL: https://github.com/apache/carbondata/pull/3846#issuecomment-662235965
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
QiangCai commented on pull request #3849:
URL: https://github.com/apache/carbondata/pull/3849#issuecomment-662199441
please check all usage of
CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT/CarbonCommonConstants.CARBON_DATE_FORMAT
and consider whether it need get table properties or not.
jackylk commented on pull request #3770:
URL: https://github.com/apache/carbondata/pull/3770#issuecomment-662189893
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
CarbonDataQA1 commented on pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857#issuecomment-662073114
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
Karan980 opened a new pull request #3857:
URL: https://github.com/apache/carbondata/pull/3857
**Why is this PR needed?**
Reading data from empty carbontable through hive beeline was giving "Unable
read Carbon Schema" exception, when no data is present in table.
CarbonDataQA1 commented on pull request #3846:
URL: https://github.com/apache/carbondata/pull/3846#issuecomment-662012100
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1716/
CarbonDataQA1 commented on pull request #3846:
URL: https://github.com/apache/carbondata/pull/3846#issuecomment-662011240
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3458/
CarbonDataQA1 commented on pull request #3841:
URL: https://github.com/apache/carbondata/pull/3841#issuecomment-661917823
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1715/
CarbonDataQA1 commented on pull request #3841:
URL: https://github.com/apache/carbondata/pull/3841#issuecomment-661915225
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3457/
CarbonDataQA1 commented on pull request #3849:
URL: https://github.com/apache/carbondata/pull/3849#issuecomment-661896594
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3456/
CarbonDataQA1 commented on pull request #3849:
URL: https://github.com/apache/carbondata/pull/3849#issuecomment-661896331
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1714/
[
https://issues.apache.org/jira/browse/CARBONDATA-3907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash R Nilugal resolved CARBONDATA-3907.
-
Resolution: Fixed
> Reuse firePreLoadEvents and firePostLoadEvents methods
asfgit closed pull request #3850:
URL: https://github.com/apache/carbondata/pull/3850
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
akashrn5 commented on pull request #3850:
URL: https://github.com/apache/carbondata/pull/3850#issuecomment-661876221
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/CARBONDATA-3846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ajantha Bhat resolved CARBONDATA-3846.
--
Fix Version/s: 2.1.0
Resolution: Fixed
> Dataload fails for boolean column
asfgit closed pull request #3831:
URL: https://github.com/apache/carbondata/pull/3831
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
VenuReddy2103 commented on a change in pull request #3850:
URL: https://github.com/apache/carbondata/pull/3850#discussion_r458109264
##
File path:
processing/src/main/java/org/apache/carbondata/processing/loading/events/LoadEvents.java
##
@@ -51,12 +51,6 @@ public
CarbonDataQA1 commented on pull request #3850:
URL: https://github.com/apache/carbondata/pull/3850#issuecomment-661863139
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1713/
CarbonDataQA1 commented on pull request #3850:
URL: https://github.com/apache/carbondata/pull/3850#issuecomment-661862560
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3455/
ShreelekhyaG commented on a change in pull request #3841:
URL: https://github.com/apache/carbondata/pull/3841#discussion_r458094901
##
File path: core/src/main/java/org/apache/carbondata/core/view/MVManager.java
##
@@ -143,9 +143,9 @@ public void createSchema(String
ShreelekhyaG commented on a change in pull request #3841:
URL: https://github.com/apache/carbondata/pull/3841#discussion_r458068490
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/view/rewrite/MVCreateTestCase.scala
##
@@ -955,9 +955,9 @@ class
ShreelekhyaG commented on a change in pull request #3841:
URL: https://github.com/apache/carbondata/pull/3841#discussion_r458068693
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/view/MVTest.scala
##
@@ -178,6 +180,13 @@ class MVTest extends QueryTest
ShreelekhyaG commented on a change in pull request #3849:
URL: https://github.com/apache/carbondata/pull/3849#discussion_r458050377
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestLoadDataWithDiffTimestampFormat.scala
##
@@
CarbonDataQA1 commented on pull request #3856:
URL: https://github.com/apache/carbondata/pull/3856#issuecomment-661812319
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3454/
CarbonDataQA1 commented on pull request #3856:
URL: https://github.com/apache/carbondata/pull/3856#issuecomment-661812041
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1712/
VenuReddy2103 commented on a change in pull request #3841:
URL: https://github.com/apache/carbondata/pull/3841#discussion_r458023893
##
File path:
integration/spark/src/main/scala/org/apache/carbondata/view/MVManagerInSpark.scala
##
@@ -48,17 +48,14 @@ class
VenuReddy2103 commented on a change in pull request #3841:
URL: https://github.com/apache/carbondata/pull/3841#discussion_r458023893
##
File path:
integration/spark/src/main/scala/org/apache/carbondata/view/MVManagerInSpark.scala
##
@@ -48,17 +48,14 @@ class
akashrn5 commented on a change in pull request #3846:
URL: https://github.com/apache/carbondata/pull/3846#discussion_r458019493
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/merge/MergeTestCase.scala
##
@@ -869,10 +910,15 @@ class
akashrn5 commented on a change in pull request #3846:
URL: https://github.com/apache/carbondata/pull/3846#discussion_r458018787
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/merge/MergeTestCase.scala
##
@@ -725,6 +725,47 @@ class
akashrn5 commented on a change in pull request #3846:
URL: https://github.com/apache/carbondata/pull/3846#discussion_r458018898
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/merge/MergeTestCase.scala
##
@@ -725,6 +725,47 @@ class
akashrn5 commented on a change in pull request #3846:
URL: https://github.com/apache/carbondata/pull/3846#discussion_r458018601
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/merge/MergeTestCase.scala
##
@@ -725,6 +725,47 @@ class
akashrn5 commented on a change in pull request #3846:
URL: https://github.com/apache/carbondata/pull/3846#discussion_r458017848
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/merge/CarbonMergeDataSetCommand.scala
##
@@ -175,6
akashrn5 commented on pull request #3850:
URL: https://github.com/apache/carbondata/pull/3850#issuecomment-661791291
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
VenuReddy2103 commented on a change in pull request #3841:
URL: https://github.com/apache/carbondata/pull/3841#discussion_r458011089
##
File path:
integration/spark/src/main/scala/org/apache/carbondata/view/MVManagerInSpark.scala
##
@@ -48,17 +48,14 @@ class
ShreelekhyaG commented on a change in pull request #3774:
URL: https://github.com/apache/carbondata/pull/3774#discussion_r458007728
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertIntoCommand.scala
##
@@ -482,6
CarbonDataQA1 commented on pull request #3856:
URL: https://github.com/apache/carbondata/pull/3856#issuecomment-661766963
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1709/
CarbonDataQA1 commented on pull request #3856:
URL: https://github.com/apache/carbondata/pull/3856#issuecomment-661764814
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3451/
CarbonDataQA1 commented on pull request #3778:
URL: https://github.com/apache/carbondata/pull/3778#issuecomment-661763876
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
CarbonDataQA1 commented on pull request #3846:
URL: https://github.com/apache/carbondata/pull/3846#issuecomment-661749375
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1707/
CarbonDataQA1 commented on pull request #3846:
URL: https://github.com/apache/carbondata/pull/3846#issuecomment-661748809
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3449/
xubo245 commented on pull request #3770:
URL: https://github.com/apache/carbondata/pull/3770#issuecomment-661711709
need one more LGTM
This is an automated message from the Apache Git Service.
To respond to the message,
CarbonDataQA1 commented on pull request #3834:
URL: https://github.com/apache/carbondata/pull/3834#issuecomment-661706074
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3453/
CarbonDataQA1 commented on pull request #3834:
URL: https://github.com/apache/carbondata/pull/3834#issuecomment-661705591
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1711/
akashrn5 opened a new pull request #3856:
URL: https://github.com/apache/carbondata/pull/3856
avro write
### Why is this PR needed?
### What changes were proposed in this PR?
### Does this PR introduce any user interface change?
- No
- Yes.
asfgit closed pull request #3785:
URL: https://github.com/apache/carbondata/pull/3785
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
akashrn5 commented on pull request #3850:
URL: https://github.com/apache/carbondata/pull/3850#issuecomment-661668892
@VenuReddy2103 please make PR heading short like below
`Refactor to use CommonLoadUtils API's firePreLoadEvents and
firePostLoadEvents to trigger Load pre and post
akashrn5 commented on a change in pull request #3846:
URL: https://github.com/apache/carbondata/pull/3846#discussion_r457857926
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/merge/CarbonMergeDataSetCommand.scala
##
@@ -175,6
54 matches
Mail list logo