[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4037: [CARBONDATA-4070] [CARBONDATA-4059] Fixed SI issues and improved FT.

CarbonDataQA2 commented on pull request #4037: URL: https://github.com/apache/carbondata/pull/4037#issuecomment-745113746 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5163/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4037: [CARBONDATA-4070] [CARBONDATA-4059] Fixed SI issues and improved FT.

CarbonDataQA2 commented on pull request #4037: URL: https://github.com/apache/carbondata/pull/4037#issuecomment-745113304 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3401/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4046: [CARBONDATA-4071] Fix wrong values of date or timestamp child columns on reading through SDK.

CarbonDataQA2 commented on pull request #4046: URL: https://github.com/apache/carbondata/pull/4046#issuecomment-745109211 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3400/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4046: [CARBONDATA-4071] Fix wrong values of date or timestamp child columns on reading through SDK.

CarbonDataQA2 commented on pull request #4046: URL: https://github.com/apache/carbondata/pull/4046#issuecomment-745107047 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5162/

[GitHub] [carbondata] Karan980 commented on a change in pull request #4048: [CARBONDATA-4072] Clean files command is not deleting .segment files for the segments added through alter table add segment

Karan980 commented on a change in pull request #4048: URL: https://github.com/apache/carbondata/pull/4048#discussion_r543092493 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/addsegment/AddSegmentTestCase.scala ## @@ -962,6 +962,88 @@

[GitHub] [carbondata] Karan980 commented on a change in pull request #4048: [CARBONDATA-4072] Clean files command is not deleting .segment files for the segments added through alter table add segment

Karan980 commented on a change in pull request #4048: URL: https://github.com/apache/carbondata/pull/4048#discussion_r543092185 ## File path: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java ## @@ -597,6 +599,27 @@ public static String

[GitHub] [carbondata] Indhumathi27 commented on pull request #4042: [CARBONDATA-4069] [CARBONDATA-4068] handled set streaming and long string for SI table or table having SI.

Indhumathi27 commented on pull request #4042: URL: https://github.com/apache/carbondata/pull/4042#issuecomment-745069058 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] Karan980 commented on a change in pull request #4046: [CARBONDATA-4071] Fix wrong values of date or timestamp child columns on reading through SDK.

Karan980 commented on a change in pull request #4046: URL: https://github.com/apache/carbondata/pull/4046#discussion_r543064576 ## File path: sdk/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ## @@ -1741,6 +1742,246 @@ public boolean accept(File dir,

[GitHub] [carbondata] Karan980 commented on a change in pull request #4046: [CARBONDATA-4071] Fix wrong values of date or timestamp child columns on reading through SDK.

Karan980 commented on a change in pull request #4046: URL: https://github.com/apache/carbondata/pull/4046#discussion_r543064547 ## File path: sdk/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ## @@ -1741,6 +1742,246 @@ public boolean accept(File dir,

[GitHub] [carbondata] Karan980 commented on a change in pull request #4046: [CARBONDATA-4071] Fix wrong values of date or timestamp child columns on reading through SDK.

Karan980 commented on a change in pull request #4046: URL: https://github.com/apache/carbondata/pull/4046#discussion_r543064324 ## File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ## @@ -126,6 +127,47 @@ public T readNextRow() throws

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4047: [CARBONDATA-4078] Add external segment and query with index server fails

Indhumathi27 commented on a change in pull request #4047: URL: https://github.com/apache/carbondata/pull/4047#discussion_r543056033 ## File path: integration/spark/src/main/scala/org/apache/carbondata/indexserver/IndexJobs.scala ## @@ -47,6 +47,9 @@ class DistributedIndexJob

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #4047: [CARBONDATA-4078] Add external segment and query with index server fails

ShreelekhyaG commented on a change in pull request #4047: URL: https://github.com/apache/carbondata/pull/4047#discussion_r543052297 ## File path: integration/spark/src/main/scala/org/apache/carbondata/indexserver/IndexJobs.scala ## @@ -47,6 +47,9 @@ class DistributedIndexJob

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #4047: [CARBONDATA-4078] Add external segment and query with index server fails

ShreelekhyaG commented on a change in pull request #4047: URL: https://github.com/apache/carbondata/pull/4047#discussion_r543052039 ## File path: core/src/main/java/org/apache/carbondata/core/index/IndexUtil.java ## @@ -290,6 +291,9 @@ private static FileInputFormat

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4048: [CARBONDATA-4072] Clean files command is not deleting .segment files for the segments added through alter table add s

vikramahuja1001 commented on a change in pull request #4048: URL: https://github.com/apache/carbondata/pull/4048#discussion_r543050640 ## File path: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java ## @@ -597,6 +599,27 @@ public static String

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4032: [WIP][CARBONDATA-4065] Support MERGE INTO SQL Command

CarbonDataQA2 commented on pull request #4032: URL: https://github.com/apache/carbondata/pull/4032#issuecomment-745044946 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3399/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4032: [WIP][CARBONDATA-4065] Support MERGE INTO SQL Command

CarbonDataQA2 commented on pull request #4032: URL: https://github.com/apache/carbondata/pull/4032#issuecomment-745043164 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5161/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4047: [CARBONDATA-4078] Add external segment and query with index server fails

CarbonDataQA2 commented on pull request #4047: URL: https://github.com/apache/carbondata/pull/4047#issuecomment-744599007 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3398/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4047: [CARBONDATA-4078] Add external segment and query with index server fails

CarbonDataQA2 commented on pull request #4047: URL: https://github.com/apache/carbondata/pull/4047#issuecomment-744597792 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5160/

[GitHub] [carbondata] shenjiayu17 commented on pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

shenjiayu17 commented on pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#issuecomment-744532092 > Thanks for your contribution, please raise disucssion in communtiy and get the design approved >

[jira] [Updated] (CARBONDATA-4084) Error when loading string field with high cardinary

[ https://issues.apache.org/jira/browse/CARBONDATA-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nguyen Dinh Huynh updated CARBONDATA-4084: -- Description: When i am try load string field with more than 1M distinct

[jira] [Updated] (CARBONDATA-4084) Error when loading string field with high cardinary

[ https://issues.apache.org/jira/browse/CARBONDATA-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nguyen Dinh Huynh updated CARBONDATA-4084: -- Labels: patch (was: ) > Error when loading string field with high

[jira] [Updated] (CARBONDATA-4084) Error when loading string field with high cardinary

[ https://issues.apache.org/jira/browse/CARBONDATA-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nguyen Dinh Huynh updated CARBONDATA-4084: -- Description: When i am try load string field with more than 1M distinct

[jira] [Updated] (CARBONDATA-4084) Error when loading string field with high cardinary

[ https://issues.apache.org/jira/browse/CARBONDATA-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nguyen Dinh Huynh updated CARBONDATA-4084: -- Attachment: (was: image_2020_12_13T09_29_38_891Z.png) > Error when

[jira] [Updated] (CARBONDATA-4084) Error when loading string field with high cardinary

[ https://issues.apache.org/jira/browse/CARBONDATA-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nguyen Dinh Huynh updated CARBONDATA-4084: -- Attachment: image_2020_12_13T09_29_38_891Z.png > Error when loading

[jira] [Updated] (CARBONDATA-4084) Error when loading string field with high cardinary

[ https://issues.apache.org/jira/browse/CARBONDATA-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nguyen Dinh Huynh updated CARBONDATA-4084: -- Attachment: image_2020_12_13T09_29_38_891Z.png > Error when loading

[jira] [Updated] (CARBONDATA-4084) Error when loading string field with high cardinary

[ https://issues.apache.org/jira/browse/CARBONDATA-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nguyen Dinh Huynh updated CARBONDATA-4084: -- Description: When i am try load string field with more than 1M distinct

[jira] [Updated] (CARBONDATA-4084) Error when loading string field with high cardinary

[ https://issues.apache.org/jira/browse/CARBONDATA-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nguyen Dinh Huynh updated CARBONDATA-4084: -- Attachment: image-2020-12-14-22-40-45-539.png > Error when loading string

[jira] [Created] (CARBONDATA-4084) Error when loading string field with high cardinary

Nguyen Dinh Huynh created CARBONDATA-4084: - Summary: Error when loading string field with high cardinary Key: CARBONDATA-4084 URL: https://issues.apache.org/jira/browse/CARBONDATA-4084

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4004: [CARBONDATA-4083] Refactor Update and Support Update Atomicity

CarbonDataQA2 commented on pull request #4004: URL: https://github.com/apache/carbondata/pull/4004#issuecomment-744517819 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3397/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4004: [CARBONDATA-4083] Refactor Update and Support Update Atomicity

CarbonDataQA2 commented on pull request #4004: URL: https://github.com/apache/carbondata/pull/4004#issuecomment-744514092 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5159/

[GitHub] [carbondata] marchpure commented on pull request #4004: [CARBONDATA-4083] Refactor Update and Support Update Atomicity

marchpure commented on pull request #4004: URL: https://github.com/apache/carbondata/pull/4004#issuecomment-78763 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

CarbonDataQA2 commented on pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#issuecomment-744439091 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5158/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

CarbonDataQA2 commented on pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#issuecomment-744438607 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3396/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4037: [CARBONDATA-4070] [CARBONDATA-4059] Fixed SI issues and improved FT.

CarbonDataQA2 commented on pull request #4037: URL: https://github.com/apache/carbondata/pull/4037#issuecomment-744401392 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5157/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4042: [CARBONDATA-4069] [CARBONDATA-4068] handled set streaming and long string for SI table or table having SI.

CarbonDataQA2 commented on pull request #4042: URL: https://github.com/apache/carbondata/pull/4042#issuecomment-744401229 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3395/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4042: [CARBONDATA-4069] [CARBONDATA-4068] handled set streaming and long string for SI table or table having SI.

CarbonDataQA2 commented on pull request #4042: URL: https://github.com/apache/carbondata/pull/4042#issuecomment-744400866 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5156/

[GitHub] [carbondata] Indhumathi27 commented on pull request #4042: [CARBONDATA-4069] [CARBONDATA-4068] handled set streaming and long string for SI table or table having SI.

Indhumathi27 commented on pull request #4042: URL: https://github.com/apache/carbondata/pull/4042#issuecomment-744345338 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4037: [CARBONDATA-4070] [CARBONDATA-4059] Fixed SI issues and improved FT.

CarbonDataQA2 commented on pull request #4037: URL: https://github.com/apache/carbondata/pull/4037#issuecomment-744343158 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3394/

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4037: [CARBONDATA-4070] [CARBONDATA-4059] Fixed SI issues and improved FT.

Indhumathi27 commented on a change in pull request #4037: URL: https://github.com/apache/carbondata/pull/4037#discussion_r542272811 ## File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/mergedata/CarbonDataFileMergeTestCaseOnSI.scala ## @@

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4037: [CARBONDATA-4070] [CARBONDATA-4059] Fixed SI issues and improved FT.

Indhumathi27 commented on a change in pull request #4037: URL: https://github.com/apache/carbondata/pull/4037#discussion_r542265677 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/datacompaction/CarbonIndexFileMergeTestCase.scala ## @@

[GitHub] [carbondata] Indhumathi27 commented on pull request #4047: [CARBONDATA-4078] Add external segment and query with index server fails

Indhumathi27 commented on pull request #4047: URL: https://github.com/apache/carbondata/pull/4047#issuecomment-744319236 @ShreelekhyaG Check and handle in BroadCastSIFilterPushJoin This is an automated message from the

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4047: [CARBONDATA-4078] Add external segment and query with index server fails

Indhumathi27 commented on a change in pull request #4047: URL: https://github.com/apache/carbondata/pull/4047#discussion_r542244695 ## File path: integration/spark/src/main/scala/org/apache/carbondata/indexserver/IndexJobs.scala ## @@ -47,6 +47,9 @@ class DistributedIndexJob

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4046: [CARBONDATA-4071] Fix wrong values of date or timestamp child columns on reading through SDK.

Indhumathi27 commented on a change in pull request #4046: URL: https://github.com/apache/carbondata/pull/4046#discussion_r542237261 ## File path: sdk/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ## @@ -1741,6 +1742,246 @@ public boolean accept(File

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4046: [CARBONDATA-4071] Fix wrong values of date or timestamp child columns on reading through SDK.

Indhumathi27 commented on a change in pull request #4046: URL: https://github.com/apache/carbondata/pull/4046#discussion_r542237004 ## File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ## @@ -126,6 +127,47 @@ public T readNextRow() throws

[GitHub] [carbondata] Zhangshunyu commented on a change in pull request #4032: [WIP][CARBONDATA-4065] Support MERGE INTO SQL Command

Zhangshunyu commented on a change in pull request #4032: URL: https://github.com/apache/carbondata/pull/4032#discussion_r542212249 ## File path: integration/spark/src/main/antlr4/org/apache/spark/sql/parser/CarbonSqlBase.g4 ## @@ -0,0 +1,1842 @@ +/* + * Licensed under the

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4031: [CARBONDATA-4073] Added FT for missing scenarios in Presto

ajantha-bhat commented on a change in pull request #4031: URL: https://github.com/apache/carbondata/pull/4031#discussion_r542205758 ## File path: integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestUsingSparkStore.scala ## @@ -0,0 +1,328

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4031: [CARBONDATA-4073] Added FT for missing scenarios in Presto

ajantha-bhat commented on a change in pull request #4031: URL: https://github.com/apache/carbondata/pull/4031#discussion_r542203408 ## File path: integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestUsingSparkStore.scala ## @@ -0,0 +1,328

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4031: [CARBONDATA-4073] Added FT for missing scenarios in Presto

ajantha-bhat commented on a change in pull request #4031: URL: https://github.com/apache/carbondata/pull/4031#discussion_r542203236 ## File path: integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestUsingSparkStore.scala ## @@ -0,0 +1,328

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4031: [CARBONDATA-4073] Added FT for missing scenarios in Presto

ajantha-bhat commented on a change in pull request #4031: URL: https://github.com/apache/carbondata/pull/4031#discussion_r542201944 ## File path: integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestUsingSparkStore.scala ## @@ -0,0 +1,328

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4048: [CARBONDATA-4072] Clean files command is not deleting .segment files for the segments added through alter table add segment query.

CarbonDataQA2 commented on pull request #4048: URL: https://github.com/apache/carbondata/pull/4048#issuecomment-744275496 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3393/

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4031: [CARBONDATA-4073] Added FT for missing scenarios in Presto

ajantha-bhat commented on a change in pull request #4031: URL: https://github.com/apache/carbondata/pull/4031#discussion_r542199179 ## File path: integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType/SparkStoreCreatorForPresto.scala ##

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4032: [WIP][CARBONDATA-4065] Support MERGE INTO SQL Command

ajantha-bhat commented on a change in pull request #4032: URL: https://github.com/apache/carbondata/pull/4032#discussion_r542197802 ## File path: integration/spark/src/main/antlr4/org/apache/spark/sql/parser/CarbonSqlBase.g4 ## @@ -0,0 +1,1842 @@ +/* + * Licensed under the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4048: [CARBONDATA-4072] Clean files command is not deleting .segment files for the segments added through alter table add segment query.

CarbonDataQA2 commented on pull request #4048: URL: https://github.com/apache/carbondata/pull/4048#issuecomment-744271698 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5155/