Karan980 commented on a change in pull request #4048:
URL: https://github.com/apache/carbondata/pull/4048#discussion_r543092185
##########
File path:
core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java
##########
@@ -597,6 +599,27 @@ public static String getSegmentIdFromPath(String
dataFileAbsolutePath) {
}
}
+ /**
Review comment:
If i write this logic of getting segmentFileName from segmentFile
absolute path in test code, then i have to repeat the same code in both the
testCases as i need segmentFileName in both testCases. Its better to write a
method for it and call it to avoid repetition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
