Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2259
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2175#discussion_r186616874
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/PartitionWithPreAggregateTestCase.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2175#discussion_r186616811
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/PartitionWithPreAggregateTestCase.scala
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2278
[CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450] [CARBONDATA-2453]
Fixed issues related to complex types
Be sure to do all of the following checklist to help us incorporate
your
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2175
@praveenmeenakshi56 Please write proper description
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2175
retest sdv please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2258
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2261#discussion_r186056900
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -416,16 +411,58 @@ private CarbonTable
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2261#discussion_r186056119
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -604,31 +604,58 @@ abstract class
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2261#discussion_r186055914
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2261#discussion_r186055265
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2261#discussion_r186055186
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2261#discussion_r186055072
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/DataFrameComplexTypeExample.scala
---
@@ -56,6 +72,38 @@ object
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2261#discussion_r186053512
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java
---
@@ -135,25 +157,41 @@ public ColumnSchema
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2266#discussion_r186028497
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType/TestComplexTypeQuery.scala
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2259
@praveenmeenakshi56 Please fix the build
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2266
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2249
Please add description
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2175
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2195
@kumarvishal09 build passed. Please review
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2223
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2172
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2172
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2195
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2172
retest this please
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2172#discussion_r183012262
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -73,18 +74,9
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2166
LGTM
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2195
[CARBONDATA-2366] fixed concurrent datamap creation issue
Problem1: CarbonTable is not getting refreshed while creation due to which
all datamaps are getting wrong carbonTable object. Due
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2147#discussion_r182648283
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggCreateCommand.scala
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2183
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2166
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2160
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2172
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2166
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2166#discussion_r181731645
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/PreAggregateTestCase.scala
---
@@ -209,6
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2160
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2172
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2172
retest this please
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2172
[CARBONDATA-2333] Block insert overwrite if all partition columns are not
present in anâ¦
â¦y one of the datamaps
Be sure to do all of the following checklist to help us
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2160
retest this please
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2160
[CARBONDATA-2335] Fix auto handoff for preaggregate table with streaming
Solution: MetaListener was not called for auto handoff case therefore child
load commands were not being created thus
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2065
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2065#discussion_r179413870
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/SetParameterTestCase.scala
---
@@ -0,0
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2065#discussion_r179413817
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/SetParameterTestCase.scala
---
@@ -0,0
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2137
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2109
retest sdv please
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178801883
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/partition/CarbonAlterTableDropHivePartitionCommand.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178801803
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
---
@@ -39,6 +41,212
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178801930
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggregateCompaction.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178801858
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/partition/CarbonAlterTableDropHivePartitionCommand.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178801779
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
---
@@ -39,6 +41,212
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178801747
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
---
@@ -39,6 +41,212
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178801685
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -62,8 +63,25
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178801725
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
---
@@ -39,6 +41,212
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178795973
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2109
retest this please
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178264753
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178264718
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -59,8 +60,22
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178239696
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -59,8 +60,22
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178239706
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -59,8 +60,22
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178238607
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/AggregateDataMapCompactor.scala
---
@@ -47,7 +47,15 @@ class
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178237981
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -149,7 +143,16
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178237773
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/partition/CarbonAlterTableDropHivePartitionCommand.scala
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1857
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1857#discussion_r178037845
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggregateLoad.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1857#discussion_r178037427
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggregateIUDSuite.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1857#discussion_r178036919
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggregateIUDSuite.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1857#discussion_r178033753
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggCreateCommand.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1857#discussion_r178033617
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggCreateCommand.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1857#discussion_r178033489
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggCreateCommand.scala
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2084
@ravipesala @manishgupta88 Build passed
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2084
retest sdv please
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2084#discussion_r177729512
--- Diff:
integration/spark2/src/test/scala/org/apache/spark/carbondata/TestStreamingTableOperation.scala
---
@@ -249,6 +251,195 @@ class
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2084#discussion_r177707665
--- Diff:
integration/spark2/src/test/scala/org/apache/spark/carbondata/TestStreamingTableOperation.scala
---
@@ -173,9 +175,9 @@ class
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2084#discussion_r177706270
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonCreateDataMapCommand.scala
---
@@ -49,10 +49,6
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2084#discussion_r177706257
--- Diff:
core/src/main/java/org/apache/carbondata/events/OperationContext.java ---
@@ -41,4 +41,12 @@ public void setProperty(String key, Object
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2109
[WIP] Partition preaggregate support
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2065
can you add a test scenario where the same property is added to set command
and load command and the load command should have higher priority!!
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2084#discussion_r176649884
--- Diff:
streaming/src/main/scala/org/apache/carbondata/streaming/StreamHandoffRDD.scala
---
@@ -299,8 +302,8 @@ object StreamHandoffRDD
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1981
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2082
LGTM
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2084
[WIP][CARBONDATA-1522] Support preaggregate table creation and loading on
streaming tables
1. Added support to create preaggregate datamap on streaming table.
2. Added support to load
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2079
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1981
Please remove the test cases which are already covered in Functional
tests(eg. Negative scenarios, compaction).
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1981#discussion_r175446224
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/PreAggregateTestCase.scala
---
@@ -0,0
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2042
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1981#discussion_r174716702
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/PreAggregateTestCase.scala
---
@@ -0,0
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1856#discussion_r174406656
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/timeseries/TestTimeSeriesCreateTable.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1856#discussion_r174406193
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/timeseries/TestTimeSeriesUnsupportedSuite.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1856#discussion_r174404853
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/timeseries/TestTimeSeriesCreateTable.scala
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2033
@ravipesala Please review
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1856#discussion_r174066548
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/sortcolumns/TestSortColumns.scala
---
@@ -33,16 +33,15
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1856#discussion_r174066445
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/timeseries/TestTimeseriesTableSelection.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1856#discussion_r174064855
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/timeseries/TestTimeseriesTableSelection.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1856#discussion_r174063930
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/timeseries/TestTimeSeriesUnsupportedSuite.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1856#discussion_r174060918
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/timeseries/TestTimeSeriesMatchStrategySuite.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1856#discussion_r174060602
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/timeseries/TestTimeSeriesDropSuite.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1856#discussion_r174060559
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/timeseries/TestTimeSeriesCreateTable.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1856#discussion_r174059512
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/timeseries/TestTimeSeriesCreateTable.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1856#discussion_r174058262
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/timeseries/TestTimeSeriesCreateTable.scala
401 - 500 of 728 matches
Mail list logo
