Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1856#discussion_r174058314
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/timeseries/TestTimeSeriesCreateTable.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1856#discussion_r174056762
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/timeseries/TestTimeSeriesCreateTable.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2042#discussion_r173369924
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/StandardPartitionTestCase.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2042#discussion_r173369580
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/StandardPartitionTestCase.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2042#discussion_r173369404
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/StandardPartitionTestCase.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2042#discussion_r173369982
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/StandardPartitionTestCase.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2042#discussion_r173367821
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/StandardPartitionTestCase.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2042#discussion_r173367335
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/StandardPartitionTestCase.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2042#discussion_r173373691
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/StandardPartitionTestCase.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2042#discussion_r173367883
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/StandardPartitionTestCase.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2042#discussion_r173369434
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/StandardPartitionTestCase.scala
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2033
retest this please
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2033
[CARBONDATA-2227] Added support to show partition details in describe
formatted
Added Detailed information in describe formatted command like **partition
location** and **partition values
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2017
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1975
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1975
retest this please
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1975#discussion_r170174790
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala
---
@@ -445,11 +443,11
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1980#discussion_r168687633
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonShowTablesCommand.scala
---
@@ -44,39 +44,15
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1980#discussion_r168687592
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonShowTablesCommand.scala
---
@@ -44,39 +44,15
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1980#discussion_r168687437
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonShowTablesCommand.scala
---
@@ -44,39 +44,15
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1981
retest sdv please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1975
@ravipesala please review
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1975
[CARBONDATA-2142] [CARBONDATA-1763] Fixed issues while creation concurrent
datamaps
Be sure to do all of the following checklist to help us incorporate
your contribution quickly
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1957
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1951
@ravipesala done
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1951
retest sdv please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1951
@ravipesala Build success
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1951
[CARBONDATA-1763] Dropped table if exception thrown while creation
Preaggregate table is not getting dropped when creation fails because
1. Exceptions from undo metadata is not handled
Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/1946
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1946
[WIP] Refresh fix
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1914
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1915
retest please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1910
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1910
@geetikagupta16 can you write the existing problem with the code and the
fix that you have done in the description.
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1911
[CARBONDATA-2119] Fixed deserialization issues for carbonLoadModel
**Problem:**
Load model was not getting de-serialized in the executor due to which 2
different carbon table objects were
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1894
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1861
LGTM
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1861#discussion_r165272350
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonCreateDataMapCommand.scala
---
@@ -49,10 +52,22
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1861#discussion_r165271557
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/timeseries/TestTimeSeriesCreateTable.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1861#discussion_r165271343
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggregateLoad.scala
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1861#discussion_r165270563
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/timeseries/TestTimeSeriesCreateTable.scala
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1781
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1850
retest this please
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1844#discussion_r163459153
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
---
@@ -700,11 +708,28 @@ public static Boolean
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1844#discussion_r163459325
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
---
@@ -700,11 +708,28 @@ public static Boolean
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1850
[CARBONDATA-2069] Restrict create datamap when load is in progress
**Problem:**
1. Load data into maintable
2. create datamap parallelly
preaggregate table will not have
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1821
retest sdv please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1821
@jackylk handled all the review comments.
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1821#discussion_r162052102
--- Diff:
core/src/main/java/org/apache/carbondata/events/OperationListenerBus.java ---
@@ -57,9 +57,9 @@ public OperationListenerBus addListener
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1821
[WIP]refactored code to support external session state impl
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1781
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1803
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1807
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1781
retest this please
---
Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/1802
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1802
[WIP] test
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1724
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1781
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1724
@geetikagupta16 can you squash the commits.
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1781
[CARBONDATA-2012] Add support to load pre-aggregate in one transaction
Change the pre-aggregate load process to support load as one transaction
for the parent and child tables
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1758
[CARBONDATA-1978] Handled preaggregate issues with hive metastore
During creation of TableInfo from hivemetastore the DataMapSchemas and the
columns DataTypes are not converted
Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/1746
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1747
[Compatibility] Added changes for backward compatibility
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1746
retest this please
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1746
[TEST] Enable pre-aggregate tests as CI issue is fixed
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1722#discussion_r158901669
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/iud/TestInsertUpdateConcurrentTest.scala
---
@@ -0,0
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1725
LGTM
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1703
retest this please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1712
retest this please
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1710
[CARBONDATA-1930] Added condition to refer to parent dictionary if filter
is given in aggregate table query
**Analysis:** When filter is applied to aggregate query then the query
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1708
[CARBONDATA-1928] Seperate the properties for timeout and retries for load
flow
**Analysis:** Currently the property that is used to configure the lock
retry count and the interval between
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1692
retest this please
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1697#discussion_r158041809
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
---
@@ -38,7 +40,10
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1692
[CARBONDATA-1777] Added check to update relation if catalog relation is
present in plan
**Analysis:** In spark 2.2 while doing lookup relation there was no case to
handle CatalogRelation due
Github user kunal642 closed the pull request at:
https://github.com/apache/carbondata/pull/1597
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1521
@ravipesala Please review
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r156946110
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataload
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1651#discussion_r156611792
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala
---
@@ -514,9 +514,16
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1639
retest sdv please
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1646
[CARBONDATA-1886] Delete stale segment folders on new load
**Analysis**: segment folders are not getting deleted if corresponding
entry is not available in table status file.
**Solution
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1622#discussion_r156304089
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -160,7 +160,7
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1601
We will not validate the create tbl properties as the user can define his
own properties as well.
Please close this
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1639
Retest this please
---
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1639
[CARBONDATA-1881] Insert overwrite value for pre-aggregate load was
incorrect
Analysis: while loading the value for insert overwrite was set to false.
Solution: Consider the value
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1601#discussion_r155719835
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/V3offheapvectorTestCase.scala
---
@@ -35,7
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1601#discussion_r155713651
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/V3offheapvectorTestCase.scala
---
@@ -35,7
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1601#discussion_r155713494
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
---
@@ -190,7 +191,7 @@ class
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1601#discussion_r155712770
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
---
@@ -232,6 +233,30 @@ class
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1622
retest sdv please
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1605
Retest this please
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1605#discussion_r155444843
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/Compactor.scala
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1605#discussion_r155441909
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonTableCompactor.scala
---
@@ -0,0 +1,129 @@
+/*
+ * Licensed
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1613
retest this please
---
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1613#discussion_r155155362
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala
---
@@ -493,4 +495,49
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1605#discussion_r154990944
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala
---
@@ -493,4 +493,20
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1605#discussion_r154990350
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModel.java
---
@@ -172,6 +173,16 @@
private
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1605#discussion_r154986219
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModel.java
---
@@ -172,6 +173,16 @@
private
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1605#discussion_r154984035
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
---
@@ -78,6 +89,57
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1605#discussion_r154983970
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
---
@@ -78,6 +89,57
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1605#discussion_r154983698
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -130,6 +131,9
501 - 600 of 728 matches
Mail list logo
