[GitHub] carbondata pull request #3064: [CARBONDATA-3243] Updated DOC for No-Sort Com...

2019-01-11 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3064#discussion_r247096965 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -1201,6 +1202,17 @@ abstract class

[GitHub] carbondata pull request #3070: [CARBONDATA-3246]Fix sdk reader issue if batc...

2019-01-11 Thread shardul-cr7
GitHub user shardul-cr7 opened a pull request: https://github.com/apache/carbondata/pull/3070 [CARBONDATA-3246]Fix sdk reader issue if batch size is given as zero and vectorRead False. This PR is to fix sdk reader issue when batch size is given as zero and vectorRead False

[GitHub] carbondata pull request #3045: [CARBONDATA-3222]Fix dataload failure after c...

2019-01-07 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3045#discussion_r245585973 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala --- @@ -110,22

[GitHub] carbondata issue #3045: [CARBONDATA-3222]Fix dataload failure after creation...

2019-01-06 Thread shardul-cr7
Github user shardul-cr7 commented on the issue: https://github.com/apache/carbondata/pull/3045 retest this please ---

[GitHub] carbondata pull request #3045: [CARBONDATA-3222]Fix dataload failure after c...

2019-01-06 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3045#discussion_r245516216 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala --- @@ -110,7

[GitHub] carbondata pull request #3045: [CARBONDATA-3222]Fix dataload failure after c...

2019-01-06 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3045#discussion_r245516158 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala --- @@ -110,7

[GitHub] carbondata pull request #3045: [CARBONDATA-3222]Fix dataload failure after c...

2019-01-05 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3045#discussion_r245475409 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala --- @@ -110,22

[GitHub] carbondata pull request #3045: [CARBONDATA-3222]Fix dataload failure after c...

2019-01-05 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3045#discussion_r245475435 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala --- @@ -110,22

[GitHub] carbondata pull request #3045: [CARBONDATA-3222]Fix dataload failure after c...

2019-01-05 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3045#discussion_r245475427 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala --- @@ -110,22

[GitHub] carbondata pull request #3045: [CARBONDATA-3222]Fix dataload failure after c...

2019-01-03 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3045#discussion_r244992105 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala --- @@ -126,6

[GitHub] carbondata pull request #3045: [CARBONDATA-3222]Fix dataload failure after c...

2019-01-03 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3045#discussion_r244992035 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/longstring/VarcharDataTypesBasicTestCase.scala

[GitHub] carbondata pull request #3045: [CARBONDATA-3222]Fix dataload failure after c...

2019-01-02 Thread shardul-cr7
GitHub user shardul-cr7 opened a pull request: https://github.com/apache/carbondata/pull/3045 [CARBONDATA-3222]Fix dataload failure after creation of preaggregate datamap on main table with long_string_columns This PR is to Fix dataload failure after creation of preaggregate

[GitHub] carbondata issue #3020: [CARBONDATA-3195]Added validation for Inverted Index...

2018-12-26 Thread shardul-cr7
Github user shardul-cr7 commented on the issue: https://github.com/apache/carbondata/pull/3020 > I think you need describe this validation in the ddl-of-carbondata.md of Inverted Index Configuration part Done! ---

[GitHub] carbondata pull request #3020: [CARBONDATA-3195]Added validation for Inverte...

2018-12-23 Thread shardul-cr7
GitHub user shardul-cr7 opened a pull request: https://github.com/apache/carbondata/pull/3020 [CARBONDATA-3195]Added validation for Inverted INdex columns and added a test case in case of varchar Be sure to do all of the following checklist to help us incorporate

[GitHub] carbondata pull request #2986: [CARBONDATA-3166]Updated Document and added C...

2018-12-13 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2986#discussion_r241376148 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDescribeFormattedCommand.scala --- @@ -92,7 +92,9

[GitHub] carbondata pull request #2986: [CARBONDATA-3166]Updated Document and added C...

2018-12-13 Thread shardul-cr7
GitHub user shardul-cr7 opened a pull request: https://github.com/apache/carbondata/pull/2986 [CARBONDATA-3166]Updated Document and added Column Compressor used in Describe Forma… …tted Command Be sure to do all of the following checklist to help us incorporate

[GitHub] carbondata pull request #2847: [CARBONDATA-3005]Support Gzip as column compr...

2018-12-10 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2847#discussion_r240247558 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataWithCompression.scala

[GitHub] carbondata pull request #2847: [CARBONDATA-3005]Support Gzip as column compr...

2018-12-10 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2847#discussion_r240236819 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java --- @@ -0,0 +1,201 @@ +/* + * Licensed

[GitHub] carbondata pull request #2847: [CARBONDATA-3005]Support Gzip as column compr...

2018-12-10 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2847#discussion_r240236269 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java --- @@ -0,0 +1,201 @@ +/* + * Licensed

[GitHub] carbondata pull request #2847: [CARBONDATA-3005]Support Gzip as column compr...

2018-12-10 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2847#discussion_r240236381 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java --- @@ -0,0 +1,201 @@ +/* + * Licensed

[GitHub] carbondata pull request #2847: [CARBONDATA-3005]Support Gzip as column compr...

2018-12-10 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2847#discussion_r240236462 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java --- @@ -0,0 +1,201 @@ +/* + * Licensed

[GitHub] carbondata pull request #2847: [CARBONDATA-3005]Support Gzip as column compr...

2018-12-10 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2847#discussion_r240227006 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java --- @@ -0,0 +1,132 @@ +/* + * Licensed

[GitHub] carbondata pull request #2847: [CARBONDATA-3005]Support Gzip as column compr...

2018-12-10 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2847#discussion_r240157144 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java --- @@ -0,0 +1,132 @@ +/* + * Licensed

[GitHub] carbondata pull request #2847: [CARBONDATA-3005]Support Gzip as column compr...

2018-12-10 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2847#discussion_r240135884 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/CompressorFactory.java --- @@ -35,8 +35,8 @@ private final

[GitHub] carbondata pull request #2847: [CARBONDATA-3005]Support Gzip as column compr...

2018-12-10 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2847#discussion_r240130514 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java --- @@ -0,0 +1,138 @@ +/* + * Licensed

[GitHub] carbondata pull request #2847: [CARBONDATA-3005]Support Gzip as column compr...

2018-12-10 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2847#discussion_r240130469 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java --- @@ -0,0 +1,138 @@ +/* + * Licensed

[GitHub] carbondata pull request #2847: [CARBONDATA-3005]Support Gzip as column compr...

2018-12-10 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2847#discussion_r240130373 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java --- @@ -0,0 +1,138 @@ +/* + * Licensed

[GitHub] carbondata pull request #2847: [CARBONDATA-3005]Support Gzip as column compr...

2018-12-09 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2847#discussion_r240102212 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataWithCompression.scala

[GitHub] carbondata pull request #2847: [WIP]Support Gzip as column compressor

2018-12-05 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2847#discussion_r238971669 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java --- @@ -0,0 +1,203 @@ +/* + * Licensed

[GitHub] carbondata pull request #2847: [WIP]Support Gzip as column compressor

2018-12-05 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2847#discussion_r238971644 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java --- @@ -0,0 +1,203 @@ +/* + * Licensed

[GitHub] carbondata pull request #2948: [CARBONDATA-3124] Updated log message in Unsa...

2018-11-28 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2948#discussion_r237000628 --- Diff: docs/faq.md --- @@ -216,20 +216,18 @@ TimeZone.setDefault(TimeZone.getTimeZone("Asia/Shanghai")) ## How to check LRU ca

[GitHub] carbondata pull request #2948: [CARBONDATA-3124] Updated log message in Unsa...

2018-11-28 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2948#discussion_r236998844 --- Diff: docs/faq.md --- @@ -216,20 +216,18 @@ TimeZone.setDefault(TimeZone.getTimeZone("Asia/Shanghai")) ## How to check LRU ca

[GitHub] carbondata pull request #2948: [CARBONDATA-3124] Updated log message in Unsa...

2018-11-23 Thread shardul-cr7
GitHub user shardul-cr7 opened a pull request: https://github.com/apache/carbondata/pull/2948 [CARBONDATA-3124] Updated log message in UnsafeMemoryManager Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily

[GitHub] carbondata issue #2850: [CARBONDATA-3056] Added concurrent reading through S...

2018-10-31 Thread shardul-cr7
Github user shardul-cr7 commented on the issue: https://github.com/apache/carbondata/pull/2850 retest this please ---

[GitHub] carbondata pull request #2847: [WIP]Support Gzip as column compressor

2018-10-24 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2847#discussion_r227658900 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java --- @@ -0,0 +1,201 @@ +/* + * Licensed

[GitHub] carbondata pull request #2847: [WIP]Support Gzip as column compressor

2018-10-24 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2847#discussion_r227658842 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/GzipCompressor.java --- @@ -0,0 +1,201 @@ +/* + * Licensed

[GitHub] carbondata pull request #2847: [WIP]Support Gzip as column compressor

2018-10-23 Thread shardul-cr7
GitHub user shardul-cr7 opened a pull request: https://github.com/apache/carbondata/pull/2847 [WIP]Support Gzip as column compressor Gzip compressed file size is less than that of snappy but takes more time. Data generated by tpch-dbgen(lineitem) **Load Performance

[GitHub] carbondata issue #2758: [CARBONDATA-2972] Debug Logs and function added for ...

2018-09-26 Thread shardul-cr7
Github user shardul-cr7 commented on the issue: https://github.com/apache/carbondata/pull/2758 retest this please ---

[GitHub] carbondata issue #2760: [CARBONDATA-2968] Single pass load fails 2nd time in...

2018-09-25 Thread shardul-cr7
Github user shardul-cr7 commented on the issue: https://github.com/apache/carbondata/pull/2760 retest this please ---

[GitHub] carbondata pull request #2760: [CARBONDATA-2968] Single pass load fails 2nd ...

2018-09-25 Thread shardul-cr7
GitHub user shardul-cr7 opened a pull request: https://github.com/apache/carbondata/pull/2760 [CARBONDATA-2968] Single pass load fails 2nd time in Spark submit execution due to port binding error. Problem : In secure cluster setup, single pass load is failing in spark-submit after

[GitHub] carbondata issue #2747: [CARBONDATA-2960] SDK Reader fix with projection col...

2018-09-24 Thread shardul-cr7
Github user shardul-cr7 commented on the issue: https://github.com/apache/carbondata/pull/2747 retest this please ---

[GitHub] carbondata pull request #2739: [CARBONDATA-2954]Fix error when create extern...

2018-09-24 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2739#discussion_r219739583 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java --- @@ -2226,7 +2226,11 @@ public static String

[GitHub] carbondata issue #2739: [CARBONDATA-2954]Fix error when create external tabl...

2018-09-20 Thread shardul-cr7
Github user shardul-cr7 commented on the issue: https://github.com/apache/carbondata/pull/2739 retest this please ---

[GitHub] carbondata issue #2739: [CARBONDATA-2954]Fix error when create external tabl...

2018-09-20 Thread shardul-cr7
Github user shardul-cr7 commented on the issue: https://github.com/apache/carbondata/pull/2739 retest this please ---

[GitHub] carbondata pull request #2739: [CARBONDATA-2954]Fix error when create extern...

2018-09-20 Thread shardul-cr7
GitHub user shardul-cr7 opened a pull request: https://github.com/apache/carbondata/pull/2739 [CARBONDATA-2954]Fix error when create external table command fired if path already exists Problem : Creating a external table and providing a valid location having some empty directory

[GitHub] carbondata pull request #2714: [CARBONDATA-2875]Two different threads overwr...

2018-09-12 Thread shardul-cr7
GitHub user shardul-cr7 opened a pull request: https://github.com/apache/carbondata/pull/2714 [CARBONDATA-2875]Two different threads overwriting the same carbondatafile. Problem :- During concurrent load through two different threads in a external table for non transactional tables

[GitHub] carbondata pull request #2710: [2875]two different threads overwriting the s...

2018-09-11 Thread shardul-cr7
Github user shardul-cr7 closed the pull request at: https://github.com/apache/carbondata/pull/2710 ---

[GitHub] carbondata pull request #2710: [2875]two different threads overwriting the s...

2018-09-11 Thread shardul-cr7
GitHub user shardul-cr7 opened a pull request: https://github.com/apache/carbondata/pull/2710 [2875]two different threads overwriting the same carbondatafile Problem : Two different threads are overwriting the same carbondata file during creation of external table