Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1362
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143891060
--- Diff:
integration/spark2/src/test/scala/org/apache/carbondata/spark/testsuite/booleantype/BooleanDataTypesLoadTest.scala
---
@@ -0,0 +1,655 @@
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143890886
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java
---
@@ -187,6 +188,12 @@ private void
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143890910
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -361,6 +360,10 @@ public void putData(int rowId, Object
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143890846
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/bool/BooleanConvert.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143890823
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecuterImpl.java
---
@@ -215,7 +215,7 @@ private void
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143890833
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/bool/BooleanConvert.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143890779
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodingFactory.java
---
@@ -38,11 +38,7 @@
import
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143890810
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecuterImpl.java
---
@@ -203,7 +203,7 @@ private void
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143890703
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodingFactory.java
---
@@ -38,11 +38,7 @@
import
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143890685
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -530,6 +546,11 @@ private void putNull(int rowId) {
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143890419
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -485,6 +496,11 @@ private void putNull(int rowId) {
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143890454
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -321,6 +315,11 @@ private static ColumnPage
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143890406
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -321,6 +315,11 @@ private static ColumnPage
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143890387
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -436,6 +439,11 @@ public void putData(int rowId, Object
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143890342
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/bool/BooleanEncoderMeta.java
---
@@ -0,0 +1,40 @@
+package
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143890311
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -271,6 +267,18 @@ private static ColumnPage
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143890228
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -187,6 +179,7 @@ public static ColumnPage
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143890183
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/bool/BooleanConvert.java
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143890027
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodingFactory.java
---
@@ -92,6 +90,10 @@ public ColumnPageDecoder
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143617246
--- Diff:
integration/spark2/src/test/scala/org/apache/carbondata/spark/testsuite/booleantype/BooleanDataTypesLoadTest.scala
---
@@ -0,0 +1,655 @@
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143616906
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java
---
@@ -187,6 +188,12 @@ private void
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143616554
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/bool/BooleanConvert.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143616465
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/bool/BooleanConvert.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143615585
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecuterImpl.java
---
@@ -203,7 +203,7 @@ private void
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143615593
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecuterImpl.java
---
@@ -215,7 +215,7 @@ private void
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143615434
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodingFactory.java
---
@@ -38,11 +38,7 @@
import
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143615152
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -485,6 +496,11 @@ private void putNull(int rowId) {
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143615171
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -530,6 +546,11 @@ private void putNull(int rowId) {
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143614968
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -436,6 +439,11 @@ public void putData(int rowId, Object
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r143614990
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -321,6 +315,11 @@ private static ColumnPage
31 matches
Mail list logo
