Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2059
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2059#discussion_r174364855
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/NewRowComparatorForNormalDims.java
---
@@ -16,13 +16,16 @@
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2059#discussion_r174193598
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/NewRowComparatorForNormalDims.java
---
@@ -16,13 +16,16 @@
*/
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2059
[CARBONDATA-2250][DataLoad] Reduce massive object generation in global sort
Generate compatator outside the function, otherwise it will be generated
for every row
Be sure to do
