[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2180 ---

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-26 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r184358059 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala --- @@ -536,6 +536,13 @@

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-26 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r184357724 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala --- @@ -536,6 +536,13 @@

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-26 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r184357465 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala --- @@ -141,7 +141,9 @@ object CarbonFilters {

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-26 Thread Indhumathi27
Github user Indhumathi27 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r184353464 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/expression/ColumnExpression.java --- @@ -132,5 +132,8 @@ public void

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r184322994 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/expression/ColumnExpression.java --- @@ -132,5 +132,8 @@ public void

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-25 Thread Indhumathi27
Github user Indhumathi27 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r184057789 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java --- @@ -182,7 +182,7 @@ private String

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-23 Thread Indhumathi27
Github user Indhumathi27 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r183458964 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java --- @@ -182,7 +182,7 @@ private String

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-21 Thread Indhumathi27
Github user Indhumathi27 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r183212273 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java --- @@ -157,6 +162,14 @@ private String

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-21 Thread Indhumathi27
Github user Indhumathi27 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r183212203 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java --- @@ -157,6 +162,14 @@ private String

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-21 Thread Indhumathi27
Github user Indhumathi27 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r183212201 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java --- @@ -85,6 +85,11 @@

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-21 Thread Indhumathi27
Github user Indhumathi27 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r183212178 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMapSuite.scala --- @@ -197,13

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r183211461 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java --- @@ -157,6 +162,14 @@ private String

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r183211383 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java --- @@ -157,6 +162,14 @@ private String

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r183211362 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java --- @@ -157,6 +162,14 @@ private String

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r183211315 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java --- @@ -85,6 +85,11 @@ this.analyzer

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r183211288 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java --- @@ -157,6 +162,14 @@ private String

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r183211277 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java --- @@ -85,6 +85,11 @@ this.analyzer

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r183211234 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMapSuite.scala --- @@ -197,13 +197,353

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-21 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r183211232 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMapSuite.scala --- @@ -197,13 +197,353

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-21 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r183205830 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java --- @@ -182,7 +182,7 @@ private String

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-20 Thread Indhumathi27
Github user Indhumathi27 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r183140729 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java --- @@ -182,7 +182,7 @@ private String

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-20 Thread Indhumathi27
Github user Indhumathi27 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r183140665 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMapSuite.scala --- @@ -197,13

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-20 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r183083696 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMapSuite.scala --- @@ -197,13 +197,334

[GitHub] carbondata pull request #2180: [CARBONDATA-2356] Added UT Scenarios for Luce...

2018-04-20 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2180#discussion_r183083335 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java --- @@ -182,7 +182,7 @@ private String