Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2875
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230991320
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1744,89 +2021,101 @@ private
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230629905
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -975,16 +1140,39 @@ private
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230629760
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -117,77 +126,106 @@ private
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230629803
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -897,7 +1041,8 @@ private CarbonCommonConstants()
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230629792
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -435,53 +520,77 @@ private CarbonCommonConstants()
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230629800
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -594,6 +713,7 @@ private CarbonCommonConstants() {
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230629669
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -117,77 +126,106 @@ private
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230629658
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -117,77 +126,106 @@ private
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230629266
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/path/HDFSLeaseUtils.java ---
@@ -164,22 +157,25 @@ private static boolean
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230626185
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -722,17 +723,19 @@ private void loadProperties() {
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230626228
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -722,17 +723,19 @@ private void loadProperties() {
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230618777
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1744,89 +2021,101 @@ private
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230618624
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -975,16 +1140,39 @@ private
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230618503
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -897,7 +1041,8 @@ private CarbonCommonConstants()
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230618427
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -594,6 +713,7 @@ private CarbonCommonConstants() {
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230618398
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -435,53 +520,77 @@ private CarbonCommonConstants()
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230618379
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -435,53 +520,77 @@ private CarbonCommonConstants()
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230617961
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -117,77 +126,106 @@ private
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230617938
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -117,77 +126,106 @@ private
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230617917
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -117,77 +126,106 @@ private
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230616881
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/path/HDFSLeaseUtils.java ---
@@ -164,22 +157,25 @@ private static boolean
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230616699
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -722,17 +723,19 @@ private void loadProperties() {
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230616611
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -722,17 +723,19 @@ private void loadProperties() {
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2875
[CARBONDATA-3038] Refactor dynamic configuration
1.remove CarbonProperty annotation, and DynamicConfigurable,
NonDynamicConfigurable, DefaultValue,Threshold and so on
2.unify default value
25 matches
Mail list logo
