[GitHub] carbondata pull request #2914: [WIP][CARBONDATA-3093] Provide property build...

2018-11-12 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2914#discussion_r232632794 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1237,10 +1238,12 @@ private

[GitHub] carbondata pull request #2914: [WIP][CARBONDATA-3093] Provide property build...

2018-11-12 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2914#discussion_r232632711 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1237,10 +1238,12 @@ private

[GitHub] carbondata pull request #2914: [WIP][CARBONDATA-3093] Provide property build...

2018-11-12 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2914#discussion_r232632618 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1237,10 +1238,12 @@ private

[GitHub] carbondata pull request #2914: [WIP][CARBONDATA-3093] Provide property build...

2018-11-12 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2914#discussion_r232629531 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1237,10 +1238,12 @@ private

[GitHub] carbondata pull request #2914: [WIP][CARBONDATA-3093] Provide property build...

2018-11-12 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2914#discussion_r232628480 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1237,10 +1238,12 @@ private

[GitHub] carbondata pull request #2914: [WIP][CARBONDATA-3093] Provide property build...

2018-11-12 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2914#discussion_r232628397 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1237,10 +1238,12 @@ private

[GitHub] carbondata pull request #2914: [WIP][CARBONDATA-3093] Provide property build...

2018-11-12 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2914#discussion_r232628355 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1237,10 +1238,12 @@ private

[GitHub] carbondata pull request #2914: [WIP][CARBONDATA-3093] Provide property build...

2018-11-12 Thread xubo245
GitHub user xubo245 opened a pull request: https://github.com/apache/carbondata/pull/2914 [WIP][CARBONDATA-3093] Provide property builder for carbon properties. [CARBONDATA-3093] Provide property builder for carbon properties. Optimize the String implementation, we can provide